24066 2009-02-20 12:16:18 -0800 Chromium drop-down box: selected items don't paint correctly when scrolled 2009-02-25 08:59:08 -0800 1 1 1 Unclassified WebKit Platform 420+ PC Windows Vista RESOLVED FIXED P2 Normal --- 1 jcampan jcampan fishd oldest_to_newest 110421 0 jcampan 2009-02-20 12:16:18 -0800 When opening a select input in Chromium and scrolling-down in the popup, the items in the list don't paint properly, several are displayed as selected. Chromium associated bug : http://crbug.com/6743 110422 1 27835 jcampan 2009-02-20 12:24:48 -0800 Created attachment 27835 FramelessScrollView::invalidateRect now invalidates in the scrolled view coordinates A previous patch of mine fixing a painting problem with scroll-bars changes FramelessScrollView::invalidateRect to invalidate in the host window coordinates. This caused other painting problems. This patch reverts back that changes and fixes the painting of scroll-bars by ensuring the invalidateScrollBars method invalidates in the scrolled view coordinates. 110833 2 27835 fishd 2009-02-24 15:08:51 -0800 Comment on attachment 27835 FramelessScrollView::invalidateRect now invalidates in the scrolled view coordinates >+2009-02-20 Jay Campan <jcampan@google.com> >+ >+ Reviewed by NOBODY (OOPS!). >+ nit: please add a bug link here and a description of the code change. >Index: WebCore/platform/chromium/FramelessScrollView.cpp >=================================================================== >--- WebCore/platform/chromium/FramelessScrollView.cpp (revision 41110) >+++ WebCore/platform/chromium/FramelessScrollView.cpp (working copy) >@@ -47,7 +47,7 @@ void FramelessScrollView::invalidateScro > // Add in our offset within the ScrollView. > IntRect dirtyRect = rect; > dirtyRect.move(scrollbar->x(), scrollbar->y()); >- invalidateRect(dirtyRect); >+ invalidateRect(windowToContents(dirtyRect)); I would expect that we need to convert from the coordinates of the Scrollbar to the coordinates of the ScrollView's content area. That is what FrameView::invalidateScrollbarRect does, and it is what the old code did. So, this change seems wrong. > bool FramelessScrollView::isActive() const >@@ -59,7 +59,7 @@ bool FramelessScrollView::isActive() con > void FramelessScrollView::invalidateRect(const IntRect& rect) > { > if (HostWindow* h = hostWindow()) >- h->repaint(rect, true); >+ h->repaint(contentsToWindow(rect), true); Same deal here. I'm surprised to see this differ from FrameView's invalidateRect implementation, but maybe there is something more subtle at play? 110959 3 27966 jcampan 2009-02-25 08:39:58 -0800 Created attachment 27966 Updated patch that invalidates in the parent coordinates. 110960 4 27966 fishd 2009-02-25 08:50:21 -0800 Comment on attachment 27966 Updated patch that invalidates in the parent coordinates. >Index: WebCore/ChangeLog ... >+ Reviewed by NOBODY (OOPS!). >+ >+ https://bugs.webkit.org/show_bug.cgi?id=24066 >+ >+ Items in drop-downs were not painted correctly. >+ Makes sure the PopupListBox invalidates in the coordinates of >+ the window as this is FramelessScrollView::invalidateRect >+ paints to. the ChangeLog has tabs in it. those should be replaced with spaces. otherwise, looks great! 110963 5 27967 jcampan 2009-02-25 08:57:26 -0800 Created attachment 27967 Updated patch, evil tabs removed in ChangeLog 110965 6 fishd 2009-02-25 08:59:08 -0800 Landed as http://trac.webkit.org/changeset/41212 27835 2009-02-20 12:24:48 -0800 2009-02-25 08:39:58 -0800 FramelessScrollView::invalidateRect now invalidates in the scrolled view coordinates chromium_drop_down_patch text/plain 2510 jcampan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTExMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDItMjAgIEpheSBDYW1wYW4gIDxqY2FtcGFuQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9jaHJvbWl1bS9GcmFtZWxlc3NTY3JvbGxWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkZyYW1lbGVzc1Njcm9sbFZpZXc6OmludmFsaWRhdGVTY3JvbGxiYXJSZWN0KToKKyAgICAg ICAgKFdlYkNvcmU6OkZyYW1lbGVzc1Njcm9sbFZpZXc6OmludmFsaWRhdGVSZWN0KToKKyAgICAg ICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHA6CisKIDIwMDktMDIt MjAgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgSG9sZ2VyIEZyZXl0aGVyLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1 bS9GcmFtZWxlc3NTY3JvbGxWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3Jt L2Nocm9taXVtL0ZyYW1lbGVzc1Njcm9sbFZpZXcuY3BwCShyZXZpc2lvbiA0MTExMCkKKysrIFdl YkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vRnJhbWVsZXNzU2Nyb2xsVmlldy5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQ3LDcgKzQ3LDcgQEAgdm9pZCBGcmFtZWxlc3NTY3JvbGxWaWV3OjppbnZhbGlk YXRlU2NybwogICAgIC8vIEFkZCBpbiBvdXIgb2Zmc2V0IHdpdGhpbiB0aGUgU2Nyb2xsVmlldy4K ICAgICBJbnRSZWN0IGRpcnR5UmVjdCA9IHJlY3Q7CiAgICAgZGlydHlSZWN0Lm1vdmUoc2Nyb2xs YmFyLT54KCksIHNjcm9sbGJhci0+eSgpKTsKLSAgICBpbnZhbGlkYXRlUmVjdChkaXJ0eVJlY3Qp OworICAgIGludmFsaWRhdGVSZWN0KHdpbmRvd1RvQ29udGVudHMoZGlydHlSZWN0KSk7CiB9CiAK IGJvb2wgRnJhbWVsZXNzU2Nyb2xsVmlldzo6aXNBY3RpdmUoKSBjb25zdApAQCAtNTksNyArNTks NyBAQCBib29sIEZyYW1lbGVzc1Njcm9sbFZpZXc6OmlzQWN0aXZlKCkgY29uCiB2b2lkIEZyYW1l bGVzc1Njcm9sbFZpZXc6OmludmFsaWRhdGVSZWN0KGNvbnN0IEludFJlY3QmIHJlY3QpCiB7CiAg ICAgaWYgKEhvc3RXaW5kb3cqIGggPSBob3N0V2luZG93KCkpCi0gICAgICAgIGgtPnJlcGFpbnQo cmVjdCwgdHJ1ZSk7CisgICAgICAgIGgtPnJlcGFpbnQoY29udGVudHNUb1dpbmRvdyhyZWN0KSwg dHJ1ZSk7CiB9CiAKIEhvc3RXaW5kb3cqIEZyYW1lbGVzc1Njcm9sbFZpZXc6Omhvc3RXaW5kb3co KSBjb25zdApJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1 bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVD aHJvbWl1bS5jcHAJKHJldmlzaW9uIDQxMTEwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1 bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk4LDkgKzk4LDYgQEAg cHVibGljOgogICAgIC8vIFNjcm9sbFZpZXcKICAgICB2aXJ0dWFsIEhvc3RXaW5kb3cqIGhvc3RX aW5kb3coKSBjb25zdDsKIAotICAgIC8vIFdpZGdldAotICAgIHZpcnR1YWwgdm9pZCBpbnZhbGlk YXRlUmVjdChjb25zdCBJbnRSZWN0Jik7Ci0KICAgICAvLyBQb3B1cExpc3RCb3ggbWV0aG9kcwog CiAgICAgLy8gU2hvd3MgdGhlIHBvcHVwCkBAIC02NTEsMTUgKzY0OCw2IEBAIEhvc3RXaW5kb3cq IFBvcHVwTGlzdEJveDo6aG9zdFdpbmRvdygpIGMKICAgICByZXR1cm4gcGFyZW50KCkgPyBwYXJl bnQoKS0+aG9zdFdpbmRvdygpIDogMDsKIH0KIAotdm9pZCBQb3B1cExpc3RCb3g6OmludmFsaWRh dGVSZWN0KGNvbnN0IEludFJlY3QmIHJlY3QpCi17Ci0gICAgLy8gU2luY2Ugd2UgYXJlIHJldHVy bmluZyB0aGUgSG9zdFdpbmRvdyBvZiBvdXIgcGFyZW50IGFzIG91ciBvd24gaW4KLSAgICAvLyBo b3N0V2luZG93KCksIHdlIG5lZWQgdG8gaW52YWxpZGF0ZSBpbiBvdXIgcGFyZW50J3MgY29vcmRp bmF0ZXMuCi0gICAgSW50UmVjdCBuZXdSZWN0KHJlY3QpOwotICAgIG5ld1JlY3QubW92ZShrQm9y ZGVyU2l6ZSwga0JvcmRlclNpemUpOwotICAgIEZyYW1lbGVzc1Njcm9sbFZpZXc6OmludmFsaWRh dGVSZWN0KG5ld1JlY3QpOwotfQotCiAvLyBGcm9tIEhUTUxTZWxlY3RFbGVtZW50LmNwcAogc3Rh dGljIFN0cmluZyBzdHJpcExlYWRpbmdXaGl0ZVNwYWNlKGNvbnN0IFN0cmluZyYgc3RyaW5nKQog ewo= 27966 2009-02-25 08:39:58 -0800 2009-02-25 08:57:26 -0800 Updated patch that invalidates in the parent coordinates. chromium_drop_down_patch text/plain 2107 jcampan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTIxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDItMjUgIEpheSBDYW1wYW4gIDxqY2FtcGFuQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwlodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQwNjYKKworCUl0ZW1zIGluIGRyb3AtZG93 bnMgd2VyZSBub3QgcGFpbnRlZCBjb3JyZWN0bHkuCisJTWFrZXMgc3VyZSB0aGUgUG9wdXBMaXN0 Qm94IGludmFsaWRhdGVzIGluIHRoZSBjb29yZGluYXRlcyBvZgorCXRoZSB3aW5kb3cgYXMgdGhp cyBpcyBGcmFtZWxlc3NTY3JvbGxWaWV3OjppbnZhbGlkYXRlUmVjdAorCXBhaW50cyB0by4KKwkK KyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpQb3B1cExpc3RCb3g6OmludmFsaWRhdGVSb3cpOgorCiAyMDA5LTAyLTI0 ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFuZGVycyBDYXJsc3NvbgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Q b3B1cE1lbnVDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9jaHJv bWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDQxMjA2KQorKysgV2ViQ29yZS9w bGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTk4LDkgKzk4LDYgQEAgcHVibGljOgogICAgIC8vIFNjcm9sbFZpZXcKICAgICB2aXJ0dWFsIEhv c3RXaW5kb3cqIGhvc3RXaW5kb3coKSBjb25zdDsKIAotICAgIC8vIFdpZGdldAotICAgIHZpcnR1 YWwgdm9pZCBpbnZhbGlkYXRlUmVjdChjb25zdCBJbnRSZWN0Jik7Ci0KICAgICAvLyBQb3B1cExp c3RCb3ggbWV0aG9kcwogCiAgICAgLy8gU2hvd3MgdGhlIHBvcHVwCkBAIC02NTEsMTUgKzY0OCw2 IEBAIEhvc3RXaW5kb3cqIFBvcHVwTGlzdEJveDo6aG9zdFdpbmRvdygpIGMKICAgICByZXR1cm4g cGFyZW50KCkgPyBwYXJlbnQoKS0+aG9zdFdpbmRvdygpIDogMDsKIH0KIAotdm9pZCBQb3B1cExp c3RCb3g6OmludmFsaWRhdGVSZWN0KGNvbnN0IEludFJlY3QmIHJlY3QpCi17Ci0gICAgLy8gU2lu Y2Ugd2UgYXJlIHJldHVybmluZyB0aGUgSG9zdFdpbmRvdyBvZiBvdXIgcGFyZW50IGFzIG91ciBv d24gaW4KLSAgICAvLyBob3N0V2luZG93KCksIHdlIG5lZWQgdG8gaW52YWxpZGF0ZSBpbiBvdXIg cGFyZW50J3MgY29vcmRpbmF0ZXMuCi0gICAgSW50UmVjdCBuZXdSZWN0KHJlY3QpOwotICAgIG5l d1JlY3QubW92ZShrQm9yZGVyU2l6ZSwga0JvcmRlclNpemUpOwotICAgIEZyYW1lbGVzc1Njcm9s bFZpZXc6OmludmFsaWRhdGVSZWN0KG5ld1JlY3QpOwotfQotCiAvLyBGcm9tIEhUTUxTZWxlY3RF bGVtZW50LmNwcAogc3RhdGljIFN0cmluZyBzdHJpcExlYWRpbmdXaGl0ZVNwYWNlKGNvbnN0IFN0 cmluZyYgc3RyaW5nKQogewpAQCAtOTA1LDcgKzg5Myw5IEBAIHZvaWQgUG9wdXBMaXN0Qm94Ojpp bnZhbGlkYXRlUm93KGludCBpbmQKICAgICBpZiAoaW5kZXggPCAwKQogICAgICAgICByZXR1cm47 CiAKLSAgICBpbnZhbGlkYXRlUmVjdChnZXRSb3dCb3VuZHMoaW5kZXgpKTsKKyAgICAvLyBJbnZh bGlkYXRlIGluIHRoZSB3aW5kb3cgY29udGVudHMsIGFzIEZyYW1lbGVzc1Njcm9sbFZpZXc6Omlu dmFsaWRhdGVSZWN0CisgICAgLy8gcGFpbnRzIGluIHRoZSB3aW5kb3cgY29vcmRpbmF0ZXMuCisg ICAgaW52YWxpZGF0ZVJlY3QoY29udGVudHNUb1dpbmRvdyhnZXRSb3dCb3VuZHMoaW5kZXgpKSk7 CiB9CiAKIHZvaWQgUG9wdXBMaXN0Qm94OjpzY3JvbGxUb1JldmVhbFJvdyhpbnQgaW5kZXgpCg== 27967 2009-02-25 08:57:26 -0800 2009-02-25 08:57:26 -0800 Updated patch, evil tabs removed in ChangeLog chromium_drop_down_patch text/plain 2141 jcampan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTIxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDItMjUgIEpheSBDYW1wYW4gIDxqY2FtcGFuQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MDY2CisKKyAgICAgICAgSXRl bXMgaW4gZHJvcC1kb3ducyB3ZXJlIG5vdCBwYWludGVkIGNvcnJlY3RseS4KKyAgICAgICAgTWFr ZXMgc3VyZSB0aGUgUG9wdXBMaXN0Qm94IGludmFsaWRhdGVzIGluIHRoZSBjb29yZGluYXRlcyBv ZgorICAgICAgICB0aGUgd2luZG93IGFzIHRoaXMgaXMgRnJhbWVsZXNzU2Nyb2xsVmlldzo6aW52 YWxpZGF0ZVJlY3QKKyAgICAgICAgcGFpbnRzIHRvLgorCisgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBMaXN0 Qm94OjppbnZhbGlkYXRlUm93KToKKwogMjAwOS0wMi0yNCAgU2ltb24gRnJhc2VyICA8c2ltb24u ZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24K SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0u Y3BwCShyZXZpc2lvbiA0MTIwNikKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBN ZW51Q2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05OCw5ICs5OCw2IEBAIHB1YmxpYzoK ICAgICAvLyBTY3JvbGxWaWV3CiAgICAgdmlydHVhbCBIb3N0V2luZG93KiBob3N0V2luZG93KCkg Y29uc3Q7CiAKLSAgICAvLyBXaWRnZXQKLSAgICB2aXJ0dWFsIHZvaWQgaW52YWxpZGF0ZVJlY3Qo Y29uc3QgSW50UmVjdCYpOwotCiAgICAgLy8gUG9wdXBMaXN0Qm94IG1ldGhvZHMKIAogICAgIC8v IFNob3dzIHRoZSBwb3B1cApAQCAtNjUxLDE1ICs2NDgsNiBAQCBIb3N0V2luZG93KiBQb3B1cExp c3RCb3g6Omhvc3RXaW5kb3coKSBjCiAgICAgcmV0dXJuIHBhcmVudCgpID8gcGFyZW50KCktPmhv c3RXaW5kb3coKSA6IDA7CiB9CiAKLXZvaWQgUG9wdXBMaXN0Qm94OjppbnZhbGlkYXRlUmVjdChj b25zdCBJbnRSZWN0JiByZWN0KQotewotICAgIC8vIFNpbmNlIHdlIGFyZSByZXR1cm5pbmcgdGhl IEhvc3RXaW5kb3cgb2Ygb3VyIHBhcmVudCBhcyBvdXIgb3duIGluCi0gICAgLy8gaG9zdFdpbmRv dygpLCB3ZSBuZWVkIHRvIGludmFsaWRhdGUgaW4gb3VyIHBhcmVudCdzIGNvb3JkaW5hdGVzLgot ICAgIEludFJlY3QgbmV3UmVjdChyZWN0KTsKLSAgICBuZXdSZWN0Lm1vdmUoa0JvcmRlclNpemUs IGtCb3JkZXJTaXplKTsKLSAgICBGcmFtZWxlc3NTY3JvbGxWaWV3OjppbnZhbGlkYXRlUmVjdChu ZXdSZWN0KTsKLX0KLQogLy8gRnJvbSBIVE1MU2VsZWN0RWxlbWVudC5jcHAKIHN0YXRpYyBTdHJp bmcgc3RyaXBMZWFkaW5nV2hpdGVTcGFjZShjb25zdCBTdHJpbmcmIHN0cmluZykKIHsKQEAgLTkw NSw3ICs4OTMsOSBAQCB2b2lkIFBvcHVwTGlzdEJveDo6aW52YWxpZGF0ZVJvdyhpbnQgaW5kCiAg ICAgaWYgKGluZGV4IDwgMCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaW52YWxpZGF0ZVJlY3Qo Z2V0Um93Qm91bmRzKGluZGV4KSk7CisgICAgLy8gSW52YWxpZGF0ZSBpbiB0aGUgd2luZG93IGNv bnRlbnRzLCBhcyBGcmFtZWxlc3NTY3JvbGxWaWV3OjppbnZhbGlkYXRlUmVjdAorICAgIC8vIHBh aW50cyBpbiB0aGUgd2luZG93IGNvb3JkaW5hdGVzLgorICAgIGludmFsaWRhdGVSZWN0KGNvbnRl bnRzVG9XaW5kb3coZ2V0Um93Qm91bmRzKGluZGV4KSkpOwogfQogCiB2b2lkIFBvcHVwTGlzdEJv eDo6c2Nyb2xsVG9SZXZlYWxSb3coaW50IGluZGV4KQo=