240639 2022-05-19 03:46:08 -0700 Canvas.toDataURL causes excessive GPUP memory use on Cocoa 2025-05-07 15:38:50 -0700 1 1 1 Unclassified WebKit Canvas Safari 15 Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=292651 InRadar P2 Normal --- 240866 241127 1 kkinnunen nmouchtaris csaavedra dino webkit-bug-importer oldest_to_newest 1870323 0 kkinnunen 2022-05-19 03:46:08 -0700 Canvas.toDataURL causes excessive GPUP memory use on Cocoa IOSurface -backed image -> CGBitmap copy -> compressed data string 1 (61.0M) CONTENT: VM: CG raster data + 1 (61.0M) mmap (in libsystem_kernel.dylib) + 0 [0x1dfc92c84] ..... + 1 (61.0M) CGBitmapContextCreateImage (in CoreGraphics) + 172 [0x1a6b6d444] + 1 (61.0M) WebKit::ShareableBitmap::makeCGImageCopy() (in WebKit) + 84 [0x10544eb60] + 1 (61.0M) WebKit::ImageBufferShareableBitmapBackend::copyNativeImage(WebCore::BackingStoreCopy) const (in WebKit) + 40 [0x105a7e1a4] + 1 (61.0M) WebCore::ImageBufferCGBackend::copyCGImageForEncoding(__CFString const*, WebCore::PreserveResolution) const (in WebCore) + 568 [0x113f87f34] + 1 (61.0M) WebCore::ImageBufferCGBackend::toDataURL(WTF::String const&, std::__1::optional<double>, WebCore::PreserveResolution) const (in WebCore) + 124 [0x113f883a0] + 1 (61.0M) WebKit::RemoteRenderingBackend::getDataURLForImageBufferWithQualifiedIdentifier(WTF::String const&, std::__1::optional<double>, WebCore::PreserveResolution, WebCore::ProcessQualified<WTF::ObjectIdentifier<WebCore::RenderingResourceIdentifierType> >, WTF::CompletionHandler<void (WTF::String&&)>&&) (in WebKit) + 124 [0x1057ac384] + 1 (61.0M) void IPC::handleMessageSynchronous<Messages::RemoteRenderingBackend::GetDataURLForImageBuffer, WebKit::RemoteRenderingBackend, void (WebKit::RemoteRenderingBackend::*)(WTF::String const&, std::__1::optional<double>, WebCore::PreserveResolution, WTF::ObjectIdentifier<WebCore::RenderingResourceIdentifierType>, WTF::CompletionHandler<void (WTF::String&&)>&&)>(IPC::StreamServerConnection&, IPC::Decoder&, WebKit::RemoteRenderingBackend*, void (WebKit::RemoteRenderingBackend::*)(WTF::String const&, std::__1::optional<double>, WebCore::PreserveResolution, WTF::ObjectIdentifier<WebCore::RenderingResourceIdentifierType>, WTF::CompletionHandler<void (WTF::String&&)>&&)) (in WebKit) + 232 [0x10579cdf0] 1870324 1 webkit-bug-importer 2022-05-19 03:48:16 -0700 <rdar://problem/93567863> 1870400 2 kkinnunen 2022-05-19 08:59:13 -0700 Should probably be fixed by removing ImageBuffer::toData / ImageBuffer::toDataURL and using data(), dataURL(), String dataURL(ImageBuffer&, const String& mimeType, std::optional<double> quality = std::nullopt, PreserveResolution preserveResolution) Vector<uint8_t> toData(ImageBuffer&, const String& mimeType, std::optional<double> quality = std::nullopt) 1874913 3 kkinnunen 2022-06-08 23:35:00 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1407 1875930 4 nmouchtaris 2022-06-14 17:50:21 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1528 1877850 5 nmouchtaris 2022-06-23 14:19:59 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1741 1879229 6 ews-feeder 2022-06-29 20:16:29 -0700 Committed 251974@main (bc684eeb57fb): <https://commits.webkit.org/251974@main> Reviewed commits have been landed. Closing PR #1741 and removing active labels. 1879316 7 csaavedra 2022-06-30 04:31:49 -0700 Reopening as the change was reverted, see https://github.com/WebKit/WebKit/pull/1940 1879424 8 nmouchtaris 2022-06-30 10:36:42 -0700 Pull request: https://github.com/WebKit/WebKit/pull/1951 1879664 9 ews-feeder 2022-06-30 23:40:02 -0700 Committed 252032@main (55390aa216e4): <https://commits.webkit.org/252032@main> Reviewed commits have been landed. Closing PR #1951 and removing active labels.