<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>24060</bug_id>
          
          <creation_ts>2009-02-20 08:15:33 -0800</creation_ts>
          <short_desc>Fix up to match with the CanvasPixelArray reintroduction</short_desc>
          <delta_ts>2009-02-21 20:24:33 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dimitri Glazkov (Google)">dglazkov</reporter>
          <assigned_to name="Dimitri Glazkov (Google)">dglazkov</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>110397</commentid>
    <comment_count>0</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-02-20 08:15:33 -0800</bug_when>
    <thetext>In http://trac.webkit.org/changeset/40089, CanvasPixelArray is back, which creates the need for this change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>110401</commentid>
    <comment_count>1</comment_count>
      <attachid>27831</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-02-20 08:46:44 -0800</bug_when>
    <thetext>Created attachment 27831
Fix up to accommodate for CanvasPixelArray return, v1.

 WebCore/ChangeLog                                  |   11 +++++++++++
 WebCore/platform/graphics/skia/ImageBufferSkia.cpp |    4 ++--
 2 files changed, 13 insertions(+), 2 deletions(-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>110404</commentid>
    <comment_count>2</comment_count>
      <attachid>27831</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-02-20 10:00:58 -0800</bug_when>
    <thetext>Comment on attachment 27831
Fix up to accommodate for CanvasPixelArray return, v1.

source-&gt;data()-&gt;data()-data()

Wrong.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>110425</commentid>
    <comment_count>3</comment_count>
      <attachid>27837</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-02-20 13:12:13 -0800</bug_when>
    <thetext>Created attachment 27837
Fix up to accommodate for CanvasPixelArray return, v2

 WebCore/ChangeLog                                  |   11 +++++++++++
 WebCore/platform/graphics/skia/ImageBufferSkia.cpp |    4 ++--
 2 files changed, 13 insertions(+), 2 deletions(-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>110428</commentid>
    <comment_count>4</comment_count>
      <attachid>27837</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-02-20 13:16:24 -0800</bug_when>
    <thetext>Comment on attachment 27837
Fix up to accommodate for CanvasPixelArray return, v2

Right!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>110486</commentid>
    <comment_count>5</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-02-21 20:24:33 -0800</bug_when>
    <thetext>Landed as http://trac.webkit.org/changeset/41119.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>27831</attachid>
            <date>2009-02-20 08:46:44 -0800</date>
            <delta_ts>2009-02-20 10:00:58 -0800</delta_ts>
            <desc>Fix up to accommodate for CanvasPixelArray return, v1.</desc>
            <filename>Fix-up-to-accommodate-for-CanvasPixelArray-return-v1..patch</filename>
            <type>text/plain</type>
            <size>1803</size>
            <attacher name="Dimitri Glazkov (Google)">dglazkov</attacher>
            
              <data encoding="base64">OWMxYzg3ZTRiNzVmOWMzMTRjZjFhZmI0NThkNDFkMzM0OWYzNmUyMgpkaWZmIC0tZ2l0IGEvV2Vi
Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyOTE2ZWYxLi4wMTU2MjRk
IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDE0IEBACisyMDA5LTAyLTE5ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj
aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MDYwCisgICAg
ICAgIEZpeCB1cCB0byBhY2NvbW1vZGF0ZSBmb3IgQ2FudmFzUGl4ZWxBcnJheSByZXR1cm4uCisK
KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHA6Cisg
ICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6Z2V0SW1hZ2VEYXRhKTogQWRkZWQgYW4gZXh0
cmEgZGF0YSgpIHRvIGNhbGwuCisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6cHV0SW1h
Z2VEYXRhKTogRGl0dG8uCisKIDIwMDktMDItMTkgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9y
Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBCZXRoIERha2luLgpkaWZmIC0tZ2l0IGEvV2ViQ29y
ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAgYi9XZWJDb3JlL3Bs
YXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAppbmRleCBjM2YzZDUwLi4x
OTRiNmJiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VC
dWZmZXJTa2lhLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VC
dWZmZXJTa2lhLmNwcApAQCAtMTA2LDcgKzEwNiw3IEBAIFBhc3NSZWZQdHI8SW1hZ2VEYXRhPiBJ
bWFnZUJ1ZmZlcjo6Z2V0SW1hZ2VEYXRhKGNvbnN0IEludFJlY3QmIHJlY3QpIGNvbnN0CiAgICAg
QVNTRVJUKGNvbnRleHQoKSk7CiAKICAgICBSZWZQdHI8SW1hZ2VEYXRhPiByZXN1bHQgPSBJbWFn
ZURhdGE6OmNyZWF0ZShyZWN0LndpZHRoKCksIHJlY3QuaGVpZ2h0KCkpOwotICAgIHVuc2lnbmVk
IGNoYXIqIGRhdGEgPSByZXN1bHQtPmRhdGEoKS0+ZGF0YSgpOworICAgIHVuc2lnbmVkIGNoYXIq
IGRhdGEgPSByZXN1bHQtPmRhdGEoKS0+ZGF0YSgpLT5kYXRhKCk7CiAKICAgICBpZiAocmVjdC54
KCkgPCAwIHx8IHJlY3QueSgpIDwgMCB8fAogICAgICAgICAocmVjdC54KCkgKyByZWN0LndpZHRo
KCkpID4gbV9zaXplLndpZHRoKCkgfHwKQEAgLTE5Myw3ICsxOTMsNyBAQCB2b2lkIEltYWdlQnVm
ZmVyOjpwdXRJbWFnZURhdGEoSW1hZ2VEYXRhKiBzb3VyY2UsIGNvbnN0IEludFJlY3QmIHNvdXJj
ZVJlY3QsCiAKICAgICB1bnNpZ25lZCBzcmNCeXRlc1BlclJvdyA9IDQgKiBzb3VyY2UtPndpZHRo
KCk7CiAKLSAgICBjb25zdCB1bnNpZ25lZCBjaGFyKiBzcmNSb3cgPSBzb3VyY2UtPmRhdGEoKS0+
ZGF0YSgpICsgb3JpZ2luWSAqIHNyY0J5dGVzUGVyUm93ICsgb3JpZ2luWCAqIDQ7CisgICAgY29u
c3QgdW5zaWduZWQgY2hhciogc3JjUm93ID0gc291cmNlLT5kYXRhKCktPmRhdGEoKS1kYXRhKCkg
KyBvcmlnaW5ZICogc3JjQnl0ZXNQZXJSb3cgKyBvcmlnaW5YICogNDsKIAogICAgIGZvciAoaW50
IHkgPSAwOyB5IDwgbnVtUm93czsgKyt5KSB7CiAgICAgICAgIHVpbnQzMl90KiBkZXN0Um93ID0g
Yml0bWFwLmdldEFkZHIzMihkZXN0WCwgZGVzdFkgKyB5KTsK
</data>
<flag name="review"
          id="13538"
          type_id="1"
          status="-"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>27837</attachid>
            <date>2009-02-20 13:12:13 -0800</date>
            <delta_ts>2009-02-20 13:16:24 -0800</delta_ts>
            <desc>Fix up to accommodate for CanvasPixelArray return, v2</desc>
            <filename>Fix-up-to-accommodate-for-CanvasPixelArray-return-v2.patch</filename>
            <type>text/plain</type>
            <size>1816</size>
            <attacher name="Dimitri Glazkov (Google)">dglazkov</attacher>
            
              <data encoding="base64">MDRhMTdiNTExZGI2NDIzNjVkOGYwZDhmM2MxYjk4ZGNhNzE5YjQyNwpkaWZmIC0tZ2l0IGEvV2Vi
Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2ZjdlMDRiLi4wNjllM2Y5
IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDE0IEBACisyMDA5LTAyLTE5ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj
aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MDYwCisgICAg
ICAgIEZpeCB1cCB0byBhY2NvbW1vZGF0ZSBmb3IgQ2FudmFzUGl4ZWxBcnJheSByZXR1cm4uCisK
KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHA6Cisg
ICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6Z2V0SW1hZ2VEYXRhKTogQWRkZWQgYW4gZXh0
cmEgZGF0YSgpIHRvIGNhbGwuCisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6cHV0SW1h
Z2VEYXRhKTogRGl0dG8uCisKIDIwMDktMDItMjAgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292
QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0t
Z2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAg
Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAppbmRl
eCBjM2YzZDUwLi41ZTkwNDkxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz
L3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz
L3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcApAQCAtMTA2LDcgKzEwNiw3IEBAIFBhc3NSZWZQdHI8
SW1hZ2VEYXRhPiBJbWFnZUJ1ZmZlcjo6Z2V0SW1hZ2VEYXRhKGNvbnN0IEludFJlY3QmIHJlY3Qp
IGNvbnN0CiAgICAgQVNTRVJUKGNvbnRleHQoKSk7CiAKICAgICBSZWZQdHI8SW1hZ2VEYXRhPiBy
ZXN1bHQgPSBJbWFnZURhdGE6OmNyZWF0ZShyZWN0LndpZHRoKCksIHJlY3QuaGVpZ2h0KCkpOwot
ICAgIHVuc2lnbmVkIGNoYXIqIGRhdGEgPSByZXN1bHQtPmRhdGEoKS0+ZGF0YSgpOworICAgIHVu
c2lnbmVkIGNoYXIqIGRhdGEgPSByZXN1bHQtPmRhdGEoKS0+ZGF0YSgpLT5kYXRhKCk7CiAKICAg
ICBpZiAocmVjdC54KCkgPCAwIHx8IHJlY3QueSgpIDwgMCB8fAogICAgICAgICAocmVjdC54KCkg
KyByZWN0LndpZHRoKCkpID4gbV9zaXplLndpZHRoKCkgfHwKQEAgLTE5Myw3ICsxOTMsNyBAQCB2
b2lkIEltYWdlQnVmZmVyOjpwdXRJbWFnZURhdGEoSW1hZ2VEYXRhKiBzb3VyY2UsIGNvbnN0IElu
dFJlY3QmIHNvdXJjZVJlY3QsCiAKICAgICB1bnNpZ25lZCBzcmNCeXRlc1BlclJvdyA9IDQgKiBz
b3VyY2UtPndpZHRoKCk7CiAKLSAgICBjb25zdCB1bnNpZ25lZCBjaGFyKiBzcmNSb3cgPSBzb3Vy
Y2UtPmRhdGEoKS0+ZGF0YSgpICsgb3JpZ2luWSAqIHNyY0J5dGVzUGVyUm93ICsgb3JpZ2luWCAq
IDQ7CisgICAgY29uc3QgdW5zaWduZWQgY2hhciogc3JjUm93ID0gc291cmNlLT5kYXRhKCktPmRh
dGEoKS0+ZGF0YSgpICsgb3JpZ2luWSAqIHNyY0J5dGVzUGVyUm93ICsgb3JpZ2luWCAqIDQ7CiAK
ICAgICBmb3IgKGludCB5ID0gMDsgeSA8IG51bVJvd3M7ICsreSkgewogICAgICAgICB1aW50MzJf
dCogZGVzdFJvdyA9IGJpdG1hcC5nZXRBZGRyMzIoZGVzdFgsIGRlc3RZICsgeSk7Cg==
</data>
<flag name="review"
          id="13543"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>