240593 2022-05-18 12:26:48 -0700 Remove invalid assertion in parseKeywordValue 2022-05-20 19:26:31 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen esprehn+autocc ews-watchlist glenn gyuyoung.kim koivisto macpherson menard ntim webkit-bug-importer oldest_to_newest 1870100 0 achristensen 2022-05-18 12:26:48 -0700 It can be hit. 1870102 1 459552 achristensen 2022-05-18 12:28:16 -0700 Created attachment 459552 Patch 1870341 2 459552 ntim 2022-05-19 05:33:32 -0700 Comment on attachment 459552 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459552&action=review > LayoutTests/fast/css/parse-non-descriptor.html:8 > +<script> > + if (window.testRunner) { testRunner.dumpAsText() } > + onload = function() { > + body.style.setProperty('src', 'url(#abc)') > + } > +</script> > +<body id='body'> > +This test passes if it does not assert. Seems pretty wrong that we try to parse the value at all in this case, src is a descriptor for @font-face, not a CSS property (I find it unfortunate that we mix both in CSSProperties.json fwiw). https://webkit-search.igalia.com/webkit/rev/0393f2f7c7a1e97a7a4c63441b50703cc11d493f/Source/WebCore/css/CSSProperties.json#4340-4349 1870421 3 achristensen 2022-05-19 09:45:09 -0700 Do you have any better suggestions? 1870644 4 459552 koivisto 2022-05-19 23:55:13 -0700 Comment on attachment 459552 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459552&action=review > Source/WebCore/css/parser/CSSParserFastPaths.cpp:-1092 > bool parsingDescriptor = context.enclosingRuleType && *context.enclosingRuleType != StyleRuleType::Style; > - ASSERT(!CSSProperty::isDescriptorOnly(propertyId) || parsingDescriptor); Maybe the assert can be loosened instead? Does ASSERT(!CSSProperty::isDescriptorOnly(propertyId) || parsingDescriptor || !context.enclosingRuleType); pass? It would be good to also add a FIXME that this is suspicious. 1870728 5 459619 achristensen 2022-05-20 09:24:52 -0700 Created attachment 459619 Patch 1870903 6 ews-feeder 2022-05-20 19:25:16 -0700 Committed r294606 (250831@main): <https://commits.webkit.org/250831@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459619. 1870906 7 webkit-bug-importer 2022-05-20 19:26:31 -0700 <rdar://problem/93691077> 459552 2022-05-18 12:28:16 -0700 2022-05-20 09:24:50 -0700 Patch bug-240593-20220518122815.patch text/plain 2377 achristensen RnJvbSAzZDJkMTcyMzBmMTY4YTA2YWU4NTk2NTMzZDk1ODhkZmZmNWFmZmI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4IENocmlzdGVuc2VuIDxhY2hyaXN0ZW5zZW5AYXBwbGUu Y29tPgpEYXRlOiBXZWQsIDE4IE1heSAyMDIyIDEyOjI3OjAzIC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gUmVtb3ZlIGludmFsaWQgYXNzZXJ0aW9uIGluIHBhcnNlS2V5d29yZFZhbHVlCiBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQwNTkzCgpSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KClRlc3Q6IGZhc3QvY3NzL3BhcnNlLW5vbi1kZXNjcmlwdG9yLmh0bWwKCiog U291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQYXJzZXJGYXN0UGF0aHMuY3BwOgpUaGlzIGZ1 bmN0aW9uIHJldHVybnMgbnVsbCwgd2hpY2ggaXMgZmluZS4KLS0tCiBTb3VyY2UvV2ViQ29yZS9j c3MvcGFyc2VyL0NTU1BhcnNlckZhc3RQYXRocy5jcHAgICAgICAgfCAxIC0KIExheW91dFRlc3Rz L2Zhc3QvY3NzL3BhcnNlLW5vbi1kZXNjcmlwdG9yLWV4cGVjdGVkLnR4dCB8IDEgKwogTGF5b3V0 VGVzdHMvZmFzdC9jc3MvcGFyc2Utbm9uLWRlc2NyaXB0b3IuaHRtbCAgICAgICAgIHwgOCArKysr KysrKwogMyBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKIGNy ZWF0ZSBtb2RlIDEwMDY0NCBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9wYXJzZS1ub24tZGVzY3JpcHRv ci1leHBlY3RlZC50eHQKIGNyZWF0ZSBtb2RlIDEwMDY0NCBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9w YXJzZS1ub24tZGVzY3JpcHRvci5odG1sCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3Nz L3BhcnNlci9DU1NQYXJzZXJGYXN0UGF0aHMuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL3BhcnNl ci9DU1NQYXJzZXJGYXN0UGF0aHMuY3BwCmluZGV4IDU5YWM4OTI0NjhkMC4uODM4NzRlZjdmZTRk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1BhcnNlckZhc3RQYXRo cy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQYXJzZXJGYXN0UGF0aHMu Y3BwCkBAIC0xMDg5LDcgKzEwODksNiBAQCBzdGF0aWMgUmVmUHRyPENTU1ZhbHVlPiBwYXJzZUtl eXdvcmRWYWx1ZShDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SWQsIFN0cmluZ1ZpZXcgcwogICAgIEFT U0VSVCghc3RyaW5nLmlzRW1wdHkoKSk7CiAKICAgICBib29sIHBhcnNpbmdEZXNjcmlwdG9yID0g Y29udGV4dC5lbmNsb3NpbmdSdWxlVHlwZSAmJiAqY29udGV4dC5lbmNsb3NpbmdSdWxlVHlwZSAh PSBTdHlsZVJ1bGVUeXBlOjpTdHlsZTsKLSAgICBBU1NFUlQoIUNTU1Byb3BlcnR5Ojppc0Rlc2Ny aXB0b3JPbmx5KHByb3BlcnR5SWQpIHx8IHBhcnNpbmdEZXNjcmlwdG9yKTsKIAogICAgIGlmICgh Q1NTUGFyc2VyRmFzdFBhdGhzOjppc0tleXdvcmRQcm9wZXJ0eUlEKHByb3BlcnR5SWQpKSB7CiAg ICAgICAgIC8vIEFsbCBwcm9wZXJ0aWVzLCBpbmNsdWRpbmcgbm9uLWtleXdvcmQgcHJvcGVydGll cywgYWNjZXB0IHRoZSBDU1Mtd2lkZSBrZXl3b3Jkcy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvY3NzL3BhcnNlLW5vbi1kZXNjcmlwdG9yLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2Zhc3QvY3NzL3BhcnNlLW5vbi1kZXNjcmlwdG9yLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAuLjU5NjdhYTNlNWMwZAotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3BhcnNlLW5vbi1kZXNjcmlwdG9yLWV4cGVjdGVkLnR4 dApAQCAtMCwwICsxIEBACitUaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IGFzc2VydC4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3BhcnNlLW5vbi1kZXNjcmlwdG9yLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9wYXJzZS1ub24tZGVzY3JpcHRvci5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMC4uNmExNjYxNGYxNzE2Ci0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvcGFyc2Utbm9uLWRlc2NyaXB0b3IuaHRt bApAQCAtMCwwICsxLDggQEAKKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7 IHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpIH0KKyAgICBvbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAg ICAgICAgYm9keS5zdHlsZS5zZXRQcm9wZXJ0eSgnc3JjJywgJ3VybCgjYWJjKScpCisgICAgfQor PC9zY3JpcHQ+Cis8Ym9keSBpZD0nYm9keSc+CitUaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMg bm90IGFzc2VydC4KLS0gCjIuMzIuMCAoQXBwbGUgR2l0LTEzMikKCg== 459619 2022-05-20 09:24:52 -0700 2022-05-20 19:25:17 -0700 Patch bug-240593-20220520092451.patch text/plain 2548 achristensen RnJvbSBlNzM1YjllY2FhMmYwMzQzZmYyZDQ5MDAxNTgwOGYyZWEyYmJmZDA0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4IENocmlzdGVuc2VuIDxhY2hyaXN0ZW5zZW5AYXBwbGUu Y29tPgpEYXRlOiBGcmksIDIwIE1heSAyMDIyIDA5OjIyOjUxIC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gRml4IGludmFsaWQgYXNzZXJ0aW9uIGluIHBhcnNlS2V5d29yZFZhbHVlCiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjQwNTkzCgpSZXZpZXdlZCBieSBBbnR0aSBL b2l2aXN0by4KClRlc3Q6IGZhc3QvY3NzL3BhcnNlLW5vbi1kZXNjcmlwdG9yLmh0bWwKCiogU291 cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQYXJzZXJGYXN0UGF0aHMuY3BwOgpUaGlzIGZ1bmN0 aW9uIHJldHVybnMgbnVsbCwgd2hpY2ggaXMgZmluZS4KLS0tCiBTb3VyY2UvV2ViQ29yZS9jc3Mv cGFyc2VyL0NTU1BhcnNlckZhc3RQYXRocy5jcHAgICAgICAgfCAzICsrLQogTGF5b3V0VGVzdHMv ZmFzdC9jc3MvcGFyc2Utbm9uLWRlc2NyaXB0b3ItZXhwZWN0ZWQudHh0IHwgMSArCiBMYXlvdXRU ZXN0cy9mYXN0L2Nzcy9wYXJzZS1ub24tZGVzY3JpcHRvci5odG1sICAgICAgICAgfCA4ICsrKysr KysrCiAzIGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKIGNy ZWF0ZSBtb2RlIDEwMDY0NCBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9wYXJzZS1ub24tZGVzY3JpcHRv ci1leHBlY3RlZC50eHQKIGNyZWF0ZSBtb2RlIDEwMDY0NCBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9w YXJzZS1ub24tZGVzY3JpcHRvci5odG1sCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3Nz L3BhcnNlci9DU1NQYXJzZXJGYXN0UGF0aHMuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL3BhcnNl ci9DU1NQYXJzZXJGYXN0UGF0aHMuY3BwCmluZGV4IDU5YWM4OTI0NjhkMC4uYzk2NWU3NmMxMGMx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1BhcnNlckZhc3RQYXRo cy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQYXJzZXJGYXN0UGF0aHMu Y3BwCkBAIC0xMDg5LDcgKzEwODksOCBAQCBzdGF0aWMgUmVmUHRyPENTU1ZhbHVlPiBwYXJzZUtl eXdvcmRWYWx1ZShDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SWQsIFN0cmluZ1ZpZXcgcwogICAgIEFT U0VSVCghc3RyaW5nLmlzRW1wdHkoKSk7CiAKICAgICBib29sIHBhcnNpbmdEZXNjcmlwdG9yID0g Y29udGV4dC5lbmNsb3NpbmdSdWxlVHlwZSAmJiAqY29udGV4dC5lbmNsb3NpbmdSdWxlVHlwZSAh PSBTdHlsZVJ1bGVUeXBlOjpTdHlsZTsKLSAgICBBU1NFUlQoIUNTU1Byb3BlcnR5Ojppc0Rlc2Ny aXB0b3JPbmx5KHByb3BlcnR5SWQpIHx8IHBhcnNpbmdEZXNjcmlwdG9yKTsKKyAgICAvLyBGSVhN RTogVGhlICIhY29udGV4dC5lbmNsb3NpbmdSdWxlVHlwZSIgaXMgc3VzcGljaW91cy4KKyAgICBB U1NFUlQoIUNTU1Byb3BlcnR5Ojppc0Rlc2NyaXB0b3JPbmx5KHByb3BlcnR5SWQpIHx8IHBhcnNp bmdEZXNjcmlwdG9yIHx8ICFjb250ZXh0LmVuY2xvc2luZ1J1bGVUeXBlKTsKIAogICAgIGlmICgh Q1NTUGFyc2VyRmFzdFBhdGhzOjppc0tleXdvcmRQcm9wZXJ0eUlEKHByb3BlcnR5SWQpKSB7CiAg ICAgICAgIC8vIEFsbCBwcm9wZXJ0aWVzLCBpbmNsdWRpbmcgbm9uLWtleXdvcmQgcHJvcGVydGll cywgYWNjZXB0IHRoZSBDU1Mtd2lkZSBrZXl3b3Jkcy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvY3NzL3BhcnNlLW5vbi1kZXNjcmlwdG9yLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2Zhc3QvY3NzL3BhcnNlLW5vbi1kZXNjcmlwdG9yLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAuLjU5NjdhYTNlNWMwZAotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3BhcnNlLW5vbi1kZXNjcmlwdG9yLWV4cGVjdGVkLnR4 dApAQCAtMCwwICsxIEBACitUaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IGFzc2VydC4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3BhcnNlLW5vbi1kZXNjcmlwdG9yLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9wYXJzZS1ub24tZGVzY3JpcHRvci5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMC4uNmExNjYxNGYxNzE2Ci0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvcGFyc2Utbm9uLWRlc2NyaXB0b3IuaHRt bApAQCAtMCwwICsxLDggQEAKKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7 IHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpIH0KKyAgICBvbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAg ICAgICAgYm9keS5zdHlsZS5zZXRQcm9wZXJ0eSgnc3JjJywgJ3VybCgjYWJjKScpCisgICAgfQor PC9zY3JpcHQ+Cis8Ym9keSBpZD0nYm9keSc+CitUaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMg bm90IGFzc2VydC4KLS0gCjIuMzIuMCAoQXBwbGUgR2l0LTEzMikKCg==