240577 2022-05-18 06:50:27 -0700 Remove unused memory capacity output value in calculateURLCacheSizes 2022-05-19 20:48:13 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 olivier.blin webkit-unassigned achristensen cdumez cgarcia darin ggaren kkinnunen loic.yhuel mcatanzaro webkit-bug-importer oldest_to_newest 1869990 0 olivier.blin 2022-05-18 06:50:27 -0700 calculateURLCacheSizes() had a urlCacheMemoryCapacity output value since its creation in r203857, which was passed to platformSetURLCacheSize(). But the implementation has been removed for the soup platform in r205556 when switching to the WebKit network cache, and for the Cocoa platform in r232201 when dropping NSURLCache support. urlCacheMemoryCapacity is now unused. 1869991 1 459539 olivier.blin 2022-05-18 06:53:07 -0700 Created attachment 459539 Patch 1870034 2 459539 achristensen 2022-05-18 09:35:19 -0700 Comment on attachment 459539 Patch r=me I think this needs a COMMIT_MESSAGE which is uploaded automatically with webkit-patch upload after you commit locally with git. 1870303 3 olivier.blin 2022-05-19 01:23:55 -0700 Pull request: https://github.com/WebKit/WebKit/pull/771 1870620 4 ews-feeder 2022-05-19 20:47:20 -0700 Committed r294527 (250782@main): <https://commits.webkit.org/250782@main> Reviewed commits have been landed. Closing PR #771 and removing active labels. 1870621 5 webkit-bug-importer 2022-05-19 20:48:13 -0700 <rdar://problem/93626827> 459539 2022-05-18 06:53:07 -0700 2022-05-18 09:35:19 -0700 Patch bug-240577-20220518155305.patch text/plain 4305 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjkyNzgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5jcHAKaW5kZXggYzRmZmFmYTlhNGM1YWE2YjFk Njk3NjE2MzVkNWNlOGY5ZmM5NTM5NC4uMWU4ZTMxYWNhZDk4YjI1NDgzNjBhMGRhMTFiOWE1MjJm MWI1M2Y4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9O ZXR3b3JrQ2FjaGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUv TmV0d29ya0NhY2hlLmNwcApAQCAtNjQsMTMgKzY0LDEyIEBAIHN0YXRpYyBjb25zdCBBdG9tU3Ry aW5nJiByZXNvdXJjZVR5cGUoKQogCiBzdGF0aWMgc2l6ZV90IGNvbXB1dGVDYXBhY2l0eShDYWNo ZU1vZGVsIGNhY2hlTW9kZWwsIGNvbnN0IFN0cmluZyYgY2FjaGVQYXRoKQogewotICAgIHVuc2ln bmVkIHVybENhY2hlTWVtb3J5Q2FwYWNpdHkgPSAwOwogICAgIHVpbnQ2NF90IHVybENhY2hlRGlz a0NhcGFjaXR5ID0gMDsKICAgICBpZiAoYXV0byBkaXNrRnJlZVNpemUgPSBGaWxlU3lzdGVtOjp2 b2x1bWVGcmVlU3BhY2UoY2FjaGVQYXRoKSkgewogICAgICAgICAvLyBBcyBhIGZ1ZGdlIGZhY3Rv ciwgdXNlIDEwMDAgaW5zdGVhZCBvZiAxMDI0LCBpbiBjYXNlIHRoZSByZXBvcnRlZCBieXRlCiAg ICAgICAgIC8vIGNvdW50IGRvZXNuJ3QgYWxpZ24gZXhhY3RseSB0byBhIG1lZ2FieXRlIGJvdW5k YXJ5LgogICAgICAgICAqZGlza0ZyZWVTaXplIC89IEtCICogMTAwMDsKLSAgICAgICAgY2FsY3Vs YXRlVVJMQ2FjaGVTaXplcyhjYWNoZU1vZGVsLCAqZGlza0ZyZWVTaXplLCB1cmxDYWNoZU1lbW9y eUNhcGFjaXR5LCB1cmxDYWNoZURpc2tDYXBhY2l0eSk7CisgICAgICAgIGNhbGN1bGF0ZVVSTENh Y2hlU2l6ZXMoY2FjaGVNb2RlbCwgKmRpc2tGcmVlU2l6ZSwgdXJsQ2FjaGVEaXNrQ2FwYWNpdHkp OwogICAgIH0KICAgICByZXR1cm4gdXJsQ2FjaGVEaXNrQ2FwYWNpdHk7CiB9CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9DYWNoZU1vZGVsLmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hh cmVkL0NhY2hlTW9kZWwuY3BwCmluZGV4IGMzZGFmMzFlYmY1MDhkNzEzODVjYmZjYTdkMzEwZTIy MjVhNjIxN2UuLjQ1YjA1YTQyNTNjZmE2NTYwNjM5NTVlNWYzMzFhM2M4NWRiYTY5ZjggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0NhY2hlTW9kZWwuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvU2hhcmVkL0NhY2hlTW9kZWwuY3BwCkBAIC0xMjUsMzEgKzEyNSwxNiBAQCB2b2lkIGNh bGN1bGF0ZU1lbW9yeUNhY2hlU2l6ZXMoQ2FjaGVNb2RlbCBjYWNoZU1vZGVsLCB1bnNpZ25lZCYg Y2FjaGVUb3RhbENhcGFjaQogICAgIH07CiB9CiAKLXZvaWQgY2FsY3VsYXRlVVJMQ2FjaGVTaXpl cyhDYWNoZU1vZGVsIGNhY2hlTW9kZWwsIHVpbnQ2NF90IGRpc2tGcmVlU2l6ZSwgdW5zaWduZWQm IHVybENhY2hlTWVtb3J5Q2FwYWNpdHksIHVpbnQ2NF90JiB1cmxDYWNoZURpc2tDYXBhY2l0eSkK K3ZvaWQgY2FsY3VsYXRlVVJMQ2FjaGVTaXplcyhDYWNoZU1vZGVsIGNhY2hlTW9kZWwsIHVpbnQ2 NF90IGRpc2tGcmVlU2l6ZSwgdWludDY0X3QmIHVybENhY2hlRGlza0NhcGFjaXR5KQogewogICAg IHN3aXRjaCAoY2FjaGVNb2RlbCkgewogICAgIGNhc2UgQ2FjaGVNb2RlbDo6RG9jdW1lbnRWaWV3 ZXI6IHsKLSAgICAgICAgLy8gRm91bmRhdGlvbiBtZW1vcnkgY2FjaGUgY2FwYWNpdHkgKGluIGJ5 dGVzKQotICAgICAgICB1cmxDYWNoZU1lbW9yeUNhcGFjaXR5ID0gMDsKLQogICAgICAgICAvLyBE aXNrIGNhY2hlIGNhcGFjaXR5IChpbiBieXRlcykKICAgICAgICAgdXJsQ2FjaGVEaXNrQ2FwYWNp dHkgPSAwOwogCiAgICAgICAgIGJyZWFrOwogICAgIH0KICAgICBjYXNlIENhY2hlTW9kZWw6OkRv Y3VtZW50QnJvd3NlcjogewotICAgICAgICB1aW50NjRfdCBtZW1vcnlTaXplID0gcmFtU2l6ZSgp IC8gTUI7Ci0KLSAgICAgICAgLy8gRm91bmRhdGlvbiBtZW1vcnkgY2FjaGUgY2FwYWNpdHkgKGlu IGJ5dGVzKQotICAgICAgICBpZiAobWVtb3J5U2l6ZSA+PSAyMDQ4KQotICAgICAgICAgICAgdXJs Q2FjaGVNZW1vcnlDYXBhY2l0eSA9IDQgKiBNQjsKLSAgICAgICAgZWxzZSBpZiAobWVtb3J5U2l6 ZSA+PSAxMDI0KQotICAgICAgICAgICAgdXJsQ2FjaGVNZW1vcnlDYXBhY2l0eSA9IDIgKiBNQjsK LSAgICAgICAgZWxzZSBpZiAobWVtb3J5U2l6ZSA+PSA1MTIpCi0gICAgICAgICAgICB1cmxDYWNo ZU1lbW9yeUNhcGFjaXR5ID0gMSAqIE1COwotICAgICAgICBlbHNlCi0gICAgICAgICAgICB1cmxD YWNoZU1lbW9yeUNhcGFjaXR5ID0gNTEyICogS0I7Ci0KICAgICAgICAgLy8gRGlzayBjYWNoZSBj YXBhY2l0eSAoaW4gYnl0ZXMpCiAgICAgICAgIGlmIChkaXNrRnJlZVNpemUgPj0gMTYzODQpCiAg ICAgICAgICAgICB1cmxDYWNoZURpc2tDYXBhY2l0eSA9IDc1ICogTUI7CkBAIC0xNjMsMjYgKzE0 OCw2IEBAIHZvaWQgY2FsY3VsYXRlVVJMQ2FjaGVTaXplcyhDYWNoZU1vZGVsIGNhY2hlTW9kZWws IHVpbnQ2NF90IGRpc2tGcmVlU2l6ZSwgdW5zaWduCiAgICAgICAgIGJyZWFrOwogICAgIH0KICAg ICBjYXNlIENhY2hlTW9kZWw6OlByaW1hcnlXZWJCcm93c2VyOiB7Ci0gICAgICAgIHVpbnQ2NF90 IG1lbW9yeVNpemUgPSByYW1TaXplKCkgLyBNQjsKLQotI2lmIFBMQVRGT1JNKElPU19GQU1JTFkp Ci0gICAgICAgIGlmIChtZW1vcnlTaXplID49IDEwMjQpCi0gICAgICAgICAgICB1cmxDYWNoZU1l bW9yeUNhcGFjaXR5ID0gMTYgKiBNQjsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAgdXJsQ2Fj aGVNZW1vcnlDYXBhY2l0eSA9IDggKiBNQjsKLSNlbHNlCi0gICAgICAgIC8vIEZvdW5kYXRpb24g bWVtb3J5IGNhY2hlIGNhcGFjaXR5IChpbiBieXRlcykKLSAgICAgICAgLy8gKFRoZXNlIHZhbHVl cyBhcmUgc21hbGwgYmVjYXVzZSBXZWJDb3JlIGRvZXMgbW9zdCBjYWNoaW5nIGl0c2VsZi4pCi0g ICAgICAgIGlmIChtZW1vcnlTaXplID49IDEwMjQpCi0gICAgICAgICAgICB1cmxDYWNoZU1lbW9y eUNhcGFjaXR5ID0gNCAqIE1COwotICAgICAgICBlbHNlIGlmIChtZW1vcnlTaXplID49IDUxMikK LSAgICAgICAgICAgIHVybENhY2hlTWVtb3J5Q2FwYWNpdHkgPSAyICogTUI7Ci0gICAgICAgIGVs c2UgaWYgKG1lbW9yeVNpemUgPj0gMjU2KQotICAgICAgICAgICAgdXJsQ2FjaGVNZW1vcnlDYXBh Y2l0eSA9IDEgKiBNQjsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAgdXJsQ2FjaGVNZW1vcnlD YXBhY2l0eSA9IDUxMiAqIEtCOwotI2VuZGlmCi0KICAgICAgICAgLy8gRGlzayBjYWNoZSBjYXBh Y2l0eSAoaW4gYnl0ZXMpCiAgICAgICAgIGlmIChkaXNrRnJlZVNpemUgPj0gMTYzODQpCiAgICAg ICAgICAgICB1cmxDYWNoZURpc2tDYXBhY2l0eSA9IDEgKiBHQjsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvU2hhcmVkL0NhY2hlTW9kZWwuaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0NhY2hl TW9kZWwuaAppbmRleCBiNWNkOWZlYjRiNzgzYjEyZjA0YTE1NDk5MTM3ZjcxNGI1NDFiNmYwLi4x YjZjOTE4ZDBmMzMxYzhjMTE1YmRkZWNiZTM5MWJkNzQxYWQ2YjJlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1NoYXJlZC9DYWNoZU1vZGVsLmgKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQv Q2FjaGVNb2RlbC5oCkBAIC0zOSw3ICszOSw3IEBAIGVudW0gY2xhc3MgQ2FjaGVNb2RlbCA6IHVp bnQ4X3QgewogfTsKIAogdm9pZCBjYWxjdWxhdGVNZW1vcnlDYWNoZVNpemVzKENhY2hlTW9kZWws IHVuc2lnbmVkJiBjYWNoZVRvdGFsQ2FwYWNpdHksIHVuc2lnbmVkJiBjYWNoZU1pbkRlYWRDYXBh Y2l0eSwgdW5zaWduZWQmIGNhY2hlTWF4RGVhZENhcGFjaXR5LCBTZWNvbmRzJiBkZWFkRGVjb2Rl ZERhdGFEZWxldGlvbkludGVydmFsLCB1bnNpZ25lZCYgYmFja0ZvcndhcmRDYWNoZUNhcGFjaXR5 KTsKLXZvaWQgY2FsY3VsYXRlVVJMQ2FjaGVTaXplcyhDYWNoZU1vZGVsLCB1aW50NjRfdCBkaXNr RnJlZVNpemUsIHVuc2lnbmVkJiB1cmxDYWNoZU1lbW9yeUNhcGFjaXR5LCB1aW50NjRfdCYgdXJs Q2FjaGVEaXNrQ2FwYWNpdHkpOwordm9pZCBjYWxjdWxhdGVVUkxDYWNoZVNpemVzKENhY2hlTW9k ZWwsIHVpbnQ2NF90IGRpc2tGcmVlU2l6ZSwgdWludDY0X3QmIHVybENhY2hlRGlza0NhcGFjaXR5 KTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CiAK