<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>240543</bug_id>
          
          <creation_ts>2022-05-17 15:24:22 -0700</creation_ts>
          <short_desc>[Python3] Fix Tools/Scripts/check-for-invalid-symbols-in-version-script</short_desc>
          <delta_ts>2022-05-17 16:19:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=237442</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adrian Perez">aperez</reporter>
          <assigned_to name="Adrian Perez">aperez</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1869827</commentid>
    <comment_count>0</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2022-05-17 15:24:22 -0700</bug_when>
    <thetext>Traceback (most recent call last):
  File &quot;/app/webkit/Tools/Scripts/check-for-invalid-symbols-in-version-script&quot;, line 33, in &lt;module&gt;
    if symbol not in data:
TypeError: a bytes-like object is required, not &apos;str&apos;

---

As with other recent examples we need to decode the bytes objects
returned by reading from the popen stream into strings (see the fix
for “check-for-global-bss-symbols-in-webkitgtk-libs”, bug #237442,
for an example of a similar fix)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1869828</commentid>
    <comment_count>1</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2022-05-17 15:31:07 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/699</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1869846</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-05-17 16:18:37 -0700</bug_when>
    <thetext>Committed r294358 (250663@main): &lt;https://commits.webkit.org/250663@main&gt;

Reviewed commits have been landed. Closing PR #699 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1869847</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-05-17 16:19:13 -0700</bug_when>
    <thetext>&lt;rdar://problem/93460708&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>