240540 2022-05-17 14:33:00 -0700 [CMake][Visual Studio] PrivateHeaders/JavaScriptCore/InspectorProtocolObjects.h isn't regenerated in incremental builds 2022-05-18 19:29:23 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fujii fujii annulen don.olmstead ews-watchlist gyuyoung.kim keith_miller mark.lam msaboff ryuan.choi saam sergio tzagallo yurys oldest_to_newest 1869807 0 fujii 2022-05-17 14:33:00 -0700 [CMake][Visual Studio] PrivateHeaders/JavaScriptCore/InspectorProtocolObjects.h isn't regenerated in incremental builds Reported in bug#240326 comment#14. This looks like same with the following bug: Bug 240297 – [CMake][VS] PrivateHeaders/WebCore/WebCoreJSBuiltinInternals.h is not updated in incremental build 1869814 1 459517 fujii 2022-05-17 15:01:07 -0700 Created attachment 459517 Patch 1869822 2 yurys 2022-05-17 15:14:04 -0700 Looking at Source/JavaScriptCore/CMakeLists.txt the dependency chain looks correct to me but I see that there are two entries like this: ``` MAIN_DEPENDENCY ${JavaScriptCore_DERIVED_SOURCES_DIR}/CombinedDomains.json ``` one is for C++ bindings and the other is for inspector UI. At the same time Cmake documentation for MAIN_DEPENDENCY says[1]: ``` MAIN_DEPENDENCY <...> Each source file may have at most one command specifying it as its main dependency. <...> ``` I wonder if that causes InspectorProtocolObjects.h to not be properly recompiled. Fujii, what do you think? [1] https://cmake.org/cmake/help/latest/command/add_custom_command.html 1869874 3 fujii 2022-05-17 17:18:56 -0700 Do you mean a change like this? https://gist.github.com/fujii/af58b4f46bbaac0aa91c072072a2a975 This change doesn't fix this bug. 1869876 4 yurys 2022-05-17 17:22:02 -0700 (In reply to Fujii Hironori from comment #3) > Do you mean a change like this? > https://gist.github.com/fujii/af58b4f46bbaac0aa91c072072a2a975 > > This change doesn't fix this bug. Yes, just my guess. 1870246 5 ews-feeder 2022-05-18 19:29:20 -0700 Committed r294462 (250724@main): <https://commits.webkit.org/250724@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459517. 459517 2022-05-17 15:01:07 -0700 2022-05-18 19:29:22 -0700 Patch bug-240540-20220518070106.patch text/plain 1757 fujii RnJvbSAzNTMxMTYyODIxMDhiZmQzZTE3Mzk0MzM1MjY2NmNjN2QwZDY3MTU0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBIaXJvbm9yaSA8SGlyb25vcmkuRnVqaWlAc29ueS5j b20+CkRhdGU6IFdlZCwgMTggTWF5IDIwMjIgMDY6NTI6NDggKzA5MDAKU3ViamVjdDogW1BBVENI XSBbQ01ha2VdW1Zpc3VhbCBTdHVkaW9dCiBQcml2YXRlSGVhZGVycy9KYXZhU2NyaXB0Q29yZS9J bnNwZWN0b3JQcm90b2NvbE9iamVjdHMuaCBpc24ndCByZWdlbmVyYXRlZCBpbgogaW5jcmVtZW50 YWwgYnVpbGRzIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDA1NDAK ClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKSW4gQ01ha2UgVmlzdWFsIFN0dWRpbyBnZW5l cmF0b3IgYnVpbGRzLCBJbnNwZWN0b3JQcm90b2NvbE9iamVjdHMuaAp3YXMgbm90IGNvcGllZCB0 byB0aGUgcHJpdmF0ZSBoZWFkZXJzIGRpcmVjdG9yeSBhcyBleHBlY3RlZCBpbgppbmNyZW1lbnRh bCBidWlsZHMuCgoke0phdmFTY3JpcHRDb3JlX0RFUklWRURfU09VUkNFU19ESVJ9L2luc3BlY3Rv ci9JbnNwZWN0b3JQcm90b2NvbE9iamVjdHMuaAp3YXMgYWRkZWQgdG8gYm90aCBKYXZhU2NyaXB0 Q29yZV9QUklWQVRFX0ZSQU1FV09SS19IRUFERVJTIGFuZApKYXZhU2NyaXB0Q29yZV9IRUFERVJT LiBUaGlzIGNhdXNlZCB0aGUgaW5jcmVtZW50YWwgYnVpbGQgcHJvYmxlbS4KRG9uJ3QgYWRkIHN1 Y2ggaGVhZGVycyB0byBKYXZhU2NyaXB0Q29yZV9IRUFERVJTLgoKKiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvQ01ha2VMaXN0cy50eHQ6Ci0tLQogU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlz dHMudHh0IHwgNyAtLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNyBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggZTZlZDdlZDQwNjM3Li4xMTc2OGMyY2Iz MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTEzOTksMTMgKzEzOTks NiBAQCBhZGRfY3VzdG9tX2NvbW1hbmQoCiAgICAgVkVSQkFUSU0pCiBhZGRfY3VzdG9tX3Rhcmdl dChJbnNwZWN0b3JCYWNrZW5kQ29tbWFuZHMgREVQRU5EUyAiJHtKYXZhU2NyaXB0Q29yZV9ERVJJ VkVEX1NPVVJDRVNfRElSfS9pbnNwZWN0b3IvSW5zcGVjdG9yQmFja2VuZENvbW1hbmRzLmpzIikK IAotbGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVfSEVBREVSUwotICAgICR7SmF2YVNjcmlwdENv cmVfREVSSVZFRF9TT1VSQ0VTX0RJUn0vaW5zcGVjdG9yL0luc3BlY3RvckJhY2tlbmREaXNwYXRj aGVycy5oCi0gICAgJHtKYXZhU2NyaXB0Q29yZV9ERVJJVkVEX1NPVVJDRVNfRElSfS9pbnNwZWN0 b3IvSW5zcGVjdG9yRnJvbnRlbmREaXNwYXRjaGVycy5oCi0gICAgJHtKYXZhU2NyaXB0Q29yZV9E RVJJVkVEX1NPVVJDRVNfRElSfS9pbnNwZWN0b3IvSW5zcGVjdG9yUHJvdG9jb2xPYmplY3RzLmgK LSAgICAke0phdmFTY3JpcHRDb3JlX0RFUklWRURfU09VUkNFU19ESVJ9L0pTQ0J1aWx0aW5zLmgK LSkKLQogaWYgKFdURl9DUFVfWDg2XzY0KQogICAgIGlmIChNU1ZDIEFORCBOT1QgRU5BQkxFX0Nf TE9PUCkKICAgICAgICAgYWRkX2N1c3RvbV9jb21tYW5kKAotLSAKMi4yNS4xCgo=