240535 2022-05-17 13:32:50 -0700 [WPE][GTK] Improve dependency tracking of PDF.js files (and other GResources) 2022-05-19 13:59:15 -0700 1 1 1 Unclassified WebKit PDF WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply mcatanzaro ntim thorton webkit-bug-importer oldest_to_newest 1869785 0 mcatanzaro 2022-05-17 13:32:50 -0700 In https://github.com/WebKit/WebKit/pull/654#issuecomment-1128776747 we found an issue with CMake incremental builds of PDF.js not working correctly. In that PR, I wound up using CONFIGURE_DEPENDS as a solution, but ideally we should not be using GLOB here at all. The CMake documentation explicitly warns against doing this at https://cmake.org/cmake/help/latest/command/file.html#filesystem. I modified the generate-pdfjs-gresource-manifest.py script to generate a PdfJSFiles.cmake containing a list of files instead, but might not submit this solution because at https://github.com/WebKit/WebKit/pull/654#issuecomment-1129262642 we received a suggestion to use CMake's DEPFILES feature instead. glib-compile-resources can generate the depfile for us, so this is probably going to be the better approach. 1869882 1 mcatanzaro 2022-05-17 17:43:20 -0700 Pull request: https://github.com/WebKit/WebKit/pull/709 1870520 2 ews-feeder 2022-05-19 13:58:12 -0700 Committed r294504 (250761@main): <https://commits.webkit.org/250761@main> Reviewed commits have been landed. Closing PR #709 and removing active labels. 1870521 3 webkit-bug-importer 2022-05-19 13:59:15 -0700 <rdar://problem/93601221>