240495 2022-05-16 18:12:57 -0700 REGRESSION (r294215): [ iOS ] Nine focus ring tests are a consistent image failure 2022-05-17 17:08:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 240452 InRadar P2 Normal --- 240452 1 rackler rackler bfulgham kkinnunen simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer zalan oldest_to_newest 1869526 0 rackler 2022-05-16 18:12:57 -0700 Description: fast/css/paint-order-shadow.html fast/forms/ios/focus-ring-size.html fast/inline/hidpi-outline-auto-negative-offset-with-border-radius.html fast/inline/hidpi-outline-auto-with-border-radius-horizontal-ltr.html fast/inline/hidpi-outline-auto-with-border-radius-horizontal-rtl.html fast/inline/hidpi-outline-auto-with-border-radius-vertical-ltr.html fast/inline/hidpi-outline-auto-with-border-radius-vertical-rtl.html fast/inline/hidpi-outline-auto-with-fractional-radius.html fast/inline/hidpi-outline-auto-with-one-focusring-rect.html The first failure I saw on the dashboard was on 5/15/2022 at r294215. r294215 modified use of WebCore::IOSurface has WebCore::GraphicsContext so that probably introduced the consistent image failure. REPRODUCTION STEPS I can reproduce this on r294215, but unable to reproduce on r294214 or earlier. Command: run-webkit-tests --root 294215 --ios-simulator --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 --no-retry fast/inline/hidpi-outline-auto-with-border-radius-horizontal-rtl.html Result: Regressions: Unexpected image-only failures (1) fast/inline/hidpi-outline-auto-with-border-radius-horizontal-rtl.html [ ImageOnlyFailure ] History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Finline%2Fhidpi-outline-auto-with-border-radius-horizontal-ltr.html&test=fast%2Finline%2Fhidpi-outline-auto-with-border-radius-vertical-ltr.html&test=fast%2Finline%2Fhidpi-outline-auto-with-border-radius-vertical-rtl.html&test=css3%2Fcolor-filters%2Fsvg%2Fcolor-filter-inline-svg.html&test=fast%2Fcss%2Fpaint-order-shadow.html&test=fast%2Fforms%2Fios%2Ffocus-ring-size.html&test=fast%2Finline%2Fhidpi-outline-auto-with-fractional-radius.html&test=fast%2Finline%2Fhidpi-outline-auto-with-one-focusring-rect.html&test=css3%2Fcolor-filters%2Fsvg%2Fcolor-filter-inline-svg.html&test=fast%2Fcss%2Fpaint-order-shadow.html&test=fast%2Fforms%2Fios%2Ffocus-ring-size.html&limit=50000&platform=ios Image Diff: fast/css/paint-order-shadow.html https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/css/paint-order-shadow-diffs.html fast/forms/ios/focus-ring-size.html https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/forms/ios/focus-ring-size-diffs.html fast/inline/hidpi-outline-auto-negative-offset-with-border-radius.html https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/inline/hidpi-outline-auto-negative-offset-with-border-radius-diffs.html fast/inline/hidpi-outline-auto-with-border-radius-horizontal-ltr.html https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/inline/hidpi-outline-auto-with-border-radius-horizontal-ltr-diffs.html fast/inline/hidpi-outline-auto-with-border-radius-horizontal-rtl.html https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/inline/hidpi-outline-auto-with-border-radius-horizontal-rtl-diffs.html fast/inline/hidpi-outline-auto-with-border-radius-vertical-ltr.html https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/inline/hidpi-outline-auto-with-border-radius-vertical-ltr-diffs.html fast/inline/hidpi-outline-auto-with-border-radius-vertical-rtl.html https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/inline/hidpi-outline-auto-with-border-radius-vertical-rtl-diffs.html fast/inline/hidpi-outline-auto-with-fractional-radius.html https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/inline/hidpi-outline-auto-with-fractional-radius-diffs.html fast/inline/hidpi-outline-auto-with-one-focusring-rect.html https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-GPUProcess-arm64-WK2-Tests/250573@main%20(1679)/fast/inline/hidpi-outline-auto-with-one-focusring-rect-diffs.html 1869527 1 webkit-bug-importer 2022-05-16 18:13:18 -0700 <rdar://problem/93385433> 1869533 2 rackler 2022-05-16 18:27:37 -0700 I have marked these tests as consistent image failures while this issue is investigated. 1869534 3 rackler 2022-05-16 18:30:25 -0700 Pull request: https://github.com/WebKit/WebKit/pull/659 1869535 4 ews-feeder 2022-05-16 18:33:28 -0700 Test gardening commit r294283 (250627@main): <https://commits.webkit.org/250627@main> Reviewed commits have been landed. Closing PR #659 and removing active labels. 1869544 5 simon.fraser 2022-05-16 19:21:07 -0700 Looks like the focus rings are missing from the expected results. 1869612 6 kkinnunen 2022-05-17 01:55:00 -0700 In r294215 I missed that m_needsSetupContext started as false, and it ends up skipping one of the subtly recursive applyBaseTransformToContext() calls. This is fixed in bug 240452 1869723 7 ap 2022-05-17 10:20:12 -0700 So this should be marked as a dupe of bug 240452, and test gardening should be reverted? 1869857 8 rackler 2022-05-17 16:37:02 -0700 Verified https://commits.webkit.org/250637@main resolved this issue. 1869862 9 rackler 2022-05-17 16:48:12 -0700 Remove gardening. 1869863 10 rackler 2022-05-17 16:48:17 -0700 Re-opening for pull request https://github.com/WebKit/WebKit/pull/706 1869865 11 ews-feeder 2022-05-17 16:51:09 -0700 Test gardening commit r294363 (250666@main): <https://commits.webkit.org/250666@main> Reviewed commits have been landed. Closing PR #706 and removing active labels. 1869870 12 rackler 2022-05-17 17:08:21 -0700 *** This bug has been marked as a duplicate of bug 240452 ***