240478 2022-05-16 14:09:52 -0700 check-webkit-style: validate enums declared with explicit type 2022-05-17 15:02:13 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yurys yurys ews-watchlist glenn hi jbedard webkit-bug-importer oldest_to_newest 1869401 0 yurys 2022-05-16 14:09:52 -0700 check-webkit-style: validate enums declared with explicit type 1869402 1 459453 yurys 2022-05-16 14:12:10 -0700 Created attachment 459453 Patch 1869404 2 yurys 2022-05-16 14:12:58 -0700 This was discovered while looking at the style bot failures inhttps://bugs.webkit.org/show_bug.cgi?id=240326 1869755 3 459453 hi 2022-05-17 12:16:30 -0700 Comment on attachment 459453 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459453&action=review rs=mews > Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:4396 > + '''enum class Type : uint8_t { FIRST, SECOND };''', i'd include some valid test cases too (e.g. `enum class Foo : uint8_t { First, Second }`) 1869783 4 yurys 2022-05-17 13:31:10 -0700 Pull request: https://github.com/WebKit/WebKit/pull/688 1869784 5 459453 yurys 2022-05-17 13:32:08 -0700 Comment on attachment 459453 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459453&action=review >> Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:4396 >> + '''enum class Type : uint8_t { FIRST, SECOND };''', > > i'd include some valid test cases too (e.g. `enum class Foo : uint8_t { First, Second }`) Done. 1869815 6 ews-feeder 2022-05-17 15:01:38 -0700 Committed r294351 (250659@main): <https://commits.webkit.org/250659@main> Reviewed commits have been landed. Closing PR #688 and removing active labels. 1869816 7 webkit-bug-importer 2022-05-17 15:02:13 -0700 <rdar://problem/93455377> 459453 2022-05-16 14:12:10 -0700 2022-05-17 13:32:26 -0700 Patch bug-240478-20220516141210.patch text/plain 3088 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMjk0MDc3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzU0NWQyMzE5OTJiZDk2ODVkNTkzMjIwMWRhNmQ0ZGUy YjI4OGMxNC4uODBmOWFiNjhmMDQ0ZGQ5YWZmMTNkMGNkNDY1ODhhMzc4MzQwYTkxMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIyLTA1LTE2ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgor CisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZTogdmFsaWRhdGUgZW51bXMgZGVjbGFyZWQgd2l0 aCBleHBsaWNpdCB0eXBlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yNDA0NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAg ICAgICAgCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBub3cgdmFsaWRhdGVzIGNhc2Ugb2Yg dGhlIGVudW1zIGRlbGNhcmVkIHdpdGggZXhwbGljaXQKKyAgICAgICAgdHlwZSBzcGVjaWZpZXIu CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKKyAg ICAgICAgKF9FbnVtU3RhdGUucHJvY2Vzc19jbGVhbl9saW5lKToKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weToKKyAgICAgICAgKE5vTm9u VmlydHVhbERlc3RydWN0b3JzVGVzdCk6CisKIDIwMjItMDUtMTAgIFdlbnNvbiBIc2llaCAgPHdl bnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYnBhZ2UgVHJhbnNsYXRpb25dIEF2 b2lkIHJlbW92aW5nIGVsZW1lbnRzIHdpdGggbm8gY2hpbGRyZW4gZHVyaW5nIHRleHQgbWFuaXB1 bGF0aW9uCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5Cmlu ZGV4IGYzMDY0ZmM2MDA4MDVkYzQ4NWNmYWJjNWU5MTM1NzNhYzVmODM5YTkuLjhjOWY5NDdjZWM4 NTg0N2NjOTAwYzY3YWZhMzgwYTA3ODE4NWMxOGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0xMzU2LDcgKzEzNTYsNyBAQCBjbGFzcyBfRW51 bVN0YXRlKG9iamVjdCk6CiAgICAgICAgIGV4cHJfYWxsX3VwcGVyY2FzZSA9IHInXHMqW0EtWjAt OV9dK1xzKig/Oj1ccypbYS16QS1aMC05XStccyopPyw/XHMqJCcKICAgICAgICAgZXhwcl9zdGFy dHNfbG93ZXJjYXNlID0gcidccypbYS1qbC16XScKICAgICAgICAgZXhwcl9lbnVtX2VuZCA9IHIn fVxzKig/OlthLXpBLVowLTldK1xzKig/Oj1ccypbYS16QS1aMC05XSspPyk/XHMqO1xzKicKLSAg ICAgICAgZXhwcl9lbnVtX3N0YXJ0ID0gcidccyooPzplbnVtKD86XHMrY2xhc3MpPyg/OlxzKyg/ UDxpZGVudGlmaWVyPlthLXpBLVowLTldKykpPylccypcez9ccyonCisgICAgICAgIGV4cHJfZW51 bV9zdGFydCA9IHInXHMqKD86ZW51bSg/OlxzK2NsYXNzKT8oPzpccysoP1A8aWRlbnRpZmllcj5b YS16QS1aMC05XSspKT8pKD86XHMqOlxzKlthLXpBLVowLTlfXSs/KT9ccypcez9ccyonCiAgICAg ICAgIGlmIHNlbGYuaW5fZW51bV9kZWNsOgogICAgICAgICAgICAgaWYgbWF0Y2gocidccyonICsg ZXhwcl9lbnVtX2VuZCArIHInJCcsIGxpbmUpOgogICAgICAgICAgICAgICAgIHNlbGYuaW5fZW51 bV9kZWNsID0gRmFsc2UKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggZjhiZmQ0NDQwYjcyM2IyMWVlODU1YmMxY2I1 NmY5MzQ3MDE3NmRlYy4uODU4YWExMWQ3NGY1ZjQxMmExMmQxZjliNWVkMWM1MzBmZTBjMzA4NiAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5p dHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBf dW5pdHRlc3QucHkKQEAgLTQzODQsNiArNDM4NCwxOCBAQCBjbGFzcyBOb05vblZpcnR1YWxEZXN0 cnVjdG9yc1Rlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAgICAgfTsnJycsCiAg ICAgICAgICAgICAnJykKIAorICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoCisg ICAgICAgICAgICAnJydcCisgICAgICAgICAgICAgICAgZW51bSBjbGFzcyBGb28gOiB1aW50OF90 IHsKKyAgICAgICAgICAgICAgICAgICAgT05FLAorICAgICAgICAgICAgICAgICAgICBUd28KKyAg ICAgICAgICAgICAgICB9OycnJywKKyAgICAgICAgICAgICdlbnVtIG1lbWJlcnMgc2hvdWxkIHVz ZSBJbnRlckNhcHMgd2l0aCBhbiBpbml0aWFsIGNhcGl0YWwgbGV0dGVyIG9yIGluaXRpYWwgXCdr XCcgZm9yIEMtc3R5bGUgZW51bXMuICBbcmVhZGFiaWxpdHkvZW51bV9jYXNpbmddIFs0XScpCisK KyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKKyAgICAgICAgICAgICcnJ2VudW0gY2xhc3MgVHlw ZSA6IHVpbnQ4X3QgeyBGSVJTVCwgU0VDT05EIH07JycnLAorICAgICAgICAgICAgJ2VudW0gbWVt YmVycyBzaG91bGQgdXNlIEludGVyQ2FwcyB3aXRoIGFuIGluaXRpYWwgY2FwaXRhbCBsZXR0ZXIg b3IgaW5pdGlhbCBcJ2tcJyBmb3IgQy1zdHlsZSBlbnVtcy4gIFtyZWFkYWJpbGl0eS9lbnVtX2Nh c2luZ10gWzRdJykKKwogICAgICAgICBzZWxmLmFzc2VydF9saW50KAogICAgICAgICAgICAgJycn ZW51bSB7IGFPbmUgPSAxLCB6VHdvID0gMiB9OycnJywKICAgICAgICAgICAgICdlbnVtIG1lbWJl cnMgc2hvdWxkIHVzZSBJbnRlckNhcHMgd2l0aCBhbiBpbml0aWFsIGNhcGl0YWwgbGV0dGVyIG9y IGluaXRpYWwgXCdrXCcgZm9yIEMtc3R5bGUgZW51bXMuICBbcmVhZGFiaWxpdHkvZW51bV9jYXNp bmddIFs0XScpCg==