240472 2022-05-16 12:00:46 -0700 [WPE][GTK] Add more padding to WebKitWebView vtable 2023-01-26 08:31:10 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 210100 1 mcatanzaro mcatanzaro aperez bugs-noreply mcatanzaro oldest_to_newest 1869355 0 mcatanzaro 2022-05-16 12:00:46 -0700 We're running out of room in the WebKitWebView vtable. Let's add more padding here than we're likely to need (when building with newer API versions). And let's also review other vtables and add more padding where it looks useful. 1927928 1 mcatanzaro 2023-01-24 13:55:29 -0800 Actually most vtables will no longer be public after bug #243663, except notably WebKitWebView. This object should receive a _very_ healthy amount of padding IMO. 1928228 2 mcatanzaro 2023-01-25 12:16:03 -0800 So currently the vtable is 29 bytes for GTK, with zero bytes of padding remaining. WPE uses a little bit less and has 5 bytes of padding remaining. Let's go crazy and add 30 bytes. I think we can afford to splurge here because web views are relatively rare. 1928231 3 mcatanzaro 2023-01-25 12:19:24 -0800 Pull request: https://github.com/WebKit/WebKit/pull/9139 1928282 4 aperez 2023-01-25 14:53:34 -0800 (In reply to Michael Catanzaro from comment #2) > So currently the vtable is 29 bytes for GTK, with zero bytes of padding > remaining. WPE uses a little bit less and has 5 bytes of padding remaining. > > Let's go crazy and add 30 bytes. I think we can afford to splurge here > because web views are relatively rare. Nitpick: 30 *pointer* entries (plus 29 existing). That makes for 236 bytes on 32-bit platforms, and 472 bytes on 64-bit ones. Still reasonable to add that many, I think. 1928313 5 mcatanzaro 2023-01-25 15:57:01 -0800 Oh yeah... because pointers require more than one byte. You'll never hear me claim to be competent. 1928611 6 ews-feeder 2023-01-26 08:31:06 -0800 Committed 259425@main (5737721c0eb3): <https://commits.webkit.org/259425@main> Reviewed commits have been landed. Closing PR #9139 and removing active labels.