24043 2009-02-19 16:02:28 -0800 [GTK] Workers with url 'about:blank' do not load 2009-02-25 14:16:02 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 zan webkit-unassigned ap oldest_to_newest 110312 0 zan 2009-02-19 16:02:28 -0800 This problem can be seen in fast/events/dispatchEvent-crash.html[1] test that is timing out on the Gtk buildbot. In the test, Worker is given a 'about:blank' URL. Normally, when loading about:blank through MainResourceLoader, we catch blank URLs and prevent loading them, i.e. we finish loading and do not proceed with actions, which otherwise at some point end up in ResourceHandle::start. Worker uses Loader and ResourceLoader as its loaders, which do not check for blank URLs. Therefor, we do get to ResourceHandle::start. From there on, it seems that it depends on the network backend how about:blank is handled, but that should not be the case. Therefor, while the test is only failing for the Gtk port, I believe fix can be applied directly into WebCore, as I tend to blame network backends of non-Gtk ports being able to properly handle about:blank (which I only assume) while LibSoup fails to do so. As a fix, shouldLoadAsEmptyDocument() should be made available for other loaders and properly planted into the Worker's loaders. [1]: http://trac.webkit.org/browser/trunk/LayoutTests/fast/events/dispatchEvent-crash.html 110341 1 27820 zan 2009-02-19 18:38:40 -0800 Created attachment 27820 Check URL prior to loading it in SubresourceLoader Moved shouldLoadAsEmptyDocument to a better spot. Planted a check if request's URL should load as an empty document. With patch applied, the test causing regression successfully passes. 110352 2 27820 ap 2009-02-19 23:23:11 -0800 Comment on attachment 27820 Check URL prior to loading it in SubresourceLoader I don't think that this is correct - trying to load about:blank as a non-main resource should result in a failure due to unknown protocol in the loader (just like any foo:bar URL would). There is no reason to special-case "about:". Why does this test time out? It doesn't use layoutTestController.waitUntilDone(), and it doesn't depend on the results of loading the worker script in any way that I could see. 110399 3 27830 zan 2009-02-20 08:29:52 -0800 Created attachment 27830 Report errors through an idle function when faced unsupported URL protocols Catches URLs with unsupported protocol and adds idle function to the main loop that reports error to resource handle's client. In Loader::Host::servePendingRequests, a subresource loader is created for every pending request with SubresourceLoader::create, but not yet added to the map of loaders with requests that Loader::Host holds. In this function, the return value of ResourceLoader::load is subsequently checked, which causes to create a resource handle with ResourceHandle::create, which also calls ResourceHandle::start. There, we check the protocol of request's URL. In the case of bogus URLs, such as about:blank or foo:bar, we immediately call didFail on the handle's client. This results in premature return in Loader::Host::didFail and therefor we never get to call error on resource of the request because the latter hasn't yet been added to the map of loaders with requests. To fix this, instead of immediately calling didFail on an URL with unknown protocol, we add an idle function into the main loop. We also must return true, otherwise there is no handle returned in ResourceHandle::create. This lets things to move on - loader and request are added to the map, idle function is executed and failure is reported, from there the error to the cached resource is announced, which brings worker to the hold with calling notifyFinished. With patch, test passes with no new regressions. 110407 4 27830 zan 2009-02-20 10:39:06 -0800 Comment on attachment 27830 Report errors through an idle function when faced unsupported URL protocols Forgot to set the review flag the first time. 110410 5 27830 ap 2009-02-20 11:06:51 -0800 Comment on attachment 27830 Report errors through an idle function when faced unsupported URL protocols What happens if the request is canceled while waiting for the idle handler to fire? 110441 6 zan 2009-02-20 15:05:25 -0800 (In reply to comment #5) > What happens if the request is canceled while waiting for the idle handler to > fire? Utter failure :) Will post a patch with checks in near future. 110444 7 27841 zan 2009-02-20 15:37:27 -0800 Created attachment 27841 Report errors through an idle function when faced unsupported URL protocols Added checks if client exists and the request is not canceled. 110448 8 27844 zan 2009-02-20 16:07:03 -0800 Created attachment 27844 Report errors through an idle function when faced unsupported URL protocols Also checks for existing handle, properly uses ResourceHandleInternal. 110464 9 27844 ap 2009-02-20 23:42:39 -0800 Comment on attachment 27844 Report errors through an idle function when faced unsupported URL protocols > + ResourceHandle* handle = static_cast<ResourceHandle*>(callback_data); > + if (!handle) > + return FALSE; I don't see how the handle can possibly be null. The callback data is set to "this" in start(), and can't be modified by WebCore. Looks like you need to ref() the handle when creating an idle handler, and deref it when reportError() is done. 110730 10 27916 zan 2009-02-24 07:01:15 -0800 Created attachment 27916 Report errors through an idle function when faced unsupported URL protocols Now made to rely on reference counting. 110731 11 27916 ap 2009-02-24 07:08:29 -0800 Comment on attachment 27916 Report errors through an idle function when faced unsupported URL protocols > +static gboolean reportError(gpointer callback_data) I think that this function could use a more descriptive name, like reportUnknownProtocolError. r=me with or without this change. 111034 12 gustavo 2009-02-25 14:16:02 -0800 Landed as r41226 with the function rename proposed by ap. 27820 2009-02-19 18:38:40 -0800 2009-02-20 08:29:52 -0800 Check URL prior to loading it in SubresourceLoader blankworker.diff text/plain 2719 zan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDE5NDk2MS4uM2EwZDBjZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wMi0xOSAgWmFuIERvYmVyc2Vr ICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNDA0MworICAgICAgICBXb3JrZXJzIHdpdGggJ2Fib3V0OmJsYW5rJyBnaXZlbiBhcyBVUkwg ZG8gbm90IGxvYWQgb24gR3RrIHBvcnQuCisgICAgICAgIENoZWNrIFVSTCBiZWZvcmUgbG9hZGlu ZyBpdCBpbiBTdWJyZXNvdXJjZUxvYWRlci4KKworICAgICAgICAqIGxvYWRlci9NYWluUmVzb3Vy Y2VMb2FkZXIuY3BwOgorICAgICAgICAqIGxvYWRlci9SZXNvdXJjZUxvYWRlci5oOgorICAgICAg ICAoV2ViQ29yZTo6c2hvdWxkTG9hZEFzRW1wdHlEb2N1bWVudCk6CisgICAgICAgICogbG9hZGVy L1N1YnJlc291cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN1YnJlc291cmNlTG9h ZGVyOjpjcmVhdGUpOgorCiAyMDA5LTAyLTE4ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQnJhZHkgRWlkc29uLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9sb2FkZXIvTWFpblJlc291cmNlTG9hZGVyLmNwcCBiL1dlYkNvcmUvbG9hZGVyL01haW5S ZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggYjYyNThhNi4uOTU4MTgzZiAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9sb2FkZXIvTWFpblJlc291cmNlTG9hZGVyLmNwcAorKysgYi9XZWJDb3JlL2xvYWRlci9N YWluUmVzb3VyY2VMb2FkZXIuY3BwCkBAIC0xODQsMTUgKzE4NCw2IEBAIHZvaWQgTWFpblJlc291 cmNlTG9hZGVyOjp3aWxsU2VuZFJlcXVlc3QoUmVzb3VyY2VSZXF1ZXN0JiBuZXdSZXF1ZXN0LCBj b25zdCBSZXNvCiAgICAgZnJhbWVMb2FkZXIoKS0+Y2hlY2tOYXZpZ2F0aW9uUG9saWN5KG5ld1Jl cXVlc3QsIGNhbGxDb250aW51ZUFmdGVyTmF2aWdhdGlvblBvbGljeSwgdGhpcyk7CiB9CiAKLXN0 YXRpYyBib29sIHNob3VsZExvYWRBc0VtcHR5RG9jdW1lbnQoY29uc3QgS1VSTCYgdXJsKQotewot I2lmIFBMQVRGT1JNKFRPUkNITU9CSUxFKQotICAgIHJldHVybiB1cmwuaXNFbXB0eSgpIHx8ICh1 cmwucHJvdG9jb2xJcygiYWJvdXQiKSAmJiBlcXVhbElnbm9yaW5nUmVmKHVybCwgYmxhbmtVUkwo KSkpOwotI2Vsc2UgCi0gICAgcmV0dXJuIHVybC5pc0VtcHR5KCkgfHwgdXJsLnByb3RvY29sSXMo ImFib3V0Iik7Ci0jZW5kaWYKLX0KLQogdm9pZCBNYWluUmVzb3VyY2VMb2FkZXI6OmNvbnRpbnVl QWZ0ZXJDb250ZW50UG9saWN5KFBvbGljeUFjdGlvbiBjb250ZW50UG9saWN5LCBjb25zdCBSZXNv dXJjZVJlc3BvbnNlJiByKQogewogICAgIEtVUkwgdXJsID0gcmVxdWVzdCgpLnVybCgpOwpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuaCBiL1dlYkNvcmUvbG9hZGVy L1Jlc291cmNlTG9hZGVyLmgKaW5kZXggYzhjYzIwOC4uMDdjZDYyMSAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuaAorKysgYi9XZWJDb3JlL2xvYWRlci9SZXNvdXJj ZUxvYWRlci5oCkBAIC0xNDksNiArMTQ5LDE1IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg ICAgUmVzb3VyY2VSZXF1ZXN0IG1fZGVmZXJyZWRSZXF1ZXN0OwogICAgIH07CiAKKyAgICBzdGF0 aWMgYm9vbCBzaG91bGRMb2FkQXNFbXB0eURvY3VtZW50KGNvbnN0IEtVUkwmIHVybCkKKyAgICB7 CisgICAgI2lmIFBMQVRGT1JNKFRPUkNITU9CSUxFKQorICAgICAgICByZXR1cm4gdXJsLmlzRW1w dHkoKSB8fCAodXJsLnByb3RvY29sSXMoImFib3V0IikgJiYgZXF1YWxJZ25vcmluZ1JlZih1cmws IGJsYW5rVVJMKCkpKTsKKyAgICAjZWxzZQorICAgICAgICByZXR1cm4gdXJsLmlzRW1wdHkoKSB8 fCB1cmwucHJvdG9jb2xJcygiYWJvdXQiKTsKKyAgICAjZW5kaWYKKyAgICB9CisKIH0KIAogI2Vu ZGlmCmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHAgYi9X ZWJDb3JlL2xvYWRlci9TdWJyZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggNGEzMzllZi4uMDIxNDJh MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCisrKyBi L1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcApAQCAtNzcsNiArNzcsOSBAQCBQ YXNzUmVmUHRyPFN1YnJlc291cmNlTG9hZGVyPiBTdWJyZXNvdXJjZUxvYWRlcjo6Y3JlYXRlKEZy YW1lKiBmcmFtZSwgU3VicmVzb3VyYwogICAgICAgICBGcmFtZUxvYWRlcjo6cmVwb3J0TG9jYWxM b2FkRmFpbGVkKGZyYW1lLCByZXF1ZXN0LnVybCgpLnN0cmluZygpKTsKICAgICAgICAgcmV0dXJu IDA7CiAgICAgfQorCisgICAgaWYgKHNob3VsZExvYWRBc0VtcHR5RG9jdW1lbnQocmVxdWVzdC51 cmwoKSkpCisgICAgICAgIHJldHVybiAwOwogICAgIAogICAgIGlmIChGcmFtZUxvYWRlcjo6c2hv dWxkSGlkZVJlZmVycmVyKHJlcXVlc3QudXJsKCksIGZsLT5vdXRnb2luZ1JlZmVycmVyKCkpKQog ICAgICAgICBuZXdSZXF1ZXN0LmNsZWFySFRUUFJlZmVycmVyKCk7Cg== 27830 2009-02-20 08:29:52 -0800 2009-02-20 15:37:27 -0800 Report errors through an idle function when faced unsupported URL protocols blankworker.diff text/plain 2309 zan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDE5NDk2MS4uNGMyMjQ1NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wMi0yMCAgWmFuIERvYmVyc2Vr ICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNDA0MworICAgICAgICBXaGVuIGZhY2VkIHdpdGggVVJMcyB3aXRoIHVuc3VwcG9ydGVkIHBy b3RvY29sIG9uIEd0ayBwb3J0LAorICAgICAgICByZXBvcnQgdGhlIGVycm9yIHRocm91Z2ggYW4g aWRsZSBmdW5jdGlvbiBhbmQgcmV0dXJuIHRydWUsIHNvCisgICAgICAgIGEgcHJvcGVyIHJlc291 cmNlIGhhbmRsZSBpcyBjcmVhdGVkLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3Vw L1Jlc291cmNlSGFuZGxlU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZXBvcnRFcnJvcik6 CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6c3RhcnQpOgorCiAyMDA5LTAyLTE4 ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QnJhZHkgRWlkc29uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv UmVzb3VyY2VIYW5kbGVTb3VwLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jl c291cmNlSGFuZGxlU291cC5jcHAKaW5kZXggOTVjODM4NS4uNWM2N2E1YiAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAorKysg Yi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCkBA IC00NzEsNiArNDcxLDE4IEBAIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnN0YXJ0SHR0cChTdHJpbmcg dXJsU3RyaW5nKQogICAgIHJldHVybiB0cnVlOwogfQogCitzdGF0aWMgZ2Jvb2xlYW4gcmVwb3J0 RXJyb3IoZ3BvaW50ZXIgY2FsbGJhY2tfZGF0YSkKK3sKKyAgICBSZXNvdXJjZUhhbmRsZSogaGFu ZGxlID0gc3RhdGljX2Nhc3Q8UmVzb3VyY2VIYW5kbGUqPihjYWxsYmFja19kYXRhKTsKKyAgICBS ZXNvdXJjZUhhbmRsZUNsaWVudCogY2xpZW50ID0gaGFuZGxlLT5jbGllbnQoKTsKKworICAgIEtV UkwgdXJsID0gaGFuZGxlLT5yZXF1ZXN0KCkudXJsKCk7CisgICAgUmVzb3VyY2VFcnJvciBlcnJv cigid2Via2l0LW5ldHdvcmstZXJyb3IiLCBFUlJPUl9VTktOT1dOX1BST1RPQ09MLCB1cmwuc3Ry aW5nKCksIHVybC5wcm90b2NvbCgpKTsKKyAgICBjbGllbnQtPmRpZEZhaWwoaGFuZGxlLCBlcnJv cik7CisKKyAgICByZXR1cm4gRkFMU0U7Cit9CisKIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnN0YXJ0 KEZyYW1lKiBmcmFtZSkKIHsKICAgICBBU1NFUlQoIWQtPm1fbXNnKTsKQEAgLTQ5MiwxMiArNTA0 LDExIEBAIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnN0YXJ0KEZyYW1lKiBmcmFtZSkKICAgICAgICAg Ly8gRklYTUU6IHNob3VsZCB3ZSBiZSBkb2luZyBhbnkgb3RoZXIgcHJvdG9jb2xzIGhlcmU/CiAg ICAgICAgIHJldHVybiBzdGFydEdpbyh1cmwpOwogICAgIGVsc2UgewotICAgICAgICAvLyBJZiB3 ZSBkb24ndCBjYWxsIGRpZEZhaWwgdGhlIGpvYiBpcyBub3QgY29tcGxldGUgZm9yIHdlYmtpdCBl dmVuIGZhbHNlIGlzIHJldHVybmVkLgotICAgICAgICBpZiAoZC0+Y2xpZW50KCkpIHsKLSAgICAg ICAgICAgIFJlc291cmNlRXJyb3IgZXJyb3IoIndlYmtpdC1uZXR3b3JrLWVycm9yIiwgRVJST1Jf VU5LTk9XTl9QUk9UT0NPTCwgdXJsU3RyaW5nLCBwcm90b2NvbCk7Ci0gICAgICAgICAgICBkLT5j bGllbnQoKS0+ZGlkRmFpbCh0aGlzLCBlcnJvcik7Ci0gICAgICAgIH0KLSAgICAgICAgcmV0dXJu IGZhbHNlOworICAgICAgICAvLyBFcnJvciBtdXN0IG5vdCBiZSByZXBvcnRlZCBpbW1lZGlhdGVs eSwgYnV0IHRocm91Z2ggYW4gaWRsZSBmdW5jdGlvbi4KKyAgICAgICAgLy8gRGVzcGl0ZSBlcnJv ciwgd2Ugc2hvdWxkIHJldHVybiB0cnVlIHNvIGEgcHJvcGVyIGhhbmRsZSBpcyBjcmVhdGVkLAor ICAgICAgICAvLyB0byB3aGljaCB0aGlzIGZhaWx1cmUgY2FuIGJlIHJlcG9ydGVkLgorICAgICAg ICBkLT5tX2lkbGVIYW5kbGVyID0gZ19pZGxlX2FkZChyZXBvcnRFcnJvciwgdGhpcyk7CisgICAg ICAgIHJldHVybiB0cnVlOwogICAgIH0KIH0KIAo= 27841 2009-02-20 15:37:27 -0800 2009-02-20 16:07:03 -0800 Report errors through an idle function when faced unsupported URL protocols blankworker.diff text/plain 2382 zan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDJlZTU5OS4uMTQwNmM3MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wMi0yMCAgWmFuIERvYmVyc2Vr ICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNDA0MworICAgICAgICBXaGVuIGZhY2VkIHdpdGggVVJMcyB3aXRoIHVuc3VwcG9ydGVkIHBy b3RvY29sIG9uIEd0ayBwb3J0LAorICAgICAgICByZXBvcnQgdGhlIGVycm9yIHRocm91Z2ggYW4g aWRsZSBmdW5jdGlvbiBhbmQgcmV0dXJuIHRydWUsIHNvCisgICAgICAgIGEgcHJvcGVyIHJlc291 cmNlIGhhbmRsZSBpcyBjcmVhdGVkLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3Vw L1Jlc291cmNlSGFuZGxlU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZXBvcnRFcnJvcik6 CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6c3RhcnQpOgorCiAyMDA5LTAyLTIw ICBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciAgPHplY2tlQHNlbGZpc2gub3JnPgogCiAgICAg ICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKaW5kZXggM2M0ODA1Mi4uOGE3NDVjMyAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVT b3VwLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRs ZVNvdXAuY3BwCkBAIC00NzEsNiArNDcxLDIxIEBAIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnN0YXJ0 SHR0cChTdHJpbmcgdXJsU3RyaW5nKQogICAgIHJldHVybiB0cnVlOwogfQogCitzdGF0aWMgZ2Jv b2xlYW4gcmVwb3J0RXJyb3IoZ3BvaW50ZXIgY2FsbGJhY2tfZGF0YSkKK3sKKyAgICBSZXNvdXJj ZUhhbmRsZSogaGFuZGxlID0gc3RhdGljX2Nhc3Q8UmVzb3VyY2VIYW5kbGUqPihjYWxsYmFja19k YXRhKTsKKyAgICBSZXNvdXJjZUhhbmRsZUNsaWVudCogY2xpZW50ID0gaGFuZGxlLT5jbGllbnQo KTsKKworICAgIGlmIChkLT5tX2NhbmNlbGxlZCB8fCAhY2xpZW50KQorICAgICAgICByZXR1cm4g RkFMU0U7CisKKyAgICBLVVJMIHVybCA9IGhhbmRsZS0+cmVxdWVzdCgpLnVybCgpOworICAgIFJl c291cmNlRXJyb3IgZXJyb3IoIndlYmtpdC1uZXR3b3JrLWVycm9yIiwgRVJST1JfVU5LTk9XTl9Q Uk9UT0NPTCwgdXJsLnN0cmluZygpLCB1cmwucHJvdG9jb2woKSk7CisgICAgY2xpZW50LT5kaWRG YWlsKGhhbmRsZSwgZXJyb3IpOworCisgICAgcmV0dXJuIEZBTFNFOworfQorCiBib29sIFJlc291 cmNlSGFuZGxlOjpzdGFydChGcmFtZSogZnJhbWUpCiB7CiAgICAgQVNTRVJUKCFkLT5tX21zZyk7 CkBAIC00OTIsMTIgKzUwNywxMSBAQCBib29sIFJlc291cmNlSGFuZGxlOjpzdGFydChGcmFtZSog ZnJhbWUpCiAgICAgICAgIC8vIEZJWE1FOiBzaG91bGQgd2UgYmUgZG9pbmcgYW55IG90aGVyIHBy b3RvY29scyBoZXJlPwogICAgICAgICByZXR1cm4gc3RhcnRHaW8odXJsKTsKICAgICBlbHNlIHsK LSAgICAgICAgLy8gSWYgd2UgZG9uJ3QgY2FsbCBkaWRGYWlsIHRoZSBqb2IgaXMgbm90IGNvbXBs ZXRlIGZvciB3ZWJraXQgZXZlbiBmYWxzZSBpcyByZXR1cm5lZC4KLSAgICAgICAgaWYgKGQtPmNs aWVudCgpKSB7Ci0gICAgICAgICAgICBSZXNvdXJjZUVycm9yIGVycm9yKCJ3ZWJraXQtbmV0d29y ay1lcnJvciIsIEVSUk9SX1VOS05PV05fUFJPVE9DT0wsIHVybFN0cmluZywgcHJvdG9jb2wpOwot ICAgICAgICAgICAgZC0+Y2xpZW50KCktPmRpZEZhaWwodGhpcywgZXJyb3IpOwotICAgICAgICB9 Ci0gICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgLy8gRXJyb3IgbXVzdCBub3QgYmUgcmVw b3J0ZWQgaW1tZWRpYXRlbHksIGJ1dCB0aHJvdWdoIGFuIGlkbGUgZnVuY3Rpb24uCisgICAgICAg IC8vIERlc3BpdGUgZXJyb3IsIHdlIHNob3VsZCByZXR1cm4gdHJ1ZSBzbyBhIHByb3BlciBoYW5k bGUgaXMgY3JlYXRlZCwKKyAgICAgICAgLy8gdG8gd2hpY2ggdGhpcyBmYWlsdXJlIGNhbiBiZSBy ZXBvcnRlZC4KKyAgICAgICAgZC0+bV9pZGxlSGFuZGxlciA9IGdfaWRsZV9hZGQocmVwb3J0RXJy b3IsIHRoaXMpOworICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiB9CiAK 27844 2009-02-20 16:07:03 -0800 2009-02-24 07:01:15 -0800 Report errors through an idle function when faced unsupported URL protocols blankworker.diff text/plain 2481 zan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDJlZTU5OS4uMTQwNmM3MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wMi0yMCAgWmFuIERvYmVyc2Vr ICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNDA0MworICAgICAgICBXaGVuIGZhY2VkIHdpdGggVVJMcyB3aXRoIHVuc3VwcG9ydGVkIHBy b3RvY29sIG9uIEd0ayBwb3J0LAorICAgICAgICByZXBvcnQgdGhlIGVycm9yIHRocm91Z2ggYW4g aWRsZSBmdW5jdGlvbiBhbmQgcmV0dXJuIHRydWUsIHNvCisgICAgICAgIGEgcHJvcGVyIHJlc291 cmNlIGhhbmRsZSBpcyBjcmVhdGVkLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3Vw L1Jlc291cmNlSGFuZGxlU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZXBvcnRFcnJvcik6 CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6c3RhcnQpOgorCiAyMDA5LTAyLTIw ICBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciAgPHplY2tlQHNlbGZpc2gub3JnPgogCiAgICAg ICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKaW5kZXggM2M0ODA1Mi4uYzA4MDk5NiAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVT b3VwLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRs ZVNvdXAuY3BwCkBAIC00NzEsNiArNDcxLDI1IEBAIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnN0YXJ0 SHR0cChTdHJpbmcgdXJsU3RyaW5nKQogICAgIHJldHVybiB0cnVlOwogfQogCitzdGF0aWMgZ2Jv b2xlYW4gcmVwb3J0RXJyb3IoZ3BvaW50ZXIgY2FsbGJhY2tfZGF0YSkKK3sKKyAgICBSZXNvdXJj ZUhhbmRsZSogaGFuZGxlID0gc3RhdGljX2Nhc3Q8UmVzb3VyY2VIYW5kbGUqPihjYWxsYmFja19k YXRhKTsKKyAgICBpZiAoIWhhbmRsZSkKKyAgICAgICAgcmV0dXJuIEZBTFNFOworCisgICAgUmVz b3VyY2VIYW5kbGVJbnRlcm5hbCogZCA9IGhhbmRsZS0+Z2V0SW50ZXJuYWwoKTsKKyAgICBSZXNv dXJjZUhhbmRsZUNsaWVudCogY2xpZW50ID0gaGFuZGxlLT5jbGllbnQoKTsKKworICAgIGlmIChk LT5tX2NhbmNlbGxlZCB8fCAhY2xpZW50KQorICAgICAgICByZXR1cm4gRkFMU0U7CisKKyAgICBL VVJMIHVybCA9IGhhbmRsZS0+cmVxdWVzdCgpLnVybCgpOworICAgIFJlc291cmNlRXJyb3IgZXJy b3IoIndlYmtpdC1uZXR3b3JrLWVycm9yIiwgRVJST1JfVU5LTk9XTl9QUk9UT0NPTCwgdXJsLnN0 cmluZygpLCB1cmwucHJvdG9jb2woKSk7CisgICAgY2xpZW50LT5kaWRGYWlsKGhhbmRsZSwgZXJy b3IpOworCisgICAgcmV0dXJuIEZBTFNFOworfQorCiBib29sIFJlc291cmNlSGFuZGxlOjpzdGFy dChGcmFtZSogZnJhbWUpCiB7CiAgICAgQVNTRVJUKCFkLT5tX21zZyk7CkBAIC00OTIsMTIgKzUx MSwxMSBAQCBib29sIFJlc291cmNlSGFuZGxlOjpzdGFydChGcmFtZSogZnJhbWUpCiAgICAgICAg IC8vIEZJWE1FOiBzaG91bGQgd2UgYmUgZG9pbmcgYW55IG90aGVyIHByb3RvY29scyBoZXJlPwog ICAgICAgICByZXR1cm4gc3RhcnRHaW8odXJsKTsKICAgICBlbHNlIHsKLSAgICAgICAgLy8gSWYg d2UgZG9uJ3QgY2FsbCBkaWRGYWlsIHRoZSBqb2IgaXMgbm90IGNvbXBsZXRlIGZvciB3ZWJraXQg ZXZlbiBmYWxzZSBpcyByZXR1cm5lZC4KLSAgICAgICAgaWYgKGQtPmNsaWVudCgpKSB7Ci0gICAg ICAgICAgICBSZXNvdXJjZUVycm9yIGVycm9yKCJ3ZWJraXQtbmV0d29yay1lcnJvciIsIEVSUk9S X1VOS05PV05fUFJPVE9DT0wsIHVybFN0cmluZywgcHJvdG9jb2wpOwotICAgICAgICAgICAgZC0+ Y2xpZW50KCktPmRpZEZhaWwodGhpcywgZXJyb3IpOwotICAgICAgICB9Ci0gICAgICAgIHJldHVy biBmYWxzZTsKKyAgICAgICAgLy8gRXJyb3IgbXVzdCBub3QgYmUgcmVwb3J0ZWQgaW1tZWRpYXRl bHksIGJ1dCB0aHJvdWdoIGFuIGlkbGUgZnVuY3Rpb24uCisgICAgICAgIC8vIERlc3BpdGUgZXJy b3IsIHdlIHNob3VsZCByZXR1cm4gdHJ1ZSBzbyBhIHByb3BlciBoYW5kbGUgaXMgY3JlYXRlZCwK KyAgICAgICAgLy8gdG8gd2hpY2ggdGhpcyBmYWlsdXJlIGNhbiBiZSByZXBvcnRlZC4KKyAgICAg ICAgZC0+bV9pZGxlSGFuZGxlciA9IGdfaWRsZV9hZGQocmVwb3J0RXJyb3IsIHRoaXMpOworICAg ICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiB9CiAK 27916 2009-02-24 07:01:15 -0800 2009-02-24 07:08:29 -0800 Report errors through an idle function when faced unsupported URL protocols blankworker.diff text/plain 2505 zan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWUyMjJhYS4uMmZmYzI5MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wMi0yNCAgWmFuIERvYmVyc2Vr ICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNDA0MworICAgICAgICBXaGVuIGZhY2VkIHdpdGggVVJMcyB3aXRoIHVuc3VwcG9ydGVkIHBy b3RvY29sIG9uIEd0ayBwb3J0LAorICAgICAgICByZXBvcnQgdGhlIGVycm9yIHRocm91Z2ggYW4g aWRsZSBmdW5jdGlvbiBhbmQgcmV0dXJuIHRydWUsIHNvCisgICAgICAgIGEgcHJvcGVyIHJlc291 cmNlIGhhbmRsZSBpcyBjcmVhdGVkLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3Vw L1Jlc291cmNlSGFuZGxlU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZXBvcnRFcnJvcik6 CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6c3RhcnQpOgorCiAyMDA5LTAyLTI0 ICBKaWFuIExpICA8amlhbmxpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBB bGV4ZXkgUHJvc2t1cnlha292LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9z b3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKaW5kZXggODgyZmIxOS4uMjRlZGZiNSAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNw cAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAu Y3BwCkBAIC00ODYsNiArNDg2LDI1IEBAIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnN0YXJ0SHR0cChT dHJpbmcgdXJsU3RyaW5nKQogICAgIHJldHVybiB0cnVlOwogfQogCitzdGF0aWMgZ2Jvb2xlYW4g cmVwb3J0RXJyb3IoZ3BvaW50ZXIgY2FsbGJhY2tfZGF0YSkKK3sKKyAgICBSZXNvdXJjZUhhbmRs ZSogaGFuZGxlID0gc3RhdGljX2Nhc3Q8UmVzb3VyY2VIYW5kbGUqPihjYWxsYmFja19kYXRhKTsK KyAgICBSZXNvdXJjZUhhbmRsZUludGVybmFsKiBkID0gaGFuZGxlLT5nZXRJbnRlcm5hbCgpOwor ICAgIFJlc291cmNlSGFuZGxlQ2xpZW50KiBjbGllbnQgPSBoYW5kbGUtPmNsaWVudCgpOworCisg ICAgaWYgKGQtPm1fY2FuY2VsbGVkIHx8ICFjbGllbnQpIHsKKyAgICAgICAgaGFuZGxlLT5kZXJl ZigpOworICAgICAgICByZXR1cm4gRkFMU0U7CisgICAgfQorCisgICAgS1VSTCB1cmwgPSBoYW5k bGUtPnJlcXVlc3QoKS51cmwoKTsKKyAgICBSZXNvdXJjZUVycm9yIGVycm9yKCJ3ZWJraXQtbmV0 d29yay1lcnJvciIsIEVSUk9SX1VOS05PV05fUFJPVE9DT0wsIHVybC5zdHJpbmcoKSwgdXJsLnBy b3RvY29sKCkpOworICAgIGNsaWVudC0+ZGlkRmFpbChoYW5kbGUsIGVycm9yKTsKKworICAgIGhh bmRsZS0+ZGVyZWYoKTsKKyAgICByZXR1cm4gRkFMU0U7Cit9CisKIGJvb2wgUmVzb3VyY2VIYW5k bGU6OnN0YXJ0KEZyYW1lKiBmcmFtZSkKIHsKICAgICBBU1NFUlQoIWQtPm1fbXNnKTsKQEAgLTUw NywxMiArNTI2LDEyIEBAIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnN0YXJ0KEZyYW1lKiBmcmFtZSkK ICAgICAgICAgLy8gRklYTUU6IHNob3VsZCB3ZSBiZSBkb2luZyBhbnkgb3RoZXIgcHJvdG9jb2xz IGhlcmU/CiAgICAgICAgIHJldHVybiBzdGFydEdpbyh1cmwpOwogICAgIGVsc2UgewotICAgICAg ICAvLyBJZiB3ZSBkb24ndCBjYWxsIGRpZEZhaWwgdGhlIGpvYiBpcyBub3QgY29tcGxldGUgZm9y IHdlYmtpdCBldmVuIGZhbHNlIGlzIHJldHVybmVkLgotICAgICAgICBpZiAoZC0+Y2xpZW50KCkp IHsKLSAgICAgICAgICAgIFJlc291cmNlRXJyb3IgZXJyb3IoIndlYmtpdC1uZXR3b3JrLWVycm9y IiwgRVJST1JfVU5LTk9XTl9QUk9UT0NPTCwgdXJsU3RyaW5nLCBwcm90b2NvbCk7Ci0gICAgICAg ICAgICBkLT5jbGllbnQoKS0+ZGlkRmFpbCh0aGlzLCBlcnJvcik7Ci0gICAgICAgIH0KLSAgICAg ICAgcmV0dXJuIGZhbHNlOworICAgICAgICAvLyBFcnJvciBtdXN0IG5vdCBiZSByZXBvcnRlZCBp bW1lZGlhdGVseSwgYnV0IHRocm91Z2ggYW4gaWRsZSBmdW5jdGlvbi4KKyAgICAgICAgLy8gRGVz cGl0ZSBlcnJvciwgd2Ugc2hvdWxkIHJldHVybiB0cnVlIHNvIGEgcHJvcGVyIGhhbmRsZSBpcyBj cmVhdGVkLAorICAgICAgICAvLyB0byB3aGljaCB0aGlzIGZhaWx1cmUgY2FuIGJlIHJlcG9ydGVk LgorICAgICAgICByZWYoKTsKKyAgICAgICAgZC0+bV9pZGxlSGFuZGxlciA9IGdfaWRsZV9hZGQo cmVwb3J0RXJyb3IsIHRoaXMpOworICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiB9CiAK