240421 2022-05-14 11:28:24 -0700 MockAudioSharedInternalUnit should exit early when being stopped in generateSampleBuffers 2022-05-16 00:27:37 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf youssefdevelops y_soliman oldest_to_newest 1869020 0 youennf 2022-05-14 11:28:24 -0700 MockAudioSharedInternalUnit should exit early when being stopped in generateSampleBuffers 1869021 1 youennf 2022-05-14 11:30:19 -0700 <rdar://93279260> 1869022 2 459358 youennf 2022-05-14 11:40:01 -0700 Created attachment 459358 Patch 1869123 3 459358 eric.carlson 2022-05-15 20:47:00 -0700 Comment on attachment 459358 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459358&action=review > Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:150 > + Ref<MockAudioSharedInternalUnitState> m_isProducingState; Nit: `m_isProducingState` doesn't seem right, maybee `m_internalState`? 1869148 4 youennf 2022-05-15 23:25:17 -0700 (In reply to Eric Carlson from comment #3) > Comment on attachment 459358 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459358&action=review > > > Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:150 > > + Ref<MockAudioSharedInternalUnitState> m_isProducingState; > > Nit: `m_isProducingState` doesn't seem right, maybee `m_internalState`? Let's do that in a follow-up on GitHub, bugzilla webkit patch infra has some issues. 1869158 5 ews-feeder 2022-05-16 00:27:34 -0700 Committed r294223 (250581@main): <https://commits.webkit.org/250581@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459358. 459358 2022-05-14 11:40:01 -0700 2022-05-16 00:27:36 -0700 Patch 0001-fix-240421.patch text/plain 6888 youennf RnJvbSA3ODJlNDQzODYxMzRiNmQ0YjZiMjY0NjRmZTQ0NGZkM2RmMzEzMGNiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBZb3Vlbm4gRmFibGV0IDx5b3Vlbm5AYXBwbGUuY29tPgpEYXRl OiBTYXQsIDE0IE1heSAyMDIyIDIwOjMzOjM3ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gZml4LTI0 MDQyMQoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg fCAyOCArKysrKysrKysrKysrCiAuLi4vbWVkaWFzdHJlYW0vbWFjL01vY2tBdWRpb1NoYXJlZFVu aXQubW0gICAgfCA0MSArKysrKysrKysrKysrLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDU3IGlu c2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2YzU0NTgzNjI0NTYu LmJiZDUyODJjOTFjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDIyLTA1LTE0ICBZ b3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNb2NrQXVkaW9TaGFy ZWRJbnRlcm5hbFVuaXQgc2hvdWxkIGV4aXQgZWFybHkgd2hlbiBiZWluZyBzdG9wcGVkIGluIGdl bmVyYXRlU2FtcGxlQnVmZmVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjQwNDIxCisgICAgICAgIDxyZGFyOi8vOTMyNzkyNjA+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgdXNlZCB0byBhbHdheXMg Y2FsbCBnZW5lcmF0ZVNhbXBsZUJ1ZmZlcnMgZnJvbSBtYWluIHRocmVhZC4KKyAgICAgICAgV2Ug YXJlIG5vdyBjYWxsaW5nIGl0IGZyb20gYmFja2dyb3VuZCB0aHJlYWQgd2l0aCBkaXNwYXRjaEFm dGVyIHRvIG1pbWljayBhIHJlYWx0aW1lIGNsb2NrLgorICAgICAgICBUaGlzIGJyb2tlIHRoZSBk aXNwYXRjaFN5bmMgY2FsbCB3ZSB3ZXJlIGNhbGxpbmcgd2hlbiBzdG9wcGluZyB0aGUgbW9jayB1 bml0IGFzIHRoZSBkaXNwYXRjaEFmdGVyIHRhc2sgd291bGQgYmUgY2FsbGVkCisgICAgICAgIGFm dGVyIHRoZSBkaXNwYXRjaFN5bmMgYW5kIHx0aGlzfCBjb3VsZCBwb3RlbnRpYWxseSBubyBsb25n ZXIgYmUgdmFsaWQuCisgICAgICAgIFRvIHByZXZlbnQgdGhpcywgd2UgaW50cm9kdWNlIE1vY2tB dWRpb1NoYXJlZEludGVybmFsVW5pdFN0YXRlIHdoaWNoIGFsbG93cyB0byBzYWZlbHkga25vdyB3 aGV0aGVyIHRoZSB1bml0IGlzIHN0b3BwZWQgb3Igbm90CisgICAgICAgIGF0IGFueSBwb2ludCBp biB0aW1lLiBJZiB0aGUgdW5pdCBpcyBzdG9wcGVkLCBkaXNwYXRjaEFmdGVyIHdpbGwgbm90IGNh bGwgZ2VuZXJhdGVTYW1wbGVCdWZmZXJzLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3Rpbmcg dGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvTW9ja0F1ZGlvU2hh cmVkVW5pdC5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1vY2tBdWRpb1NoYXJlZEludGVybmFsVW5p dFN0YXRlOjpjcmVhdGUpOgorICAgICAgICAoV2ViQ29yZTo6TW9ja0F1ZGlvU2hhcmVkSW50ZXJu YWxVbml0U3RhdGU6OmlzUHJvZHVjaW5nRGF0YSBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpN b2NrQXVkaW9TaGFyZWRJbnRlcm5hbFVuaXRTdGF0ZTo6c2V0SXNQcm9kdWNpbmdEYXRhKToKKyAg ICAgICAgKFdlYkNvcmU6Ok1vY2tBdWRpb1NoYXJlZEludGVybmFsVW5pdDo6TW9ja0F1ZGlvU2hh cmVkSW50ZXJuYWxVbml0KToKKyAgICAgICAgKFdlYkNvcmU6Ok1vY2tBdWRpb1NoYXJlZEludGVy bmFsVW5pdDo6fk1vY2tBdWRpb1NoYXJlZEludGVybmFsVW5pdCk6CisgICAgICAgIChXZWJDb3Jl OjpNb2NrQXVkaW9TaGFyZWRJbnRlcm5hbFVuaXQ6OnN0YXJ0KToKKyAgICAgICAgKFdlYkNvcmU6 Ok1vY2tBdWRpb1NoYXJlZEludGVybmFsVW5pdDo6c3RvcCk6CisgICAgICAgIChXZWJDb3JlOjpN b2NrQXVkaW9TaGFyZWRJbnRlcm5hbFVuaXQ6OnVuaW5pdGlhbGl6ZSk6CisgICAgICAgIChXZWJD b3JlOjpNb2NrQXVkaW9TaGFyZWRJbnRlcm5hbFVuaXQ6OmdlbmVyYXRlU2FtcGxlQnVmZmVycyk6 CisKIDIwMjItMDUtMTMgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK ICAgICAgICAgQXBwbGVQYXlMb2dvU3lzdGVtSW1hZ2UgbmVlZGxlc3NseSBsb2FkcyBQYXNzS2l0 IGluIFdlYktpdCBjaGlsZCBwcm9jZXNzZXMgb24gaU9TCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvTW9ja0F1ZGlvU2hhcmVkVW5pdC5tbSBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9Nb2NrQXVkaW9TaGFyZWRVbml0 Lm1tCmluZGV4IGUzYzYxZmI3ZGM5Ni4uZWQ1NTI3MDcxZGZjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvTW9ja0F1ZGlvU2hhcmVkVW5pdC5tbQor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvTW9ja0F1ZGlvU2hh cmVkVW5pdC5tbQpAQCAtOTcsNiArOTcsMTcgQEAgQ2FwdHVyZVNvdXJjZU9yRXJyb3IgTW9ja1Jl YWx0aW1lQXVkaW9Tb3VyY2U6OmNyZWF0ZShTdHJpbmcmJiBkZXZpY2VJRCwgQXRvbVN0cmkKICAg ICByZXR1cm4gQ29yZUF1ZGlvQ2FwdHVyZVNvdXJjZTo6Y3JlYXRlRm9yVGVzdGluZyhXVEZNb3Zl KGRldmljZUlEKSwgV1RGTW92ZShuYW1lKSwgV1RGTW92ZShoYXNoU2FsdCksIGNvbnN0cmFpbnRz LCBNb2NrQXVkaW9TaGFyZWRVbml0OjpzaW5nbGV0b24oKSwgcGFnZUlkZW50aWZpZXIpOwogfQog CitjbGFzcyBNb2NrQXVkaW9TaGFyZWRJbnRlcm5hbFVuaXRTdGF0ZSA6IHB1YmxpYyBUaHJlYWRT YWZlUmVmQ291bnRlZDxNb2NrQXVkaW9TaGFyZWRJbnRlcm5hbFVuaXRTdGF0ZT4geworcHVibGlj OgorICAgIHN0YXRpYyBSZWY8TW9ja0F1ZGlvU2hhcmVkSW50ZXJuYWxVbml0U3RhdGU+IGNyZWF0 ZSgpIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgTW9ja0F1ZGlvU2hhcmVkSW50ZXJuYWxVbml0U3Rh dGUoKSk7IH0KKworICAgIGJvb2wgaXNQcm9kdWNpbmdEYXRhKCkgY29uc3QgeyByZXR1cm4gbV9p c1Byb2R1Y2luZ0RhdGE7IH0KKyAgICB2b2lkIHNldElzUHJvZHVjaW5nRGF0YShib29sIHZhbHVl KSB7IG1faXNQcm9kdWNpbmdEYXRhID0gdmFsdWU7IH0KKworcHJpdmF0ZToKKyAgICBib29sIG1f aXNQcm9kdWNpbmdEYXRhIHsgZmFsc2UgfTsKK307CisKIGNsYXNzIE1vY2tBdWRpb1NoYXJlZElu dGVybmFsVW5pdCA6ICBwdWJsaWMgQ29yZUF1ZGlvU2hhcmVkVW5pdDo6SW50ZXJuYWxVbml0IHsK ICAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1YmxpYzoKQEAgLTEwNSw3ICsxMTYsNyBA QCBwdWJsaWM6CiAKIHByaXZhdGU6CiAgICAgT1NTdGF0dXMgaW5pdGlhbGl6ZSgpIGZpbmFsOwot ICAgIE9TU3RhdHVzIHVuaW5pdGlhbGl6ZSgpIGZpbmFsIHsgcmV0dXJuIDA7IH0KKyAgICBPU1N0 YXR1cyB1bmluaXRpYWxpemUoKSBmaW5hbDsKICAgICBPU1N0YXR1cyBzdGFydCgpIGZpbmFsOwog ICAgIE9TU3RhdHVzIHN0b3AoKSBmaW5hbDsKICAgICBPU1N0YXR1cyBzZXQoQXVkaW9Vbml0UHJv cGVydHlJRCwgQXVkaW9Vbml0U2NvcGUsIEF1ZGlvVW5pdEVsZW1lbnQsIGNvbnN0IHZvaWQqLCBV SW50MzIpIGZpbmFsOwpAQCAtMTM2LDcgKzE0Nyw3IEBAIHByaXZhdGU6CiAKICAgICBWZWN0b3I8 ZmxvYXQ+IG1fYmlwQm9wQnVmZmVyOwogICAgIGJvb2wgbV9oYXNBdWRpb1VuaXQgeyBmYWxzZSB9 OwotICAgIGJvb2wgbV9pc1Byb2R1Y2luZ0RhdGEgeyBmYWxzZSB9OworICAgIFJlZjxNb2NrQXVk aW9TaGFyZWRJbnRlcm5hbFVuaXRTdGF0ZT4gbV9pc1Byb2R1Y2luZ1N0YXRlOwogICAgIGJvb2wg bV9lbmFibGVFY2hvQ2FuY2VsbGF0aW9uIHsgdHJ1ZSB9OwogICAgIFJ1bkxvb3A6OlRpbWVyPE1v Y2tBdWRpb1NoYXJlZEludGVybmFsVW5pdD4gbV90aW1lcjsKICAgICBNb25vdG9uaWNUaW1lIG1f bGFzdFJlbmRlclRpbWUgeyBNb25vdG9uaWNUaW1lOjpuYW4oKSB9OwpAQCAtMTc3LDcgKzE4OCw4 IEBAIHN0YXRpYyBBdWRpb1N0cmVhbUJhc2ljRGVzY3JpcHRpb24gY3JlYXRlQXVkaW9Gb3JtYXQo RmxvYXQ2NCBzYW1wbGVSYXRlLCBVSW50MzIKIH0KIAogTW9ja0F1ZGlvU2hhcmVkSW50ZXJuYWxV bml0OjpNb2NrQXVkaW9TaGFyZWRJbnRlcm5hbFVuaXQoKQotICAgIDogbV90aW1lcihSdW5Mb29w OjpjdXJyZW50KCksIFt0aGlzXSB7IHRoaXMtPnN0YXJ0KCk7IH0pCisgICAgOiBtX2lzUHJvZHVj aW5nU3RhdGUoTW9ja0F1ZGlvU2hhcmVkSW50ZXJuYWxVbml0U3RhdGU6OmNyZWF0ZSgpKQorICAg ICwgbV90aW1lcihSdW5Mb29wOjpjdXJyZW50KCksIFt0aGlzXSB7IHRoaXMtPnN0YXJ0KCk7IH0p CiAgICAgLCBtX3dvcmtRdWV1ZShXb3JrUXVldWU6OmNyZWF0ZSgiTW9ja0F1ZGlvU2hhcmVkSW50 ZXJuYWxVbml0IENhcHR1cmUgUXVldWUiLCBXb3JrUXVldWU6OlFPUzo6VXNlckludGVyYWN0aXZl KSkKIHsKICAgICBtX3N0cmVhbUZvcm1hdCA9IG1fb3V0cHV0U3RyZWFtRm9ybWF0ID0gY3JlYXRl QXVkaW9Gb3JtYXQoNDQxMDAsIDIpOwpAQCAtMTg1LDcgKzE5Nyw3IEBAIE1vY2tBdWRpb1NoYXJl ZEludGVybmFsVW5pdDo6TW9ja0F1ZGlvU2hhcmVkSW50ZXJuYWxVbml0KCkKIAogTW9ja0F1ZGlv U2hhcmVkSW50ZXJuYWxVbml0Ojp+TW9ja0F1ZGlvU2hhcmVkSW50ZXJuYWxVbml0KCkKIHsKLSAg ICBBU1NFUlQoIW1faXNQcm9kdWNpbmdEYXRhKTsKKyAgICBBU1NFUlQoIW1faXNQcm9kdWNpbmdT dGF0ZS0+aXNQcm9kdWNpbmdEYXRhKCkpOwogfQogCiBPU1N0YXR1cyBNb2NrQXVkaW9TaGFyZWRJ bnRlcm5hbFVuaXQ6OmluaXRpYWxpemUoKQpAQCAtMjAzLDcgKzIxNSw4IEBAIE9TU3RhdHVzIE1v Y2tBdWRpb1NoYXJlZEludGVybmFsVW5pdDo6c3RhcnQoKQogICAgICAgICBtX2hhc0F1ZGlvVW5p dCA9IHRydWU7CiAKICAgICBtX2xhc3RSZW5kZXJUaW1lID0gTW9ub3RvbmljVGltZTo6bm93KCk7 Ci0gICAgbV9pc1Byb2R1Y2luZ0RhdGEgPSB0cnVlOworCisgICAgbV9pc1Byb2R1Y2luZ1N0YXRl LT5zZXRJc1Byb2R1Y2luZ0RhdGEodHJ1ZSk7CiAgICAgbV93b3JrUXVldWUtPmRpc3BhdGNoKFt0 aGlzLCByZW5kZXJUaW1lID0gbV9sYXN0UmVuZGVyVGltZV0gewogICAgICAgICBnZW5lcmF0ZVNh bXBsZUJ1ZmZlcnMocmVuZGVyVGltZSk7CiAgICAgfSk7CkBAIC0yMTIsNyArMjI1LDcgQEAgT1NT dGF0dXMgTW9ja0F1ZGlvU2hhcmVkSW50ZXJuYWxVbml0OjpzdGFydCgpCiAKIE9TU3RhdHVzIE1v Y2tBdWRpb1NoYXJlZEludGVybmFsVW5pdDo6c3RvcCgpCiB7Ci0gICAgbV9pc1Byb2R1Y2luZ0Rh dGEgPSBmYWxzZTsKKyAgICBtX2lzUHJvZHVjaW5nU3RhdGUtPnNldElzUHJvZHVjaW5nRGF0YShm YWxzZSk7CiAgICAgaWYgKG1faGFzQXVkaW9Vbml0KQogICAgICAgICBtX2xhc3RSZW5kZXJUaW1l ID0gTW9ub3RvbmljVGltZTo6bmFuKCk7CiAKQEAgLTIyMSw2ICsyMzQsMTIgQEAgT1NTdGF0dXMg TW9ja0F1ZGlvU2hhcmVkSW50ZXJuYWxVbml0OjpzdG9wKCkKICAgICByZXR1cm4gMDsKIH0KIAor T1NTdGF0dXMgTW9ja0F1ZGlvU2hhcmVkSW50ZXJuYWxVbml0Ojp1bmluaXRpYWxpemUoKQorewor ICAgIEFTU0VSVCghbV9pc1Byb2R1Y2luZ1N0YXRlLT5pc1Byb2R1Y2luZ0RhdGEoKSk7CisgICAg cmV0dXJuIDA7Cit9CisKIHZvaWQgTW9ja0F1ZGlvU2hhcmVkSW50ZXJuYWxVbml0OjpkZWxheVNh bXBsZXMoU2Vjb25kcyBkZWx0YSkKIHsKICAgICBzdG9wKCk7CkBAIC0yODMsMTAgKzMwMiw2IEBA IHZvaWQgTW9ja0F1ZGlvU2hhcmVkSW50ZXJuYWxVbml0OjplbWl0U2FtcGxlQnVmZmVycyh1aW50 MzJfdCBmcmFtZUNvdW50KQogCiB2b2lkIE1vY2tBdWRpb1NoYXJlZEludGVybmFsVW5pdDo6Z2Vu ZXJhdGVTYW1wbGVCdWZmZXJzKE1vbm90b25pY1RpbWUgcmVuZGVyVGltZSkKIHsKLSAgICBBU1NF UlQoIWlzTWFpblRocmVhZCgpKTsKLSAgICBpZiAoIW1faXNQcm9kdWNpbmdEYXRhKQotICAgICAg ICByZXR1cm47Ci0KICAgICBhdXRvIGRlbHRhID0gcmVuZGVySW50ZXJ2YWwoKTsKICAgICBhdXRv IGN1cnJlbnRUaW1lID0gTW9ub3RvbmljVGltZTo6bm93KCk7CiAgICAgYXV0byBuZXh0UmVuZGVy VGltZSA9IHJlbmRlclRpbWUgKyBkZWx0YTsKQEAgLTI5NSw4ICszMTAsMTAgQEAgdm9pZCBNb2Nr QXVkaW9TaGFyZWRJbnRlcm5hbFVuaXQ6OmdlbmVyYXRlU2FtcGxlQnVmZmVycyhNb25vdG9uaWNU aW1lIHJlbmRlclRpbWUKICAgICAgICAgbmV4dFJlbmRlclRpbWUgPSBjdXJyZW50VGltZTsKICAg ICAgICAgbmV4dFJlbmRlckRlbGF5ID0gMF9zOwogICAgIH0KLSAgICBtX3dvcmtRdWV1ZS0+ZGlz cGF0Y2hBZnRlcihuZXh0UmVuZGVyRGVsYXksIFt0aGlzLCBuZXh0UmVuZGVyVGltZV0gewotICAg ICAgICBnZW5lcmF0ZVNhbXBsZUJ1ZmZlcnMobmV4dFJlbmRlclRpbWUpOworCisgICAgbV93b3Jr UXVldWUtPmRpc3BhdGNoQWZ0ZXIobmV4dFJlbmRlckRlbGF5LCBbdGhpcywgbmV4dFJlbmRlclRp bWUsIHN0YXRlID0gbV9pc1Byb2R1Y2luZ1N0YXRlXSB7CisgICAgICAgIGlmIChzdGF0ZS0+aXNQ cm9kdWNpbmdEYXRhKCkpCisgICAgICAgICAgICBnZW5lcmF0ZVNhbXBsZUJ1ZmZlcnMobmV4dFJl bmRlclRpbWUpOwogICAgIH0pOwogCiAgICAgaWYgKCFtX2F1ZGlvQnVmZmVyTGlzdCB8fCAhbV9i aXBCb3BCdWZmZXIuc2l6ZSgpKQotLSAKMi4zMi4wIChBcHBsZSBHaXQtMTMyKQoK