24036 2009-02-19 11:51:07 -0800 Keyboard events need disambiguation on the Linux platform too. 2009-02-20 07:34:58 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Enhancement --- 1 avi avi oldest_to_newest 110261 0 avi 2009-02-19 11:51:07 -0800 Linux (in all its flavors) needs the same disambiguation of events as the Mac does (see plat/gtk/KeyEventGtk.cpp, plat/qt/PlatformKeyboardEventQt.cpp, and plat/wx/KeyboardEventWc.cpp). 110263 1 27805 avi 2009-02-19 11:51:59 -0800 Created attachment 27805 Diff to provide disambiguation for all non-Windows platforms in Chromium, not just the Mac. 110265 2 avi 2009-02-19 11:52:27 -0800 See http://codereview.chromium.org/21514 . 110301 3 27805 eric 2009-02-19 14:27:33 -0800 Comment on attachment 27805 Diff to provide disambiguation for all non-Windows platforms in Chromium, not just the Mac. Looks fine to me. 110393 4 fishd 2009-02-20 07:34:58 -0800 Landed as http://trac.webkit.org/changeset/41106 27805 2009-02-19 11:51:59 -0800 2009-02-19 14:27:33 -0800 Diff to provide disambiguation for all non-Windows platforms in Chromium, not just the Mac. key.diff text/plain 1913 avi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTA3NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDItMTkgIEF2aSBEcmlzc21hbiAgPGF2aUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgS2V5 Ym9hcmQgZXZlbnRzIG5lZWQgZGlzYW1iaWd1YXRpb24gb24gdGhlIExpbnV4IHBsYXRmb3JtIHRv by4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1BsYXRmb3JtS2V5Ym9hcmRFdmVudENo cm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6ZGlz YW1iaWd1YXRlS2V5RG93bkV2ZW50KToKKwogMjAwOS0wMi0xOSAgR3VzdGF2byBOb3JvbmhhIFNp bHZhICA8Z25zQGdub21lLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1 cnlha292LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybUtleWJvYXJk RXZlbnRDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1 bS9QbGF0Zm9ybUtleWJvYXJkRXZlbnRDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDQxMDc3KQorKysg V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybUtleWJvYXJkRXZlbnRDaHJvbWl1bS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTQyLDcgKzQyLDcgQEAgdm9pZCBQbGF0Zm9ybUtleWJvYXJk RXZlbnQ6OmRpc2FtYmlndWF0ZQogI2lmIFBMQVRGT1JNKFdJTl9PUykKICAgICAvLyBObyBLZXlE b3duIGV2ZW50cyBvbiBXaW5kb3dzIHRvIGRpc2FtYmlndWF0ZS4KICAgICBBU1NFUlRfTk9UX1JF QUNIRUQoKTsKLSNlbGlmIFBMQVRGT1JNKERBUldJTikKKyNlbHNlCiAgICAgLy8gQ2FuIG9ubHkg Y2hhbmdlIHR5cGUgZnJvbSBLZXlEb3duIHRvIFJhd0tleURvd24gb3IgQ2hhciwgYXMgd2UgbGFj ayBpbmZvcm1hdGlvbiBmb3Igb3RoZXIgY29udmVyc2lvbnMuCiAgICAgQVNTRVJUKG1fdHlwZSA9 PSBLZXlEb3duKTsKICAgICBBU1NFUlQodHlwZSA9PSBSYXdLZXlEb3duIHx8IHR5cGUgPT0gQ2hh cik7CkBAIC01Niw2ICs1Niw3IEBAIHZvaWQgUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpkaXNhbWJp Z3VhdGUKICAgICB9IGVsc2UgewogICAgICAgICBtX2tleUlkZW50aWZpZXIgPSBTdHJpbmcoKTsK ICAgICAgICAgbV93aW5kb3dzVmlydHVhbEtleUNvZGUgPSAwOworI2lmIFBMQVRGT1JNKERBUldJ TikKICAgICAgICAgaWYgKG1fdGV4dC5sZW5ndGgoKSA9PSAxICYmIChtX3RleHRbMFVdID49IDB4 RjcwMCAmJiBtX3RleHRbMFVdIDw9IDB4RjdGRikpIHsKICAgICAgICAgICAgIC8vIEFjY29yZGlu ZyB0byBOU0V2ZW50cy5oLCBPcGVuU3RlcCByZXNlcnZlcyB0aGUgcmFuZ2UgMHhGNzAwLTB4RjhG RiBmb3IgZnVuY3Rpb24ga2V5cy4gSG93ZXZlciwgc29tZSBhY3R1YWwgcHJpdmF0ZSB1c2UgY2hh cmFjdGVycwogICAgICAgICAgICAgLy8gaGFwcGVuIHRvIGJlIGluIHRoaXMgcmFuZ2UsIGUuZy4g dGhlIEFwcGxlIGxvZ28gKE9wdGlvbitTaGlmdCtLKS4KQEAgLTYzLDYgKzY0LDcgQEAgdm9pZCBQ bGF0Zm9ybUtleWJvYXJkRXZlbnQ6OmRpc2FtYmlndWF0ZQogICAgICAgICAgICAgbV90ZXh0ID0g U3RyaW5nKCk7CiAgICAgICAgICAgICBtX3VubW9kaWZpZWRUZXh0ID0gU3RyaW5nKCk7CiAgICAg ICAgIH0KKyNlbmRpZgogICAgIH0KICNlbmRpZgogfQo=