240358 2022-05-12 13:23:10 -0700 -Wattributes warnings from AtomString.cpp and WTFString.cpp 2022-05-12 19:14:12 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro mcatanzaro webkit-bug-importer oldest_to_newest 1868525 0 mcatanzaro 2022-05-12 13:23:10 -0700 https://github.com/WebKit/WebKit/pull/474 introduced some new build warnings: [109/2539] Building CXX object Source/WTF/wtf/CMakeFiles/WTF.dir/text/AtomString.cpp.o /home/mcatanzaro/Projects/WebKit/Source/WTF/wtf/text/AtomString.cpp:35:43: warning: ‘visibility’ attribute ignored [-Wattributes] 35 | WTF_EXPORT_PRIVATE const StaticAtomString nullAtomData { nullptr }; | ^~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Source/WTF/wtf/text/AtomString.cpp:36:43: warning: ‘visibility’ attribute ignored [-Wattributes] 36 | WTF_EXPORT_PRIVATE const StaticAtomString emptyAtomData { &StringImpl::s_emptyAtomString }; | ^~~~~~~~~~~~~ [144/2539] Building CXX object Source/WTF/wtf/CMakeFiles/WTF.dir/text/WTFString.cpp.o /home/mcatanzaro/Projects/WebKit/Source/WTF/wtf/text/WTFString.cpp:638:39: warning: ‘visibility’ attribute ignored [-Wattributes] 638 | WTF_EXPORT_PRIVATE const StaticString nullStringData { nullptr }; | ^~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Source/WTF/wtf/text/WTFString.cpp:639:39: warning: ‘visibility’ attribute ignored [-Wattributes] 639 | WTF_EXPORT_PRIVATE const StaticString emptyStringData { &StringImpl::s_emptyAtomString }; | ^~~~~~~~~~~~~~~ 1868527 1 mcatanzaro 2022-05-12 13:25:58 -0700 Ah, it's redundant because it's already specified in the header file. We can just remove it. Easy. 1868528 2 mcatanzaro 2022-05-12 13:27:29 -0700 Pull request: https://github.com/WebKit/WebKit/pull/604 1868621 3 ews-feeder 2022-05-12 19:13:36 -0700 Committed r294139 (250509@main): <https://commits.webkit.org/250509@main> Reviewed commits have been landed. Closing PR #604 and removing active labels. 1868622 4 webkit-bug-importer 2022-05-12 19:14:12 -0700 <rdar://problem/93216876>