240353 2022-05-12 11:53:15 -0700 [WebAuthn] Include backup state in authenticatorData 2022-05-12 14:53:10 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pascoe pascoe bfulgham webkit-bug-importer oldest_to_newest 1868500 0 pascoe 2022-05-12 11:53:15 -0700 These flags hint the backup state of the credential, which is beneficial for knowing when to offer password removal for a user or similar. 1868501 1 webkit-bug-importer 2022-05-12 11:53:38 -0700 <rdar://problem/93191958> 1868503 2 pascoe 2022-05-12 11:57:23 -0700 https://github.com/w3c/webauthn/pull/1695 1868504 3 459244 pascoe 2022-05-12 12:14:58 -0700 Created attachment 459244 Patch 1868536 4 459244 bfulgham 2022-05-12 13:53:51 -0700 Comment on attachment 459244 Patch LGTM. r+ 1868556 5 ews-feeder 2022-05-12 14:53:08 -0700 Committed r294122 (250501@main): <https://commits.webkit.org/250501@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459244. 459244 2022-05-12 12:14:58 -0700 2022-05-12 14:53:09 -0700 Patch bug-240353-20220512121457.patch text/plain 5976 pascoe U3VidmVyc2lvbiBSZXZpc2lvbjogMjk0MDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmYxYWY5MDhlY2Y4YjYz OTljOWNmZmY5NjY2MjQ5N2Q3NDgzODgwNS4uMDg5YTQ4ODlkM2RjMzlmNzEzY2U0NmViNGE2Mjlk OWY4ZDZhYzI3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTA1LTEyICBKIFBh c2NvZSAgPGpfcGFzY29lQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIEluY2x1ZGUg YmFja3VwIHN0YXRlIGluIGF1dGhlbnRpY2F0b3JEYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDAzNTMKKyAgICAgICAgcmRhcjovL3Byb2JsZW0v OTMxOTE5NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgZmxhZ3MgZm9yIGNyZWRlbnRpYWwgYmFja3VwIHN0YXRlOiBodHRwczovL2dpdGh1Yi5j b20vdzNjL3dlYmF1dGhuL3B1bGwvMTY5NQorCisgICAgICAgICogTW9kdWxlcy93ZWJhdXRobi9X ZWJBdXRoZW50aWNhdGlvbkNvbnN0YW50cy5oOgorCiAyMDIyLTA1LTExICBZb3Vlbm4gRmFibGV0 ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBJbnRyb2R1Y2UgYSBjYW52YXMtZHJhd0lt YWdlIHNwZWNpZmljIG1ldGhvZCB0byBnZXQgYSBOYXRpdmVJbWFnZSBmcm9tIGEgdmlkZW8gZWxl bWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0 L0NoYW5nZUxvZwppbmRleCBiNGRhZmIwZmM3MWVjNzRmY2FhZmFmNTRjMWJjMjhhYzQ4ODJiZTUw Li5jY2ZiZGM4MTc0OWJkZGUwNjdjY2U3MWIyMjQ4YzllZjYwMWQ2M2FjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAt MSwzICsxLDI0IEBACisyMDIyLTA1LTEyICBKIFBhc2NvZSAgPGpfcGFzY29lQGFwcGxlLmNvbT4K KworICAgICAgICBbV2ViQXV0aG5dIEluY2x1ZGUgYmFja3VwIHN0YXRlIGluIGF1dGhlbnRpY2F0 b3JEYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y NDAzNTMKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vOTMxOTE5NTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgc3VwcG9ydCBm b3IgYmFja3VwIHN0YXRlIGZsYWdzLCB3aGljaCB3aWxsIGJlIGFkZGVkIHRvCisgICAgICAgIHRo ZSBXZWIgQXV0aGVudGljYXRpb24gc3BlYyBzb29uIHZpYSBodHRwczovL2dpdGh1Yi5jb20vdzNj L3dlYmF1dGhuL3B1bGwvMTY5NQorCisgICAgICAgIFRoZXNlIGZsYWdzIGFyZSBzZXQgd2hlbmV2 ZXIgYSBjcmVkZW50aWFsIGlzICJiYWNrdXAgZWxpZ2libGUiIGFuZCAiYmFja2VkIHVwIgorICAg ICAgICBoaW50aW5nIHRvIFJQcyB0aGF0IHRoZSBjcmVkZW50aWFsIGlzICJkdXJhYmxlIiBhbmQg bWF5IHBlcnNpc3QgdGhyb3VnaCBkZXZpY2UKKyAgICAgICAgcmVzdG9yZXMuIFRoaXMgaXMgdXNl ZnVsIGZvciBSUHMgdGhhdCBtYXkgY2hvb3NlIHRvIG9mZmVyIHRvIHJlbW92ZSB0aGUgdXNlcgor ICAgICAgICBwYXNzd29yZCBpZiBhIGNyZWRlbnRhbCBpcyBpbiB0aGlzIHN0YXRlLgorCisgICAg ICAgICogVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0NvY29hL0xvY2FsQXV0aGVudGljYXRv ci5tbToKKyAgICAgICAgKFdlYktpdDo6TG9jYWxBdXRoZW50aWNhdG9ySW50ZXJuYWw6OmF1dGhE YXRhRmxhZ3MpOgorICAgICAgICAoV2ViS2l0OjpMb2NhbEF1dGhlbnRpY2F0b3I6OmNvbnRpbnVl TWFrZUNyZWRlbnRpYWxBZnRlclVzZXJWZXJpZmljYXRpb24pOgorICAgICAgICAoV2ViS2l0OjpM b2NhbEF1dGhlbnRpY2F0b3I6OmNvbnRpbnVlR2V0QXNzZXJ0aW9uQWZ0ZXJVc2VyVmVyaWZpY2F0 aW9uKToKKwogMjAyMi0wNS0xMSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgSW50cm9kdWNlIGEgY2FudmFzLWRyYXdJbWFnZSBzcGVjaWZpYyBtZXRob2QgdG8g Z2V0IGEgTmF0aXZlSW1hZ2UgZnJvbSBhIHZpZGVvIGVsZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvd2ViYXV0aG4vV2ViQXV0aGVudGljYXRpb25Db25zdGFudHMuaCBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXV0aG4vV2ViQXV0aGVudGljYXRpb25Db25zdGFu dHMuaAppbmRleCBmYTc1NWEzOGVjNTVhZTcxZGE1ZTczNjdjZWM2MjkxZWM3ZGU5NjEyLi5jZDQz NDJmOWVkMDk3NmMxNThiOTgwOGUyZmU0NjEwNjM3NTU2YzVmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmF1dGhuL1dlYkF1dGhlbnRpY2F0aW9uQ29uc3RhbnRzLmgKKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdXRobi9XZWJBdXRoZW50aWNhdGlvbkNvbnN0 YW50cy5oCkBAIC0xMTAsNSArMTEwLDggQEAgZW51bSBjbGFzcyBTY29wZSB7CiBjb25zdGV4cHIg dWludDhfdCB1c2VyUHJlc2VuY2VGbGFnID0gMGIwMDAwMDAwMTsKIGNvbnN0ZXhwciB1aW50OF90 IHVzZXJWZXJpZmllZEZsYWcgPSAwYjAwMDAwMTAwOwogY29uc3RleHByIHVpbnQ4X3QgYXR0ZXN0 ZWRDcmVkZW50aWFsRGF0YUluY2x1ZGVkRmxhZyA9IDBiMDEwMDAwMDA7CisvLyBodHRwczovL2dp dGh1Yi5jb20vdzNjL3dlYmF1dGhuL3B1bGwvMTY5NQorY29uc3RleHByIHVpbnQ4X3QgYmFja3Vw RWxpZ2liaWxpdHlGbGFnID0gMGIwMDAwMTAwMDsKK2NvbnN0ZXhwciB1aW50OF90IGJhY2t1cFN0 YXRlRmxhZyA9IDBiMDAwMTAwMDA7CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkF1dGhuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9Db2NvYS9Mb2Nh bEF1dGhlbnRpY2F0b3IubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNh dGlvbi9Db2NvYS9Mb2NhbEF1dGhlbnRpY2F0b3IubW0KaW5kZXggZWVlNmI4NzkxMjE4NTUxODUw ZWRlYmJmNWEyNTkyZmI0MzYwYjAzNy4uM2IxYmY1YTRlMWU1ZDhlZGJhNDdkOWE1MTAxNmM1M2I1 YjM5Yzg3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGlj YXRpb24vQ29jb2EvTG9jYWxBdXRoZW50aWNhdG9yLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0NvY29hL0xvY2FsQXV0aGVudGljYXRvci5tbQpAQCAt NzUsMTEgKzc1LDYgQEAgdXNpbmcgQ0JPUiA9IGNib3I6OkNCT1JWYWx1ZTsKIAogbmFtZXNwYWNl IExvY2FsQXV0aGVudGljYXRvckludGVybmFsIHsKIAotLy8gU2VlIGh0dHBzOi8vd3d3LnczLm9y Zy9UUi93ZWJhdXRobi8jZmxhZ3MuCi1jb25zdCB1aW50OF90IG1ha2VDcmVkZW50aWFsRmxhZ3Mg PSB1c2VyUHJlc2VuY2VGbGFnIHwgdXNlclZlcmlmaWVkRmxhZyB8IGF0dGVzdGVkQ3JlZGVudGlh bERhdGFJbmNsdWRlZEZsYWc7IC8vIFVQLCBVViBhbmQgQVQgYXJlIHNldC4KLWNvbnN0IHVpbnQ4 X3Qgb3RoZXJNYWtlQ3JlZGVudGlhbEZsYWdzID0gdXNlclByZXNlbmNlRmxhZyB8IGF0dGVzdGVk Q3JlZGVudGlhbERhdGFJbmNsdWRlZEZsYWc7IC8vIFVQIGFuZCBBVCBhcmUgc2V0LgotY29uc3Qg dWludDhfdCBnZXRBc3NlcnRpb25GbGFncyA9IHVzZXJQcmVzZW5jZUZsYWcgfCB1c2VyVmVyaWZp ZWRGbGFnOyAvLyBVUCBhbmQgVVYgYXJlIHNldC4KLWNvbnN0IHVpbnQ4X3Qgb3RoZXJHZXRBc3Nl cnRpb25GbGFncyA9IHVzZXJQcmVzZW5jZUZsYWc7IC8vIFVQIGlzIHNldC4KIC8vIENyZWRlbnRp YWwgSUQgaXMgY3VycmVudGx5IFNIQS0xIG9mIHRoZSBjb3JyZXNwb25kaW5nIHB1YmxpYyBrZXku CiBjb25zdCB1aW50MTZfdCBjcmVkZW50aWFsSWRMZW5ndGggPSAyMDsKIGNvbnN0IHVpbnQ2NF90 IGNvdW50ZXIgPSAwOwpAQCAtMTAxLDYgKzk2LDE4IEBAIHN0YXRpYyBpbmxpbmUgSGFzaFNldDxT dHJpbmc+IHByb2R1Y2VIYXNoU2V0KGNvbnN0IFZlY3RvcjxQdWJsaWNLZXlDcmVkZW50aWFsRGVz CiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAorc3RhdGljIGlubGluZSB1aW50OF90IGF1dGhEYXRh RmxhZ3MoQ2xpZW50RGF0YVR5cGUgdHlwZSwgTG9jYWxDb25uZWN0aW9uOjpVc2VyVmVyaWZpY2F0 aW9uIHZlcmlmaWNhdGlvbiwgYm9vbCBzeW5jaHJvbml6YWJsZSkKK3sKKyAgICBhdXRvIGZsYWdz ID0gdXNlclByZXNlbmNlRmxhZzsKKyAgICBpZiAodmVyaWZpY2F0aW9uICE9IExvY2FsQ29ubmVj dGlvbjo6VXNlclZlcmlmaWNhdGlvbjo6UHJlc2VuY2UpCisgICAgICAgIGZsYWdzIHw9IHVzZXJW ZXJpZmllZEZsYWc7CisgICAgaWYgKHR5cGUgPT0gQ2xpZW50RGF0YVR5cGU6OkNyZWF0ZSkKKyAg ICAgICAgZmxhZ3MgfD0gYXR0ZXN0ZWRDcmVkZW50aWFsRGF0YUluY2x1ZGVkRmxhZzsKKyAgICBp ZiAoc3luY2hyb25pemFibGUpCisgICAgICAgIGZsYWdzIHw9IGJhY2t1cEVsaWdpYmlsaXR5Rmxh ZyB8IGJhY2t1cFN0YXRlRmxhZzsKKyAgICByZXR1cm4gZmxhZ3M7Cit9CisKIHN0YXRpYyBpbmxp bmUgVmVjdG9yPHVpbnQ4X3Q+IGFhZ3VpZFZlY3RvcigpCiB7CiAgICAgc3RhdGljIE5ldmVyRGVz dHJveWVkPFZlY3Rvcjx1aW50OF90Pj4gYWFndWlkVmVjdG9yID0geyBhYWd1aWQsIGFhZ3VpZExl bmd0aCB9OwpAQCAtNDUxLDcgKzQ1OCw3IEBAIHZvaWQgTG9jYWxBdXRoZW50aWNhdG9yOjpjb250 aW51ZU1ha2VDcmVkZW50aWFsQWZ0ZXJVc2VyVmVyaWZpY2F0aW9uKFNlY0FjY2Vzc0NvCiAgICAg ICAgIGNvc2VQdWJsaWNLZXkgPSBlbmNvZGVFUzI1NlB1YmxpY0tleUFzQ0JPUihXVEZNb3ZlKHgp LCBXVEZNb3ZlKHkpKTsKICAgICB9CiAKLSAgICBhdXRvIGZsYWdzID0gdmVyaWZpY2F0aW9uID09 IExvY2FsQ29ubmVjdGlvbjo6VXNlclZlcmlmaWNhdGlvbjo6UHJlc2VuY2UgPyBvdGhlck1ha2VD cmVkZW50aWFsRmxhZ3MgOiBtYWtlQ3JlZGVudGlhbEZsYWdzOworICAgIGF1dG8gZmxhZ3MgPSBh dXRoRGF0YUZsYWdzKENsaWVudERhdGFUeXBlOjpDcmVhdGUsIHZlcmlmaWNhdGlvbiwgc2hvdWxk VXBkYXRlUXVlcnkoKSk7CiAgICAgLy8gU3RlcCAxMi4KICAgICAvLyBTa2lwIEFwcGxlIEF0dGVz dGF0aW9uIGZvciBub25lIGF0dGVzdGF0aW9uLgogICAgIGlmIChjcmVhdGlvbk9wdGlvbnMuYXR0 ZXN0YXRpb24gPT0gQXR0ZXN0YXRpb25Db252ZXlhbmNlUHJlZmVyZW5jZTo6Tm9uZSkgewpAQCAt NjIyLDcgKzYyOSw4IEBAIHZvaWQgTG9jYWxBdXRoZW50aWNhdG9yOjpjb250aW51ZUdldEFzc2Vy dGlvbkFmdGVyVXNlclZlcmlmaWNhdGlvbihSZWY8V2ViQ29yZTo6CiAKICAgICAvLyBTdGVwIDEw LgogICAgIGF1dG8gcmVxdWVzdE9wdGlvbnMgPSBzdGQ6OmdldDxQdWJsaWNLZXlDcmVkZW50aWFs UmVxdWVzdE9wdGlvbnM+KHJlcXVlc3REYXRhKCkub3B0aW9ucyk7Ci0gICAgYXV0byBhdXRoRGF0 YSA9IGJ1aWxkQXV0aERhdGEocmVxdWVzdE9wdGlvbnMucnBJZCwgdmVyaWZpY2F0aW9uID09IExv Y2FsQ29ubmVjdGlvbjo6VXNlclZlcmlmaWNhdGlvbjo6UHJlc2VuY2UgPyBvdGhlckdldEFzc2Vy dGlvbkZsYWdzIDogZ2V0QXNzZXJ0aW9uRmxhZ3MsIGNvdW50ZXIsIHsgfSk7CisgICAgYXV0byBm bGFncyA9IGF1dGhEYXRhRmxhZ3MoQ2xpZW50RGF0YVR5cGU6OkdldCwgdmVyaWZpY2F0aW9uLCBy ZXNwb25zZS0+c3luY2hyb25pemFibGUoKSk7CisgICAgYXV0byBhdXRoRGF0YSA9IGJ1aWxkQXV0 aERhdGEocmVxdWVzdE9wdGlvbnMucnBJZCwgZmxhZ3MsIGNvdW50ZXIsIHsgfSk7CiAKICAgICAv LyBTdGVwIDExLgogICAgIFJldGFpblB0cjxDRkRhdGFSZWY+IHNpZ25hdHVyZTsK