240315 2022-05-11 13:37:57 -0700 Mail compose: right clicking an image attachment selects it 2022-05-13 07:20:25 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 240381 1 katherine_cheney katherine_cheney akeerthi ap commit-queue rniwa thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1868209 0 katherine_cheney 2022-05-11 13:37:57 -0700 Mail compose: right clicking an image attachment selects it 1868228 1 katherine_cheney 2022-05-11 14:58:07 -0700 Pull request: https://github.com/WebKit/WebKit/pull/593 1868491 2 ews-feeder 2022-05-12 11:23:41 -0700 Committed r294113 (250494@main): <https://commits.webkit.org/250494@main> Reviewed commits have been landed. Closing PR #593 and removing active labels. 1868492 3 webkit-bug-importer 2022-05-12 11:24:13 -0700 <rdar://problem/93189849> 1868609 4 ap 2022-05-12 18:14:01 -0700 What was the motivation for this change? AFAICT context click always selects its text target on macOS, and it also always selects an image in editable content. We had the same behavior as TextEdit, and no longer do. Also, the commit message looks malformed. 1868610 5 ap 2022-05-12 18:16:30 -0700 I see some discussion in the PR, so CC'ing folks who participated in it. That discussion doesn't appear to answer my question. 1868614 6 wenson_hsieh 2022-05-12 18:26:59 -0700 The motivation was to make right clicking an image in Mail compose *not* select the image. This is the behavior of legacy WebKit compose, and the behavior of WebKit2 compose (which selects images when right-clicking) is a regression. I had incorrectly thought that this change was aligning us to AppKit (TextEdit/NSTextView) behavior. Upon further testing, this does not appear to be the case — when right clicking an image in TextEdit, the image is indeed selected, but the selection is painted *behind* the image rather than in the foreground, which makes it appear as if the image isn't selected. 1868745 7 commit-queue 2022-05-13 07:20:25 -0700 Re-opened since this is blocked by bug 240381