240313 2022-05-11 12:43:50 -0700 [GTK][WPE] Make ANGLE backend EGL context initialization work 2022-05-16 11:01:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 237649 1 alex alex clord dino ews-watchlist glenn jbedard kondapallykalyan webkit-bug-importer zdobersek oldest_to_newest 1868200 0 alex 2022-05-11 12:43:50 -0700 Currently there are issues when running tests with our headless backend, we need to review the way we create the display and choose configuration. 1868202 1 459178 alex 2022-05-11 12:51:07 -0700 Created attachment 459178 Patch 1868364 2 459178 zdobersek 2022-05-12 05:50:08 -0700 Comment on attachment 459178 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459178&action=review > Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp:222 > - m_displayObj = EGL_GetPlatformDisplayEXT(EGL_PLATFORM_ANGLE_ANGLE, EGL_DEFAULT_DISPLAY, displayAttributes.data()); > + m_displayObj = EGL_GetPlatformDisplayEXT(EGL_PLATFORM_ANGLE_ANGLE, PlatformDisplay::sharedDisplay().eglDisplay(), displayAttributes.data()); EGL_DEFAULT_DISPLAY is a native display identifier for the default display, it's cast to EGLNativeDisplayType. The change now pushes an EGLDisplay value into the EGL call, which is not how the entrypoint works. There has to be a different way taken of avoiding X11 in Mesa. 1868785 3 alex 2022-05-13 09:51:25 -0700 (In reply to Zan Dobersek (Reviews) from comment #2) > Comment on attachment 459178 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459178&action=review > > > Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp:222 > > - m_displayObj = EGL_GetPlatformDisplayEXT(EGL_PLATFORM_ANGLE_ANGLE, EGL_DEFAULT_DISPLAY, displayAttributes.data()); > > + m_displayObj = EGL_GetPlatformDisplayEXT(EGL_PLATFORM_ANGLE_ANGLE, PlatformDisplay::sharedDisplay().eglDisplay(), displayAttributes.data()); > > EGL_DEFAULT_DISPLAY is a native display identifier for the default display, > it's cast to EGLNativeDisplayType. The change now pushes an EGLDisplay value > into the EGL call, which is not how the entrypoint works. There has to be a > different way taken of avoiding X11 in Mesa. Right, I made the mistake to think the Display was the same Egl display, but it is just used to make sure we return the same EGLDisplay for the same NativeDisplay; just tested even passing (void *) 1, makes the tests work, because it just stores the pointer as an Id and allows the code path to be different using a guessing function, avoiding the building default like when you pass EGL_DEFAULT_DISPLAY, which is 0x0. I can try and environment variable in the script to try to avoid it if I do not find other code path that can be used. Thanks for the review! 1868837 4 459320 alex 2022-05-13 13:05:39 -0700 Created attachment 459320 Patch 1869327 5 ews-feeder 2022-05-16 10:59:57 -0700 Committed r294245 (250603@main): <https://commits.webkit.org/250603@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459320. 1869328 6 webkit-bug-importer 2022-05-16 11:01:14 -0700 <rdar://problem/93357585> 459178 2022-05-11 12:51:07 -0700 2022-05-13 13:05:35 -0700 Patch bug-240313-20220511215106.patch text/plain 2534 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzOTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGIwOWYwOWRiNjVmNjE1 OWQ5ZWRmZjRhMjc0NDVmOWRiM2RlZDRkNi4uMmYyNjk5ZjkyZGI3MjBhZmU0NmUwYzgxZmQxOTRi M2NmNTdlZjQ4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIyLTA1LTExICBBbGVq YW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0g TWFrZSBBTkdMRSBiYWNrZW5kIEVHTCBjb250ZXh0IGluaXRpYWxpemF0aW9uIHdvcmsKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MDMxMworCisgICAg ICAgIFR3byBkaWZmZXJlbnQgaXNzdWVzIGF0IHRoZSBzYW1lIHRpbWUgd2VyZSBjYXVzaW5nIHRo ZSBwcm9ibGVtLgorCisgICAgICAgIFdlIG5lZWQgdG8gYWRkIHRoZSBjdXJyZW50IGRpc3BsYXkg YXMgYSBoaW50IGZvciB0aGUgZGlzcGxheQorICAgICAgICBkaXNjb3ZlcnkgdG8gbWFrZSBzdXJl IGl0IGRvZXMgbm90IHVzZSB0aGUgZGVmYXVsdCBpbiB0aGUgbWVzYQorICAgICAgICBjb2RlIGJl Y2F1c2UgaXQgaXMgWDExLgorCisgICAgICAgIFdlIGFyZSBhbHNvIHJlZHVjaW5nIHRoZSByZXF1 aXJlbWVudHMgb2YgdGhlIEVHTF9TVVJGQUNFX1RZUEUKKyAgICAgICAgYXR0cmlidXRlIGJlY2F1 c2UgdGhlIGRlZmF1bHQgaXMgRUdMX1dJTkRPV19CSVQsIGJ1dCB3ZSBkbyBub3QKKyAgICAgICAg bmVlZCB0aGF0IGZvciBvdXIgc3VyZmFjZWxlc3Mgc29sdXRpb24uCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBpdCBmaXhlcyB0 aGUgdGVzdHMgZm9yIHRoZSBBTkdMRSBpbXBsZW1lbnRhdGlvbi4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2dibS9HcmFwaGljc0NvbnRleHRHTEdCTS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpHcmFwaGljc0NvbnRleHRHTEdCTTo6cGxhdGZvcm1Jbml0aWFsaXplQ29udGV4dCk6CisK IDIwMjItMDUtMDkgIEdhYnJpZWwgTmF2YSBNYXJpbm8gIDxnbmF2YW1hcmlub0BhcHBsZS5jb20+ CiAKICAgICAgICAgQVNTRVJUIGluIFdlYkNvcmU6OlJlbmRlclRyZWVVcGRhdGVyOjp1cGRhdGVS ZW5kZXJUcmVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n Ym0vR3JhcGhpY3NDb250ZXh0R0xHQk0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ2JtL0dyYXBoaWNzQ29udGV4dEdMR0JNLmNwcAppbmRleCA4N2Y1OTA2MWI5OWJjMGFj OTc3ZjY4NjM3ZWY4NGEzMDQzODc1YWIxLi5mZjgxYWRlYjNkNTI0OGU4MWY0Y2ZkMDJiYjkzNzg4 MDE3M2E5YTE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n Ym0vR3JhcGhpY3NDb250ZXh0R0xHQk0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dibS9HcmFwaGljc0NvbnRleHRHTEdCTS5jcHAKQEAgLTMyLDYgKzMyLDcgQEAK ICNpbmNsdWRlICJBTkdMRUhlYWRlcnMuaCIKICNpbmNsdWRlICJMb2dnaW5nLmgiCiAjaW5jbHVk ZSAiUGl4ZWxCdWZmZXIuaCIKKyNpbmNsdWRlICJQbGF0Zm9ybURpc3BsYXkuaCIKIAogI2lmIEVO QUJMRShNRURJQV9TVFJFQU0pCiAjaW5jbHVkZSAiVmlkZW9GcmFtZS5oIgpAQCAtMjE4LDcgKzIx OSw3IEBAIGJvb2wgR3JhcGhpY3NDb250ZXh0R0xHQk06OnBsYXRmb3JtSW5pdGlhbGl6ZUNvbnRl eHQoKQogICAgICAgICBFR0xfTk9ORSwKICAgICB9OwogCi0gICAgbV9kaXNwbGF5T2JqID0gRUdM X0dldFBsYXRmb3JtRGlzcGxheUVYVChFR0xfUExBVEZPUk1fQU5HTEVfQU5HTEUsIEVHTF9ERUZB VUxUX0RJU1BMQVksIGRpc3BsYXlBdHRyaWJ1dGVzLmRhdGEoKSk7CisgICAgbV9kaXNwbGF5T2Jq ID0gRUdMX0dldFBsYXRmb3JtRGlzcGxheUVYVChFR0xfUExBVEZPUk1fQU5HTEVfQU5HTEUsIFBs YXRmb3JtRGlzcGxheTo6c2hhcmVkRGlzcGxheSgpLmVnbERpc3BsYXkoKSwgZGlzcGxheUF0dHJp YnV0ZXMuZGF0YSgpKTsKICAgICBpZiAobV9kaXNwbGF5T2JqID09IEVHTF9OT19ESVNQTEFZKQog ICAgICAgICByZXR1cm4gZmFsc2U7CiAKQEAgLTIzNCw2ICsyMzUsNyBAQCBib29sIEdyYXBoaWNz Q29udGV4dEdMR0JNOjpwbGF0Zm9ybUluaXRpYWxpemVDb250ZXh0KCkKIAogICAgIEVHTGludCBj b25maWdBdHRyaWJ1dGVzW10gPSB7CiAgICAgICAgIEVHTF9SRU5ERVJBQkxFX1RZUEUsIEVHTF9P UEVOR0xfRVMyX0JJVCwKKyAgICAgICAgRUdMX1NVUkZBQ0VfVFlQRSwgRUdMX1BCVUZGRVJfQklU LAogICAgICAgICBFR0xfUkVEX1NJWkUsIDgsCiAgICAgICAgIEVHTF9HUkVFTl9TSVpFLCA4LAog ICAgICAgICBFR0xfQkxVRV9TSVpFLCA4LAo= 459320 2022-05-13 13:05:39 -0700 2022-05-16 11:00:00 -0700 Patch bug-240313-20220513220538.patch text/plain 2080 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzOTgyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGQ3MDkwMzY2YTM2YWRjNzZiYmQ5OWQzZTZlNTU4ZTJj OTczZjkyMS4uMGQwMmE4OTJmNjgwODk1ZWVkMDc1YTMwOTZjNjg2ZTIxMjAzZDQ2MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2 IEBACisyMDIyLTA1LTEzICBBbGVqYW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdW1dQRV0gTWFrZSBBTkdMRSBiYWNrZW5kIEVHTCBjb250ZXh0IGluaXRp YWxpemF0aW9uIHdvcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTI0MDMxMworCisgICAgICAgIFRoZSBwbGF0Zm9ybSBpcyBub3Qgc2VsZWN0ZWQgY29y cmVjdGx5IGJ5IGRlZmF1bHQgYW5kIHRoZSBjb25maWcKKyAgICAgICAgY2FuIG5vdCBiZSBjaG9z ZW4gaW4gc29tZSBjYXNlcyBpbiB0aGUgY3VycmVudCBjb25kaXRpb25zLiBNYXliZQorICAgICAg ICBhdCBzb21lIHBvaW50IHdlIHdhbnQgc29tZXRoaW5nIG1vcmUgZ2VuZXJhbCBpbiB0aGUgY29k ZSBmb3IgdGhlCisgICAgICAgIHBsYXRmb3JtIGRldGVjdGlvbiBidXQgZm9yIHRlc3Rpbmcgd2Ug aGF2ZSBzb2x2ZWQgaXQgYWRkaW5nIHRoZQorICAgICAgICBlbnZpcm9ubWVudCB2YXJpYWJsZSAo RUdMX1BMQVRPUk0pIHRvIG1ha2Ugc3VyZSB0aGUgcGxhdGZvcm0KKyAgICAgICAgaW5zaWRlIG1l c2EgaXMgY29ycmVjdGx5IHNlbGVjdGVkIHdoZW4gcnVubmluZyB0aGUgdGVzdHMuIElmIHdlCisg ICAgICAgIGRvbid0IGRvIGl0IHRoZSBzbWFsbCBlbnZpcm9ubWVudCBpbiB0aGUgdGVzdGluZyBk cml2ZXIgcHJvY2VzcworICAgICAgICBjYXVzZXMgdG8gY2hvc2UgdGhlIFgxMSBiZWNhdXNlIGl0 IGlzIHRoZSBidWlsZGluZyBkZWZhdWx0CisgICAgICAgIG9wdGlvbi4gV2UgdXNlZCB3YXlsYW5k IGJlY2F1c2UgdGhlIGhlYWRsZXNzIGRyaXZlciB3ZSB1c2UgaXMgYQorICAgICAgICB3YXlsYW5k IGJhY2tlZCBpbXBsZW1lbnRlZCB1c2luZyBzaGFyZWQgbWVtb3J5LgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgaXQgZml4ZXMg dGhlIHRlc3RzIGZvciB0aGUgQU5HTEUgaW1wbGVtZW50YXRpb24uCisKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L3BvcnQvaGVhZGxlc3Nkcml2ZXIucHk6CisgICAgICAgIChIZWFkbGVzc0Ry aXZlci5fc2V0dXBfZW52aXJvbl9mb3JfdGVzdCk6CisKIDIwMjItMDUtMDYgIEtlaXRoIE1pbGxl ciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgVGVzdDI2MiBydW5uZXIgc2hv dWxkIHNob3cgcHJvZ3Jlc3MKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9y dC9oZWFkbGVzc2RyaXZlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9oZWFkbGVz c2RyaXZlci5weQppbmRleCAxNDQzMjM1MTEwNGI2Yjc3MDg1ZjVkNDM3MjkyODM1NGMxNjJlM2Ri Li41NGUwYTVmNzI2ZjlmMzUyY2QwOTdkODExMDYyMTZiOGQ1YzJhNWI0IDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaGVhZGxlc3Nkcml2ZXIucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wb3J0L2hlYWRsZXNzZHJpdmVyLnB5CkBAIC00MCw0ICs0MCw1IEBA IGNsYXNzIEhlYWRsZXNzRHJpdmVyKERyaXZlcik6CiAgICAgZGVmIF9zZXR1cF9lbnZpcm9uX2Zv cl90ZXN0KHNlbGYpOgogICAgICAgICBkcml2ZXJfZW52aXJvbm1lbnQgPSBzdXBlcihIZWFkbGVz c0RyaXZlciwgc2VsZikuX3NldHVwX2Vudmlyb25fZm9yX3Rlc3QoKQogICAgICAgICBkcml2ZXJf ZW52aXJvbm1lbnRbJ1dQRV9VU0VfSEVBRExFU1NfVklFV19CQUNLRU5EJ10gPSAiMSIKKyAgICAg ICAgZHJpdmVyX2Vudmlyb25tZW50WydFR0xfUExBVEZPUk0nXSA9ICJ3YXlsYW5kIgogICAgICAg ICByZXR1cm4gZHJpdmVyX2Vudmlyb25tZW50Cg==