24030 2009-02-19 10:57:42 -0800 Amalgamate suspendActiveDOMObjects/resumeActiveDOMObjects and documentWillBecomeInactive/documentDidBecomeActive? 2011-01-28 14:26:49 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.5 NEW P2 Normal --- 1 simon.fraser webkit-unassigned ap dimich eric.carlson jorlow mihaip psolanki oldest_to_newest 110232 0 simon.fraser 2009-02-19 10:57:42 -0800 suspendActiveDOMObjects/resumeActiveDOMObjects and documentWillBecomeInactive/documentDidBecomeActive do something very similar. Perhaps they should be one and the same? 341736 1 dimich 2011-01-28 14:23:49 -0800 Indeed. Perhaps it makes sense to split ActiveDOMObject into 2 parts - the more generic interface like ScriptExecutionContextObserver (name?) that would receive stop/start/canSuspend/suspend/resume/contextDestroyed, and a PendingActivity object that would have hasPendingActivity (with counter) and optionally register with the list on SEC to keep their wrappers alive. By splitting observer-like functionality from ActiveDOMObject, we would be able to have observers that don't have JS wrappers or a notion of pending activity. Old ActiveDOMObjects would derive from both, while things like HTMLInputElement could only be an observer. What do you think? 341739 2 jorlow 2011-01-28 14:26:49 -0800 For the record, https://bugs.webkit.org/show_bug.cgi?id=53202 has some similar discussion....but yeah, I think that's probably the right basic concept. We should probably also add a comment to ActiveDOMObject to make it more clear what it should be used for (and what an "active dom object" really means/implies).