240274 2022-05-10 02:09:57 -0700 [GPU Process] [Filters] REGRESSION(r287782): FilterImages can be leaked 2022-05-17 11:49:24 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 231253 1 sabouhallawa sabouhallawa bfulgham dino ews-watchlist kondapallykalyan simon.fraser webkit-bug-importer zalan oldest_to_newest 1867881 0 459104 sabouhallawa 2022-05-10 02:09:57 -0700 Created attachment 459104 test case Open the attached test case and watch the memory taken by WebKit. The memory allocation will climb very quickly. Getting the memgraph of WebKit will show the following allocations: 28625 (3251M) << TOTAL >> 1016 (3238M) CONTENT: malloc<3342336> + 1016 (3238M) _malloc_zone_malloc (in libsystem_malloc.dylib) + 0 [0x7ff81af62a0b] + 1016 (3238M) bmalloc_heap_config_specialized_try_allocate_common_impl_slow (in JavaScriptCore) + 882 [0x10b4f4432] bmalloc_heap_config.c:43 + 1016 (3238M) bmalloc_try_allocate_auxiliary_impl_impl_slow (in JavaScriptCore) + 45 [0x10b4e7dcd] bmalloc_heap_inlines.h:458 + 1016 (3238M) bmalloc_try_allocate_auxiliary_impl_casual_case (in JavaScriptCore) + 401 [0x10b4e6ae1] bmalloc_heap_inlines.h:458 + 1016 (3238M) Gigacage::tryMalloc(Gigacage::Kind, unsigned long) (in JavaScriptCore) + 318 [0x10b4674ee] Gigacage.cpp:94 + 1016 (3238M) JSC::ArrayBufferContents::tryAllocate(unsigned long, unsigned int, JSC::ArrayBufferContents::InitializationPolicy) (in JavaScriptCore) + 79 [0x10bd69cdf] ArrayBuffer.cpp:125 + 1016 (3238M) JSC::ArrayBuffer::tryCreate(unsigned long, unsigned int, JSC::ArrayBufferContents::InitializationPolicy) (in JavaScriptCore) + 61 [0x10bd6a35d] ArrayBuffer.cpp:280 + 1016 (3238M) JSC::ArrayBuffer::tryCreateUninitialized(unsigned long, unsigned int) (in JavaScriptCore) + 17 [0x10c41aad1] ArrayBuffer.cpp:256 + 1016 (3238M) JSC::GenericTypedArrayView<JSC::Uint8ClampedAdaptor>::tryCreateUninitialized(unsigned long) (in WebCore) + 38 [0x111081bd6] GenericTypedArrayViewInlines.h:116 + 1016 (3238M) WebCore::PixelBuffer::tryCreate(WebCore::PixelBufferFormat const&, WebCore::IntSize const&) (in WebCore) + 88 [0x1111de4f8] PixelBuffer.cpp:79 + 1016 (3238M) WebCore::FilterImage::pixelBuffer(WebCore::AlphaPremultiplication) (in WebCore) + 112 [0x1123ac5f0] FilterImage.cpp:235 + 1016 (3238M) WebCore::FETurbulenceSoftwareApplier::apply(WebCore::Filter const&, WTF::Vector<WTF::Ref<WebCore::FilterImage, WTF::RawPtrTraits<WebCore::FilterImage> >, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::FilterImage&) const (in WebCore) + 48 [0x1123b9150] FETurbulenceSoftwareApplier.cpp:344 + 1016 (3238M) WebCore::FilterEffect::apply(WebCore::Filter const&, WTF::Vector<WTF::Ref<WebCore::FilterImage, WTF::RawPtrTraits<WebCore::FilterImage> >, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::FilterResults&, std::__1::optional<WebCore::FilterEffectGeometry> const&) (in WebCore) + 803 [0x111211093] FilterEffect.cpp:152 + 1016 (3238M) WebCore::SVGFilter::apply(WebCore::FilterImage*, WebCore::FilterResults&) (in WebCore) + 143 [0x11138a03f] SVGFilter.cpp:138 + 1016 (3238M) WebCore::Filter::apply(WebCore::ImageBuffer*, WebCore::FloatRect const&, WebCore::FilterResults&) (in WebCore) + 242 [0x111210ad2] Filter.cpp:95 + 1016 (3238M) WebCore::GraphicsContext::drawFilteredImageBuffer(WebCore::ImageBuffer*, WebCore::FloatRect const&, WebCore::Filter&, WebCore::FilterResults&) (in WebCore) + 44 [0x1111d259c] GraphicsContext.cpp:345 This means the FilterImages are leaked when clearing the FilterResults while doing the animation dynamic update. 1867882 1 459105 sabouhallawa 2022-05-10 02:18:56 -0700 Created attachment 459105 Patch 1867999 2 sabouhallawa 2022-05-10 13:20:32 -0700 I tried to write a test case but I could not. There is no way right now to get the total allocated memory (using malloc and bmalloc) by the WebContent process. 1868005 3 ews-feeder 2022-05-10 13:53:44 -0700 Committed r294015 (250449@main): <https://commits.webkit.org/250449@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459105. 1868006 4 webkit-bug-importer 2022-05-10 13:54:22 -0700 <rdar://problem/93052392> 459104 2022-05-10 02:09:57 -0700 2022-05-10 02:09:57 -0700 test case test-dynamic-update-leaks.html text/html 907 sabouhallawa PGJvZHk+CiAgICA8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgd2lkdGg9 IjYwMCIgaGVpZ2h0PSIyNDAiPgogICAgICAgIDxmaWx0ZXIgaWQ9InR1cmJ1bGVuY2VGaWx0ZXIi IGZpbHRlclVuaXRzPSJ1c2VyU3BhY2VPblVzZSI+CiAgICAgICAgICAgIDxmZVR1cmJ1bGVuY2Ug dHlwZT0idHVyYnVsZW5jZSIgYmFzZUZyZXF1ZW5jeT0iMC4wNSIgbnVtT2N0YXZlcz0iMiIgcmVz dWx0PSJ0dXJidWxlbmNlIj4KICAgICAgICAgICAgICAgIDxhbmltYXRlIGF0dHJpYnV0ZU5hbWU9 ImJhc2VGcmVxdWVuY3kiIGZyb209IjAiIHRvPSIwLjI1IiBkdXI9IjVzIiByZXBlYXRDb3VudD0i aW5kZWZpbml0ZSIgLz4KICAgICAgICAgICAgPC9mZVR1cmJ1bGVuY2U+CiAgICAgICAgICAgIDxm ZURpc3BsYWNlbWVudE1hcCBpbjI9InR1cmJ1bGVuY2UiIGluPSJTb3VyY2VHcmFwaGljIiBzY2Fs ZT0iNTAiIHhDaGFubmVsU2VsZWN0b3I9IlIiIHlDaGFubmVsU2VsZWN0b3I9IkciLz4KICAgICAg ICA8L2ZpbHRlcj4KICAgICAgICA8ZyBmaWx0ZXI9InVybCgjdHVyYnVsZW5jZUZpbHRlcikiPgog ICAgICAgICAgICA8cmVjdCB4PSIwIiAgIHk9IjAiICAgd2lkdGg9IjEwMCIgaGVpZ2h0PSIxMDAi IGZpbGw9InJlZCIvPgogICAgICAgICAgICAgICAgPHJlY3QgeD0iMTAwIiB5PSIwIiAgIHdpZHRo PSIxMDAiIGhlaWdodD0iMTAwIiBmaWxsPSJncmVlbiIvPgogICAgICAgICAgICAgICAgPHJlY3Qg eD0iMCIgICB5PSIxMDAiIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiBmaWxsPSJibHVlIi8+CiAg ICAgICAgICAgICAgICA8cmVjdCB4PSIxMDAiIHk9IjEwMCIgd2lkdGg9IjEwMCIgaGVpZ2h0PSIx MDAiIGZpbGw9InllbGxvdyIvPgogICAgICAgIDwvZz4KICAgIDwvc3ZnPgo8L2JvZHk+Cg== 459105 2022-05-10 02:18:56 -0700 2022-05-10 13:53:46 -0700 Patch bug-240274-20220510021855.patch text/plain 1910 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzOTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGIwOWYwOWRiNjVmNjE1 OWQ5ZWRmZjRhMjc0NDVmOWRiM2RlZDRkNi4uZWNmMjI3ODAzNmFhMTMyMjE0YzhiNWZjZDQ2ODM4 YjNhZTE4ZDllYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIyLTA1LTEwICBTYWlk IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g W0ZpbHRlcnNdIEZpbHRlckltYWdlcyBjYW4gYmUgbGVha2VkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDAyNzQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGEgRmlsdGVyRWZmZWN0IGlzIGR5bmFt aWNhbGx5IHVwZGF0ZWQgd2UgY2xlYXIgaXRzIHJlc3VsdCBGaWx0ZXJJbWFnZS4KKyAgICAgICAg V2UgYWxzbyBuZWVkIHRvIGNsZWFyIGFsbCB0aGUgcmVzdWx0IEZpbHRlckltYWdlcyBvZiBhbGwg dGhlIEZpbHRlckVmZmVjdHMKKyAgICAgICAgcmVjdXJzaXZlbHkgd2hpY2ggdGFrZXMgdGhpcyBj aGFuZ2luZyBGaWx0ZXJFZmZlY3QgYXMgYW4gaW5wdXQuCisKKyAgICAgICAgQ2xlYXJpbmcgdGhl IHJlc3VsdCBGaWx0ZXJJbWFnZSBvZiB0aGUgY2hhbmdpbmcgRmlsdGVyRWZmZWN0IGhhcHBlbnMg YnkKKyAgICAgICAgcmVtb3ZpbmcgdGhlIGVudHJ5IGZyb20gRmlsdGVyUmVzdWx0czo6bV9yZXN1 bHRzLgorCisgICAgICAgIENsZWFyaW5nIHRoZSBGaWx0ZXJJbWFnZXMgb2YgdGhlIGRlcGVuZGVu dCBGaWx0ZXJFZmZlY3RzIGhhcHBlbnMgYnkgdXNpbmcgCisgICAgICAgIEZpbHRlclJlc3VsdHM6 Om1fcmVzdWx0UmVmZXJlbmNlcy4KKworICAgICAgICBXaGF0IGlzIG1pc3NpbmcgaXMgcmVtb3Zp bmcgdGhlIEZpbHRlckltYWdlIGVudHJ5IGl0c2VsZiBmcm9tCisgICAgICAgIEZpbHRlclJlc3Vs dHM6Om1fcmVzdWx0UmVmZXJlbmNlcy4gICAgICAgIAorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvZmlsdGVycy9GaWx0ZXJSZXN1bHRzLmg6CisgICAgICAgIChXZWJDb3JlOjpGaWx0ZXJS ZXN1bHRzOjpjbGVhckVmZmVjdFJlc3VsdCk6CisKIDIwMjItMDUtMDkgIEdhYnJpZWwgTmF2YSBN YXJpbm8gIDxnbmF2YW1hcmlub0BhcHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJUIGluIFdlYkNv cmU6OlJlbmRlclRyZWVVcGRhdGVyOjp1cGRhdGVSZW5kZXJUcmVlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZpbHRlclJlc3VsdHMuaCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmlsdGVyUmVzdWx0cy5oCmlu ZGV4IGU1MGI2YmNlOTliZTZjZGMyZGJiOTc5MjBiMTlmOTA5NTA2MjI2ZGYuLmE0MWIyYjBiZmMx MmVhOTAyNjgyMTNkMTNmYmMwODYwNWM5MjgxNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmlsdGVyUmVzdWx0cy5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmlsdGVyUmVzdWx0cy5oCkBAIC02Myw2 ICs2Myw4IEBAIHB1YmxpYzoKIAogICAgICAgICBmb3IgKGF1dG8mIHJlZmVyZW5jZSA6IG1fcmVz dWx0UmVmZXJlbmNlcy5nZXQocmVzdWx0KSkKICAgICAgICAgICAgIGNsZWFyRWZmZWN0UmVzdWx0 KHJlZmVyZW5jZSk7CisgICAgICAgIAorICAgICAgICBtX3Jlc3VsdFJlZmVyZW5jZXMucmVtb3Zl KHJlc3VsdCk7CiAgICAgfQogCiBwcml2YXRlOgo=