240227 2022-05-09 03:56:54 -0700 [WinCairo] CloseEvent has wasClean=true and no error code when the WebSocket connection got terminated from the server side 2023-02-08 12:04:22 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Other Windows 10 RESOLVED FIXED InRadar P2 Normal --- 1 max fujii aperez bugs-noreply don.olmstead fujii mcatanzaro webkit-bug-importer oldest_to_newest 1867603 0 max 2022-05-09 03:56:54 -0700 Repro: ```js // server.js const express = require('express'); const ws = require('ws'); const app = express(); const wsServer = new ws.Server({ noServer: true }); app.get("/", (req, res)=>res.end(` <p>watch console</p> <script> function createWs(){ const ws=new WebSocket("ws://localhost:3003/ws"); ws.onopen = e => console.log("onopen", e); ws.onerror = e => console.error("onerror",e); ws.onclose = e => { console.log("onclose",e,e.code,e.wasClean); document.writeln("onclose with code " + e.code + " wasClean: " + e.wasClean); }; } createWs(); </script> `)); const server = app.listen(3003); server.on('upgrade', (request, socket, head) => { wsServer.handleUpgrade(request, socket, head, socket => { socket.terminate(); }); }); ``` 1. `mkdir tmp` 2. `cd tmp` 3. `npm init -y` 4. `npm install ws express` 5. `node server.js` 6. Navigate to `http://localhost:3003` Expected (Firefox, Chromium): `onclose with code 1006 wasClean: false ` Actual (Epiphany 42.1, Custom WebKit on tip-of-tree): `onclose with code 0 wasClean: true` Downstream bug: https://github.com/microsoft/playwright/issues/12353 1930976 1 max 2023-02-03 12:28:06 -0800 Looks like this is fixed on Linux now and is only present in Windows. 1931483 2 464871 fujii 2023-02-06 13:57:23 -0800 Created attachment 464871 WIP patch 1931556 3 464879 fujii 2023-02-06 16:35:09 -0800 Created attachment 464879 server.js WinCairo WK1 can't load the page because it has no Content-Type responose header. Modified server.js. I confirmed WinCairo WK1 works fine. 1931582 4 fujii 2023-02-06 17:50:56 -0800 Pull request: https://github.com/WebKit/WebKit/pull/9728 1932098 5 ews-feeder 2023-02-08 12:03:26 -0800 Committed 260025@main (42847605cf96): <https://commits.webkit.org/260025@main> Reviewed commits have been landed. Closing PR #9728 and removing active labels. 1932099 6 webkit-bug-importer 2023-02-08 12:04:22 -0800 <rdar://problem/105186438> 464871 2023-02-06 13:57:23 -0800 2023-02-06 17:52:59 -0800 WIP patch wip.patch text/plain 589 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY3VybC9XZWJTb2NrZXRU YXNrQ3VybC5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2N1cmwvV2ViU29ja2V0 VGFza0N1cmwuY3BwCmluZGV4IDAyZDZiMTUzNDBmNi4uOTA4Zjc1ZjgzYjlmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2N1cmwvV2ViU29ja2V0VGFza0N1cmwuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY3VybC9XZWJTb2NrZXRUYXNrQ3Vy bC5jcHAKQEAgLTEzMSw3ICsxMzEsNyBAQCB2b2lkIFdlYlNvY2tldFRhc2s6OmRpZFJlY2VpdmVE YXRhKFdlYkNvcmU6OkN1cmxTdHJlYW1JRCwgY29uc3QgV2ViQ29yZTo6U2hhcmVkQgogICAgICAg ICByZXR1cm47CiAKICAgICBpZiAoIWJ1ZmZlci5zaXplKCkpIHsKLSAgICAgICAgZGlkQ2xvc2Uo MCwgeyB9KTsKKyAgICAgICAgZGlkQ2xvc2UoV2ViQ29yZTo6V2ViU29ja2V0Q2hhbm5lbDo6Q2xv c2VFdmVudENvZGU6OkNsb3NlRXZlbnRDb2RlQWJub3JtYWxDbG9zdXJlLCB7IH0pOwogICAgICAg ICByZXR1cm47CiAgICAgfQogCg== 464879 2023-02-06 16:35:09 -0800 2023-02-06 16:35:09 -0800 server.js server.js text/javascript 781 fujii Y29uc3QgZXhwcmVzcyA9IHJlcXVpcmUoJ2V4cHJlc3MnKTsKY29uc3Qgd3MgPSByZXF1aXJlKCd3 cycpOwpjb25zdCBhcHAgPSBleHByZXNzKCk7CmNvbnN0IHdzU2VydmVyID0gbmV3IHdzLlNlcnZl cih7IG5vU2VydmVyOiB0cnVlIH0pOwphcHAuZ2V0KCIvIiwgKHJlcSwgcmVzKT0+IHsKICAgIHJl cy5zZXQoJ0NvbnRlbnQtVHlwZScsICd0ZXh0L2h0bWwnKTsKICAgIHJlcy5lbmQoYAo8cD53YXRj aCBjb25zb2xlPC9wPgo8c2NyaXB0PgpmdW5jdGlvbiBjcmVhdGVXcygpewogIGNvbnN0IHdzPW5l dyBXZWJTb2NrZXQoIndzOi8vbG9jYWxob3N0OjMwMDMvd3MiKTsKICB3cy5vbm9wZW4gPSBlID0+ IGNvbnNvbGUubG9nKCJvbm9wZW4iLCBlKTsKICB3cy5vbmVycm9yID0gZSA9PiBjb25zb2xlLmVy cm9yKCJvbmVycm9yIixlKTsKICB3cy5vbmNsb3NlID0gZSA9PiB7CiAgICBjb25zb2xlLmxvZygi b25jbG9zZSIsZSxlLmNvZGUsZS53YXNDbGVhbik7CiAgICBkb2N1bWVudC53cml0ZWxuKCJvbmNs b3NlIHdpdGggY29kZSAiICsgZS5jb2RlICsgIiB3YXNDbGVhbjogIiArIGUud2FzQ2xlYW4pOwog IH07Cn0KY3JlYXRlV3MoKTsKPC9zY3JpcHQ+CmApfSk7CmNvbnN0IHNlcnZlciA9IGFwcC5saXN0 ZW4oMzAwMyk7CnNlcnZlci5vbigndXBncmFkZScsIChyZXF1ZXN0LCBzb2NrZXQsIGhlYWQpID0+ IHsKICB3c1NlcnZlci5oYW5kbGVVcGdyYWRlKHJlcXVlc3QsIHNvY2tldCwgaGVhZCwgc29ja2V0 ID0+IHsKICAgIHNvY2tldC50ZXJtaW5hdGUoKTsKICB9KTsKfSk7Cg==