240219 2022-05-08 16:36:21 -0700 foo(optional [EnforceRange] unsigned long long offset = 0) IDL functions don't work when called like foo(undefined) or foo() 2026-01-23 06:43:34 -0800 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=240441 InRadar P2 Normal --- 232558 1 mmaxfield sam ahmad.saleem792 cdumez sam webkit-bug-importer oldest_to_newest 1867540 0 mmaxfield 2022-05-08 16:36:21 -0700 In WebGPU, see mapAsync() and getMappedRange(). The C++ version of these functions never get called when the optional parameters with default values are specified by JS as undefined or omitted. 1867543 1 cdumez 2022-05-08 16:51:23 -0700 I find his very surprising. Pretty sure we already have similar IDL in the code Base. I’d expect our generated code to call the implementation function with 0 if the parameter is omitted or undefined. 1868607 2 cdumez 2022-05-12 18:11:08 -0700 I have just double-checked here and things seem to work as expected. I validated with the following patch: ``` diff --git a/Source/WebCore/dom/Document.cpp b/Source/WebCore/dom/Document.cpp index 0636bd5b4363..370a789c0a9e 100644 --- a/Source/WebCore/dom/Document.cpp +++ b/Source/WebCore/dom/Document.cpp @@ -9202,6 +9202,11 @@ bool Document::isSameSiteForCookies(const URL& url) const return domain.matches(url); } +void Document::testOptionalUnsignedLongLong(uint64_t param) +{ + WTFLogAlways("CHRIS: Document::testOptionalUnsignedLongLong(%llu)", param); +} + } // namespace WebCore #undef DOCUMENT_RELEASE_LOG diff --git a/Source/WebCore/dom/Document.h b/Source/WebCore/dom/Document.h index 866abc6d7986..fcc1319cadb0 100644 --- a/Source/WebCore/dom/Document.h +++ b/Source/WebCore/dom/Document.h @@ -699,6 +699,8 @@ public: void cancelParsing(); + void testOptionalUnsignedLongLong(uint64_t); + ExceptionOr<void> write(Document* entryDocument, SegmentedString&&); WEBCORE_EXPORT ExceptionOr<void> write(Document* entryDocument, FixedVector<String>&&); WEBCORE_EXPORT ExceptionOr<void> writeln(Document* entryDocument, FixedVector<String>&&); diff --git a/Source/WebCore/dom/Document.idl b/Source/WebCore/dom/Document.idl index b5cc4978066a..db9726d66df7 100644 --- a/Source/WebCore/dom/Document.idl +++ b/Source/WebCore/dom/Document.idl @@ -94,6 +94,8 @@ typedef (HTMLScriptElement or SVGScriptElement) HTMLOrSVGScriptElement; // Non standard: It has been dropped from Blink already. RenderingContext? getCSSCanvasContext(DOMString contextId, DOMString name, long width, long height); + + undefined testOptionalUnsignedLongLong(optional unsigned long long parameter = 0); }; enum DocumentReadyState { "loading", "interactive", "complete" }; ``` document.testOptionalUnsignedLongLong() -> implementation called with 0 document.testOptionalUnsignedLongLong(0) -> implementation called with 0 document.testOptionalUnsignedLongLong(1) -> implementation called with 1 document.testOptionalUnsignedLongLong(undefined) -> implementation called with 0 Works as expected IMO. 1868875 3 mmaxfield 2022-05-13 15:01:12 -0700 Cool, thanks for trying it out. I'll try to figure out why the WebGPU stuff isn't working then. 1869086 4 459381 mmaxfield 2022-05-15 11:47:12 -0700 Created attachment 459381 Test file Here is a test file demonstrating the problem. (You have to open it in DumpRenderTree; it's not hooked up into WK2 yet, and is intentionally disabled in Minibrowser.) The IDL has: Promise<undefined> mapAsync(GPUMapModeFlags mode, optional GPUSize64 offset = 0, optional GPUSize64 size); And if you call it like buffer.mapAsync(GPUMapMode.WRITE); then our generated bindings code does this: auto offset = convert<IDLEnforceRangeAdaptor<IDLUnsignedLongLong>>(*lexicalGlobalObject, argument1.value()); which gets sent to: double JSValue::toNumberSlowCase(JSGlobalObject* globalObject) const { ... return isUndefined() ? PNaN : 0; // null and false both convert to 0. } and then sent to static double enforceRange(JSGlobalObject& lexicalGlobalObject, double x, double minimum, double maximum) { ... if (std::isnan(x) || std::isinf(x)) { throwTypeError(&lexicalGlobalObject, scope, rangeErrorString(x, minimum, maximum)); return 0; } ... } 1869106 5 webkit-bug-importer 2022-05-15 16:37:12 -0700 <rdar://problem/93317646> 1869884 6 mmaxfield 2022-05-17 18:03:12 -0700 Pull request: https://github.com/WebKit/WebKit/pull/710 1896006 7 ahmad.saleem792 2022-09-03 04:04:05 -0700 In Pull Request from Comment 06, there is mention that it was landed as part of following: https://trac.webkit.org/changeset/294373/webkit Is anything else needed here? BY THE WAY - the test file show "failure" in all browsers (Chrome Canary 107, Firefox Nightly 106 and Safari Technology Preview 152). 1896977 8 mmaxfield 2022-09-07 22:41:16 -0700 Yes, there is more to do here. The bug itself isn't fixed; that pull request just worked around the problem. 2174328 9 sam 2026-01-22 17:55:33 -0800 This only is an issue for types annotated with [EnforceRange]. The fix is to disable the "WillConvertUndefinedToDefaultParameterValue" optimization for [EnforceRange] types. 2174329 10 sam 2026-01-22 18:00:29 -0800 Pull request: https://github.com/WebKit/WebKit/pull/57096 2174457 11 ews-feeder 2026-01-23 06:43:30 -0800 Committed 306087@main (8e68a118b1aa): <https://commits.webkit.org/306087@main> Reviewed commits have been landed. Closing PR #57096 and removing active labels. 459381 2022-05-15 11:47:12 -0700 2022-05-15 11:47:12 -0700 Test file webgpu.html text/html 478 mmaxfield PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPC9oZWFkPgo8Ym9keT4KPHNjcmlwdD4KYXN5 bmMgZnVuY3Rpb24gcnVuKCkgewogICAgbGV0IGFkYXB0ZXIgPSBhd2FpdCBuYXZpZ2F0b3IuZ3B1 LnJlcXVlc3RBZGFwdGVyKCk7CiAgICBsZXQgZGV2aWNlID0gYXdhaXQgYWRhcHRlci5yZXF1ZXN0 RGV2aWNlKCk7CiAgICBsZXQgYnVmZmVyID0gZGV2aWNlLmNyZWF0ZUJ1ZmZlcih7c2l6ZTogMTI4 LCB1c2FnZTogR1BVQnVmZmVyVXNhZ2UuTUFQX1dSSVRFfSk7CiAgICAvL2F3YWl0IGJ1ZmZlci5t YXBBc3luYyhHUFVNYXBNb2RlLldSSVRFLCAwLCAxMjgpOwogICAgYXdhaXQgYnVmZmVyLm1hcEFz eW5jKEdQVU1hcE1vZGUuV1JJVEUpOwp9CnJ1bigpLnRoZW4oZnVuY3Rpb24oKSB7CiAgICBhbGVy dCgiZG9uZSIpOwp9LCBmdW5jdGlvbigpIHsKICAgIGFsZXJ0KCJmYWlsdXJlIik7Cn0pOwo8L3Nj cmlwdD4KPC9ib2R5Pgo8L2h0bWw+Cg==