240178 2022-05-06 11:34:38 -0700 [macOS] Content filter blocking shield is not displayed 2022-05-06 17:03:03 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan webkit-unassigned ggaren webkit-bug-importer oldest_to_newest 1867290 0 pvollan 2022-05-06 11:34:38 -0700 Content filter blocking shield is not displayed on macOS for blocked URLs. 1867291 1 pvollan 2022-05-06 11:34:55 -0700 <rdar://91586177> 1867296 2 458966 pvollan 2022-05-06 11:46:32 -0700 Created attachment 458966 Patch 1867337 3 458966 ggaren 2022-05-06 14:09:52 -0700 Comment on attachment 458966 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458966&action=review r=me > Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:185 > + auto unblocked = false; > + callOnMainThread([decisionHandler, unblocked] { > + decisionHandler(unblocked); > + }); Can unblocked be a local variable rather than a captured variable here? 1867364 4 pvollan 2022-05-06 15:02:25 -0700 (In reply to Geoffrey Garen from comment #3) > Comment on attachment 458966 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=458966&action=review > > r=me > > > Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:185 > > + auto unblocked = false; > > + callOnMainThread([decisionHandler, unblocked] { > > + decisionHandler(unblocked); > > + }); > > Can unblocked be a local variable rather than a captured variable here? Yes, that is a good point, will fix. Thanks for reviewing! 1867367 5 458976 pvollan 2022-05-06 15:11:07 -0700 Created attachment 458976 Patch 1867398 6 ews-feeder 2022-05-06 17:02:58 -0700 Committed r293931 (250378@main): <https://commits.webkit.org/250378@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458976. 458966 2022-05-06 11:46:32 -0700 2022-05-06 14:09:52 -0700 Patch 240178.patch text/plain 1901 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI5MzkwOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIyLTA1LTA2ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIENvbnRlbnQg ZmlsdGVyIGJsb2NraW5nIHNoaWVsZCBpcyBub3QgZGlzcGxheWVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDAxNzgKKyAgICAgICAgPHJkYXI6Ly85 MTU4NjE3Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGlzIGEgcmVncmVzc2lvbiBmcm9tIG1vdmluZyBjb250ZW50IGZpbHRlcmluZyBmcm9t IHRoZSBXZWJDb250ZW50IHByb2Nlc3MgdG8gdGhlIE5ldHdvcmsgcHJvY2VzcyBpbiByMjkxNjMw LgorICAgICAgICBBZnRlciByMjkxNjMwLCB0aGUgZnVuY3Rpb24gdG8gZGV0ZXJtaW5lIGlmIGEg YmxvY2tlZCByZXF1ZXN0IGNhbiBiZSB1bmJsb2NrZWQsIGlzIGNhbGxlZCBpbiB0aGUgTmV0d29y ayBwcm9jZXNzLAorICAgICAgICBidXQgaXQgaXMgbm90IGhhbmRsaW5nIHRoZSBjYXNlIHdoZXJl IHRoZSBmdW5jdGlvbiB0byB1bmJsb2NrIHRoZSByZXF1ZXN0IGlzIG5vdCBzZXQuIFRoaXMgaXMg Y2F1c2luZyB0aGUgbG9hZAorICAgICAgICBmb3IgYmxvY2tlZCBVUkxzIHRvIG5ldmVyIGZpbmlz aCwgc2luY2UgdGhlIGRlY2lzaW9uIGhhbmRsZXIgcHJvdmlkZWQgdG8gdGhlIHVuYmxvY2sgcmVx dWVzdCBmdW5jdGlvbiBpcyBuZXZlcgorICAgICAgICBjYWxsZWQuIFRoaXMgcGF0Y2ggYWRkcmVz c2VzIHRoaXMgYnkgY2FsbGluZyB0aGUgZGVjaXNpb25oYW5kbGVyIHdpdGggdGhlIGJsb2NrZWQg ZmxhZyBzZXQgaW4gdGhpcyBjYXNlLgorCisgICAgICAgICogcGxhdGZvcm0vY29jb2EvQ29udGVu dEZpbHRlclVuYmxvY2tIYW5kbGVyQ29jb2EubW06CisgICAgICAgIChXZWJDb3JlOjpDb250ZW50 RmlsdGVyVW5ibG9ja0hhbmRsZXI6OnJlcXVlc3RVbmJsb2NrQXN5bmMgY29uc3QpOgorCiAyMDIy LTA1LTA2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFJl bW92ZSB0aGUgdmlld3BvcnRGaXRFbmFibGVkIFdLUHJlZmVyZW5jZSBub3cgdGhhdCBpdCBpcyBh bHdheXMgb24gCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9Db250ZW50Rmls dGVyVW5ibG9ja0hhbmRsZXJDb2NvYS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9jb2NvYS9Db250ZW50RmlsdGVyVW5ibG9ja0hhbmRsZXJDb2NvYS5tbQkocmV2aXNp b24gMjkzODY0KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvQ29udGVudEZpbHRl clVuYmxvY2tIYW5kbGVyQ29jb2EubW0JKHdvcmtpbmcgY29weSkKQEAgLTE3OCw2ICsxNzgsMTEg QEAKICAgICAgICAgICAgICAgICBkZWNpc2lvbkhhbmRsZXIodW5ibG9ja2VkKTsKICAgICAgICAg ICAgIH0pOwogICAgICAgICB9KTsKKyAgICB9IGVsc2UgeworICAgICAgICBhdXRvIHVuYmxvY2tl ZCA9IGZhbHNlOworICAgICAgICBjYWxsT25NYWluVGhyZWFkKFtkZWNpc2lvbkhhbmRsZXIsIHVu YmxvY2tlZF0geworICAgICAgICAgICAgZGVjaXNpb25IYW5kbGVyKHVuYmxvY2tlZCk7CisgICAg ICAgIH0pOwogICAgIH0KIH0KIAo= 458976 2022-05-06 15:11:07 -0700 2022-05-06 17:03:00 -0700 Patch 240178.patch text/plain 1911 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI5MzkyMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIyLTA1LTA2ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIENvbnRlbnQg ZmlsdGVyIGJsb2NraW5nIHNoaWVsZCBpcyBub3QgZGlzcGxheWVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNDAxNzgKKyAgICAgICAgPHJkYXI6Ly85 MTU4NjE3Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4KKworICAgICAg ICBUaGlzIGlzIGEgcmVncmVzc2lvbiBmcm9tIG1vdmluZyBjb250ZW50IGZpbHRlcmluZyBmcm9t IHRoZSBXZWJDb250ZW50IHByb2Nlc3MgdG8gdGhlIE5ldHdvcmsgcHJvY2VzcyBpbiByMjkxNjMw LgorICAgICAgICBBZnRlciByMjkxNjMwLCB0aGUgZnVuY3Rpb24gdG8gZGV0ZXJtaW5lIGlmIGEg YmxvY2tlZCByZXF1ZXN0IGNhbiBiZSB1bmJsb2NrZWQsIGlzIGNhbGxlZCBpbiB0aGUgTmV0d29y ayBwcm9jZXNzLAorICAgICAgICBidXQgaXQgaXMgbm90IGhhbmRsaW5nIHRoZSBjYXNlIHdoZXJl IHRoZSBmdW5jdGlvbiB0byB1bmJsb2NrIHRoZSByZXF1ZXN0IGlzIG5vdCBzZXQuIFRoaXMgaXMg Y2F1c2luZyB0aGUgbG9hZAorICAgICAgICBmb3IgYmxvY2tlZCBVUkxzIHRvIG5ldmVyIGZpbmlz aCwgc2luY2UgdGhlIGRlY2lzaW9uIGhhbmRsZXIgcHJvdmlkZWQgdG8gdGhlIHVuYmxvY2sgcmVx dWVzdCBmdW5jdGlvbiBpcyBuZXZlcgorICAgICAgICBjYWxsZWQuIFRoaXMgcGF0Y2ggYWRkcmVz c2VzIHRoaXMgYnkgY2FsbGluZyB0aGUgZGVjaXNpb25oYW5kbGVyIHdpdGggdGhlIGJsb2NrZWQg ZmxhZyBzZXQgaW4gdGhpcyBjYXNlLgorCisgICAgICAgICogcGxhdGZvcm0vY29jb2EvQ29udGVu dEZpbHRlclVuYmxvY2tIYW5kbGVyQ29jb2EubW06CisgICAgICAgIChXZWJDb3JlOjpDb250ZW50 RmlsdGVyVW5ibG9ja0hhbmRsZXI6OnJlcXVlc3RVbmJsb2NrQXN5bmMgY29uc3QpOgorCiAyMDIy LTA1LTA2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFJl bW92ZSBpbnRlcm5hbCBXS1ByZWZlcmVuY2UgZm9yIG5vbi1pVHVuZXNBVk91dHB1dCBub3cgdGhh dCBhbGwgcGxhdGZvcm0gc3VwcG9ydCBpdCAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2NvY29hL0NvbnRlbnRGaWx0ZXJVbmJsb2NrSGFuZGxlckNvY29hLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL0NvbnRlbnRGaWx0ZXJVbmJsb2NrSGFuZGxl ckNvY29hLm1tCShyZXZpc2lvbiAyOTM5MjApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9j b2NvYS9Db250ZW50RmlsdGVyVW5ibG9ja0hhbmRsZXJDb2NvYS5tbQkod29ya2luZyBjb3B5KQpA QCAtMTc4LDYgKzE3OCwxMSBAQAogICAgICAgICAgICAgICAgIGRlY2lzaW9uSGFuZGxlcih1bmJs b2NrZWQpOwogICAgICAgICAgICAgfSk7CiAgICAgICAgIH0pOworICAgIH0gZWxzZSB7CisgICAg ICAgIGNhbGxPbk1haW5UaHJlYWQoW2RlY2lzaW9uSGFuZGxlcl0geworICAgICAgICAgICAgYXV0 byB1bmJsb2NrZWQgPSBmYWxzZTsKKyAgICAgICAgICAgIGRlY2lzaW9uSGFuZGxlcih1bmJsb2Nr ZWQpOworICAgICAgICB9KTsKICAgICB9CiB9CiAK