240158 2022-05-05 23:48:57 -0700 [WinCairo] Some integrity and WebIDLParser tests are failing if the EOL is CR LF (checked out by Windows Git) 2023-10-16 17:18:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified REOPENED https://bugs.webkit.org/show_bug.cgi?id=34645 P2 Normal --- 263173 263174 1 fujii webkit-unassigned oldest_to_newest 1867114 0 fujii 2022-05-05 23:48:57 -0700 [WinCairo] Some integrity and WebIDLParser tests are failing if the EOL is CR LF (checked out by Windows Git) https://build.webkit.org/#/builders/60/builds/6567 imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/global-immutable-prototype.any.worker.html [ Failure ] imported/w3c/web-platform-tests/WebIDL/idlharness.any.worker.html [ Failure ] imported/w3c/web-platform-tests/reporting/idlharness.any.worker.html [ Failure ] js/dom/modules/module-integrity-bad-value-success-with-cache.html [ Failure ] js/dom/modules/module-integrity-non-top-level.html [ Failure ] 1867115 1 fujii 2022-05-05 23:50:43 -0700 Disabling core.autocrlf will fix it. git config --system core.autocrlf false 1867116 2 fujii 2022-05-05 23:52:32 -0700 web-platform-tests is using .gitattributes to disable the EOL conversion. https://github.com/web-platform-tests/wpt/commit/2aef503a5b83fd08f57b7277533293773176b445 1869094 3 fujii 2022-05-15 13:09:37 -0700 WinCairo bots fixed the issue by changing git configuration. https://github.com/WebKitForWindows/docker-webkit-dev/commit/8d9c7fd63d7ffe6b072df38e0bbc084176bcb0a1 1950173 4 fujii 2023-04-20 15:20:13 -0700 The list of failing tests due to core.autocrlf=true: fast/dom/adopt-attribute-crash.svg [ Failure ] http/tests/inspector/network/resource-sizes-memory-cache.html [ Failure ] http/tests/inspector/network/resource-sizes-network.html [ Failure ] http/tests/xmlhttprequest/cache-override.html [ Failure ] http/tests/xmlhttprequest/response-empty-arraybuffer.html [ Failure ] http/wpt/push-api/pushSubscription.https.any.serviceworker.html [ Failure ] http/wpt/push-api/pushSubscriptionChangeEvent.any.serviceworker.html [ Failure ] http/wpt/service-workers/claim-worker-fetch-without-nesting.https.html [ Failure ] http/wpt/service-workers/cors-preflight-star.any-serviceworker.html [ Failure ] imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/global-immutable-prototype.any.worker.html [ Failure ] imported/w3c/web-platform-tests/WebIDL/idlharness.any.worker.html [ Failure ] js/dom/modules/module-integrity-bad-value-success-with-cache.html [ Failure ] js/dom/modules/module-integrity-non-top-level.html [ Failure ] 1950206 5 fujii 2023-04-20 18:23:47 -0700 There are a lot of files checked in accidentally with CR-LF. > git grep --cached -lI $'\r' We should prevent Windows developers to check in CR-LF. > git config --global core.autocrlf input 1950208 6 fujii 2023-04-20 18:36:09 -0700 LayoutTests/.gitattributes has `-crlf`. https://github.com/WebKit/WebKit/blob/204cc1e1e3a384a40bed51c2bd73cbe4df86b1fe/LayoutTests/.gitattributes `-crlf` is old style of `-text`. https://git-scm.com/docs/gitattributes It was added by 45745@main (bug#34645). 1950217 7 fujii 2023-04-20 18:58:52 -0700 Because core.autocrlf=true is the defalut of Windows Git, I think we should add something to LayoutTests/.gitattributes. > fast/dom/adopt-attribute-crash.svg eol=lf 1985438 8 fujii 2023-10-16 15:14:53 -0700 remaining failures: http/wpt/push-api/pushSubscription.https.any.serviceworker.html [ Failure ] http/wpt/push-api/pushSubscriptionChangeEvent.any.serviceworker.html [ Failure ] http/wpt/service-workers/cors-preflight-star.any-serviceworker.html [ Failure ] 1985462 9 fujii 2023-10-16 17:18:17 -0700 One more: fast/dom/Range/detach-range-during-deletecontents.html [ Timeout ]