240129 2022-05-05 10:57:41 -0700 Remove abandoned WKPreference for SelectionPaintingWithoutSelectionGaps 2022-05-06 14:12:13 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham cdumez changseok esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan pdr webkit-bug-importer zalan oldest_to_newest 1866917 0 bfulgham 2022-05-05 10:57:41 -0700 This setting was added in Bug 156900 for the EFL port, which has since left the WebKit project. As the port is no longer buildable, and this code is never used outside of EFL, we should remove this dead code. 1866919 1 458894 bfulgham 2022-05-05 11:01:40 -0700 Created attachment 458894 Patch 1867021 2 458894 cdumez 2022-05-05 15:55:21 -0700 Comment on attachment 458894 Patch What about this check? Source/WebCore/rendering/RenderBlock.cpp: if (settings().selectionPaintingWithoutSelectionGapsEnabled()) 1867032 3 bfulgham 2022-05-05 16:14:41 -0700 (In reply to Chris Dumez from comment #2) > Comment on attachment 458894 [details] > Patch > > What about this check? > Source/WebCore/rendering/RenderBlock.cpp: if > (settings().selectionPaintingWithoutSelectionGapsEnabled()) Right -- this conditional is always 'false' for non-EFL builds, so there's no point in having the preference, or calling that method (and performing that test) on any active WebKit port. 1867338 4 ews-feeder 2022-05-06 14:11:55 -0700 Committed r293923 (250370@main): <https://commits.webkit.org/250370@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458894. 1867339 5 webkit-bug-importer 2022-05-06 14:12:13 -0700 <rdar://problem/92879882> 458894 2022-05-05 11:01:40 -0700 2022-05-06 14:11:57 -0700 Patch bug-240129-20220505110140.patch text/plain 6590 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzODQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQwMzNkYjQ5ZmJlYmNlYjM0ZDJmOGMz ZmU0ZTJjNDFmNzU0YmE4OTQuLmNiODMyNGJjYzQzZTA1MGZjNTdmMTU0ZjQ3MzM3ZjhlODBlY2Jm NzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjItMDUtMDUgIEJyZW50IEZ1bGdoYW0gIDxiZnVs Z2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGFiYW5kb25lZCBXS1ByZWZlcmVuY2Ug Zm9yIFNlbGVjdGlvblBhaW50aW5nV2l0aG91dFNlbGVjdGlvbkdhcHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI0MDEyOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB0aGUgYWJhbmRvbmVkIFdL UHJlZmVyZW5jZSAnU2VsZWN0aW9uUGFpbnRpbmdXaXRob3V0U2VsZWN0aW9uR2FwcycsIHdoaWNo IHdhcyBhZGRlZCB0byBzdXBwb3J0CisgICAgICAgIHRoZSBFRkwgcG9ydC4gQXMgdGhlIEVGTCBw b3J0IGlzIG5vIGxvbmdlciBidWlsZGFibGUsIGFuZCB0aGlzIGNvZGUgaXMgbmV2ZXIgdXNlZCBv dXRzaWRlIG9mIEVGTCwgd2UKKyAgICAgICAgc2hvdWxkIHJlbW92ZSB0aGlzIGRlYWQgY29kZS4K KworICAgICAgICAqIFNjcmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXMueWFtbDoKKwog MjAyMi0wNS0wNCAgS2ltbW8gS2lubnVuZW4gIDxra2lubnVuZW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFNoYXJlZE1lbW9yeTo6c3lzdGVtUGFnZVNpemUgaXMgcmVkdW5kYW50IGZ1bmN0aW9uCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggNTAyYTQ5YjY3MTViMGQ2OTQ4NGI4ODk0ZjQyMWZlM2Q4MDI2YjVmNy4uZTll YzljMGIxZjYwYWZmNzJjMjViZGMyMjhjM2NkM2VkMmEwOTNkNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE3IEBACisyMDIyLTA1LTA1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFJlbW92ZSBhYmFuZG9uZWQgV0tQcmVmZXJlbmNlIGZvciBTZWxlY3Rpb25Q YWludGluZ1dpdGhvdXRTZWxlY3Rpb25HYXBzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yNDAxMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdGhlIGFiYW5kb25lZCBXS1ByZWZlcmVuY2UgJ1Nl bGVjdGlvblBhaW50aW5nV2l0aG91dFNlbGVjdGlvbkdhcHMnLCB3aGljaCB3YXMgYWRkZWQgdG8g c3VwcG9ydAorICAgICAgICB0aGUgRUZMIHBvcnQuIEFzIHRoZSBFRkwgcG9ydCBpcyBubyBsb25n ZXIgYnVpbGRhYmxlLCBhbmQgdGhpcyBjb2RlIGlzIG5ldmVyIHVzZWQgb3V0c2lkZSBvZiBFRkws IHdlCisgICAgICAgIHNob3VsZCByZW1vdmUgdGhpcyBkZWFkIGNvZGUuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6 OnNob3VsZFBhaW50U2VsZWN0aW9uR2FwcyBjb25zdCk6CisKIDIwMjItMDUtMDUgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl1bQ29jb2FdIFJlbW92ZSB1 c2Ugb2YgQ1ZQaXhlbEJ1ZmZlckNvbmZvcm1lciBmcm9tIFdlYkNvbnRlbnQgcHJvY2VzcyBpbiBN ZWRpYVBsYXllclByaXZhdGVSZW1vdGU6Om5hdGl2ZUltYWdlRm9yQ3VycmVudFRpbWUoKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxv ZwppbmRleCBiNGQwNTcxNzRlNzA0ZTY2YmEzMWYwZjYwOTYxYjgwNTA3ZGJlYzk2Li4xYWQ0NmU1 YWJjYzczNGEwMDc4ZTZmYjQwYTU2YzZhNTVmYzdkZDUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIyLTA1LTA1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisg ICAgICAgIFJlbW92ZSBhYmFuZG9uZWQgV0tQcmVmZXJlbmNlIGZvciBTZWxlY3Rpb25QYWludGlu Z1dpdGhvdXRTZWxlY3Rpb25HYXBzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yNDAxMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZW1vdmUgdGhlIGFiYW5kb25lZCBXS1ByZWZlcmVuY2UgJ1NlbGVjdGlv blBhaW50aW5nV2l0aG91dFNlbGVjdGlvbkdhcHMnLCB3aGljaCB3YXMgYWRkZWQgdG8gc3VwcG9y dAorICAgICAgICB0aGUgRUZMIHBvcnQuIEFzIHRoZSBFRkwgcG9ydCBpcyBubyBsb25nZXIgYnVp bGRhYmxlLCBhbmQgdGhpcyBjb2RlIGlzIG5ldmVyIHVzZWQgb3V0c2lkZSBvZiBFRkwsIHdlCisg ICAgICAgIHNob3VsZCByZW1vdmUgdGhpcyBkZWFkIGNvZGUuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL0MvV0tQcmVmZXJlbmNlcy5jcHA6CisgICAgICAgIChXS1ByZWZlcmVuY2VzU2V0U2Vs ZWN0aW9uUGFpbnRpbmdXaXRob3V0U2VsZWN0aW9uR2Fwc0VuYWJsZWQpOiBEZWxldGVkLgorICAg ICAgICAoV0tQcmVmZXJlbmNlc0dldFNlbGVjdGlvblBhaW50aW5nV2l0aG91dFNlbGVjdGlvbkdh cHNFbmFibGVkKTogRGVsZXRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJl bmNlc1JlZlByaXZhdGUuaDoKKwogMjAyMi0wNS0wNSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFw cGxlLmNvbT4KIAogICAgICAgICBbV0syXVtDb2NvYV0gUmVtb3ZlIHVzZSBvZiBDVlBpeGVsQnVm ZmVyQ29uZm9ybWVyIGZyb20gV2ViQ29udGVudCBwcm9jZXNzIGluIE1lZGlhUGxheWVyUHJpdmF0 ZVJlbW90ZTo6bmF0aXZlSW1hZ2VGb3JDdXJyZW50VGltZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL1NjcmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXMueWFtbCBiL1NvdXJjZS9XVEYv U2NyaXB0cy9QcmVmZXJlbmNlcy9XZWJQcmVmZXJlbmNlcy55YW1sCmluZGV4IGYwMGMxNTk2NmMx YzE2ZmM5ZmNmMjI5Y2NjMzRmM2ZhY2E3MWYzNWUuLmNjZjQ2NzhiYjc3NzE5MGQzY2I1NmU4NWFj M2M3YmE3NTM1ZGMwNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvU2NyaXB0cy9QcmVmZXJlbmNl cy9XZWJQcmVmZXJlbmNlcy55YW1sCisrKyBiL1NvdXJjZS9XVEYvU2NyaXB0cy9QcmVmZXJlbmNl cy9XZWJQcmVmZXJlbmNlcy55YW1sCkBAIC0xOTA5LDE2ICsxOTA5LDYgQEAgU2VsZWN0VHJhaWxp bmdXaGl0ZXNwYWNlRW5hYmxlZDoKICAgICBXZWJDb3JlOgogICAgICAgZGVmYXVsdDogZmFsc2UK IAotU2VsZWN0aW9uUGFpbnRpbmdXaXRob3V0U2VsZWN0aW9uR2Fwc0VuYWJsZWQ6Ci0gIHR5cGU6 IGJvb2wKLSAgZGVmYXVsdFZhbHVlOgotICAgIFdlYktpdExlZ2FjeToKLSAgICAgIGRlZmF1bHQ6 IGZhbHNlCi0gICAgV2ViS2l0OgotICAgICAgZGVmYXVsdDogZmFsc2UKLSAgICBXZWJDb3JlOgot ICAgICAgZGVmYXVsdDogZmFsc2UKLQogU2VyaWZGb250RmFtaWx5OgogICB0eXBlOiBTdHJpbmcK ICAgd2ViS2l0TGVnYWN5UHJlZmVyZW5jZUtleTogV2ViS2l0U2VyaWZGb250CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAppbmRleCA0N2VkMjRlZDVjN2E3MjM4OTg1ZGE0 NjdmMDllZTg2YTQzNGQwZWQ4Li4yZjdiMTA2NDc1ZjNmZDBlMjQyYjZjNjBlNzc1NjY0NGEzN2M4 NmQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKQEAgLTE0NDUs OSArMTQ0NSw2IEBAIHZvaWQgUmVuZGVyQmxvY2s6OnBhaW50Q29udGludWF0aW9uT3V0bGluZXMo UGFpbnRJbmZvJiBpbmZvLCBjb25zdCBMYXlvdXRQb2ludCYKIAogYm9vbCBSZW5kZXJCbG9jazo6 c2hvdWxkUGFpbnRTZWxlY3Rpb25HYXBzKCkgY29uc3QKIHsKLSAgICBpZiAoc2V0dGluZ3MoKS5z ZWxlY3Rpb25QYWludGluZ1dpdGhvdXRTZWxlY3Rpb25HYXBzRW5hYmxlZCgpKQotICAgICAgICBy ZXR1cm4gZmFsc2U7Ci0KICAgICByZXR1cm4gc2VsZWN0aW9uU3RhdGUoKSAhPSBIaWdobGlnaHRT dGF0ZTo6Tm9uZSAmJiBzdHlsZSgpLnZpc2liaWxpdHkoKSA9PSBWaXNpYmlsaXR5OjpWaXNpYmxl ICYmIGlzU2VsZWN0aW9uUm9vdCgpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9DL1dLUHJlZmVyZW5jZXMuY3BwCmluZGV4IDVmY2E1ZGI4ODlmOTkzN2Q4MWUxOTE3YmJl NGJhNTU3MzhmYTk2ZDguLjgwZDQxNTAyZGI0NmM0MGViMzBhZWEzZTBlYjllY2FjMGQ3MGFhNDIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXMu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXMuY3Bw CkBAIC0xNjQ1LDE2ICsxNjQ1LDYgQEAgYm9vbCBXS1ByZWZlcmVuY2VzR2V0RmV0Y2hBUElLZWVw QWxpdmVFbmFibGVkKFdLUHJlZmVyZW5jZXNSZWYgcHJlZmVyZW5jZXNSZWYpCiAgICAgcmV0dXJu IHRvSW1wbChwcmVmZXJlbmNlc1JlZiktPmZldGNoQVBJS2VlcEFsaXZlRW5hYmxlZCgpOwogfQog Ci12b2lkIFdLUHJlZmVyZW5jZXNTZXRTZWxlY3Rpb25QYWludGluZ1dpdGhvdXRTZWxlY3Rpb25H YXBzRW5hYmxlZChXS1ByZWZlcmVuY2VzUmVmIHByZWZlcmVuY2VzUmVmLCBib29sIGZsYWcpCi17 Ci0gICAgdG9JbXBsKHByZWZlcmVuY2VzUmVmKS0+c2V0U2VsZWN0aW9uUGFpbnRpbmdXaXRob3V0 U2VsZWN0aW9uR2Fwc0VuYWJsZWQoZmxhZyk7Ci19Ci0KLWJvb2wgV0tQcmVmZXJlbmNlc0dldFNl bGVjdGlvblBhaW50aW5nV2l0aG91dFNlbGVjdGlvbkdhcHNFbmFibGVkKFdLUHJlZmVyZW5jZXNS ZWYgcHJlZmVyZW5jZXNSZWYpCi17Ci0gICAgcmV0dXJuIHRvSW1wbChwcmVmZXJlbmNlc1JlZikt PnNlbGVjdGlvblBhaW50aW5nV2l0aG91dFNlbGVjdGlvbkdhcHNFbmFibGVkKCk7Ci19Ci0KIHZv aWQgV0tQcmVmZXJlbmNlc1NldEFsbG93c1BpY3R1cmVJblBpY3R1cmVNZWRpYVBsYXliYWNrKFdL UHJlZmVyZW5jZXNSZWYgcHJlZmVyZW5jZXNSZWYsIGJvb2wgZW5hYmxlZCkKIHsKICAgICB0b0lt cGwocHJlZmVyZW5jZXNSZWYpLT5zZXRBbGxvd3NQaWN0dXJlSW5QaWN0dXJlTWVkaWFQbGF5YmFj ayhlbmFibGVkKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dL UHJlZmVyZW5jZXNSZWZQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9X S1ByZWZlcmVuY2VzUmVmUHJpdmF0ZS5oCmluZGV4IDZiNTAwMjBkMWU4YmM0MmVjMmE3NzJkYzVk OTNiOGUxOTdjYzZkZjIuLjExZDI3YWU3ZDFmNzI3NjI2NTY5MmQyZDZjYzM1NzgzYTRiNzQwYWUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXNS ZWZQcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJl bmNlc1JlZlByaXZhdGUuaApAQCAtNDEwLDEwICs0MTAsNiBAQCBXS19FWFBPUlQgZG91YmxlIFdL UHJlZmVyZW5jZXNHZXRJbmFjdGl2ZU1lZGlhQ2FwdHVyZVN0ZWFtUmVwcm9tcHRJbnRlcnZhbElu TWludQogV0tfRVhQT1JUIHZvaWQgV0tQcmVmZXJlbmNlc1NldERvd25sb2FkQXR0cmlidXRlRW5h YmxlZChXS1ByZWZlcmVuY2VzUmVmLCBib29sIGZsYWcpOwogV0tfRVhQT1JUIGJvb2wgV0tQcmVm ZXJlbmNlc0dldERvd25sb2FkQXR0cmlidXRlRW5hYmxlZChXS1ByZWZlcmVuY2VzUmVmKTsKIAot Ly8gRGVmYXVsdHMgdG8gZmFsc2UKLVdLX0VYUE9SVCB2b2lkIFdLUHJlZmVyZW5jZXNTZXRTZWxl Y3Rpb25QYWludGluZ1dpdGhvdXRTZWxlY3Rpb25HYXBzRW5hYmxlZChXS1ByZWZlcmVuY2VzUmVm LCBib29sIGZsYWcpOwotV0tfRVhQT1JUIGJvb2wgV0tQcmVmZXJlbmNlc0dldFNlbGVjdGlvblBh aW50aW5nV2l0aG91dFNlbGVjdGlvbkdhcHNFbmFibGVkKFdLUHJlZmVyZW5jZXNSZWYpOwotCiAv LyBEZWZhdWx0cyB0byBmYWxzZS4KIFdLX0VYUE9SVCB2b2lkIFdLUHJlZmVyZW5jZXNTZXRBbGxv d3NQaWN0dXJlSW5QaWN0dXJlTWVkaWFQbGF5YmFjayhXS1ByZWZlcmVuY2VzUmVmLCBib29sIGZs YWcpOwogV0tfRVhQT1JUIGJvb2wgV0tQcmVmZXJlbmNlc0dldEFsbG93c1BpY3R1cmVJblBpY3R1 cmVNZWRpYVBsYXliYWNrKFdLUHJlZmVyZW5jZXNSZWYpOwo=