24012 2009-02-18 15:53:47 -0800 Convert inline-ignored-on-legend to text-only test 2009-02-19 11:22:44 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov oldest_to_newest 110132 0 dglazkov 2009-02-18 15:53:47 -0800 There's no reason for this test to be not text-only. So I am converting it to text-only. Plus some explanation. 110133 1 27768 dglazkov 2009-02-18 15:57:38 -0800 Created attachment 27768 Convert inline-ignored-on-legend to text-only test, v1. LayoutTests/ChangeLog | 13 +++++++++++++ .../forms/inline-ignored-on-legend-expected.txt | 3 +++ .../fast/forms/inline-ignored-on-legend.html | 11 ++++++++++- .../inline-ignored-on-legend-expected.checksum | 1 - .../forms/inline-ignored-on-legend-expected.png | Bin 13718 -> 0 bytes .../forms/inline-ignored-on-legend-expected.txt | 16 ---------------- 6 files changed, 26 insertions(+), 18 deletions(-) 110134 2 27768 eric 2009-02-18 16:03:35 -0800 Comment on attachment 27768 Convert inline-ignored-on-legend to text-only test, v1. Looks fine. MIght as well add a newline at the end of hte file while you're there. 110136 3 dglazkov 2009-02-18 16:16:05 -0800 Landed as http://trac.webkit.org/changeset/41069. 110138 4 hyatt 2009-02-18 16:35:42 -0800 Please back this change out. A text only test is not helpful here, since you need to see the pixel rendering to know how the legend ended up getting treated. 110164 5 dglazkov 2009-02-18 20:00:41 -0800 Ok, I am going to try to spin again. Basically, we don't really need the pixel rendering -- all we need is making sure that legend is a block element. That's fairly easy to accomplish: <div>First Line</div>Second Line vs. <span>First Line</span>Second Line These will render differently even in text-only. Even in our existing test case, there's an extra line break in the expected result. I can "accentuate" it in the test to make it clear to the observer as to what the successful output is. 110218 6 27793 dglazkov 2009-02-19 09:50:37 -0800 Created attachment 27793 Clarify objective of the test and clean up, v1 LayoutTests/ChangeLog | 10 ++++++++++ .../forms/inline-ignored-on-legend-expected.txt | 5 +++-- .../fast/forms/inline-ignored-on-legend.html | 18 +++++++----------- 3 files changed, 20 insertions(+), 13 deletions(-) 110219 7 27793 dglazkov 2009-02-19 09:51:49 -0800 Comment on attachment 27793 Clarify objective of the test and clean up, v1 Here's a simplified, clarified test case, which works in text-only mode. 110243 8 27793 hyatt 2009-02-19 11:15:39 -0800 Comment on attachment 27793 Clarify objective of the test and clean up, v1 Yeah better. 110246 9 dglazkov 2009-02-19 11:22:44 -0800 Fix/clean up landed as http://trac.webkit.org/changeset/41079. 27768 2009-02-18 15:57:38 -0800 2009-02-18 16:03:35 -0800 Convert inline-ignored-on-legend to text-only test, v1. Convert-inline-ignored-on-legend-to-text-only-test-v1..patch text/plain 4079 dglazkov MjgzN2IzMDJjNzJkNDE1MDg5ZTJlNWVkM2VlNWM4ODc5MmExMTk2MwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQxNjU0M2Uu Ljc1ZDk5YTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wMi0xOCAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI0MDEyCisgICAgICAgIENvbnZlcnQgaW5saW5lLWlnbm9yZWQtb24tbGVn ZW5kIHRvIHRleHQtb25seSB0ZXN0LgorCisgICAgICAgICogZmFzdC9mb3Jtcy9pbmxpbmUtaWdu b3JlZC1vbi1sZWdlbmQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1z L2lubGluZS1pZ25vcmVkLW9uLWxlZ2VuZC5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9m YXN0L2Zvcm1zL2lubGluZS1pZ25vcmVkLW9uLWxlZ2VuZC1leHBlY3RlZC5jaGVja3N1bTogUmVt b3ZlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvZmFzdC9mb3Jtcy9pbmxpbmUtaWdub3JlZC1v bi1sZWdlbmQtZXhwZWN0ZWQucG5nOiBSZW1vdmVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9m YXN0L2Zvcm1zL2lubGluZS1pZ25vcmVkLW9uLWxlZ2VuZC1leHBlY3RlZC50eHQ6IFJlbW92ZWQu CisKIDIwMDktMDItMTcgIFBldGVyIEFicmFoYW1zZW4gIDxyYWluaGVhZEBnbWFpbC5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvaW5saW5lLWlnbm9yZWQtb24tbGVnZW5kLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2Zhc3QvZm9ybXMvaW5saW5lLWlnbm9yZWQtb24tbGVnZW5kLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5lZWIzZDk3Ci0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbmxpbmUtaWdub3JlZC1vbi1sZWdlbmQtZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorTWVtYmVyIExvZ2luOgorCitUaGlzIHRlc3QgY29u ZmlybXMgdGhhdCBsZWdlbmQgZWxlbWVudCBjYW4gbm90IGJlIG1hZGUgaW5saW5lLiBTdWNjZWVk cyBpZiB0aGlzIG1lc3NhZ2UgaXMgdmlzaWJsZSBhbmQgdGhlcmUncyBubyBBU1NFUlQgaW4gZGVi dWcgYnVpbGQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lubGluZS1pZ25v cmVkLW9uLWxlZ2VuZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbmxpbmUtaWdub3Jl ZC1vbi1sZWdlbmQuaHRtbAppbmRleCBlOWEzMzgyLi5lOWFkZjNhIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL2lubGluZS1pZ25vcmVkLW9uLWxlZ2VuZC5odG1sCisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5saW5lLWlnbm9yZWQtb24tbGVnZW5kLmh0bWwKQEAgLTMs NiArMywxMSBAQAogCTxzdHlsZT4KICAgICAgICAgKiB7bWFyZ2luOjA7cGFkZGluZzowfQogCTwv c3R5bGU+CisJPHNjcmlwdD4KKwkgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikg eworCSAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCSAgICB9CisJ PC9zY3JpcHQ+CiA8L2hlYWQ+CiA8Ym9keT4KIAk8Zm9ybSBzdHlsZT0iZmxvYXQ6bGVmdCI+CkBA IC0xMSw2ICsxNiwxMCBAQAogCQkJPGlucHV0IHN0eWxlPSJ3aWR0aDo4MHB4Ij4KIAkJPC9maWVs ZHNldD4KIAk8L2Zvcm0+Ci0JPGRpdiBzdHlsZT0iZmxvYXQ6bGVmdDt3aWR0aDoxMDAlIj48L2Rp dj4KKwk8ZGl2IHN0eWxlPSJmbG9hdDpsZWZ0O3dpZHRoOjEwMCUiPgorCSAgIFRoaXMgdGVzdCBj b25maXJtcyB0aGF0IDxrYmQ+bGVnZW5kPC9rYmQ+IGVsZW1lbnQgY2FuIG5vdCBiZSBtYWRlIGlu bGluZS4KKwkgICBTdWNjZWVkcyBpZiB0aGlzIG1lc3NhZ2UgaXMgdmlzaWJsZSBhbmQgdGhlcmUn cyBubyA8Y29kZT5BU1NFUlQ8L2NvZGU+IGluCisJICAgZGVidWcgYnVpbGQuCisJPC9kaXY+CiA8 L2JvZHk+CiA8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvZm9ybXMvaW5saW5lLWlnbm9yZWQtb24tbGVn ZW5kLWV4cGVjdGVkLmNoZWNrc3VtIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvZm9y bXMvaW5saW5lLWlnbm9yZWQtb24tbGVnZW5kLWV4cGVjdGVkLmNoZWNrc3VtCmRlbGV0ZWQgZmls ZSBtb2RlIDEwMDY0NAppbmRleCBmOWJiYzNiLi4wMDAwMDAwCi0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9mYXN0L2Zvcm1zL2lubGluZS1pZ25vcmVkLW9uLWxlZ2VuZC1leHBlY3RlZC5j aGVja3N1bQorKysgL2Rldi9udWxsCkBAIC0xICswLDAgQEAKLTJjZjA1MzA3ZWI0NTgxZGEwZmQy YzI1ODcwYzg5ZjRhClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvZm9ybXMvaW5saW5lLWlnbm9yZWQtb24tbGVnZW5k LWV4cGVjdGVkLnBuZyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2Zvcm1zL2lubGlu ZS1pZ25vcmVkLW9uLWxlZ2VuZC1leHBlY3RlZC5wbmcKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDM5NDFhMjQuLjAwMDAwMDAKQmluYXJ5IGZpbGVzIGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL2Zhc3QvZm9ybXMvaW5saW5lLWlnbm9yZWQtb24tbGVnZW5kLWV4cGVjdGVkLnBuZyBh bmQgL2Rldi9udWxsIGRpZmZlcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj L2Zhc3QvZm9ybXMvaW5saW5lLWlnbm9yZWQtb24tbGVnZW5kLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2Zvcm1zL2lubGluZS1pZ25vcmVkLW9uLWxlZ2VuZC1l eHBlY3RlZC50eHQKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDE3ZjA5MGQuLjAwMDAw MDAKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvZm9ybXMvaW5saW5lLWlnbm9y ZWQtb24tbGVnZW5kLWV4cGVjdGVkLnR4dAorKysgL2Rldi9udWxsCkBAIC0xLDE2ICswLDAgQEAK LWxheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAotICBSZW5kZXJWaWV3IGF0ICgwLDApIHNpemUg ODAweDYwMAotbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCi0gIFJlbmRlckJsb2NrIHtIVE1M fSBhdCAoMCwwKSBzaXplIDgwMHg2MDAKLSAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoMCwwKSBz aXplIDgwMHg2MDAKLSAgICAgIFJlbmRlckJsb2NrIChmbG9hdGluZykge0ZPUk19IGF0ICgwLDAp IHNpemUgMTAzeDM3Ci0gICAgICAgIFJlbmRlckZpZWxkU2V0IHtGSUVMRFNFVH0gYXQgKDAsMCkg c2l6ZSAxMDN4MzcgW2JvcmRlcjogKDJweCBncm9vdmUgI0MwQzBDMCldCi0gICAgICAgICAgUmVu ZGVyQmxvY2sge0xFR0VORH0gYXQgKDIsMCkgc2l6ZSA5OXgxOAotICAgICAgICAgICAgUmVuZGVy VGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgOTl4MTgKLSAgICAgICAgICAgICAgdGV4dCBydW4g YXQgKDAsMCkgd2lkdGggOTk6ICJNZW1iZXIgTG9naW46IgotICAgICAgICAgIFJlbmRlckJsb2Nr IChhbm9ueW1vdXMpIGF0ICgyLDE4KSBzaXplIDk5eDE3Ci0gICAgICAgICAgICBSZW5kZXJUZXh0 Q29udHJvbCB7SU5QVVR9IGF0ICgwLDApIHNpemUgODB4MTcgW2JnY29sb3I9I0ZGRkZGRl0gW2Jv cmRlcjogKDJweCBpbnNldCAjMDAwMDAwKV0KLSAgICAgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0 fSBhdCAoMCwwKSBzaXplIDB4MAotICAgICAgUmVuZGVyQmxvY2sgKGZsb2F0aW5nKSB7RElWfSBh dCAoMCwzNykgc2l6ZSA4MDB4MAotbGF5ZXIgYXQgKDQsMjApIHNpemUgNzZ4MTMKLSAgUmVuZGVy QmxvY2sge0RJVn0gYXQgKDIsMikgc2l6ZSA3NngxMwo= 27793 2009-02-19 09:50:37 -0800 2009-02-19 11:15:39 -0800 Clarify objective of the test and clean up, v1 Clarify-objective-of-the-test-and-clean-up-v1.patch text/plain 2398 dglazkov OTgxNDI2NjI0MTBjNjExM2UyYmM1ZDhjNWUxNGUzMTAxODI1NmRjNQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGUxMjc3ZmYu LjJkNTM5NjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wMi0xOSAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNDAxMgorICAgICAgICBDbGFyaWZ5IG9iamVjdGl2ZSBvZiB0aGUgdGVzdCBhbmQgY2xl YW4gdXAuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2lubGluZS1pZ25vcmVkLW9uLWxlZ2VuZC1l eHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9mb3Jtcy9pbmxpbmUtaWdub3JlZC1vbi1sZWdl bmQuaHRtbDoKKwogMjAwOS0wMi0xOCAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbmxpbmUtaWdub3JlZC1vbi1sZWdlbmQtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbmxpbmUtaWdub3JlZC1vbi1sZWdlbmQtZXhw ZWN0ZWQudHh0CmluZGV4IGVlYjNkOTcuLmY0NWY5NDkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvaW5saW5lLWlnbm9yZWQtb24tbGVnZW5kLWV4cGVjdGVkLnR4dAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lubGluZS1pZ25vcmVkLW9uLWxlZ2VuZC1leHBlY3RlZC50 eHQKQEAgLTEsMyArMSw0IEBACi1NZW1iZXIgTG9naW46CitUaGlzIHRlc3QgY29uZmlybXMgdGhh dCBsZWdlbmQgZWxlbWVudCBjYW4gbm90IGJlIG1hZGUgaW5saW5lLiBUaGUgbmV4dCB0d28gc2Vu dGVuY2VzIHNob3VsZCBiZSBvbiBzZXBhcmF0ZSBsaW5lcy4KIAotVGhpcyB0ZXN0IGNvbmZpcm1z IHRoYXQgbGVnZW5kIGVsZW1lbnQgY2FuIG5vdCBiZSBtYWRlIGlubGluZS4gU3VjY2VlZHMgaWYg dGhpcyBtZXNzYWdlIGlzIHZpc2libGUgYW5kIHRoZXJlJ3Mgbm8gQVNTRVJUIGluIGRlYnVnIGJ1 aWxkLgorTWFyeSBoYWQgYSBsaXR0bGUgbGFtYi4KK0l0IHdhcyB3aGl0ZSBhcyBzbm93LgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbmxpbmUtaWdub3JlZC1vbi1sZWdlbmQu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW5saW5lLWlnbm9yZWQtb24tbGVnZW5kLmh0 bWwKaW5kZXggYTRmM2Q4Yy4uNGRmYmY5MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9pbmxpbmUtaWdub3JlZC1vbi1sZWdlbmQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL2lubGluZS1pZ25vcmVkLW9uLWxlZ2VuZC5odG1sCkBAIC0xLDggKzEsNSBAQAogPGh0 bWw+CiA8aGVhZD4KLQk8c3R5bGU+Ci0gICAgICAgICoge21hcmdpbjowO3BhZGRpbmc6MH0KLQk8 L3N0eWxlPgogCTxzY3JpcHQ+CiAJICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp IHsKIAkgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKQEAgLTEwLDE2 ICs3LDE1IEBACiAJPC9zY3JpcHQ+CiA8L2hlYWQ+CiA8Ym9keT4KLQk8Zm9ybSBzdHlsZT0iZmxv YXQ6bGVmdCI+CisJPHA+CisJICAgVGhpcyB0ZXN0IGNvbmZpcm1zIHRoYXQgPGtiZD5sZWdlbmQ8 L2tiZD4gZWxlbWVudCBjYW4gbm90IGJlIG1hZGUgaW5saW5lLgorCSAgIFRoZSBuZXh0IHR3byBz ZW50ZW5jZXMgc2hvdWxkIGJlIG9uIHNlcGFyYXRlIGxpbmVzLgorCTwvcD4KKwk8Zm9ybT4KIAkJ PGZpZWxkc2V0PgotCQkJPGxlZ2VuZCBzdHlsZT0iZGlzcGxheTppbmxpbmUiPk1lbWJlciBMb2dp bjo8L2xlZ2VuZD4KLQkJCTxpbnB1dCBzdHlsZT0id2lkdGg6ODBweCI+CisJCQk8bGVnZW5kIHN0 eWxlPSJkaXNwbGF5OmlubGluZSI+TWFyeSBoYWQgYSBsaXR0bGUgbGFtYi48L2xlZ2VuZD4KKwkJ CUl0IHdhcyB3aGl0ZSBhcyBzbm93LgogCQk8L2ZpZWxkc2V0PgogCTwvZm9ybT4KLQk8ZGl2IHN0 eWxlPSJmbG9hdDpsZWZ0O3dpZHRoOjEwMCUiPgotCSAgIFRoaXMgdGVzdCBjb25maXJtcyB0aGF0 IDxrYmQ+bGVnZW5kPC9rYmQ+IGVsZW1lbnQgY2FuIG5vdCBiZSBtYWRlIGlubGluZS4KLQkgICBT dWNjZWVkcyBpZiB0aGlzIG1lc3NhZ2UgaXMgdmlzaWJsZSBhbmQgdGhlcmUncyBubyA8Y29kZT5B U1NFUlQ8L2NvZGU+IGluCi0JICAgZGVidWcgYnVpbGQuCi0JPC9kaXY+CiA8L2JvZHk+CiA8L2h0 bWw+Cg==