24011 2009-02-18 15:17:57 -0800 KURL's setPort doesn't unset port if 0 is given 2010-06-30 22:20:17 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Trivial --- 41443 1 gustavo webkit-unassigned oldest_to_newest 110125 0 gustavo 2009-02-18 15:17:57 -0800 In KURL.h setPort has the following comment: // Setting the port to 0 will clear any port from the URL. void setPort(unsigned short); But passing 0 sets port to :0 instead. 110127 1 27765 gustavo 2009-02-18 15:43:02 -0800 Created attachment 27765 proposed fix 110187 2 27765 ap 2009-02-19 02:21:12 -0800 Comment on attachment 27765 proposed fix r=me > + Make setPort remove port if 0 is given to it, as promissed by the Typo: should be "promised". > // FIXME: Non-ASCII characters must be encoded and escaped to match parse() expectations, > // and to avoid changing more than just the port. Oops, this FIXME is totally bogus - this method takes a number, so there is no need to encode it! Please feel free to remove it if you wish. > + if (!i) We'd normally put the normal code path first (if (i)). 110210 3 gustavo 2009-02-19 07:20:39 -0800 Landed in r41076. 27765 2009-02-18 15:43:02 -0800 2009-02-19 02:21:12 -0800 proposed fix setportfix.diff text/plain 2130 gustavo RnJvbSAyMTE0NWRlNzliNDljMjE5MTFjOGMxMzRhOTQ5MGNlNzdlYzY3ZjNkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGtvdkBrb3YuZXRpLmJy PgpEYXRlOiBXZWQsIDE4IEZlYiAyMDA5IDIwOjM5OjU1IC0wMzAwClN1YmplY3Q6IFtQQVRDSF0g MjAwOS0wMi0xOCAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KCiAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIE1ha2Ugc2V0UG9ydCByZW1v dmUgcG9ydCBpZiAwIGlzIGdpdmVuIHRvIGl0LCBhcyBwcm9taXNzZWQgYnkgdGhlCiAgICAgICAg Y29tbWVudCBpbiBLVVJMJ3MgaGVhZGVyLgoKICAgICAgICAqIHBsYXRmb3JtL0tVUkwuY3BwOgog ICAgICAgIChXZWJDb3JlOjpLVVJMOjpzZXRQb3J0KToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAg ICAgICAgIHwgICAxMCArKysrKysrKysrCiBXZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwIHwgICAx MCArKysrKysrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDMgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCAxNzY5MTZhLi5kMGQxZGUzIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDA5LTAyLTE4ICBHdXN0 YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc2V0UG9ydCByZW1vdmUgcG9ydCBpZiAw IGlzIGdpdmVuIHRvIGl0LCBhcyBwcm9taXNzZWQgYnkgdGhlCisgICAgICAgIGNvbW1lbnQgaW4g S1VSTCdzIGhlYWRlci4KKworICAgICAgICAqIHBsYXRmb3JtL0tVUkwuY3BwOgorICAgICAgICAo V2ViQ29yZTo6S1VSTDo6c2V0UG9ydCk6CisKKzIwMDktMDItMTggIEd1c3Rhdm8gTm9yb25oYSBT aWx2YSAgPGduc0Bnbm9tZS5vcmc+CisKICAgICAgICAgVW5yZXZpZXdlZC4KIAogICAgICAgICBC dWlsZCBmaXggYWZ0ZXIgcjQxMDYwLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9LVVJM LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAKaW5kZXggN2JjZjczMS4uNDczZTVkNCAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmNwcAorKysgYi9XZWJDb3JlL3BsYXRm b3JtL0tVUkwuY3BwCkBAIC02ODEsMTAgKzY4MSwxNCBAQCB2b2lkIEtVUkw6OnNldFBvcnQodW5z aWduZWQgc2hvcnQgaSkKICAgICAvLyBGSVhNRTogTm9uLUFTQ0lJIGNoYXJhY3RlcnMgbXVzdCBi ZSBlbmNvZGVkIGFuZCBlc2NhcGVkIHRvIG1hdGNoIHBhcnNlKCkgZXhwZWN0YXRpb25zLAogICAg IC8vIGFuZCB0byBhdm9pZCBjaGFuZ2luZyBtb3JlIHRoYW4ganVzdCB0aGUgcG9ydC4KIAotICAg IGJvb2wgY29sb25OZWVkZWQgPSBtX3BvcnRFbmQgPT0gbV9ob3N0RW5kOwotICAgIGludCBwb3J0 U3RhcnQgPSAoY29sb25OZWVkZWQgPyBtX2hvc3RFbmQgOiBtX2hvc3RFbmQgKyAxKTsKKyAgICBp ZiAoIWkpCisgICAgICAgIHBhcnNlKG1fc3RyaW5nLmxlZnQobV9ob3N0RW5kKSArIG1fc3RyaW5n LnN1YnN0cmluZyhtX3BvcnRFbmQpKTsKKyAgICBlbHNlIHsKKyAgICAgICAgYm9vbCBjb2xvbk5l ZWRlZCA9IG1fcG9ydEVuZCA9PSBtX2hvc3RFbmQ7CisgICAgICAgIGludCBwb3J0U3RhcnQgPSAo Y29sb25OZWVkZWQgPyBtX2hvc3RFbmQgOiBtX2hvc3RFbmQgKyAxKTsKIAotICAgIHBhcnNlKG1f c3RyaW5nLmxlZnQocG9ydFN0YXJ0KSArIChjb2xvbk5lZWRlZCA/ICI6IiA6ICIiKSArIFN0cmlu Zzo6bnVtYmVyKGkpICsgbV9zdHJpbmcuc3Vic3RyaW5nKG1fcG9ydEVuZCkpOworICAgICAgICBw YXJzZShtX3N0cmluZy5sZWZ0KHBvcnRTdGFydCkgKyAoY29sb25OZWVkZWQgPyAiOiIgOiAiIikg KyBTdHJpbmc6Om51bWJlcihpKSArIG1fc3RyaW5nLnN1YnN0cmluZyhtX3BvcnRFbmQpKTsKKyAg ICB9CiB9CiAKIHZvaWQgS1VSTDo6c2V0SG9zdEFuZFBvcnQoY29uc3QgU3RyaW5nJiBob3N0QW5k UG9ydCkKLS0gCjEuNi4yLnJjMAoK