240106 2022-05-04 20:54:05 -0700 Optimize IPC Decoding for POD types 2022-05-05 15:12:17 -0700 1 1 1 Unclassified WebKit WebKit Process Model WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser cdumez ggaren heycam mmaxfield simon.fraser webkit-bug-importer oldest_to_newest 1866724 0 simon.fraser 2022-05-04 20:54:05 -0700 Optimize IPC Decoding for POD types 1866727 1 458848 simon.fraser 2022-05-04 20:55:54 -0700 Created attachment 458848 Patch 1866749 2 458848 mmaxfield 2022-05-04 22:47:14 -0700 Comment on attachment 458848 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458848&action=review > Source/WebKit/ChangeLog:3 > + Optimize IPC Decoding for POD types Nit: “primitive” and “POD” are different things 1866750 3 458848 mmaxfield 2022-05-04 22:47:17 -0700 Comment on attachment 458848 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458848&action=review > Source/WebKit/ChangeLog:3 > + Optimize IPC Decoding for POD types Nit: “primitive” and “POD” are different things 1867004 4 simon.fraser 2022-05-05 15:11:41 -0700 https://commits.webkit.org/250310@main 1867005 5 webkit-bug-importer 2022-05-05 15:12:17 -0700 <rdar://problem/92822845> 458848 2022-05-04 20:55:54 -0700 2022-05-04 20:57:54 -0700 Patch bug-240106-20220504205553.patch text/plain 6116 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMzYWU4ZTU1MDVhYmJiOTkx MWE5MDE1NTUwZGZhNWFkOTI1NDhiY2IuLmM3MTU0ZmQyOTA4ZjM2YTM3ODQzMTk5NDZmODNjZjBi MTgwMmE3MWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMjItMDUtMDQgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgT3B0aW1pemUgSVBDIERl Y29kaW5nIGZvciBQT0QgdHlwZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI0MDEwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENhbGxzIHRvIG1lbW1vdmUoKSBzaG93ZWQgdXAgb24gcHJvZmlsZXMgdW5k ZXIgRGVjb2Rlcjo6ZGVjb2RlRml4ZWRMZW5ndGhEYXRhKCkgZm9yCisgICAgICAgIHByaW1pdGl2 ZSB0eXBlcy4gQWxsb3cgdGhlIGNvbXBpbGVyIHRvIG9wdGltaXplIHRoZXNlIGF3YXkgYnkgaW5s aW5pbmcgRGVjb2Rlcjo6ZGVjb2RlRml4ZWRMZW5ndGhEYXRhKCkKKyAgICAgICAgYW5kIHJlbGF0 ZWQgZnVuY3Rpb25zLgorCisgICAgICAgICogUGxhdGZvcm0vSVBDL0RlY29kZXIuY3BwOgorICAg ICAgICAoSVBDOjpyb3VuZFVwVG9BbGlnbm1lbnQpOiBEZWxldGVkLgorICAgICAgICAoSVBDOjph bGlnbmVkQnVmZmVySXNMYXJnZUVub3VnaFRvQ29udGFpbik6IERlbGV0ZWQuCisgICAgICAgIChJ UEM6OkRlY29kZXI6OmFsaWduQnVmZmVyUG9zaXRpb24pOiBEZWxldGVkLgorICAgICAgICAoSVBD OjpEZWNvZGVyOjpidWZmZXJJc0xhcmdlRW5vdWdoVG9Db250YWluIGNvbnN0KTogRGVsZXRlZC4K KyAgICAgICAgKElQQzo6RGVjb2Rlcjo6ZGVjb2RlRml4ZWRMZW5ndGhEYXRhKTogRGVsZXRlZC4K KyAgICAgICAgKiBQbGF0Zm9ybS9JUEMvRGVjb2Rlci5oOgorICAgICAgICAoSVBDOjpyb3VuZFVw VG9BbGlnbm1lbnQpOgorICAgICAgICAoSVBDOjphbGlnbmVkQnVmZmVySXNMYXJnZUVub3VnaFRv Q29udGFpbik6CisgICAgICAgIChJUEM6OkRlY29kZXI6OmFsaWduQnVmZmVyUG9zaXRpb24pOgor ICAgICAgICAoSVBDOjpEZWNvZGVyOjpidWZmZXJJc0xhcmdlRW5vdWdoVG9Db250YWluIGNvbnN0 KToKKyAgICAgICAgKElQQzo6RGVjb2Rlcjo6ZGVjb2RlRml4ZWRMZW5ndGhEYXRhKToKKwogMjAy Mi0wNS0wNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAg ICBGaXggY3Jhc2ggaW4gUmVtb3RlUmVuZGVyaW5nQmFja2VuZFByb3h5OjpwcmVwYXJlQnVmZmVy c0ZvckRpc3BsYXkoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvRGVj b2Rlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9EZWNvZGVyLmNwcAppbmRleCA2 OGZjNmViZTdlODJiODJlNGRmYjcxN2RhNWJhZWEwMDNlNTU4ODRiLi40NzAwNDk4MGQ4ZGQxOTUz NzI3NDM1OWJmOTc4OThkN2U1Mzc0ZGZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRm b3JtL0lQQy9EZWNvZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9EZWNv ZGVyLmNwcApAQCAtMTUxLDUzICsxNTEsNiBAQCBzdGQ6OnVuaXF1ZV9wdHI8RGVjb2Rlcj4gRGVj b2Rlcjo6dW53cmFwRm9yVGVzdGluZyhEZWNvZGVyJiBkZWNvZGVyKQogICAgIHJldHVybiBEZWNv ZGVyOjpjcmVhdGUod3JhcHBlZE1lc3NhZ2UuZGF0YSgpLCB3cmFwcGVkTWVzc2FnZS5zaXplKCks IFdURk1vdmUoYXR0YWNobWVudHMpKTsKIH0KIAotc3RhdGljIGlubGluZSBjb25zdCB1aW50OF90 KiByb3VuZFVwVG9BbGlnbm1lbnQoY29uc3QgdWludDhfdCogcHRyLCBzaXplX3QgYWxpZ25tZW50 KQotewotICAgIC8vIEFzc2VydCB0aGF0IHRoZSBhbGlnbm1lbnQgaXMgYSBwb3dlciBvZiAyLgot ICAgIEFTU0VSVChhbGlnbm1lbnQgJiYgIShhbGlnbm1lbnQgJiAoYWxpZ25tZW50IC0gMSkpKTsK LQotICAgIHVpbnRwdHJfdCBhbGlnbm1lbnRNYXNrID0gYWxpZ25tZW50IC0gMTsKLSAgICByZXR1 cm4gcmVpbnRlcnByZXRfY2FzdDx1aW50OF90Kj4oKHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90 PihwdHIpICsgYWxpZ25tZW50TWFzaykgJiB+YWxpZ25tZW50TWFzayk7Ci19Ci0KLXN0YXRpYyBp bmxpbmUgYm9vbCBhbGlnbmVkQnVmZmVySXNMYXJnZUVub3VnaFRvQ29udGFpbihjb25zdCB1aW50 OF90KiBhbGlnbmVkUG9zaXRpb24sIGNvbnN0IHVpbnQ4X3QqIGJ1ZmZlclN0YXJ0LCBjb25zdCB1 aW50OF90KiBidWZmZXJFbmQsIHNpemVfdCBzaXplKQotewotICAgIC8vIFdoZW4gc2l6ZSA9PSAw IGZvciB0aGUgbGFzdCBhcmd1bWVudCBhbmQgaXQncyBhIHZhcmlhYmxlIGxlbmd0aCBieXRlIGFy cmF5LAotICAgIC8vIGJ1ZmZlclN0YXJ0ID09IGFsaWduZWRQb3NpdGlvbiA9PSBidWZmZXJFbmQs IHNvIGNoZWNraW5nIChidWZmZXJFbmQgPj0gYWxpZ25lZFBvc2l0aW9uKQotICAgIC8vIGlzIG5v dCBhbiBvZmYtYnktb25lIGVycm9yIHNpbmNlIChzdGF0aWNfY2FzdDxzaXplX3Q+KGJ1ZmZlckVu ZCAtIGFsaWduZWRQb3NpdGlvbikgPj0gc2l6ZSkKLSAgICAvLyB3aWxsIGNhdGNoIGlzc3VlcyB3 aGVuIHNpemUgIT0gMC4KLSAgICByZXR1cm4gYnVmZmVyRW5kID49IGFsaWduZWRQb3NpdGlvbiAm JiBidWZmZXJTdGFydCA8PSBhbGlnbmVkUG9zaXRpb24gJiYgc3RhdGljX2Nhc3Q8c2l6ZV90Pihi dWZmZXJFbmQgLSBhbGlnbmVkUG9zaXRpb24pID49IHNpemU7Ci19Ci0KLWJvb2wgRGVjb2Rlcjo6 YWxpZ25CdWZmZXJQb3NpdGlvbihzaXplX3QgYWxpZ25tZW50LCBzaXplX3Qgc2l6ZSkKLXsKLSAg ICBjb25zdCB1aW50OF90KiBhbGlnbmVkUG9zaXRpb24gPSByb3VuZFVwVG9BbGlnbm1lbnQobV9i dWZmZXJQb3MsIGFsaWdubWVudCk7Ci0gICAgaWYgKFVOTElLRUxZKCFhbGlnbmVkQnVmZmVySXNM YXJnZUVub3VnaFRvQ29udGFpbihhbGlnbmVkUG9zaXRpb24sIG1fYnVmZmVyLCBtX2J1ZmZlckVu ZCwgc2l6ZSkpKSB7Ci0gICAgICAgIC8vIFdlJ3ZlIHdhbGtlZCBvZmYgdGhlIGVuZCBvZiB0aGlz IGJ1ZmZlci4KLSAgICAgICAgbWFya0ludmFsaWQoKTsKLSAgICAgICAgcmV0dXJuIGZhbHNlOwot ICAgIH0KLQotICAgIG1fYnVmZmVyUG9zID0gYWxpZ25lZFBvc2l0aW9uOwotICAgIHJldHVybiB0 cnVlOwotfQotCi1ib29sIERlY29kZXI6OmJ1ZmZlcklzTGFyZ2VFbm91Z2hUb0NvbnRhaW4oc2l6 ZV90IGFsaWdubWVudCwgc2l6ZV90IHNpemUpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIGFsaWduZWRC dWZmZXJJc0xhcmdlRW5vdWdoVG9Db250YWluKHJvdW5kVXBUb0FsaWdubWVudChtX2J1ZmZlclBv cywgYWxpZ25tZW50KSwgbV9idWZmZXIsIG1fYnVmZmVyRW5kLCBzaXplKTsKLX0KLQotYm9vbCBE ZWNvZGVyOjpkZWNvZGVGaXhlZExlbmd0aERhdGEodWludDhfdCogZGF0YSwgc2l6ZV90IHNpemUs IHNpemVfdCBhbGlnbm1lbnQpCi17Ci0gICAgaWYgKCFhbGlnbkJ1ZmZlclBvc2l0aW9uKGFsaWdu bWVudCwgc2l6ZSkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgIG1lbWNweShkYXRhLCBt X2J1ZmZlclBvcywgc2l6ZSk7Ci0gICAgbV9idWZmZXJQb3MgKz0gc2l6ZTsKLQotICAgIHJldHVy biB0cnVlOwotfQotCiBjb25zdCB1aW50OF90KiBEZWNvZGVyOjpkZWNvZGVGaXhlZExlbmd0aFJl ZmVyZW5jZShzaXplX3Qgc2l6ZSwgc2l6ZV90IGFsaWdubWVudCkKIHsKICAgICBpZiAoIWFsaWdu QnVmZmVyUG9zaXRpb24oYWxpZ25tZW50LCBzaXplKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvUGxhdGZvcm0vSVBDL0RlY29kZXIuaCBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL0Rl Y29kZXIuaAppbmRleCA5Y2NjNGYyZmMxZjllYTM2YWI3MjIwOWI2OTFkODc1NGY0MTg3MmY5Li5j YTIwNjk1ZGY4MDQxMmM2ZGQ3NTNjOWQxM2IyN2YzNDNjODI1YmI0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1BsYXRmb3JtL0lQQy9EZWNvZGVyLmgKKysrIGIvU291cmNlL1dlYktpdC9QbGF0 Zm9ybS9JUEMvRGVjb2Rlci5oCkBAIC0xNzQsNCArMTc0LDUxIEBAIHByaXZhdGU6CiAjZW5kaWYK IH07CiAKK2lubGluZSBjb25zdCB1aW50OF90KiByb3VuZFVwVG9BbGlnbm1lbnQoY29uc3QgdWlu dDhfdCogcHRyLCBzaXplX3QgYWxpZ25tZW50KQoreworICAgIC8vIEFzc2VydCB0aGF0IHRoZSBh bGlnbm1lbnQgaXMgYSBwb3dlciBvZiAyLgorICAgIEFTU0VSVChhbGlnbm1lbnQgJiYgIShhbGln bm1lbnQgJiAoYWxpZ25tZW50IC0gMSkpKTsKKworICAgIHVpbnRwdHJfdCBhbGlnbm1lbnRNYXNr ID0gYWxpZ25tZW50IC0gMTsKKyAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDx1aW50OF90Kj4o KHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90PihwdHIpICsgYWxpZ25tZW50TWFzaykgJiB+YWxp Z25tZW50TWFzayk7Cit9CisKK2lubGluZSBib29sIGFsaWduZWRCdWZmZXJJc0xhcmdlRW5vdWdo VG9Db250YWluKGNvbnN0IHVpbnQ4X3QqIGFsaWduZWRQb3NpdGlvbiwgY29uc3QgdWludDhfdCog YnVmZmVyU3RhcnQsIGNvbnN0IHVpbnQ4X3QqIGJ1ZmZlckVuZCwgc2l6ZV90IHNpemUpCit7Cisg ICAgLy8gV2hlbiBzaXplID09IDAgZm9yIHRoZSBsYXN0IGFyZ3VtZW50IGFuZCBpdCdzIGEgdmFy aWFibGUgbGVuZ3RoIGJ5dGUgYXJyYXksCisgICAgLy8gYnVmZmVyU3RhcnQgPT0gYWxpZ25lZFBv c2l0aW9uID09IGJ1ZmZlckVuZCwgc28gY2hlY2tpbmcgKGJ1ZmZlckVuZCA+PSBhbGlnbmVkUG9z aXRpb24pCisgICAgLy8gaXMgbm90IGFuIG9mZi1ieS1vbmUgZXJyb3Igc2luY2UgKHN0YXRpY19j YXN0PHNpemVfdD4oYnVmZmVyRW5kIC0gYWxpZ25lZFBvc2l0aW9uKSA+PSBzaXplKQorICAgIC8v IHdpbGwgY2F0Y2ggaXNzdWVzIHdoZW4gc2l6ZSAhPSAwLgorICAgIHJldHVybiBidWZmZXJFbmQg Pj0gYWxpZ25lZFBvc2l0aW9uICYmIGJ1ZmZlclN0YXJ0IDw9IGFsaWduZWRQb3NpdGlvbiAmJiBz dGF0aWNfY2FzdDxzaXplX3Q+KGJ1ZmZlckVuZCAtIGFsaWduZWRQb3NpdGlvbikgPj0gc2l6ZTsK K30KKworaW5saW5lIGJvb2wgRGVjb2Rlcjo6YWxpZ25CdWZmZXJQb3NpdGlvbihzaXplX3QgYWxp Z25tZW50LCBzaXplX3Qgc2l6ZSkKK3sKKyAgICBjb25zdCB1aW50OF90KiBhbGlnbmVkUG9zaXRp b24gPSByb3VuZFVwVG9BbGlnbm1lbnQobV9idWZmZXJQb3MsIGFsaWdubWVudCk7CisgICAgaWYg KFVOTElLRUxZKCFhbGlnbmVkQnVmZmVySXNMYXJnZUVub3VnaFRvQ29udGFpbihhbGlnbmVkUG9z aXRpb24sIG1fYnVmZmVyLCBtX2J1ZmZlckVuZCwgc2l6ZSkpKSB7CisgICAgICAgIC8vIFdlJ3Zl IHdhbGtlZCBvZmYgdGhlIGVuZCBvZiB0aGlzIGJ1ZmZlci4KKyAgICAgICAgbWFya0ludmFsaWQo KTsKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKworICAgIG1fYnVmZmVyUG9zID0gYWxp Z25lZFBvc2l0aW9uOworICAgIHJldHVybiB0cnVlOworfQorCitpbmxpbmUgYm9vbCBEZWNvZGVy OjpidWZmZXJJc0xhcmdlRW5vdWdoVG9Db250YWluKHNpemVfdCBhbGlnbm1lbnQsIHNpemVfdCBz aXplKSBjb25zdAoreworICAgIHJldHVybiBhbGlnbmVkQnVmZmVySXNMYXJnZUVub3VnaFRvQ29u dGFpbihyb3VuZFVwVG9BbGlnbm1lbnQobV9idWZmZXJQb3MsIGFsaWdubWVudCksIG1fYnVmZmVy LCBtX2J1ZmZlckVuZCwgc2l6ZSk7Cit9CisKK2lubGluZSBib29sIERlY29kZXI6OmRlY29kZUZp eGVkTGVuZ3RoRGF0YSh1aW50OF90KiBkYXRhLCBzaXplX3Qgc2l6ZSwgc2l6ZV90IGFsaWdubWVu dCkKK3sKKyAgICBpZiAoIWFsaWduQnVmZmVyUG9zaXRpb24oYWxpZ25tZW50LCBzaXplKSkKKyAg ICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgbWVtY3B5KGRhdGEsIG1fYnVmZmVyUG9zLCBzaXpl KTsKKyAgICBtX2J1ZmZlclBvcyArPSBzaXplOworCisgICAgcmV0dXJuIHRydWU7Cit9CisKIH0g Ly8gbmFtZXNwYWNlIElQQwo=