<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>240102</bug_id>
          
          <creation_ts>2022-05-04 17:39:55 -0700</creation_ts>
          <short_desc>[JSC] Intl.NumberFormat lacks some validation for rounding-increment</short_desc>
          <delta_ts>2022-05-06 07:33:43 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yusuke Suzuki">ysuzuki</reporter>
          <assigned_to name="Yusuke Suzuki">ysuzuki</assigned_to>
          <cc>angelos</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1866684</commentid>
    <comment_count>0</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2022-05-04 17:39:55 -0700</bug_when>
    <thetext>[JSC] Intl.NumberFormat lacks some validation for rounding-increment</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1866685</commentid>
    <comment_count>1</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2022-05-04 17:42:24 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/517</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1866704</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-05-04 19:22:21 -0700</bug_when>
    <thetext>Committed r293813 (250286@main): &lt;https://commits.webkit.org/250286@main&gt;

Reviewed commits have been landed. Closing PR #517 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1866705</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-05-04 19:23:13 -0700</bug_when>
    <thetext>&lt;rdar://problem/92768775&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1866822</commentid>
    <comment_count>4</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2022-05-05 07:11:07 -0700</bug_when>
    <thetext>It introduced failures when running with cloop:

Running stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: Exception: RangeError: maximum and minimum fraction-digits are not equal while roundingIncrement is specified
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: NumberFormat@[native code]
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: @intl-numberformat-rounding-increment-resolved-match-v3.js:39:35
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: forEach@[native code]
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: global code@intl-numberformat-rounding-increment-resolved-match-v3.js:38:32
stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default: ERROR: Unexpected exit code: 3
FAIL: stress/intl-numberformat-rounding-increment-resolved-match-v3.js.default

Running stress/intl-numberformat-rounding-increment-v3.js.default
stress/intl-numberformat-rounding-increment-v3.js.default: Exception: RangeError: maximum and minimum fraction-digits are not equal while roundingIncrement is specified
stress/intl-numberformat-rounding-increment-v3.js.default: NumberFormat@[native code]
stress/intl-numberformat-rounding-increment-v3.js.default: @intl-numberformat-rounding-increment-v3.js:52:26
stress/intl-numberformat-rounding-increment-v3.js.default: forEach@[native code]
stress/intl-numberformat-rounding-increment-v3.js.default: global code@intl-numberformat-rounding-increment-v3.js:51:32
stress/intl-numberformat-rounding-increment-v3.js.default: ERROR: Unexpected exit code: 3
FAIL: stress/intl-numberformat-rounding-increment-v3.js.default

stress/intl-numberformat-rounding-increment-value.js.default: Exception: RangeError: maximum and minimum fraction-digits are not equal while roundingIncrement is specified
stress/intl-numberformat-rounding-increment-value.js.default: NumberFormat@[native code]
stress/intl-numberformat-rounding-increment-value.js.default: global code@intl-numberformat-rounding-increment-value.js:7:31
stress/intl-numberformat-rounding-increment-value.js.default: ERROR: Unexpected exit code: 3
FAIL: stress/intl-numberformat-rounding-increment-value.js.default

I suppose I&apos;d better print the values that are being compared to see what&apos;s up.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1866954</commentid>
    <comment_count>5</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2022-05-05 12:45:11 -0700</bug_when>
    <thetext>Committed r293858 (250323@trunk): &lt;https://commits.webkit.org/250323@trunk&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1866977</commentid>
    <comment_count>6</comment_count>
    <who name="Angelos Oikonomopoulos">angelos</who>
    <bug_when>2022-05-05 13:50:48 -0700</bug_when>
    <thetext>See also https://bugs.webkit.org/show_bug.cgi?id=240138.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1867174</commentid>
    <comment_count>7</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2022-05-06 07:33:43 -0700</bug_when>
    <thetext>(In reply to Yusuke Suzuki from comment #5)
&gt; Committed r293858 (250323@trunk): &lt;https://commits.webkit.org/250323@trunk&gt;

Thanks, that fixed it.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>