240099 2022-05-04 17:21:34 -0700 REGRESSION (r293716): macCatalyst WebKit build fails; overlapping content at /System/Library/FeatureFlags/Domain/WebKit.plist 2022-05-05 14:53:55 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton ap cdumez emw wenson_hsieh oldest_to_newest 1866674 0 thorton 2022-05-04 17:21:34 -0700 REGRESSION (r293716): macCatalyst WebKit build fails; overlapping content at /System/Library/FeatureFlags/Domain/WebKit.plist 1866676 1 thorton 2022-05-04 17:21:46 -0700 <rdar://92751323> 1866677 2 458838 thorton 2022-05-04 17:22:09 -0700 Created attachment 458838 patch 1866730 3 ews-feeder 2022-05-04 21:24:50 -0700 Committed r293818 (250291@main): <https://commits.webkit.org/250291@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458838. 1866745 4 458838 ap 2022-05-04 22:22:45 -0700 Comment on attachment 458838 patch View in context: https://bugs.webkit.org/attachment.cgi?id=458838&action=review > Source/WebKit/WebKit.xcodeproj/project.pbxproj:16134 > + outputPaths = ( No outputPaths??? 1866748 5 thorton 2022-05-04 22:43:10 -0700 (In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 458838 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=458838&action=review > > > Source/WebKit/WebKit.xcodeproj/project.pbxproj:16134 > > + outputPaths = ( > > No outputPaths??? Hmm, a bit odd. I was following the one a few steps down called "Copy Daemon Plists", which also doesn't have outputPaths... I guess they're both wrong? 1866859 6 emw 2022-05-05 08:53:06 -0700 (In reply to Tim Horton from comment #5) > (In reply to Alexey Proskuryakov from comment #4) > > Comment on attachment 458838 [details] > > patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=458838&action=review > > > > > Source/WebKit/WebKit.xcodeproj/project.pbxproj:16134 > > > + outputPaths = ( > > > > No outputPaths??? > > Hmm, a bit odd. I was following the one a few steps down called "Copy Daemon > Plists", which also doesn't have outputPaths... I guess they're both wrong? It's not really a problem here, since I'm assuming there aren't other tasks in the build which take these /System/Library/FeatureFlags/* paths as inputs. 1866895 7 ap 2022-05-05 09:51:42 -0700 Does this make the script run unnecessarily during incremental builds? 1866999 8 emw 2022-05-05 14:53:55 -0700 (In reply to Alexey Proskuryakov from comment #7) > Does this make the script run unnecessarily during incremental builds? You're right, it does! That does seem like a meaningful downside :( 458838 2022-05-04 17:22:09 -0700 2022-05-04 21:24:52 -0700 patch patch.diff text/plain 4848 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYWM0YzgzYmRkNDkwLi4yN2MyYTBhYjViNTAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTQgQEAKKzIwMjItMDUtMDQgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5j b20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI5MzcxNik6IG1hY0NhdGFseXN0IFdlYktpdCBi dWlsZCBmYWlsczsgb3ZlcmxhcHBpbmcgY29udGVudCBhdCAvU3lzdGVtL0xpYnJhcnkvRmVhdHVy ZUZsYWdzL0RvbWFpbi9XZWJLaXQucGxpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI0MDA5OQorICAgICAgICA8cmRhcjovLzkyNzUxMzIzPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0Lnhj b2RlcHJvai9wcm9qZWN0LnBieHByb2o6CisgICAgICAgIEF2b2lkIGNvcHlpbmcgdGhlIGZlYXR1 cmUgZmxhZ3MgcGxpc3QgZm9yIG1hY0NhdGFseXN0LCBzaW5jZSBpdCBpbnN0YWxscyBpbnRvIHRo ZSBzYW1lIHBsYWNlIGFzIG1hY09TLgorCiAyMDIyLTA1LTA0ICBKIFBhc2NvZSAgPGpfcGFzY29l QGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViQXV0aG5dIFJlbW92ZSB1c2VyIGdlc3R1cmUgcmVx dWlyZW1lbnQgZm9yIG1lZGlhdGlvbj1jb25kaXRpb25hbCBhc3NlcnRpb25zCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1dlYktpdC54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvU291cmNl L1dlYktpdC9XZWJLaXQueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagppbmRleCA2ZDA0MDg0MzY4 NDAuLjM0OGNkZDI2Y2Q5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJLaXQueGNvZGVw cm9qL3Byb2plY3QucGJ4cHJvagorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYktpdC54Y29kZXByb2ov cHJvamVjdC5wYnhwcm9qCkBAIC02MzgsNyArNjM4LDYgQEAKIAkJMkQ2Q0QxMTkxODkwNThBNTAw RTVBNEEwIC8qIFZpZXdTbmFwc2hvdFN0b3JlLmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhC dWlsZEZpbGU7IGZpbGVSZWYgPSAyRDZDRDExNzE4OTA1OEE1MDBFNUE0QTAgLyogVmlld1NuYXBz aG90U3RvcmUuaCAqLzsgfTsKIAkJMkQ3MkExRkEyMTJCRjQ2RTAwNTE3QTIwIC8qIFJlbW90ZUxh eWVyVHJlZURyYXdpbmdBcmVhLm1tIGluIFNvdXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxl OyBmaWxlUmVmID0gMUFCMTZBREIxNjQ4NTk4NDAwMjkwRDYyIC8qIFJlbW90ZUxheWVyVHJlZURy YXdpbmdBcmVhLm1tICovOyB9OwogCQkyRDczMDM3OTFBN0MyQjc1MDBGOEY0ODcgLyogV0tQYWdl TmF2aWdhdGlvbkNsaWVudC5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBm aWxlUmVmID0gMkQ3MzAzNzgxQTdDMkI3NTAwRjhGNDg3IC8qIFdLUGFnZU5hdmlnYXRpb25DbGll bnQuaCAqLzsgc2V0dGluZ3MgPSB7QVRUUklCVVRFUyA9IChQcml2YXRlLCApOyB9OyB9OwotCQky RDc3QkYyMDI4MjBCQTBEMDBDOUE5NjEgLyogV2ViS2l0LnBsaXN0IGluIENvcHkgRmVhdHVyZSBG bGFncyBQbGlzdCAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSAxRDA1MzBEMjI1 OTE2MkM5MDBFNDM2RjcgLyogV2ViS2l0LnBsaXN0ICovOyB9OwogCQkyRDc5MEE5RDFBRDcwNTBE MDBBQjkwQjMgLyogX1dLTGF5b3V0TW9kZS5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVp bGRGaWxlOyBmaWxlUmVmID0gMkQ3OTBBOUMxQUQ3MDUwRDAwQUI5MEIzIC8qIF9XS0xheW91dE1v ZGUuaCAqLzsgc2V0dGluZ3MgPSB7QVRUUklCVVRFUyA9IChQcml2YXRlLCApOyB9OyB9OwogCQky RDc5MEE5RjFBRDcxNjQ5MDBBQjkwQjMgLyogV0tMYXlvdXRNb2RlLmggaW4gSGVhZGVycyAqLyA9 IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSAyRDc5MEE5RTFBRDcxNjQ5MDBBQjkwQjMg LyogV0tMYXlvdXRNb2RlLmggKi87IHNldHRpbmdzID0ge0FUVFJJQlVURVMgPSAoUHJpdmF0ZSwg KTsgfTsgfTsKIAkJMkQ3QUFGRDMxOEM4NjQwNjAwQTdBQ0Q0IC8qIFdLV2ViVmlld0NvbnRlbnRQ cm92aWRlci5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0g MkQ3QUFGRDIxOEM4NjQwNjAwQTdBQ0Q0IC8qIFdLV2ViVmlld0NvbnRlbnRQcm92aWRlci5oICov OyB9OwpAQCAtMjczMCwxNyArMjcyOSw2IEBACiAJCQluYW1lID0gIkNvcHkgTWVzc2FnZSBHZW5l cmF0aW9uIFNjcmlwdHMiOwogCQkJcnVuT25seUZvckRlcGxveW1lbnRQb3N0cHJvY2Vzc2luZyA9 IDA7CiAJCX07Ci0JCTJENzdCRjFGMjgyMEI5RjUwMEM5QTk2MSAvKiBDb3B5IEZlYXR1cmUgRmxh Z3MgUGxpc3QgKi8gPSB7Ci0JCQlpc2EgPSBQQlhDb3B5RmlsZXNCdWlsZFBoYXNlOwotCQkJYnVp bGRBY3Rpb25NYXNrID0gODsKLQkJCWRzdFBhdGggPSAiJChXS19JTlNUQUxMX1BBVEhfUFJFRklY KS8kKFNZU1RFTV9MSUJSQVJZX0RJUikvRmVhdHVyZUZsYWdzL0RvbWFpbiI7Ci0JCQlkc3RTdWJm b2xkZXJTcGVjID0gMDsKLQkJCWZpbGVzID0gKAotCQkJCTJENzdCRjIwMjgyMEJBMEQwMEM5QTk2 MSAvKiBXZWJLaXQucGxpc3QgaW4gQ29weSBGZWF0dXJlIEZsYWdzIFBsaXN0ICovLAotCQkJKTsK LQkJCW5hbWUgPSAiQ29weSBGZWF0dXJlIEZsYWdzIFBsaXN0IjsKLQkJCXJ1bk9ubHlGb3JEZXBs b3ltZW50UG9zdHByb2Nlc3NpbmcgPSAxOwotCQl9OwogCQkzNzI1ODk0MzFDMUU0OTY4MDBDOTJD QTkgLyogQ29weSBTaGltcyAqLyA9IHsKIAkJCWlzYSA9IFBCWENvcHlGaWxlc0J1aWxkUGhhc2U7 CiAJCQlidWlsZEFjdGlvbk1hc2sgPSAyMTQ3NDgzNjQ3OwpAQCAtMTU3ODIsNyArMTU3NzAsNyBA QAogCQkJCTVERjQwOEQxMTMxRERCRUMwMDEzMDA3MSAvKiBDaGVjayBGb3IgSW5hcHByb3ByaWF0 ZSBGaWxlcyBJbiBGcmFtZXdvcmsgKi8sCiAJCQkJQTU1REVBQTYxNjcwNDAyRTAwM0RCODQxIC8q IENoZWNrIEZvciBJbmFwcHJvcHJpYXRlIE1hY3JvcyBpbiBFeHRlcm5hbCBIZWFkZXJzICovLAog CQkJCTFBMjE4MDE2MUI1NDU0NjIwMDQ2QUVDNCAvKiBBZGQgU3ltbGluayBpbiAvU3lzdGVtL0xp YnJhcnkvUHJpdmF0ZUZyYW1ld29ya3MgKi8sCi0JCQkJMkQ3N0JGMUYyODIwQjlGNTAwQzlBOTYx IC8qIENvcHkgRmVhdHVyZSBGbGFncyBQbGlzdCAqLywKKwkJCQkyREU3NzUxOTI4MjMzQzc1MDA0 MzM2QzEgLyogQ29weSBGZWF0dXJlIEZsYWdzIFBsaXN0ICovLAogCQkJCTUzNzlDN0FDMjFFNTI4 ODUwMEU0QThGNiAvKiBDaGVjayAueGNmaWxlbGlzdHMgKi8sCiAJCQkJOTMzMTcwMDcyMjM0Njc0 NTAwQjMyNTU0IC8qIENyZWF0ZSBzeW1saW5rcyB0byBYUEMgc2VydmljZXMgZm9yIGVuZ2luZWVy aW5nIGJ1aWxkcyAqLywKIAkJCQk1MTJCODFDQTI3M0NBRkJFMDBEODdENDkgLyogQ3JlYXRlIHN5 bWxpbmtzIHRvIERhZW1vbnMgZm9yIGVuZ2luZWVyaW5nIGJ1aWxkcyAqLywKQEAgLTE2MTMwLDYg KzE2MTE4LDI1IEBACiAJCQlzaGVsbFBhdGggPSAvYmluL3NoOwogCQkJc2hlbGxTY3JpcHQgPSAi U2NyaXB0cy9wcm9jZXNzLWVudGl0bGVtZW50cy5zaFxuIjsKIAkJfTsKKwkJMkRFNzc1MTkyODIz M0M3NTAwNDMzNkMxIC8qIENvcHkgRmVhdHVyZSBGbGFncyBQbGlzdCAqLyA9IHsKKwkJCWlzYSA9 IFBCWFNoZWxsU2NyaXB0QnVpbGRQaGFzZTsKKwkJCWJ1aWxkQWN0aW9uTWFzayA9IDg7CisJCQlm aWxlcyA9ICgKKwkJCSk7CisJCQlpbnB1dEZpbGVMaXN0UGF0aHMgPSAoCisJCQkpOworCQkJaW5w dXRQYXRocyA9ICgKKwkJCQkiJChTUkNST09UKS9GZWF0dXJlRmxhZ3MvV2ViS2l0LnBsaXN0IiwK KwkJCSk7CisJCQluYW1lID0gIkNvcHkgRmVhdHVyZSBGbGFncyBQbGlzdCI7CisJCQlvdXRwdXRG aWxlTGlzdFBhdGhzID0gKAorCQkJKTsKKwkJCW91dHB1dFBhdGhzID0gKAorCQkJKTsKKwkJCXJ1 bk9ubHlGb3JEZXBsb3ltZW50UG9zdHByb2Nlc3NpbmcgPSAxOworCQkJc2hlbGxQYXRoID0gL2Jp bi9zaDsKKwkJCXNoZWxsU2NyaXB0ID0gImlmIFtbIFwiJHtXS19QTEFURk9STV9OQU1FfVwiID09 IG1hY2NhdGFseXN0IHx8IFwiJHtXS19QTEFURk9STV9OQU1FfVwiID09IGlvc21hYyBdXTsgdGhl blxuICAgIGV4aXQgMFxuZmlcblxuRkVBVFVSRV9GTEFHU19QTElTVF9TT1VSQ0U9XCIke1NSQ1JP T1R9L0ZlYXR1cmVGbGFncy9XZWJLaXQucGxpc3RcIlxuRkVBVFVSRV9GTEFHU19QTElTVF9ERVNU SU5BVElPTj1cIiR7RFNUUk9PVH0vU3lzdGVtL0xpYnJhcnkvRmVhdHVyZUZsYWdzL0RvbWFpbi9X ZWJLaXQucGxpc3RcIlxuZWNobyBcImNvcHlpbmcgZmVhdHVyZSBmbGFncyBwbGlzdFwiXG5ta2Rp ciAtcCBcIiQoZGlybmFtZSBcIiR7RkVBVFVSRV9GTEFHU19QTElTVF9ERVNUSU5BVElPTn1cIilc IlxuZWNobyBwbHV0aWwgLWNvbnZlcnQgYmluYXJ5MSAtbyBcIiR7RkVBVFVSRV9GTEFHU19QTElT VF9ERVNUSU5BVElPTn1cIiBcIiR7RkVBVFVSRV9GTEFHU19QTElTVF9TT1VSQ0V9XCJcbnBsdXRp bCAtY29udmVydCBiaW5hcnkxIC1vIFwiJHtGRUFUVVJFX0ZMQUdTX1BMSVNUX0RFU1RJTkFUSU9O fVwiIFwiJHtGRUFUVVJFX0ZMQUdTX1BMSVNUX1NPVVJDRX1cIlxuIjsKKwkJfTsKIAkJMkUxNkI2 RjQyMDE5QkMyNTAwODk5NkQ2IC8qIENvcHkgQWRkaXRpb25hbCBSZXNvdXJjZXMgKi8gPSB7CiAJ CQlpc2EgPSBQQlhTaGVsbFNjcmlwdEJ1aWxkUGhhc2U7CiAJCQlidWlsZEFjdGlvbk1hc2sgPSAx MjsK