239977 2022-05-02 12:12:41 -0700 Revert all use of _setPrivacyProxyFailClosedForUnreachableNonMainHosts 2022-05-12 16:44:02 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen webkit-bug-importer wilander oldest_to_newest 1865907 0 achristensen 2022-05-02 12:12:41 -0700 Revert all use of _setPrivacyProxyFailClosedForUnreachableNonMainHosts 1865909 1 458699 achristensen 2022-05-02 12:16:19 -0700 Created attachment 458699 Patch 1865910 2 achristensen 2022-05-02 12:16:22 -0700 <rdar://problem/92617943> 1865935 3 458699 wilander 2022-05-02 13:36:43 -0700 Comment on attachment 458699 Patch r=me. I'd want the ios-wk2 bot goes green before landing. 1865936 4 wilander 2022-05-02 13:37:16 -0700 I'd want the ios-wk2 bot *to go* green before landing. :/ 1865972 5 wilander 2022-05-02 15:10:49 -0700 According to Ryan Haddad, the ios-wk2 test failure is likely due to https://bugs.webkit.org/show_bug.cgi?id=236794. 1865973 6 wilander 2022-05-02 15:13:21 -0700 The failing test on mac-AS-debug-wk2 is historically flaky. 1865986 7 achristensen 2022-05-02 16:04:45 -0700 http://trac.webkit.org/r293697 1867006 8 achristensen 2022-05-05 15:15:17 -0700 Reverted in http://trac.webkit.org/r293861 1868580 9 achristensen 2022-05-12 16:44:02 -0700 Re-landing in http://trac.webkit.org/r294126 458699 2022-05-02 12:16:19 -0700 2022-05-02 16:49:23 -0700 Patch bug-239977-20220502131618.patch text/plain 3951 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNjcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFjODljOTZkOTI5ZDE0YmY4 MWUyMmJlZDI0MjExZDkwZTI4MmI5YTUuLmIxNzNlZWY1MDMyZjU4MDUwOGNhNjQwNGYxMmM5ZjQ3 OTczNjkwNWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjItMDUtMDIgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZlcnQgYWxs IHVzZSBvZiBfc2V0UHJpdmFjeVByb3h5RmFpbENsb3NlZEZvclVucmVhY2hhYmxlTm9uTWFpbkhv c3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzk5 NzcKKyAgICAgICAgPHJkYXI6Ly85MjYxNzk0Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEdWUgdG8gd2hhdCBpcyBsaWtlbHkgY29uZnVzaW9uIGFi b3V0IGludGVybmFsIGludGVncmF0aW9uIHByb2Nlc3NlcywKKyAgICAgICAgdGhlIHBvd2VycyB0 aGF0IGJlIGhhdmUgZGVjaWRlZCB0aGF0IHRoZSBiZXN0IGNvdXJzZSBvZiBhY3Rpb24gZm9yIG5v dworICAgICAgICBpcyB0byByZXN0b3JlIHRoZSBzdGF0dXMgcXVvIGFuZCBhY2NlcHQgYW55IGNv bnNlcXVlbmNlcyB0aGF0IG1heSBlbnRhaWwuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9j b2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0Rh dGFUYXNrQ29jb2E6Ok5ldHdvcmtEYXRhVGFza0NvY29hKToKKyAgICAgICAgKiBOZXR3b3JrUHJv Y2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpOZXR3 b3JrU2Vzc2lvbkNvY29hOjpjcmVhdGVXZWJTb2NrZXRUYXNrKToKKwogMjAyMi0wNS0wMiAgV2Vu c29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBBZGQg c3VwcG9ydCBmb3IgdGhlICJNYXJrdXAgSW1hZ2UiIGFjdGlvbiB3aGVuIHJpZ2h0IGNsaWNraW5n IGFuIGltYWdlIGluIGVkaXRhYmxlIGNvbnRlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0gYi9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLm1tCmluZGV4IDU2 YjA3MGM1Mjc1YmRhM2Y5YTM0ZTFlYTdmNjllYTkyZmMzOWIyMzUuLjNlNTkyMDcwNTIzNzk0MDc5 Y2ExMjYyMjcyYTEzMDU1N2NiNjZkYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQpAQCAtMzQwLDE0 ICszNDAsNiBAQCBOZXR3b3JrRGF0YVRhc2tDb2NvYTo6TmV0d29ya0RhdGFUYXNrQ29jb2EoTmV0 d29ya1Nlc3Npb24mIHNlc3Npb24sIE5ldHdvcmtEYXRhVAogICAgIFJldGFpblB0cjxOU1VSTFJl cXVlc3Q+IG5zUmVxdWVzdCA9IHJlcXVlc3QubnNVUkxSZXF1ZXN0KFdlYkNvcmU6OkhUVFBCb2R5 VXBkYXRlUG9saWN5OjpVcGRhdGVIVFRQQm9keSk7CiAgICAgUmV0YWluUHRyPE5TTXV0YWJsZVVS TFJlcXVlc3Q+IG11dGFibGVSZXF1ZXN0ID0gYWRvcHROUyhbbnNSZXF1ZXN0LmdldCgpIG11dGFi bGVDb3B5XSk7CiAKLSAgICBpZiAocGFyYW1ldGVycy5pc01haW5GcmFtZU5hdmlnYXRpb24KLSAg ICAgICAgfHwgcGFyYW1ldGVycy5oYWRNYWluRnJhbWVNYWluUmVzb3VyY2VQcml2YXRlUmVsYXll ZAotICAgICAgICB8fCAhcGFyYW1ldGVycy50b3BPcmlnaW4KLSAgICAgICAgfHwgcmVxdWVzdC51 cmwoKS5ob3N0KCkgPT0gcGFyYW1ldGVycy50b3BPcmlnaW4tPmhvc3QoKSkgewotICAgICAgICBp ZiAoW211dGFibGVSZXF1ZXN0IHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoX3NldFByaXZh Y3lQcm94eUZhaWxDbG9zZWRGb3JVbnJlYWNoYWJsZU5vbk1haW5Ib3N0czopXSkKLSAgICAgICAg ICAgIFttdXRhYmxlUmVxdWVzdCBfc2V0UHJpdmFjeVByb3h5RmFpbENsb3NlZEZvclVucmVhY2hh YmxlTm9uTWFpbkhvc3RzOllFU107Ci0gICAgfQotCiAjaWYgRU5BQkxFKEFQUF9QUklWQUNZX1JF UE9SVCkKICAgICBtdXRhYmxlUmVxdWVzdC5nZXQoKS5hdHRyaWJ1dGlvbiA9IHJlcXVlc3QuaXNB cHBJbml0aWF0ZWQoKSA/IE5TVVJMUmVxdWVzdEF0dHJpYnV0aW9uRGV2ZWxvcGVyIDogTlNVUkxS ZXF1ZXN0QXR0cmlidXRpb25Vc2VyOwogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0gYi9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0KaW5kZXggNTYy M2E0ZTNjMTFkYmZhOTc4ZWNjNjNmM2I3NjJkODVmZTE2ZWUyOS4uMDkwNDg4N2FhMzVhMzZjYjY2 YWQ1OWY5N2FkMTY2NmEwOGFiZmFkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbQpAQCAtMTcxMywxNyAr MTcxMyw2IEBAIHN0ZDo6dW5pcXVlX3B0cjxXZWJTb2NrZXRUYXNrPiBOZXR3b3JrU2Vzc2lvbkNv Y29hOjpjcmVhdGVXZWJTb2NrZXRUYXNrKFdlYlBhZ2VQCiAgICAgYXBwUHJpdmFjeVJlcG9ydFRl c3RpbmdEYXRhKCkuZGlkTG9hZEFwcEluaXRpYXRlZFJlcXVlc3QobnNSZXF1ZXN0LmdldCgpLmF0 dHJpYnV0aW9uID09IE5TVVJMUmVxdWVzdEF0dHJpYnV0aW9uRGV2ZWxvcGVyKTsKICNlbmRpZgog Ci0gICAgLy8gRklYTUU6IFRoaXMgZnVuY3Rpb24gY2FuIG1ha2UgdXAgdG8gMyBjb3BpZXMgb2Yg YSByZXF1ZXN0LgotICAgIC8vIFJlZHVjZSB0aGF0IHRvIG9uZSBpZiB0aGUgcHJvdG9jb2wgaXMg bnVsbCwgdGhlIHJlcXVlc3QgaXNuJ3QgYXBwIGluaXRpYXRlZCwKLSAgICAvLyBvciB0aGUgbWFp biBmcmFtZSBtYWluIHJlc291cmNlIHdhcyBwcml2YXRlIHJlbGF5ZWQsIHRoZW4gc2V0IGFsbCBw cm9wZXJ0aWVzCi0gICAgLy8gb24gdGhlIG9uZSBjb3B5LgotICAgIGlmIChoYWRNYWluRnJhbWVN YWluUmVzb3VyY2VQcml2YXRlUmVsYXllZCB8fCByZXF1ZXN0LnVybCgpLmhvc3QoKSA9PSBjbGll bnRPcmlnaW4udG9wT3JpZ2luLmhvc3QpIHsKLSAgICAgICAgUmV0YWluUHRyPE5TTXV0YWJsZVVS TFJlcXVlc3Q+IG11dGFibGVSZXF1ZXN0ID0gYWRvcHROUyhbbnNSZXF1ZXN0LmdldCgpIG11dGFi bGVDb3B5XSk7Ci0gICAgICAgIGlmIChbbXV0YWJsZVJlcXVlc3QgcmVzcG9uZHNUb1NlbGVjdG9y OkBzZWxlY3Rvcihfc2V0UHJpdmFjeVByb3h5RmFpbENsb3NlZEZvclVucmVhY2hhYmxlTm9uTWFp bkhvc3RzOildKQotICAgICAgICAgICAgW211dGFibGVSZXF1ZXN0IF9zZXRQcml2YWN5UHJveHlG YWlsQ2xvc2VkRm9yVW5yZWFjaGFibGVOb25NYWluSG9zdHM6WUVTXTsKLSAgICAgICAgbnNSZXF1 ZXN0ID0gV1RGTW92ZShtdXRhYmxlUmVxdWVzdCk7Ci0gICAgfQotCiAgICAgYXV0byYgc2Vzc2lv blNldCA9IHNlc3Npb25TZXRGb3JQYWdlKHdlYlBhZ2VQcm94eUlEKTsKICAgICBSZXRhaW5QdHI8 TlNVUkxTZXNzaW9uV2ViU29ja2V0VGFzaz4gdGFzayA9IFtzZXNzaW9uU2V0LnNlc3Npb25XaXRo Q3JlZGVudGlhbFN0b3JhZ2Uuc2Vzc2lvbiB3ZWJTb2NrZXRUYXNrV2l0aFJlcXVlc3Q6bnNSZXF1 ZXN0LmdldCgpXTsKICAgICAK