239975 2022-05-02 11:33:50 -0700 [GitHub] git-webkit pr doesn't sort Xcode project files before uploading 2023-05-02 08:35:10 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=254703 InRadar P2 Normal --- 239082 254703 1 cdumez jbedard jbedard webkit-bug-importer ysuzuki oldest_to_newest 1865895 0 cdumez 2022-05-02 11:33:50 -0700 git-webkit pr doesn't sort Xcode project files before uploading, which seems to be a regression compared to `webkit-patch upload`. 1867705 1 webkit-bug-importer 2022-05-09 11:34:13 -0700 <rdar://problem/92976140> 1867928 2 jbedard 2022-05-10 08:07:18 -0700 There isn't a way for us to control this. PRs aren't patches, this is basically about how GitHub visualizes diffs between branches. 1867929 3 cdumez 2022-05-10 08:27:04 -0700 I think you misunderstood. If webkit-patch can sort Xcode files before uploading the patch, `git-webkit pr` can also sort Xcode files before uploading the PR. If not, please provide a better explanation. We don't want Xcode project files to be unsorted in the WebKit repository. See Tools/Scripts/sort-Xcode-project-file (which we normally don't have to call manually because it get called before upload). 1867934 4 jbedard 2022-05-10 08:35:40 -0700 Talking with Chris, I misunderstood the ask here. We do this sorting on disk prior to uploading the patch. We can do something similar with PRs. 1871323 5 jbedard 2022-05-23 15:17:30 -0700 Pull request: https://github.com/WebKit/WebKit/pull/948 1871502 6 ews-feeder 2022-05-24 08:39:28 -0700 Committed r294748 (250916@main): <https://commits.webkit.org/250916@main> Reviewed commits have been landed. Closing PR #948 and removing active labels.