239953 2022-05-01 22:41:21 -0700 avoid setting different syntax but same value Colors in DrawGlyphsRecorder 2022-05-03 17:16:45 -0700 1 1 1 Unclassified WebKit WebKit Process Model WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 235604 InRadar P2 Normal --- 1 heycam webkit-unassigned webkit-bug-importer oldest_to_newest 1865763 0 heycam 2022-05-01 22:41:21 -0700 DrawGlyphsRecorder extracts the current fill and stroke colors when text is drawn. This handles color fonts. We extract the current colors using CGGStateGetFillColor and CGGStateGetStrokeColor, then convert the CGColors to WebCore::Colors using Color::createAndPreserveColorSpace. The result is that we always create an out-of-line Color (i.e. one with float components), even if the original color we set came from an SRGBA<uint8_t> color value. The two don't compare equal, and we spend time generating and processing state change display list items for this. For the common case of the draw glyphs callback being called with the current fill and stroke set to the same CGColor object instances that we set in DrawGlyphsRecorder::populateInternalContext, we can set the fill/stroke using the brush values on m_originalState, and the graphics context state management code will detect these as the same and avoid generating changes. 1865764 1 webkit-bug-importer 2022-05-01 22:41:29 -0700 <rdar://problem/92593336> 1866321 2 heycam 2022-05-03 17:16:45 -0700 *** This bug has been marked as a duplicate of bug 235604 ***