23993 2009-02-17 14:00:19 -0800 Underline formatting bleeds into other formatting during delete/backspace 2010-03-09 21:35:22 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC All RESOLVED DUPLICATE 21840 P3 Normal --- 1 jparent webkit-unassigned eric justin.garcia rniwa tony oldest_to_newest 110004 0 jparent 2009-02-17 14:00:19 -0800 Steps to reproduce: 1. Go to your favorite contentEditable based rich text editor (like http://www.mozilla.org/editor/midasdemo/) 2. Type "Foo Bar" on the first line (without quotes). Press Enter. 3. Type "Baz" on the second line. (html is Foo <span class="Apple-style-span" style="text-decoration: underline;">Bar</span><div>Baz</div>) 4. Double-click on "Bar" to highlight it. 5. Press underline from the toolbar. 6. Go to the beginning of the second line. 7. Press Backspace. Result: Everything moved from the second line to the first is underlined (html is Foo <span class="Apple-style-span" style="text-decoration: underline;">BarBaz</span> Expected: Just "Bar" to be underlined. Notes: I've repro'ed on Chrome 1.0 Windows and a webkit nightly on Mac. This also repros if you use delete at the end of the first line, rather than backspace at the beginning of the second line. 110030 1 justin.garcia 2009-02-17 16:14:27 -0800 *** Bug 23994 has been marked as a duplicate of this bug. *** 110031 2 justin.garcia 2009-02-17 16:15:20 -0800 Minor thing: in step 3 you write that the "html is ..." but it isn't in that state until after step 5. 110039 3 justin.garcia 2009-02-17 17:09:05 -0800 Also notice that pasting text that isn't underlined anywhere inside, just before or just after underlined content will incorrectly underline the pasted content. This is because the pasted content goes into an element with text-decoration: underline, and every descendant of such an element, no matter what, will be underlined. In the bold case, pasted content goes into a bold tag, but the pasted content is surrounded by a span with font-weight: normal, which negates the boldness. We need a function positionAvoidingTextDecoration or the like in ReplaceSelectionCommand to fix this. 131462 4 32692 rniwa 2009-07-13 18:18:28 -0700 Created attachment 32692 demonstrates the bug: underline extends to the next line when adjoint lines are merged with deletion 131805 5 rniwa 2009-07-14 21:13:32 -0700 I noticed that there is -webkit-text-decorations-in-effect property is added in the result. Does anyone know what this property is for? <span class="Apple-style-span" style="text-decoration: underline;">hello<span class="Apple-style-span" style="-webkit-text-decorations-in-effect: none; ">world</span></span> 137115 6 rniwa 2009-08-04 13:53:41 -0700 This is another bug with ReplaceSelectionCommand as Justin suggested, we need to adjust where we insert the fragment. 137157 7 rniwa 2009-08-04 15:36:29 -0700 Around the line 865, we have insertNodeAtAndUpdateNodesInserted(refNode, insertionPos); And refNode->showTreeForThis() results in: SPAN 0x1af7ee50 CLASS=Apple-style-span STYLE=border-collapse: separate; color: rgb(0, 0, 0); font-family: Times; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; #text 0x1af7f170 "world" Is it even correct to have "-webkit-text-decoration: none" here? If so, when are you taking care of it? handleStyleSpans? 137191 8 rniwa 2009-08-04 17:07:10 -0700 Justin and I talked on IRC, and it's maybe sensible to delete all style-spans and reapply ApplyStyleCommand because we need to push down text decoration and other styles and apply them again. 185364 9 tony 2010-01-28 00:05:32 -0800 I have a fix for this in bug 21840. 197882 10 tony 2010-03-09 21:35:22 -0800 Fixed in r55762, which included a layout test for this case. *** This bug has been marked as a duplicate of bug 21840 *** 32692 2009-07-13 18:18:28 -0700 2009-07-13 18:18:28 -0700 demonstrates the bug: underline extends to the next line when adjoint lines are merged with deletion 23993.html text/html 656 rniwa PGh0bWw+Cjxib2R5Pgo8ZGl2IGlkPSJ0ZXN0IiBjb250ZW50ZWRpdGFibGU9InRydWUiPgo8c3Bh biBzdHlsZT0idGV4dC1kZWNvcmF0aW9uOiB1bmRlcmxpbmU7Ij5oZWxsbzwvc3Bhbj48ZGl2Pgp3 b3JsZAo8L2Rpdj48L2Rpdj4KPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cgo8c2NyaXB0IHR5cGU9 InRleHQvamF2YXNjcmlwdCI+CgppZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAg bGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwoKZG9jdW1lbnQuZGVzaWduTW9kZT0n b24nOwoKdmFyIGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGVzdCcpOwp2YXIgcyA9IHdp bmRvdy5nZXRTZWxlY3Rpb24oKTsKCnIgPSBkb2N1bWVudC5jcmVhdGVSYW5nZSgpOwoKci5zZXRT dGFydChlLmNoaWxkTm9kZXNbMl0uZmlyc3RDaGlsZCwxKTsKci5zZXRFbmQoZS5jaGlsZE5vZGVz WzJdLmZpcnN0Q2hpbGQsMSk7CgpzLnJlbW92ZUFsbFJhbmdlcygpOwpzLmFkZFJhbmdlKHIpOwoK ZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkRlbGV0ZSIsIGZhbHNlLCBudWxsKTsKCmRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCdjb25zb2xlJykuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5v ZGUoZS5pbm5lckhUTUwpKTsKCjwvc2NyaXB0Pgo=