239924 2022-04-30 01:57:40 -0700 Web Inspector: Update jsmin to 3.0.1 2022-06-28 15:13:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 242086 1 pnormand pnormand inspector-bugzilla-changes pangle tsavell webkit-bug-importer oldest_to_newest 1865628 0 pnormand 2022-04-30 01:57:40 -0700 Current version (2.0.9) is very slow: time python /app/webkit/Source/JavaScriptCore/Scripts/jsmin.py < /app/webkit/WebKitBuild/Release/WebInspectorUI/DerivedSources/Main.js > foo.js real 1m21.234s user 0m59.580s sys 0m21.253s Version 3.0.1 is much faster: time python /app/webkit/Source/JavaScriptCore/Scripts/jsmin.py < /app/webkit/WebKitBuild/Release/WebInspectorUI/DerivedSources/Main.js > foo.js real 0m3.933s user 0m3.899s sys 0m0.018s So I'll try an update. 1865630 1 pnormand 2022-04-30 02:22:35 -0700 Pull request: https://github.com/WebKit/WebKit/pull/444 1866397 2 ews-feeder 2022-05-04 02:13:05 -0700 Committed r293767 (250246@main): <https://commits.webkit.org/250246@main> Reviewed commits have been landed. Closing PR #444 and removing active labels. 1866398 3 webkit-bug-importer 2022-05-04 02:14:13 -0700 <rdar://problem/92720918> 1868026 4 tsavell 2022-05-10 15:30:23 -0700 It looks like the changes in https://github.com/WebKit/WebKit/commit/057f942c764e9f79d38e88bca94b7e35549883b4 broke inspector/timeline/line-column.html tracking in: https://bugs.webkit.org/show_bug.cgi?id=240291 1878880 5 pangle 2022-06-28 15:03:46 -0700 This broke minifying WebInspectorUI. Specifically, the comment in CodeMirrorCompletionController.js `// FIXME: Include module keywords if we know this is a module environment.` is being kept in the minified output, most likely due to the regex above in the file. It appears to be this issue in the upstream project: https://github.com/tikitu/jsmin/issues/23