23992 2009-02-17 13:55:29 -0800 REGRESSION: crash on windows loading http://www.stickam.com/liveStreams.do 2009-02-18 14:12:17 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac Windows XP RESOLVED FIXED http://www.stickam.com/liveStreams.do P1 Normal --- 1 ojan webkit-unassigned ap darin oldest_to_newest 110003 0 ojan 2009-02-17 13:55:29 -0800 I only have a debug build of Chromium. So you can see the stack here: http://crbug.com/7682 But a *Windows* webkit nightly seems to crash in the same place. Mac nightlies load fine. 110005 1 ojan 2009-02-17 14:01:14 -0800 Looks like it started with darin's change here: http://trac.webkit.org/changeset/40824 Specifically removing the null check for doc in Frame::contentRenderer() (Frame.cpp:1130) 110007 2 eric 2009-02-17 14:08:12 -0800 marking p1 since this is a regression. 110009 3 ojan 2009-02-17 14:30:01 -0800 I'm happy to just add the null-check back in. Don't know if that's the right fix though. Will send a patch with the null-check if I don't hear otherwise. 110011 4 27738 ojan 2009-02-17 14:43:03 -0800 Created attachment 27738 Fix crash on page load of http://www.stickam.com/liveStreams.do. Just readds a null-check that was removed in r40824. WebCore/page/Frame.cpp | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) 110063 5 27738 ap 2009-02-18 04:11:39 -0800 Comment on attachment 27738 Fix crash on page load of http://www.stickam.com/liveStreams.do. Just readds a null-check that was removed in r40824. r=me The code change looks fine, but I'm somewhat confused whether this needs a layout test. Did this problem cause crashes in existing tests on Windows? If it did not, can a new test be created for this fix? 110117 6 ojan 2009-02-18 14:02:29 -0800 IRC discussion: ojan: ap: regarding https://bugs.webkit.org/show_bug.cgi?id=23992...i haven't really been able to come up with a reduced case for the crash. it does crash everytime loading the page in question, but i haven' been able to figure out where exactly. saving a static version of the page and loading it doesn't cause a crash. i can dig further into the stack trace to try and understand when we're hitting this, but i'm not sure how much fruit that will yield. ap: ojan: ok I did dig further. Looks like it's crashing in the actual load event. I think (not sure) that an iframe is being appended to the page onload of the top-level window. The contentRenderer is grabbed before the iframe has a document. 110121 7 fishd 2009-02-18 14:12:17 -0800 Landed as http://trac.webkit.org/changeset/41066 27738 2009-02-17 14:43:03 -0800 2009-02-18 04:11:39 -0800 Fix crash on page load of http://www.stickam.com/liveStreams.do. Just readds a null-check that was removed in r40824. d-of-http-www.stickam.com-liveStreams.do.-Just-readds-a-null-check-that-was-removed-in-r40824..patch text/plain 437 ojan MjEzNWEyYjI3NGE2NDlhODIxYzlkZTkzZmUxOGQ4MDBkYjQzNTBhYwpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wYWdlL0ZyYW1lLmNwcCBiL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKaW5kZXggZTBlNDBk OS4uNDZkYTRmNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAorKysgYi9XZWJD b3JlL3BhZ2UvRnJhbWUuY3BwCkBAIC0xMTEwLDYgKzExMTAsOCBAQCB2b2lkIEZyYW1lOjpjbGVh ckRPTVdpbmRvdygpCiBSZW5kZXJWaWV3KiBGcmFtZTo6Y29udGVudFJlbmRlcmVyKCkgY29uc3QK IHsKICAgICBEb2N1bWVudCogZG9jID0gZG9jdW1lbnQoKTsKKyAgICBpZiAoIWRvYykKKyAgICAg ICAgcmV0dXJuIDA7CiAgICAgUmVuZGVyT2JqZWN0KiBvYmplY3QgPSBkb2MtPnJlbmRlcmVyKCk7 CiAgICAgaWYgKCFvYmplY3QpCiAgICAgICAgIHJldHVybiAwOwo=