239914 2022-04-29 15:16:17 -0700 The isYahooMail quirk is specific to PLATFORM(IOS_FAMILY) 2022-04-30 13:55:21 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead achristensen cdumez darin simon.fraser webkit-bug-importer ysuzuki oldest_to_newest 1865551 0 don.olmstead 2022-04-29 15:16:17 -0700 Found because of an unused function warning for isYahooMail. 1865553 1 458612 don.olmstead 2022-04-29 15:22:34 -0700 Created attachment 458612 Patch 1865610 2 ews-feeder 2022-04-29 20:38:29 -0700 Committed r293641 (250145@main): <https://commits.webkit.org/250145@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458612. 1865611 3 webkit-bug-importer 2022-04-29 20:39:14 -0700 <rdar://problem/92556090> 1865675 4 458612 darin 2022-04-30 13:55:21 -0700 Comment on attachment 458612 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458612&action=review > Source/WebCore/ChangeLog:10 > + The isYahooMail check is incorrectly guarded by ENABLE(PUBLIC_SUFFIX_LIST) when the only > + using this function is guarded by ENABLE(IOS_TOUCH_EVENTS) and PLATFORM(IOS_FAMILY). Use > + PLATFORM(IOS_FAMILY) since ENABLE(IOS_TOUCH_EVENTS) implies that anyways. I suppose this is a losing battle at this point, but I’ve tried to always use something more specific than the PLATFORM macro whenever possible. So in this case I would have used ENABLE(IOS_TOUCH_EVENTS). 458612 2022-04-29 15:22:34 -0700 2022-04-29 20:38:32 -0700 Patch bug-239914.diff text/plain 1412 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNGRmNGM3NWExMTQuLjg2ZWFiODQwMTk3ZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE4IEBACisyMDIyLTA0LTI5ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29u eS5jb20+CisKKyAgICAgICAgVGhlIGlzWWFob29NYWlsIHF1aXJrIGlzIHNwZWNpZmljIHRvIFBM QVRGT1JNKElPU19GQU1JTFkpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMzk5MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgaXNZYWhvb01haWwgY2hlY2sgaXMgaW5jb3JyZWN0bHkgZ3VhcmRlZCBi eSBFTkFCTEUoUFVCTElDX1NVRkZJWF9MSVNUKSB3aGVuIHRoZSBvbmx5CisgICAgICAgIHVzaW5n IHRoaXMgZnVuY3Rpb24gaXMgZ3VhcmRlZCBieSBFTkFCTEUoSU9TX1RPVUNIX0VWRU5UUykgYW5k IFBMQVRGT1JNKElPU19GQU1JTFkpLiBVc2UKKyAgICAgICAgUExBVEZPUk0oSU9TX0ZBTUlMWSkg c2luY2UgRU5BQkxFKElPU19UT1VDSF9FVkVOVFMpIGltcGxpZXMgdGhhdCBhbnl3YXlzLgorCisg ICAgICAgIEZpeGVzIGFuIHVudXNlZCBmdW5jdGlvbiB3YXJuaW5nIGZvciBvdGhlciBwb3J0cy4K KworICAgICAgICAqIHBhZ2UvUXVpcmtzLmNwcDoKKwogMjAyMi0wNC0yOSAgT3Jpb2wgQnJ1ZmF1 ICA8b2JydWZhdUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtjc3MtY2FzY2FkZV0gU29ydCBzaG9y dGhhbmQgcHJvcGVydGllcyBhdCB0aGUgZW5kIG9mIENTU1Byb3BlcnR5SUQgZW51bQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9RdWlya3MuY3BwCmluZGV4IDcyZDcxMDA2ZmE2NS4uOGU2Y2RhY2EwMWNlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9RdWlya3MuY3BwCkBAIC03Nyw3ICs3Nyw3IEBAIHN0YXRpYyBpbmxpbmUgT3B0aW9uU2V0PEF1 dG9wbGF5UXVpcms+IGFsbG93ZWRBdXRvcGxheVF1aXJrcyhEb2N1bWVudCYgZG9jdW1lbnQpCiAg ICAgcmV0dXJuIGxvYWRlci0+YWxsb3dlZEF1dG9wbGF5UXVpcmtzKCk7CiB9CiAKLSNpZiBFTkFC TEUoUFVCTElDX1NVRkZJWF9MSVNUKQorI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCiBzdGF0aWMg aW5saW5lIGJvb2wgaXNZYWhvb01haWwoRG9jdW1lbnQmIGRvY3VtZW50KQogewogICAgIGF1dG8g aG9zdCA9IGRvY3VtZW50LnRvcERvY3VtZW50KCkudXJsKCkuaG9zdCgpOwo=