23990 2009-02-17 08:25:12 -0800 Regression (r40837): JavaScript image popup doesn't work 2009-02-25 23:18:04 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://www.tetongravity.com/forums/showthread.php?t=137052&page=196 Regression P1 Normal --- 1 alexanderkahn sam kevin sam tonytung zwarich oldest_to_newest 109966 0 alexanderkahn 2009-02-17 08:25:12 -0800 Hi, On this page: http://www.tetongravity.com/forums/showthread.php?t=137052&page=196 , in post #4877, clicking on one of the attached images is supposed to popup a larger version of the image. In the current nightly (41018?), it doesn't. However, when viewing the post on its own (http://www.tetongravity.com/forums/showpost.php?p=2260986&postcount=4877), the image pops up correctly. Thanks to cpst for helping me file this. 109969 1 zwarich 2009-02-17 08:43:07 -0800 Using nightlies I tracked down this regression to the range r40813-r40884. I'll try bisecting some more with SVN. 109980 2 zwarich 2009-02-17 10:40:26 -0800 This regressed in r40837: http://trac.webkit.org/changeset/40837 I'm not sure what caused the change. 110093 3 zwarich 2009-02-18 10:49:30 -0800 The YAHOO.util.Dom.setXY YUI function seems to be broken after r40837, but I am not sure why. 110111 4 zwarich 2009-02-18 13:02:28 -0800 The problem seems to be with the getXY YUI function, which sniffs getBoundingClientRect and uses it if it exists. In the case of the element in question, getBoundingClientRect().top differs from offsetTop. 110116 5 zwarich 2009-02-18 13:59:34 -0800 The problem is that getBoundingClientRect on all other browsers gives a negative top value if the page has been scrolled downwards. We need to emulate this behaviour (and other quirks of getBoundingClientRect) for compatibility. I'll try to make a simple test case from this example. 110124 6 27764 zwarich 2009-02-18 14:36:51 -0800 Created attachment 27764 Reduced test case Here's a reduced test case. Clicking anywhere gives an alert with the top of the enclosing div's current bounding rectangle. Note that this is reported relative to the viewport in all other browsers. 110135 7 zwarich 2009-02-18 16:06:07 -0800 I'm unassigning this, because I'm probably not the one to fix it. 110740 8 kevin 2009-02-24 07:57:57 -0800 You mentioned scrolling the page downwards. I think I'm seeing what may be other related issues with scrolling between builds r40813 and r40884, so it could be the same bug. I'm seeing that javascript opened content is only positioned correctly before you start scrolling. Once scrolled it opens in it's original position on the screen but not correct relative to the page content anymore. Example: http://www.mania.com/aodvb/ On this and other forum sites, click the search or quick links drop down menus and they'll appear fine. Scroll down the page a little and then they appear out of proper position. I'm also seeing something similar on Yahoo Personals in the photo gallery grid mode where an info box appears relative to a picture, but isn't in the right spot after scrolling. 110745 9 zwarich 2009-02-24 09:02:36 -0800 It's probably the same bug. The fix is to just use viewport-relative coordinates. If Sam doesn't fix it soon, I'll ask Hyatt how to fix it and do it myself. 110879 10 27948 sam 2009-02-24 18:22:47 -0800 Created attachment 27948 patch 110887 11 27948 hyatt 2009-02-24 18:36:50 -0800 Comment on attachment 27948 patch r=me 110888 12 sam 2009-02-24 18:38:52 -0800 Fixed in r41207. 111114 13 zwarich 2009-02-25 23:18:04 -0800 *** Bug 24134 has been marked as a duplicate of this bug. *** 27764 2009-02-18 14:36:51 -0800 2009-02-18 14:36:51 -0800 Reduced test case test.html text/html 7534 zwarich PGh0bWw+CjxoZWFkPgo8dGl0bGU+Z2V0Qm91bmRpbmdDbGllbnRSZWN0IHRlc3Q8L3RpdGxlPgo8 c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CmZ1bmN0aW9uIHRlc3QoKQp7CiAgICBhbGVy dChkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZW5jbG9zaW5nRGl2IikuZ2V0Qm91bmRpbmdDbGll bnRSZWN0KCkudG9wKTsKfQo8L3NjcmlwdD4KPC9oZWFkPgo8Ym9keSBvbmNsaWNrPSJ0ZXN0KCk7 Ij4KPGRpdiBpZD0iZW5jbG9zaW5nRGl2Ij4KPHA+TG9yZW0gaXBzdW0gZG9sb3Igc2l0IGFtZXQs IGNvbnNlY3RldHVyIGFkaXBpc2ljaW5nIGVsaXQsIHNlZCBkbyBlaXVzbW9kIHRlbXBvciBpbmNp ZGlkdW50IHV0IGxhYm9yZSBldCBkb2xvcmUgbWFnbmEgYWxpcXVhLiBVdCBlbmltIGFkIG1pbmlt IHZlbmlhbSwgcXVpcyBub3N0cnVkIGV4ZXJjaXRhdGlvbiB1bGxhbWNvIGxhYm9yaXMgbmlzaSB1 dCBhbGlxdWlwIGV4IGVhIGNvbW1vZG8gY29uc2VxdWF0LiBEdWlzIGF1dGUgaXJ1cmUgZG9sb3Ig aW4gcmVwcmVoZW5kZXJpdCBpbiB2b2x1cHRhdGUgdmVsaXQgZXNzZSBjaWxsdW0gZG9sb3JlIGV1 IGZ1Z2lhdCBudWxsYSBwYXJpYXR1ci4gRXhjZXB0ZXVyIHNpbnQgb2NjYWVjYXQgY3VwaWRhdGF0 IG5vbiBwcm9pZGVudCwgc3VudCBpbiBjdWxwYSBxdWkgb2ZmaWNpYSBkZXNlcnVudCBtb2xsaXQg YW5pbSBpZCBlc3QgbGFib3J1bS48L3A+CjxwPkxvcmVtIGlwc3VtIGRvbG9yIHNpdCBhbWV0LCBj b25zZWN0ZXR1ciBhZGlwaXNpY2luZyBlbGl0LCBzZWQgZG8gZWl1c21vZCB0ZW1wb3IgaW5jaWRp ZHVudCB1dCBsYWJvcmUgZXQgZG9sb3JlIG1hZ25hIGFsaXF1YS4gVXQgZW5pbSBhZCBtaW5pbSB2 ZW5pYW0sIHF1aXMgbm9zdHJ1ZCBleGVyY2l0YXRpb24gdWxsYW1jbyBsYWJvcmlzIG5pc2kgdXQg YWxpcXVpcCBleCBlYSBjb21tb2RvIGNvbnNlcXVhdC4gRHVpcyBhdXRlIGlydXJlIGRvbG9yIGlu IHJlcHJlaGVuZGVyaXQgaW4gdm9sdXB0YXRlIHZlbGl0IGVzc2UgY2lsbHVtIGRvbG9yZSBldSBm dWdpYXQgbnVsbGEgcGFyaWF0dXIuIEV4Y2VwdGV1ciBzaW50IG9jY2FlY2F0IGN1cGlkYXRhdCBu b24gcHJvaWRlbnQsIHN1bnQgaW4gY3VscGEgcXVpIG9mZmljaWEgZGVzZXJ1bnQgbW9sbGl0IGFu aW0gaWQgZXN0IGxhYm9ydW0uPC9wPgo8cD5Mb3JlbSBpcHN1bSBkb2xvciBzaXQgYW1ldCwgY29u c2VjdGV0dXIgYWRpcGlzaWNpbmcgZWxpdCwgc2VkIGRvIGVpdXNtb2QgdGVtcG9yIGluY2lkaWR1 bnQgdXQgbGFib3JlIGV0IGRvbG9yZSBtYWduYSBhbGlxdWEuIFV0IGVuaW0gYWQgbWluaW0gdmVu aWFtLCBxdWlzIG5vc3RydWQgZXhlcmNpdGF0aW9uIHVsbGFtY28gbGFib3JpcyBuaXNpIHV0IGFs aXF1aXAgZXggZWEgY29tbW9kbyBjb25zZXF1YXQuIER1aXMgYXV0ZSBpcnVyZSBkb2xvciBpbiBy ZXByZWhlbmRlcml0IGluIHZvbHVwdGF0ZSB2ZWxpdCBlc3NlIGNpbGx1bSBkb2xvcmUgZXUgZnVn aWF0IG51bGxhIHBhcmlhdHVyLiBFeGNlcHRldXIgc2ludCBvY2NhZWNhdCBjdXBpZGF0YXQgbm9u IHByb2lkZW50LCBzdW50IGluIGN1bHBhIHF1aSBvZmZpY2lhIGRlc2VydW50IG1vbGxpdCBhbmlt IGlkIGVzdCBsYWJvcnVtLjwvcD4KPHA+TG9yZW0gaXBzdW0gZG9sb3Igc2l0IGFtZXQsIGNvbnNl Y3RldHVyIGFkaXBpc2ljaW5nIGVsaXQsIHNlZCBkbyBlaXVzbW9kIHRlbXBvciBpbmNpZGlkdW50 IHV0IGxhYm9yZSBldCBkb2xvcmUgbWFnbmEgYWxpcXVhLiBVdCBlbmltIGFkIG1pbmltIHZlbmlh bSwgcXVpcyBub3N0cnVkIGV4ZXJjaXRhdGlvbiB1bGxhbWNvIGxhYm9yaXMgbmlzaSB1dCBhbGlx dWlwIGV4IGVhIGNvbW1vZG8gY29uc2VxdWF0LiBEdWlzIGF1dGUgaXJ1cmUgZG9sb3IgaW4gcmVw cmVoZW5kZXJpdCBpbiB2b2x1cHRhdGUgdmVsaXQgZXNzZSBjaWxsdW0gZG9sb3JlIGV1IGZ1Z2lh dCBudWxsYSBwYXJpYXR1ci4gRXhjZXB0ZXVyIHNpbnQgb2NjYWVjYXQgY3VwaWRhdGF0IG5vbiBw cm9pZGVudCwgc3VudCBpbiBjdWxwYSBxdWkgb2ZmaWNpYSBkZXNlcnVudCBtb2xsaXQgYW5pbSBp ZCBlc3QgbGFib3J1bS48L3A+CjxwPkxvcmVtIGlwc3VtIGRvbG9yIHNpdCBhbWV0LCBjb25zZWN0 ZXR1ciBhZGlwaXNpY2luZyBlbGl0LCBzZWQgZG8gZWl1c21vZCB0ZW1wb3IgaW5jaWRpZHVudCB1 dCBsYWJvcmUgZXQgZG9sb3JlIG1hZ25hIGFsaXF1YS4gVXQgZW5pbSBhZCBtaW5pbSB2ZW5pYW0s IHF1aXMgbm9zdHJ1ZCBleGVyY2l0YXRpb24gdWxsYW1jbyBsYWJvcmlzIG5pc2kgdXQgYWxpcXVp cCBleCBlYSBjb21tb2RvIGNvbnNlcXVhdC4gRHVpcyBhdXRlIGlydXJlIGRvbG9yIGluIHJlcHJl aGVuZGVyaXQgaW4gdm9sdXB0YXRlIHZlbGl0IGVzc2UgY2lsbHVtIGRvbG9yZSBldSBmdWdpYXQg bnVsbGEgcGFyaWF0dXIuIEV4Y2VwdGV1ciBzaW50IG9jY2FlY2F0IGN1cGlkYXRhdCBub24gcHJv aWRlbnQsIHN1bnQgaW4gY3VscGEgcXVpIG9mZmljaWEgZGVzZXJ1bnQgbW9sbGl0IGFuaW0gaWQg ZXN0IGxhYm9ydW0uPC9wPgo8cD5Mb3JlbSBpcHN1bSBkb2xvciBzaXQgYW1ldCwgY29uc2VjdGV0 dXIgYWRpcGlzaWNpbmcgZWxpdCwgc2VkIGRvIGVpdXNtb2QgdGVtcG9yIGluY2lkaWR1bnQgdXQg bGFib3JlIGV0IGRvbG9yZSBtYWduYSBhbGlxdWEuIFV0IGVuaW0gYWQgbWluaW0gdmVuaWFtLCBx dWlzIG5vc3RydWQgZXhlcmNpdGF0aW9uIHVsbGFtY28gbGFib3JpcyBuaXNpIHV0IGFsaXF1aXAg ZXggZWEgY29tbW9kbyBjb25zZXF1YXQuIER1aXMgYXV0ZSBpcnVyZSBkb2xvciBpbiByZXByZWhl bmRlcml0IGluIHZvbHVwdGF0ZSB2ZWxpdCBlc3NlIGNpbGx1bSBkb2xvcmUgZXUgZnVnaWF0IG51 bGxhIHBhcmlhdHVyLiBFeGNlcHRldXIgc2ludCBvY2NhZWNhdCBjdXBpZGF0YXQgbm9uIHByb2lk ZW50LCBzdW50IGluIGN1bHBhIHF1aSBvZmZpY2lhIGRlc2VydW50IG1vbGxpdCBhbmltIGlkIGVz dCBsYWJvcnVtLjwvcD4KPHA+TG9yZW0gaXBzdW0gZG9sb3Igc2l0IGFtZXQsIGNvbnNlY3RldHVy IGFkaXBpc2ljaW5nIGVsaXQsIHNlZCBkbyBlaXVzbW9kIHRlbXBvciBpbmNpZGlkdW50IHV0IGxh Ym9yZSBldCBkb2xvcmUgbWFnbmEgYWxpcXVhLiBVdCBlbmltIGFkIG1pbmltIHZlbmlhbSwgcXVp cyBub3N0cnVkIGV4ZXJjaXRhdGlvbiB1bGxhbWNvIGxhYm9yaXMgbmlzaSB1dCBhbGlxdWlwIGV4 IGVhIGNvbW1vZG8gY29uc2VxdWF0LiBEdWlzIGF1dGUgaXJ1cmUgZG9sb3IgaW4gcmVwcmVoZW5k ZXJpdCBpbiB2b2x1cHRhdGUgdmVsaXQgZXNzZSBjaWxsdW0gZG9sb3JlIGV1IGZ1Z2lhdCBudWxs YSBwYXJpYXR1ci4gRXhjZXB0ZXVyIHNpbnQgb2NjYWVjYXQgY3VwaWRhdGF0IG5vbiBwcm9pZGVu dCwgc3VudCBpbiBjdWxwYSBxdWkgb2ZmaWNpYSBkZXNlcnVudCBtb2xsaXQgYW5pbSBpZCBlc3Qg bGFib3J1bS48L3A+CjxwPkxvcmVtIGlwc3VtIGRvbG9yIHNpdCBhbWV0LCBjb25zZWN0ZXR1ciBh ZGlwaXNpY2luZyBlbGl0LCBzZWQgZG8gZWl1c21vZCB0ZW1wb3IgaW5jaWRpZHVudCB1dCBsYWJv cmUgZXQgZG9sb3JlIG1hZ25hIGFsaXF1YS4gVXQgZW5pbSBhZCBtaW5pbSB2ZW5pYW0sIHF1aXMg bm9zdHJ1ZCBleGVyY2l0YXRpb24gdWxsYW1jbyBsYWJvcmlzIG5pc2kgdXQgYWxpcXVpcCBleCBl YSBjb21tb2RvIGNvbnNlcXVhdC4gRHVpcyBhdXRlIGlydXJlIGRvbG9yIGluIHJlcHJlaGVuZGVy aXQgaW4gdm9sdXB0YXRlIHZlbGl0IGVzc2UgY2lsbHVtIGRvbG9yZSBldSBmdWdpYXQgbnVsbGEg cGFyaWF0dXIuIEV4Y2VwdGV1ciBzaW50IG9jY2FlY2F0IGN1cGlkYXRhdCBub24gcHJvaWRlbnQs IHN1bnQgaW4gY3VscGEgcXVpIG9mZmljaWEgZGVzZXJ1bnQgbW9sbGl0IGFuaW0gaWQgZXN0IGxh Ym9ydW0uPC9wPgo8cD5Mb3JlbSBpcHN1bSBkb2xvciBzaXQgYW1ldCwgY29uc2VjdGV0dXIgYWRp cGlzaWNpbmcgZWxpdCwgc2VkIGRvIGVpdXNtb2QgdGVtcG9yIGluY2lkaWR1bnQgdXQgbGFib3Jl IGV0IGRvbG9yZSBtYWduYSBhbGlxdWEuIFV0IGVuaW0gYWQgbWluaW0gdmVuaWFtLCBxdWlzIG5v c3RydWQgZXhlcmNpdGF0aW9uIHVsbGFtY28gbGFib3JpcyBuaXNpIHV0IGFsaXF1aXAgZXggZWEg Y29tbW9kbyBjb25zZXF1YXQuIER1aXMgYXV0ZSBpcnVyZSBkb2xvciBpbiByZXByZWhlbmRlcml0 IGluIHZvbHVwdGF0ZSB2ZWxpdCBlc3NlIGNpbGx1bSBkb2xvcmUgZXUgZnVnaWF0IG51bGxhIHBh cmlhdHVyLiBFeGNlcHRldXIgc2ludCBvY2NhZWNhdCBjdXBpZGF0YXQgbm9uIHByb2lkZW50LCBz dW50IGluIGN1bHBhIHF1aSBvZmZpY2lhIGRlc2VydW50IG1vbGxpdCBhbmltIGlkIGVzdCBsYWJv cnVtLjwvcD4KPHA+TG9yZW0gaXBzdW0gZG9sb3Igc2l0IGFtZXQsIGNvbnNlY3RldHVyIGFkaXBp c2ljaW5nIGVsaXQsIHNlZCBkbyBlaXVzbW9kIHRlbXBvciBpbmNpZGlkdW50IHV0IGxhYm9yZSBl dCBkb2xvcmUgbWFnbmEgYWxpcXVhLiBVdCBlbmltIGFkIG1pbmltIHZlbmlhbSwgcXVpcyBub3N0 cnVkIGV4ZXJjaXRhdGlvbiB1bGxhbWNvIGxhYm9yaXMgbmlzaSB1dCBhbGlxdWlwIGV4IGVhIGNv bW1vZG8gY29uc2VxdWF0LiBEdWlzIGF1dGUgaXJ1cmUgZG9sb3IgaW4gcmVwcmVoZW5kZXJpdCBp biB2b2x1cHRhdGUgdmVsaXQgZXNzZSBjaWxsdW0gZG9sb3JlIGV1IGZ1Z2lhdCBudWxsYSBwYXJp YXR1ci4gRXhjZXB0ZXVyIHNpbnQgb2NjYWVjYXQgY3VwaWRhdGF0IG5vbiBwcm9pZGVudCwgc3Vu dCBpbiBjdWxwYSBxdWkgb2ZmaWNpYSBkZXNlcnVudCBtb2xsaXQgYW5pbSBpZCBlc3QgbGFib3J1 bS48L3A+CjxwPkxvcmVtIGlwc3VtIGRvbG9yIHNpdCBhbWV0LCBjb25zZWN0ZXR1ciBhZGlwaXNp Y2luZyBlbGl0LCBzZWQgZG8gZWl1c21vZCB0ZW1wb3IgaW5jaWRpZHVudCB1dCBsYWJvcmUgZXQg ZG9sb3JlIG1hZ25hIGFsaXF1YS4gVXQgZW5pbSBhZCBtaW5pbSB2ZW5pYW0sIHF1aXMgbm9zdHJ1 ZCBleGVyY2l0YXRpb24gdWxsYW1jbyBsYWJvcmlzIG5pc2kgdXQgYWxpcXVpcCBleCBlYSBjb21t b2RvIGNvbnNlcXVhdC4gRHVpcyBhdXRlIGlydXJlIGRvbG9yIGluIHJlcHJlaGVuZGVyaXQgaW4g dm9sdXB0YXRlIHZlbGl0IGVzc2UgY2lsbHVtIGRvbG9yZSBldSBmdWdpYXQgbnVsbGEgcGFyaWF0 dXIuIEV4Y2VwdGV1ciBzaW50IG9jY2FlY2F0IGN1cGlkYXRhdCBub24gcHJvaWRlbnQsIHN1bnQg aW4gY3VscGEgcXVpIG9mZmljaWEgZGVzZXJ1bnQgbW9sbGl0IGFuaW0gaWQgZXN0IGxhYm9ydW0u PC9wPgo8cD5Mb3JlbSBpcHN1bSBkb2xvciBzaXQgYW1ldCwgY29uc2VjdGV0dXIgYWRpcGlzaWNp bmcgZWxpdCwgc2VkIGRvIGVpdXNtb2QgdGVtcG9yIGluY2lkaWR1bnQgdXQgbGFib3JlIGV0IGRv bG9yZSBtYWduYSBhbGlxdWEuIFV0IGVuaW0gYWQgbWluaW0gdmVuaWFtLCBxdWlzIG5vc3RydWQg ZXhlcmNpdGF0aW9uIHVsbGFtY28gbGFib3JpcyBuaXNpIHV0IGFsaXF1aXAgZXggZWEgY29tbW9k byBjb25zZXF1YXQuIER1aXMgYXV0ZSBpcnVyZSBkb2xvciBpbiByZXByZWhlbmRlcml0IGluIHZv bHVwdGF0ZSB2ZWxpdCBlc3NlIGNpbGx1bSBkb2xvcmUgZXUgZnVnaWF0IG51bGxhIHBhcmlhdHVy LiBFeGNlcHRldXIgc2ludCBvY2NhZWNhdCBjdXBpZGF0YXQgbm9uIHByb2lkZW50LCBzdW50IGlu IGN1bHBhIHF1aSBvZmZpY2lhIGRlc2VydW50IG1vbGxpdCBhbmltIGlkIGVzdCBsYWJvcnVtLjwv cD4KPHA+TG9yZW0gaXBzdW0gZG9sb3Igc2l0IGFtZXQsIGNvbnNlY3RldHVyIGFkaXBpc2ljaW5n IGVsaXQsIHNlZCBkbyBlaXVzbW9kIHRlbXBvciBpbmNpZGlkdW50IHV0IGxhYm9yZSBldCBkb2xv cmUgbWFnbmEgYWxpcXVhLiBVdCBlbmltIGFkIG1pbmltIHZlbmlhbSwgcXVpcyBub3N0cnVkIGV4 ZXJjaXRhdGlvbiB1bGxhbWNvIGxhYm9yaXMgbmlzaSB1dCBhbGlxdWlwIGV4IGVhIGNvbW1vZG8g Y29uc2VxdWF0LiBEdWlzIGF1dGUgaXJ1cmUgZG9sb3IgaW4gcmVwcmVoZW5kZXJpdCBpbiB2b2x1 cHRhdGUgdmVsaXQgZXNzZSBjaWxsdW0gZG9sb3JlIGV1IGZ1Z2lhdCBudWxsYSBwYXJpYXR1ci4g RXhjZXB0ZXVyIHNpbnQgb2NjYWVjYXQgY3VwaWRhdGF0IG5vbiBwcm9pZGVudCwgc3VudCBpbiBj dWxwYSBxdWkgb2ZmaWNpYSBkZXNlcnVudCBtb2xsaXQgYW5pbSBpZCBlc3QgbGFib3J1bS48L3A+ CjxwPkxvcmVtIGlwc3VtIGRvbG9yIHNpdCBhbWV0LCBjb25zZWN0ZXR1ciBhZGlwaXNpY2luZyBl bGl0LCBzZWQgZG8gZWl1c21vZCB0ZW1wb3IgaW5jaWRpZHVudCB1dCBsYWJvcmUgZXQgZG9sb3Jl IG1hZ25hIGFsaXF1YS4gVXQgZW5pbSBhZCBtaW5pbSB2ZW5pYW0sIHF1aXMgbm9zdHJ1ZCBleGVy Y2l0YXRpb24gdWxsYW1jbyBsYWJvcmlzIG5pc2kgdXQgYWxpcXVpcCBleCBlYSBjb21tb2RvIGNv bnNlcXVhdC4gRHVpcyBhdXRlIGlydXJlIGRvbG9yIGluIHJlcHJlaGVuZGVyaXQgaW4gdm9sdXB0 YXRlIHZlbGl0IGVzc2UgY2lsbHVtIGRvbG9yZSBldSBmdWdpYXQgbnVsbGEgcGFyaWF0dXIuIEV4 Y2VwdGV1ciBzaW50IG9jY2FlY2F0IGN1cGlkYXRhdCBub24gcHJvaWRlbnQsIHN1bnQgaW4gY3Vs cGEgcXVpIG9mZmljaWEgZGVzZXJ1bnQgbW9sbGl0IGFuaW0gaWQgZXN0IGxhYm9ydW0uPC9wPgo8 cD5Mb3JlbSBpcHN1bSBkb2xvciBzaXQgYW1ldCwgY29uc2VjdGV0dXIgYWRpcGlzaWNpbmcgZWxp dCwgc2VkIGRvIGVpdXNtb2QgdGVtcG9yIGluY2lkaWR1bnQgdXQgbGFib3JlIGV0IGRvbG9yZSBt YWduYSBhbGlxdWEuIFV0IGVuaW0gYWQgbWluaW0gdmVuaWFtLCBxdWlzIG5vc3RydWQgZXhlcmNp dGF0aW9uIHVsbGFtY28gbGFib3JpcyBuaXNpIHV0IGFsaXF1aXAgZXggZWEgY29tbW9kbyBjb25z ZXF1YXQuIER1aXMgYXV0ZSBpcnVyZSBkb2xvciBpbiByZXByZWhlbmRlcml0IGluIHZvbHVwdGF0 ZSB2ZWxpdCBlc3NlIGNpbGx1bSBkb2xvcmUgZXUgZnVnaWF0IG51bGxhIHBhcmlhdHVyLiBFeGNl cHRldXIgc2ludCBvY2NhZWNhdCBjdXBpZGF0YXQgbm9uIHByb2lkZW50LCBzdW50IGluIGN1bHBh IHF1aSBvZmZpY2lhIGRlc2VydW50IG1vbGxpdCBhbmltIGlkIGVzdCBsYWJvcnVtLjwvcD4KPHA+ TG9yZW0gaXBzdW0gZG9sb3Igc2l0IGFtZXQsIGNvbnNlY3RldHVyIGFkaXBpc2ljaW5nIGVsaXQs IHNlZCBkbyBlaXVzbW9kIHRlbXBvciBpbmNpZGlkdW50IHV0IGxhYm9yZSBldCBkb2xvcmUgbWFn bmEgYWxpcXVhLiBVdCBlbmltIGFkIG1pbmltIHZlbmlhbSwgcXVpcyBub3N0cnVkIGV4ZXJjaXRh dGlvbiB1bGxhbWNvIGxhYm9yaXMgbmlzaSB1dCBhbGlxdWlwIGV4IGVhIGNvbW1vZG8gY29uc2Vx dWF0LiBEdWlzIGF1dGUgaXJ1cmUgZG9sb3IgaW4gcmVwcmVoZW5kZXJpdCBpbiB2b2x1cHRhdGUg dmVsaXQgZXNzZSBjaWxsdW0gZG9sb3JlIGV1IGZ1Z2lhdCBudWxsYSBwYXJpYXR1ci4gRXhjZXB0 ZXVyIHNpbnQgb2NjYWVjYXQgY3VwaWRhdGF0IG5vbiBwcm9pZGVudCwgc3VudCBpbiBjdWxwYSBx dWkgb2ZmaWNpYSBkZXNlcnVudCBtb2xsaXQgYW5pbSBpZCBlc3QgbGFib3J1bS48L3A+CjwvZGl2 Pgo8L2JvZHk+Cg== 27948 2009-02-24 18:22:47 -0800 2009-02-24 18:36:50 -0800 patch boundingRect.diff text/plain 5453 sam SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MTIwNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDItMjQgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9y IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzk5MAorICAgICAgICBS ZWdyZXNzaW9uIChyNDA4MzcpOiBKYXZhU2NyaXB0IGltYWdlIHBvcHVwIGRvZXNuJ3Qgd29yawor CisgICAgICAgIE1ha2UgdGhlIGdldENsaWVudFJlY3RzIGFuZCBnZXRCb3VuZGluZ0NsaWVudFJl Y3QgbWV0aG9kcyByZXR1cm4gcmVjdHMKKyAgICAgICAgcmVsYXRpdmUgdG8gdGhlIHZpZXdwb3J0 LgorCisgICAgICAgIFRlc3Q6IGZhc3QvZG9tL2dldEJvdW5kaW5nQ2xpZW50UmVjdC1nZXRDbGll bnRSZWN0cy1yZWxhdGl2ZS10by12aWV3cG9ydC5odG1sCisKKyAgICAgICAgKiBkb20vRWxlbWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50OjpnZXRDbGllbnRSZWN0cyk6CisgICAg ICAgIChXZWJDb3JlOjpFbGVtZW50OjpnZXRCb3VuZGluZ0NsaWVudFJlY3QpOgorCiAyMDA5LTAy LTI0ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL2RvbS9FbGVtZW50LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkocmV2aXNpb24gNDExOTkpCisrKyBXZWJDb3Jl L2RvbS9FbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDMyLDYgKzQzMiwxMyBAQCBQYXNz UmVmUHRyPENsaWVudFJlY3RMaXN0PiBFbGVtZW50OjpnZXRDCiAKICAgICBWZWN0b3I8RmxvYXRR dWFkPiBxdWFkczsKICAgICByZW5kZXJCb3hNb2RlbE9iamVjdC0+YWJzb2x1dGVRdWFkcyhxdWFk cyk7CisKKyAgICBpZiAoRnJhbWVWaWV3KiB2aWV3ID0gZG9jdW1lbnQoKS0+dmlldygpKSB7Cisg ICAgICAgIEludFJlY3QgdmlzaWJsZUNvbnRlbnRSZWN0ID0gdmlldy0+dmlzaWJsZUNvbnRlbnRS ZWN0KCk7CisgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgcXVhZHMuc2l6ZSgpOyArK2kp CisgICAgICAgICAgICBxdWFkc1tpXS5tb3ZlKC12aXNpYmxlQ29udGVudFJlY3QueCgpLCAtdmlz aWJsZUNvbnRlbnRSZWN0LnkoKSk7CisgICAgfQorCiAgICAgcmV0dXJuIENsaWVudFJlY3RMaXN0 OjpjcmVhdGUocXVhZHMpOwogfQogCkBAIC00NTIsNiArNDU5LDExIEBAIFBhc3NSZWZQdHI8Q2xp ZW50UmVjdD4gRWxlbWVudDo6Z2V0Qm91bmQKICAgICBmb3IgKHNpemVfdCBpID0gMTsgaSA8IHF1 YWRzLnNpemUoKTsgKytpKQogICAgICAgICByZXN1bHQudW5pdGUocXVhZHNbaV0uZW5jbG9zaW5n Qm91bmRpbmdCb3goKSk7CiAKKyAgICBpZiAoRnJhbWVWaWV3KiB2aWV3ID0gZG9jdW1lbnQoKS0+ dmlldygpKSB7CisgICAgICAgIEludFJlY3QgdmlzaWJsZUNvbnRlbnRSZWN0ID0gdmlldy0+dmlz aWJsZUNvbnRlbnRSZWN0KCk7CisgICAgICAgIHJlc3VsdC5tb3ZlKC12aXNpYmxlQ29udGVudFJl Y3QueCgpLCAtdmlzaWJsZUNvbnRlbnRSZWN0LnkoKSk7CisgICAgfQorCiAgICAgcmV0dXJuIENs aWVudFJlY3Q6OmNyZWF0ZShyZXN1bHQpOwogfQogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA0MTIwNikK KysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDA5LTAyLTI0ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdCBmb3IgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzOTkwCisgICAgICAgIFJlZ3Jlc3Npb24gKHI0 MDgzNyk6IEphdmFTY3JpcHQgaW1hZ2UgcG9wdXAgZG9lc24ndCB3b3JrCisKKyAgICAgICAgKiBm YXN0L2RvbS9nZXRCb3VuZGluZ0NsaWVudFJlY3QtZ2V0Q2xpZW50UmVjdHMtcmVsYXRpdmUtdG8t dmlld3BvcnQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9nZXRCb3Vu ZGluZ0NsaWVudFJlY3QtZ2V0Q2xpZW50UmVjdHMtcmVsYXRpdmUtdG8tdmlld3BvcnQuaHRtbDog QWRkZWQuCisKIDIwMDktMDItMjQgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9nZXRCb3VuZGluZ0NsaWVudFJlY3QtZ2V0Q2xpZW50UmVjdHMtcmVsYXRpdmUtdG8tdmlld3Bv cnQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2dldEJv dW5kaW5nQ2xpZW50UmVjdC1nZXRDbGllbnRSZWN0cy1yZWxhdGl2ZS10by12aWV3cG9ydC1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9nZXRCb3VuZGlu Z0NsaWVudFJlY3QtZ2V0Q2xpZW50UmVjdHMtcmVsYXRpdmUtdG8tdmlld3BvcnQtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDggQEAKK1BBU1MgdW5TY3JvbGxlZEJvdW5kaW5n Qm94LnRvcCAtIHNjcm9sbGVkRG93bkJvdW5kaW5nQm94LnRvcCBpcyA1MAorUEFTUyB1blNjcm9s bGVkQm91bmRpbmdCb3hlc1swXS50b3AgLSBzY3JvbGxlZERvd25Cb3VuZGluZ0JveGVzWzBdLnRv cCBpcyA1MAorUEFTUyB1blNjcm9sbGVkQm91bmRpbmdCb3gubGVmdCAtIHNjcm9sbGVkUmlnaHRC b3VuZGluZ0JveC5sZWZ0IGlzIDUwCitQQVNTIHVuU2Nyb2xsZWRCb3VuZGluZ0JveGVzWzBdLmxl ZnQgLSBzY3JvbGxlZFJpZ2h0Qm91bmRpbmdCb3hlc1swXS5sZWZ0IGlzIDUwCitQQVNTIHN1Y2Nl c3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVz dHMvZmFzdC9kb20vZ2V0Qm91bmRpbmdDbGllbnRSZWN0LWdldENsaWVudFJlY3RzLXJlbGF0aXZl LXRvLXZpZXdwb3J0Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vZ2V0 Qm91bmRpbmdDbGllbnRSZWN0LWdldENsaWVudFJlY3RzLXJlbGF0aXZlLXRvLXZpZXdwb3J0Lmh0 bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9nZXRCb3VuZGluZ0NsaWVu dFJlY3QtZ2V0Q2xpZW50UmVjdHMtcmVsYXRpdmUtdG8tdmlld3BvcnQuaHRtbAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSw1NCBAQAorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi9qcy9y ZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNl cy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c3R5bGU+CisgICAgI3B1c2hlciB7CisgICAg ICAgIHdpZHRoOiAxMDAwcHg7CisgICAgICAgIGhlaWdodDogMTAwMHB4OworICAgICAgICBvdXRs aW5lOiAxcHggc29saWQgYmxhY2s7CisgICAgfQorPC9zdHlsZT4KKzxkaXYgaWQ9ImNvbnNvbGUi PjwvZGl2PgorPGRpdiBpZD0idGVzdEFyZWEiPgorICAgIDxicj4KKyAgICA8cCBpZD0idGVzdCI+ VGVzdCBjb250ZW50PC9wPgorICAgIDxkaXYgaWQ9InB1c2hlciI+VGhpcyBib3ggaXMgaGVyZSB0 byBjcmVhdGUgc2Nyb2xsYmFycy48L2Rpdj4KKzwvZGl2PgorPHNjcmlwdD4KKyAgICBpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5k dW1wQXNUZXh0KCk7CisKKyAgICB2YXIgZWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCd0ZXN0Jyk7CisKKyAgICAvLyBHZXQgYmFzZSBudW1iZXJzCisgICAgdmFyIHVuU2Nyb2xsZWRC b3VuZGluZ0JveCA9IGVsZW1lbnQuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCk7CisgICAgdmFyIHVu U2Nyb2xsZWRCb3VuZGluZ0JveGVzID0gZWxlbWVudC5nZXRDbGllbnRSZWN0cygpOworCisgICAg Ly8gVGVzdCBzY3JvbGxpbmcgZG93bgorICAgIHdpbmRvdy5zY3JvbGxCeSgwLCA1MCk7CisgICAg dmFyIHNjcm9sbGVkRG93bkJvdW5kaW5nQm94ID0gZWxlbWVudC5nZXRCb3VuZGluZ0NsaWVudFJl Y3QoKTsKKyAgICB2YXIgc2Nyb2xsZWREb3duQm91bmRpbmdCb3hlcyA9IGVsZW1lbnQuZ2V0Q2xp ZW50UmVjdHMoKTsKKworICAgIC8vIFJlc2V0CisgICAgd2luZG93LnNjcm9sbFRvKDAsIDApOwor CisgICAgLy8gVGVzdCBzY3JvbGxpbmcgcmlnaHQKKyAgICB3aW5kb3cuc2Nyb2xsQnkoNTAsIDAp OworICAgIHZhciBzY3JvbGxlZFJpZ2h0Qm91bmRpbmdCb3ggPSBlbGVtZW50LmdldEJvdW5kaW5n Q2xpZW50UmVjdCgpOworICAgIHZhciBzY3JvbGxlZFJpZ2h0Qm91bmRpbmdCb3hlcyA9IGVsZW1l bnQuZ2V0Q2xpZW50UmVjdHMoKTsKKworICAgIC8vIFJlc2V0CisgICAgd2luZG93LnNjcm9sbFRv KDAsIDApOworCisgICAgc2hvdWxkQmUoInVuU2Nyb2xsZWRCb3VuZGluZ0JveC50b3AgLSBzY3Jv bGxlZERvd25Cb3VuZGluZ0JveC50b3AiLCAiNTAiKTsKKyAgICBzaG91bGRCZSgidW5TY3JvbGxl ZEJvdW5kaW5nQm94ZXNbMF0udG9wIC0gc2Nyb2xsZWREb3duQm91bmRpbmdCb3hlc1swXS50b3Ai LCAiNTAiKTsKKyAgICBzaG91bGRCZSgidW5TY3JvbGxlZEJvdW5kaW5nQm94LmxlZnQgLSBzY3Jv bGxlZFJpZ2h0Qm91bmRpbmdCb3gubGVmdCIsICI1MCIpOworICAgIHNob3VsZEJlKCJ1blNjcm9s bGVkQm91bmRpbmdCb3hlc1swXS5sZWZ0IC0gc2Nyb2xsZWRSaWdodEJvdW5kaW5nQm94ZXNbMF0u bGVmdCIsICI1MCIpOworCisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewor ICAgICAgICB2YXIgYXJlYSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0ZXN0QXJlYScpOwor ICAgICAgICBhcmVhLnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQoYXJlYSk7CisgICAgfQorCisgICAg c3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pz L3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0Pgo=