239877 2022-04-28 17:05:58 -0700 [LBSE] ENABLE_LAYER_BASED_SVG_ENGINE needs to match for iOS and macOS 2022-05-18 04:24:27 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=233211 InRadar P2 Normal --- 90738 1 simon.fraser zimmermann benjamin cdumez changseok cmarcelo esprehn+autocc ews-watchlist glenn kondapallykalyan pdr sabouhallawa simon.fraser webkit-bug-importer zimmermann oldest_to_newest 1865295 0 simon.fraser 2022-04-28 17:05:58 -0700 https://trac.webkit.org/changeset/286204/webkit added: #if !defined(ENABLE_LAYER_BASED_SVG_ENGINE) && PLATFORM(MAC) #define ENABLE_LAYER_BASED_SVG_ENGINE 1 #endif We don't want the value of ENABLE_LAYER_BASED_SVG_ENGINE to differ between macOS and iOS. For testing and performance consistency, it has to be the same for all Cocoa platforms. 1866970 1 zimmermann 2022-05-05 13:32:22 -0700 I was not aware of that. Shall I prepare a fix? 1866993 2 simon.fraser 2022-05-05 14:24:28 -0700 Please do. 1867049 3 webkit-bug-importer 2022-05-05 17:06:13 -0700 <rdar://problem/92829309> 1867130 4 458939 zimmermann 2022-05-06 01:26:15 -0700 Created attachment 458939 Patch, v1 1869189 5 459414 zimmermann 2022-05-16 04:25:31 -0700 Created attachment 459414 Patch, v2 1869940 6 459414 zimmermann 2022-05-18 01:31:18 -0700 Comment on attachment 459414 Patch, v2 Let's see if cq can process this even with the ChangeLog changes... 1869956 7 459535 zimmermann 2022-05-18 04:16:00 -0700 Created attachment 459535 [fast-cq] Patch, v3 (removed ChangeLogs for landing) 1869957 8 ews-feeder 2022-05-18 04:24:23 -0700 Committed r294389 (250684@main): <https://commits.webkit.org/250684@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 459535. 458939 2022-05-06 01:26:15 -0700 2022-05-16 04:25:27 -0700 Patch, v1 bug-239877-20220506012614.patch text/plain 1218 zimmermann U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzODgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDQyZDBkMGQ0NTc3ZGNkYzAwM2VmYjJj OWIxYmE1OWUyNjExYzJjMzEuLjU3ZDcyZDhkMTEyZDZlZmE1NDJjZjZkM2EwZmNiYTVjMGMyZTk2 NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDUtMDYgIE5pa29sYXMgWmltbWVybWFubiAg PG56aW1tZXJtYW5uQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0xCU0VdIEVOQUJMRV9MQVlFUl9C QVNFRF9TVkdfRU5HSU5FIG5lZWRzIHRvIG1hdGNoIGZvciBpT1MgYW5kIG1hY09TCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzk4NzcKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzkyODI5MzA5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFVuaWZ5IExCU0UgZGVmYXVsdHMgZm9yIGFsbCBDb2NvYSBwbGF0 Zm9ybXMuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm1FbmFibGVDb2NvYS5oOgorCiAyMDIyLTA1 LTA1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgSWRlbnRpZmll cjo6c3RyaW5nKCkgc2hvdWxkIHJldHVybiBhbiBBdG9tU3RyaW5nCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9QbGF0Zm9ybUVuYWJsZUNvY29hLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9y bUVuYWJsZUNvY29hLmgKaW5kZXggYjBkMjc1OWZhZjEzOWY0MTZkNDQxYjY3M2IxOWJmZTNjYmY2 MzhkYS4uYWI5MmQxODQ1MGVkMjA3MTdjNWQ5YWM2ZmZhNzI1MjRlOTdlMjA4MCAxMDA2NDQKLS0t IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1FbmFibGVDb2NvYS5oCisrKyBiL1NvdXJjZS9XVEYv d3RmL1BsYXRmb3JtRW5hYmxlQ29jb2EuaApAQCAtMzQwLDcgKzM0MCw3IEBACiAjZGVmaW5lIEVO QUJMRV9JT1NfVE9VQ0hfRVZFTlRTIDEKICNlbmRpZgogCi0jaWYgIWRlZmluZWQoRU5BQkxFX0xB WUVSX0JBU0VEX1NWR19FTkdJTkUpICYmIFBMQVRGT1JNKE1BQykKKyNpZiAhZGVmaW5lZChFTkFC TEVfTEFZRVJfQkFTRURfU1ZHX0VOR0lORSkKICNkZWZpbmUgRU5BQkxFX0xBWUVSX0JBU0VEX1NW R19FTkdJTkUgMQogI2VuZGlmCiAK 459414 2022-05-16 04:25:31 -0700 2022-05-18 04:06:27 -0700 Patch, v2 bug-239877-20220516042522.patch text/plain 3529 zimmermann RnJvbSBmYzg2MGYyMjA3YmJmN2FhNzJmMjNlN2EzY2I5YTIyNzgyODc1NThjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWtvbGFzIFppbW1lcm1hbm4gPG56aW1tZXJtYW5uQGlnYWxp YS5jb20+CkRhdGU6IEZyaSwgNiBNYXkgMjAyMiAwMToyNToxNSAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIFtMQlNFXSBFTkFCTEVfTEFZRVJfQkFTRURfU1ZHX0VOR0lORSBuZWVkcyB0byBtYXRjaCBm b3IgaU9TCiBhbmQgbWFjT1MgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzOTg3NwogPHJkYXI6Ly9wcm9ibGVtLzkyODI5MzA5PgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCgpTb3VyY2UvV2ViQ29yZToKCmhhc1RyYW5zZm9ybSgpIG5vdyBuZWVkcyBoYXNTVkdU cmFuc2Zvcm0oKSwgd2hlbiBpbiB0dXJuIHVzZXMgcmFyZURhdGEoKSwgd2hpY2gKaXMgbm90IGV4 cG9ydGVkIGJ5IFdlYkNvcmUgYXQgcHJlc2VudCBicmVha2luZyB0dk9TL3dhdGNoT1MvaU9TIGJ1 aWxkcywgZml4IHRoYXQuCgpDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLCBubyBjaGFuZ2UgaW4g YmVoYXZpb3VyLgoKKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0Lmg6CgpTb3VyY2UvV1RGOgoKVW5p ZnkgTEJTRSBkZWZhdWx0cyBmb3IgYWxsIENvY29hIHBsYXRmb3Jtcy4KCiogd3RmL1BsYXRmb3Jt RW5hYmxlQ29jb2EuaDoKLS0tCiBTb3VyY2UvV1RGL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg ICAgfCAxMiArKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICB8IDE1ICsrKysrKysrKysrKysrKwogU291cmNlL1dURi93dGYvUGxhdGZvcm1FbmFibGVD b2NvYS5oICAgIHwgIDIgKy0KIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3Qu aCB8ICAyICstCiA0IGZpbGVzIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5n ZUxvZwppbmRleCBlYTQ1ODQxYzRjOGMuLjdjODRmYzdkMDRkOSAxMDA2NDQKLS0tIGEvU291cmNl L1dURi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBA QAorMjAyMi0wNS0xNiAgTmlrb2xhcyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5AaWdhbGlhLmNv bT4KKworICAgICAgICBbTEJTRV0gRU5BQkxFX0xBWUVSX0JBU0VEX1NWR19FTkdJTkUgbmVlZHMg dG8gbWF0Y2ggZm9yIGlPUyBhbmQgbWFjT1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzOTg3NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTI4Mjkz MDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5p ZnkgTEJTRSBkZWZhdWx0cyBmb3IgYWxsIENvY29hIHBsYXRmb3Jtcy4KKworICAgICAgICAqIHd0 Zi9QbGF0Zm9ybUVuYWJsZUNvY29hLmg6CisKIDIwMjItMDUtMTUgIFdlbnNvbiBIc2llaCAgPHdl bnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmlnaHQgY2xpY2sgPiAiT3BlbiBMaW5r IiBzaG91bGQgdHJpZ2dlciBhIG5hdmlnYXRpb24gYWN0aW9uIHdpdGggV0tOYXZpZ2F0aW9uVHlw ZUxpbmtBY3RpdmF0ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMTI1NmNmZWM3MWMuLmE1ZDA2NmVlYjU5NiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTA1LTE2ICBOaWtvbGFzIFppbW1lcm1h bm4gIDxuemltbWVybWFubkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtMQlNFXSBFTkFCTEVfTEFZ RVJfQkFTRURfU1ZHX0VOR0lORSBuZWVkcyB0byBtYXRjaCBmb3IgaU9TIGFuZCBtYWNPUworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM5ODc3CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS85MjgyOTMwOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBoYXNUcmFuc2Zvcm0oKSBub3cgbmVlZHMgaGFzU1ZHVHJh bnNmb3JtKCksIHdoZW4gaW4gdHVybiB1c2VzIHJhcmVEYXRhKCksIHdoaWNoCisgICAgICAgIGlz IG5vdCBleHBvcnRlZCBieSBXZWJDb3JlIGF0IHByZXNlbnQgYnJlYWtpbmcgdHZPUy93YXRjaE9T L2lPUyBidWlsZHMsIGZpeCB0aGF0LgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVz dHMsIG5vIGNoYW5nZSBpbiBiZWhhdmlvdXIuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy T2JqZWN0Lmg6CisKIDIwMjItMDUtMTYgIE5pa29sYXMgWmltbWVybWFubiAgPG56aW1tZXJtYW5u QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0xCU0VdIEFjdGl2YXRlIHRleHQgcmVuZGVyaW5nLCBi eSByZS11c2luZyBSZW5kZXJTVkdUZXh0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0 Zm9ybUVuYWJsZUNvY29hLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUVuYWJsZUNvY29hLmgK aW5kZXggYjBkMjc1OWZhZjEzLi5hYjkyZDE4NDUwZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv d3RmL1BsYXRmb3JtRW5hYmxlQ29jb2EuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUVu YWJsZUNvY29hLmgKQEAgLTM0MCw3ICszNDAsNyBAQAogI2RlZmluZSBFTkFCTEVfSU9TX1RPVUNI X0VWRU5UUyAxCiAjZW5kaWYKIAotI2lmICFkZWZpbmVkKEVOQUJMRV9MQVlFUl9CQVNFRF9TVkdf RU5HSU5FKSAmJiBQTEFURk9STShNQUMpCisjaWYgIWRlZmluZWQoRU5BQkxFX0xBWUVSX0JBU0VE X1NWR19FTkdJTkUpCiAjZGVmaW5lIEVOQUJMRV9MQVlFUl9CQVNFRF9TVkdfRU5HSU5FIDEKICNl bmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKaW5kZXggNmI1Mzdi Y2U4YWRjLi4xM2JmMmMzYWNhZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJPYmplY3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2Jq ZWN0LmgKQEAgLTk3NSw3ICs5NzUsNyBAQCBwcml2YXRlOgogICAgICAgICBXZWFrUHRyPFJlbmRl ckJsb2NrRmxvdz4gYmFja2Ryb3BSZW5kZXJlcjsKICAgICB9OwogICAgIAotICAgIGNvbnN0IFJl bmRlck9iamVjdDo6UmVuZGVyT2JqZWN0UmFyZURhdGEmIHJhcmVEYXRhKCkgY29uc3Q7CisgICAg V0VCQ09SRV9FWFBPUlQgY29uc3QgUmVuZGVyT2JqZWN0OjpSZW5kZXJPYmplY3RSYXJlRGF0YSYg cmFyZURhdGEoKSBjb25zdDsKICAgICBSZW5kZXJPYmplY3RSYXJlRGF0YSYgZW5zdXJlUmFyZURh dGEoKTsKICAgICB2b2lkIHJlbW92ZVJhcmVEYXRhKCk7CiAgICAgCi0tIAoyLjM1LjEKCg== 459535 2022-05-18 04:16:00 -0700 2022-05-18 04:24:25 -0700 [fast-cq] Patch, v3 (removed ChangeLogs for landing) bug-239877-20220518041559.patch text/plain 1912 zimmermann RnJvbSA1NTJmNDM3YjM5Njc0N2NkYzA1YzE1OGI5ZDBkNWQ0YjhlOWU1ZGVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWtvbGFzIFppbW1lcm1hbm4gPG56aW1tZXJtYW5uQGlnYWxp YS5jb20+CkRhdGU6IFdlZCwgMTggTWF5IDIwMjIgMDQ6MTE6MjcgLTA3MDAKU3ViamVjdDogW1BB VENIXSBbTEJTRV0gRU5BQkxFX0xBWUVSX0JBU0VEX1NWR19FTkdJTkUgbmVlZHMgdG8gbWF0Y2gg Zm9yIGlPUwogYW5kIG1hY09TIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMzk4NzcKIDxyZGFyOi8vcHJvYmxlbS85MjgyOTMwOT4KClJldmlld2VkIGJ5IFNpbW9uIEZy YXNlci4KClN3aXRjaCBvbiBFTkFCTEVfTEFZRVJfQkFTRURfU1ZHX0VOR0lORSBmb3IgYWxsIENv Y29hIGJhc2VkIHBsYXRmb3Jtcy4KClRoaXMgb25seSB3b3JrcyBhZnRlciBmaXhpbmcgb25lIGJ1 aWxkIGlzc3VlOgpoYXNUcmFuc2Zvcm0oKSBub3cgbmVlZHMgaGFzU1ZHVHJhbnNmb3JtKCksIHdo ZW4gaW4gdHVybiB1c2VzIHJhcmVEYXRhKCksIHdoaWNoCmlzIG5vdCBleHBvcnRlZCBieSBXZWJD b3JlIGF0IHByZXNlbnQgYnJlYWtpbmcgdHZPUy93YXRjaE9TL2lPUyBidWlsZHMsIGZpeCB0aGF0 LgoKQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cywgbm8gY2hhbmdlIGluIGJlaGF2aW91ci4KCiog U291cmNlL1dURi93dGYvUGxhdGZvcm1FbmFibGVDb2NvYS5oOgoqIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJPYmplY3QuaDoKLS0tCiBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUVuYWJs ZUNvY29hLmggICAgfCAyICstCiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmggfCAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUVuYWJsZUNvY29hLmggYi9T b3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUVuYWJsZUNvY29hLmgKaW5kZXggYzQwMGJlY2FmYzgzLi5j YTNhMTYzYTk1NzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtRW5hYmxlQ29j b2EuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUVuYWJsZUNvY29hLmgKQEAgLTM0MCw3 ICszNDAsNyBAQAogI2RlZmluZSBFTkFCTEVfSU9TX1RPVUNIX0VWRU5UUyAxCiAjZW5kaWYKIAot I2lmICFkZWZpbmVkKEVOQUJMRV9MQVlFUl9CQVNFRF9TVkdfRU5HSU5FKSAmJiBQTEFURk9STShN QUMpCisjaWYgIWRlZmluZWQoRU5BQkxFX0xBWUVSX0JBU0VEX1NWR19FTkdJTkUpCiAjZGVmaW5l IEVOQUJMRV9MQVlFUl9CQVNFRF9TVkdfRU5HSU5FIDEKICNlbmRpZgogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmggYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKaW5kZXggNmI1MzdiY2U4YWRjLi4xM2JmMmMzYWNhZWQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKQEAgLTk3NSw3ICs5NzUs NyBAQCBwcml2YXRlOgogICAgICAgICBXZWFrUHRyPFJlbmRlckJsb2NrRmxvdz4gYmFja2Ryb3BS ZW5kZXJlcjsKICAgICB9OwogICAgIAotICAgIGNvbnN0IFJlbmRlck9iamVjdDo6UmVuZGVyT2Jq ZWN0UmFyZURhdGEmIHJhcmVEYXRhKCkgY29uc3Q7CisgICAgV0VCQ09SRV9FWFBPUlQgY29uc3Qg UmVuZGVyT2JqZWN0OjpSZW5kZXJPYmplY3RSYXJlRGF0YSYgcmFyZURhdGEoKSBjb25zdDsKICAg ICBSZW5kZXJPYmplY3RSYXJlRGF0YSYgZW5zdXJlUmFyZURhdGEoKTsKICAgICB2b2lkIHJlbW92 ZVJhcmVEYXRhKCk7CiAgICAgCi0tIAoyLjM1LjEKCg==