239867 2022-04-28 13:26:00 -0700 REGRESSION (249864@main): [ iOS ] TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndShrunkUI is failing 2022-04-29 12:26:43 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsavell simon.fraser hi kkinnunen sam simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1865239 0 tsavell 2022-04-28 13:26:00 -0700 TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndShrunkUI This test is a constant failure on iOS. this began with the changes in https://github.com/WebKit/WebKit/commit/681a897dc791f36df24e247cd4f466da669a0052 according to history. History: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndShrunkUI Diff: /Volumes/Data/worker/Apple-iOS-15-Simulator-Release-Build/build/Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:141 Expected equality of these values: [[webView scrollView] isScrollEnabled] Which is: false __objc_yes Which is: true 1865240 1 webkit-bug-importer 2022-04-28 13:26:19 -0700 <rdar://problem/92483866> 1865337 2 simon.fraser 2022-04-28 20:50:19 -0700 I think this might be because I wrote the tests to work in the iPhone 12 simulator but we run them in the iPhone 8 simulator 1865348 3 458569 simon.fraser 2022-04-28 21:37:45 -0700 Created attachment 458569 Patch 1865461 4 458569 sam 2022-04-29 10:26:21 -0700 Comment on attachment 458569 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458569&action=review > Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:127 > + auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, viewHeight, 375)]); Probably worth a comment about where the value comes from. > Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:137 > + [webView _overrideLayoutParametersWithMinimumLayoutSize:CGSizeMake(viewHeight, 325) maximumUnobscuredSizeOverride:CGSizeMake(viewHeight, 375)]; Probably worth a comment about where the value comes from. 1865465 5 458593 simon.fraser 2022-04-29 10:35:49 -0700 Created attachment 458593 Patch 1865499 6 ews-feeder 2022-04-29 12:26:40 -0700 Committed r293626 (250132@main): <https://commits.webkit.org/250132@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458593. 458569 2022-04-28 21:37:45 -0700 2022-04-29 10:26:21 -0700 Patch bug-239867-20220428213744.patch text/plain 2307 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNTcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDY0N2ViYzYxZGEyYjI1N2U2NWU5NDM1ODU3Njk1M2Ey NjEwYTIzMy4uY2U0YjZkOTIwODE0YzU1Zjk0MmI2ZGY3ZmM4YWY0ZGQ0M2JkYWZiMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIyLTA0LTI4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIFJFR1JFU1NJT04gKDI0OTg2NEBtYWluKTogWyBpT1MgXSBUZXN0V2ViS2l0QVBJ LlNjcm9sbFZpZXdTY3JvbGxhYmlsaXR5VGVzdHMuU2Nyb2xsYWJsZVdpdGhPdmVyZmxvd0hpZGRl bkFuZFNocnVua1VJIGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIzOTg2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVzZSB2YWx1ZXMgdGhhdCBhcmUgcmVwcmVzZW50YXRpdmUgb2YgaVBo b25lIDgsIHdoaWNoIGlzIHRoZSBtb2RlbCB1c2VkIGZvciBydW5uaW5nCisgICAgICAgIEFQSSB0 ZXN0cy4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL1Njcm9sbFZpZXdTY3Jv bGxhYmlsaXR5VGVzdHMubW06CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAy Mi0wNC0yOCAgS2ltbW8gS2lubnVuZW4gIDxra2lubnVuZW5AYXBwbGUuY29tPgogCiAgICAgICAg IHRlc3Qtd2Via2l0cGVybCBvdXRwdXRzIGVycm9ycyBhYm91dCB1bmluaXRpYWxpemVkICRwbGF0 Zm9ybSB2YXJpYWJsZQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3Mv U2Nyb2xsVmlld1Njcm9sbGFiaWxpdHlUZXN0cy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvaW9zL1Njcm9sbFZpZXdTY3JvbGxhYmlsaXR5VGVzdHMubW0KaW5kZXggYzQ1NWY1MWIzNTI5 YTE1N2FjNTdiOWY0M2U4N2U4ZjAxYTAxMjdlZC4uYjRlZTRkZDUyNjdmZTE3MTM0MzEwZGJkOWY1 YzFhZGNmZGVkYzc3MCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3Mv U2Nyb2xsVmlld1Njcm9sbGFiaWxpdHlUZXN0cy5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL2lvcy9TY3JvbGxWaWV3U2Nyb2xsYWJpbGl0eVRlc3RzLm1tCkBAIC0xMjQsNyArMTI0 LDcgQEAgVEVTVChTY3JvbGxWaWV3U2Nyb2xsYWJpbGl0eVRlc3RzLCBTY3JvbGxhYmxlV2l0aE92 ZXJmbG93SGlkZGVuQW5kVmlzaWJsZVVJKQogCiBURVNUKFNjcm9sbFZpZXdTY3JvbGxhYmlsaXR5 VGVzdHMsIFNjcm9sbGFibGVXaXRoT3ZlcmZsb3dIaWRkZW5BbmRTaHJ1bmtVSSkKIHsKLSAgICBh dXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFt ZTpDR1JlY3RNYWtlKDAsIDAsIHZpZXdIZWlnaHQsIDQxNCldKTsKKyAgICBhdXRvIHdlYlZpZXcg PSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpDR1JlY3RNYWtl KDAsIDAsIHZpZXdIZWlnaHQsIDM3NSldKTsKIAogICAgIC8vIFNpbXVsYXRlIGxhbmRzY2FwZSBw aG9uZSB3aXRoIGhpZGRlbiBiYXJzLgogICAgIFVJRWRnZUluc2V0cyBvYnNjdXJlZEluc2V0czsK QEAgLTEzNCw3ICsxMzQsNyBAQCBURVNUKFNjcm9sbFZpZXdTY3JvbGxhYmlsaXR5VGVzdHMsIFNj cm9sbGFibGVXaXRoT3ZlcmZsb3dIaWRkZW5BbmRTaHJ1bmtVSSkKICAgICBvYnNjdXJlZEluc2V0 cy5yaWdodCA9IDA7CiAKICAgICBbd2ViVmlldyBfc2V0T2JzY3VyZWRJbnNldHM6b2JzY3VyZWRJ bnNldHNdOwotICAgIFt3ZWJWaWV3IF9vdmVycmlkZUxheW91dFBhcmFtZXRlcnNXaXRoTWluaW11 bUxheW91dFNpemU6Q0dTaXplTWFrZSh2aWV3SGVpZ2h0LCA0MTQpIG1heGltdW1Vbm9ic2N1cmVk U2l6ZU92ZXJyaWRlOkNHU2l6ZU1ha2Uodmlld0hlaWdodCwgNDE0KV07CisgICAgW3dlYlZpZXcg X292ZXJyaWRlTGF5b3V0UGFyYW1ldGVyc1dpdGhNaW5pbXVtTGF5b3V0U2l6ZTpDR1NpemVNYWtl KHZpZXdIZWlnaHQsIDMyNSkgbWF4aW11bVVub2JzY3VyZWRTaXplT3ZlcnJpZGU6Q0dTaXplTWFr ZSh2aWV3SGVpZ2h0LCAzNzUpXTsKIAogICAgIFt3ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2FkSFRN TFN0cmluZzpub25TY3JvbGxhYmxlRG9jdW1lbnRNYXJrdXBdOwogICAgIFt3ZWJWaWV3IHdhaXRG b3JOZXh0UHJlc2VudGF0aW9uVXBkYXRlXTsK 458593 2022-04-29 10:35:49 -0700 2022-04-29 12:26:41 -0700 Patch bug-239867-20220429103548.patch text/plain 2432 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNTcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDY0N2ViYzYxZGEyYjI1N2U2NWU5NDM1ODU3Njk1M2Ey NjEwYTIzMy4uYmQ0M2IzZGMxNTA5YzYwNWU5Y2JhZDdiMTVkM2I5YmUzYjYxZDhkYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIyLTA0LTI4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIFJFR1JFU1NJT04gKDI0OTg2NEBtYWluKTogWyBpT1MgXSBUZXN0V2ViS2l0QVBJ LlNjcm9sbFZpZXdTY3JvbGxhYmlsaXR5VGVzdHMuU2Nyb2xsYWJsZVdpdGhPdmVyZmxvd0hpZGRl bkFuZFNocnVua1VJIGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIzOTg2NworCisgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcu CisKKyAgICAgICAgVXNlIHZhbHVlcyB0aGF0IGFyZSByZXByZXNlbnRhdGl2ZSBvZiBpUGhvbmUg OCwgd2hpY2ggaXMgdGhlIG1vZGVsIHVzZWQgZm9yIHJ1bm5pbmcKKyAgICAgICAgQVBJIHRlc3Rz LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvU2Nyb2xsVmlld1Njcm9sbGFi aWxpdHlUZXN0cy5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDIyLTA0 LTI4ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CiAKICAgICAgICAgdGVz dC13ZWJraXRwZXJsIG91dHB1dHMgZXJyb3JzIGFib3V0IHVuaW5pdGlhbGl6ZWQgJHBsYXRmb3Jt IHZhcmlhYmxlCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9TY3Jv bGxWaWV3U2Nyb2xsYWJpbGl0eVRlc3RzLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9p b3MvU2Nyb2xsVmlld1Njcm9sbGFiaWxpdHlUZXN0cy5tbQppbmRleCBjNDU1ZjUxYjM1MjlhMTU3 YWM1N2I5ZjQzZTg3ZThmMDFhMDEyN2VkLi5mZDQ5ZTBkODlhNjM3Mzg1OGFlNjRlNWQ0NGVlYTJj NGNmMDI2ZDIxIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9TY3Jv bGxWaWV3U2Nyb2xsYWJpbGl0eVRlc3RzLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvaW9zL1Njcm9sbFZpZXdTY3JvbGxhYmlsaXR5VGVzdHMubW0KQEAgLTEyNCw5ICsxMjQsOSBA QCBURVNUKFNjcm9sbFZpZXdTY3JvbGxhYmlsaXR5VGVzdHMsIFNjcm9sbGFibGVXaXRoT3ZlcmZs b3dIaWRkZW5BbmRWaXNpYmxlVUkpCiAKIFRFU1QoU2Nyb2xsVmlld1Njcm9sbGFiaWxpdHlUZXN0 cywgU2Nyb2xsYWJsZVdpdGhPdmVyZmxvd0hpZGRlbkFuZFNocnVua1VJKQogewotICAgIGF1dG8g d2ViVmlldyA9IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNH UmVjdE1ha2UoMCwgMCwgdmlld0hlaWdodCwgNDE0KV0pOworICAgIGF1dG8gd2ViVmlldyA9IGFk b3B0TlMoW1tUZXN0V0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNHUmVjdE1ha2UoMCwg MCwgdmlld0hlaWdodCwgMzc1KV0pOwogCi0gICAgLy8gU2ltdWxhdGUgbGFuZHNjYXBlIHBob25l IHdpdGggaGlkZGVuIGJhcnMuCisgICAgLy8gU2ltdWxhdGUgTW9iaWxlU2FmYXJpIG9uIGxhbmRz Y2FwZSBpUGhvbmUgOCB3aXRoIGhpZGRlbiBiYXJzLgogICAgIFVJRWRnZUluc2V0cyBvYnNjdXJl ZEluc2V0czsKICAgICBvYnNjdXJlZEluc2V0cy50b3AgPSAwOwogICAgIG9ic2N1cmVkSW5zZXRz LmxlZnQgPSAwOwpAQCAtMTM0LDcgKzEzNCw3IEBAIFRFU1QoU2Nyb2xsVmlld1Njcm9sbGFiaWxp dHlUZXN0cywgU2Nyb2xsYWJsZVdpdGhPdmVyZmxvd0hpZGRlbkFuZFNocnVua1VJKQogICAgIG9i c2N1cmVkSW5zZXRzLnJpZ2h0ID0gMDsKIAogICAgIFt3ZWJWaWV3IF9zZXRPYnNjdXJlZEluc2V0 czpvYnNjdXJlZEluc2V0c107Ci0gICAgW3dlYlZpZXcgX292ZXJyaWRlTGF5b3V0UGFyYW1ldGVy c1dpdGhNaW5pbXVtTGF5b3V0U2l6ZTpDR1NpemVNYWtlKHZpZXdIZWlnaHQsIDQxNCkgbWF4aW11 bVVub2JzY3VyZWRTaXplT3ZlcnJpZGU6Q0dTaXplTWFrZSh2aWV3SGVpZ2h0LCA0MTQpXTsKKyAg ICBbd2ViVmlldyBfb3ZlcnJpZGVMYXlvdXRQYXJhbWV0ZXJzV2l0aE1pbmltdW1MYXlvdXRTaXpl OkNHU2l6ZU1ha2Uodmlld0hlaWdodCwgMzI1KSBtYXhpbXVtVW5vYnNjdXJlZFNpemVPdmVycmlk ZTpDR1NpemVNYWtlKHZpZXdIZWlnaHQsIDM3NSldOwogCiAgICAgW3dlYlZpZXcgc3luY2hyb25v dXNseUxvYWRIVE1MU3RyaW5nOm5vblNjcm9sbGFibGVEb2N1bWVudE1hcmt1cF07CiAgICAgW3dl YlZpZXcgd2FpdEZvck5leHRQcmVzZW50YXRpb25VcGRhdGVdOwo=