<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>239851</bug_id>
          
          <creation_ts>2022-04-28 08:44:08 -0700</creation_ts>
          <short_desc>Merge-queue error message about missing user permissions from contributors.json should indicate how to fix it</short_desc>
          <delta_ts>2022-04-28 09:22:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Aakash Jain">aakash_jain</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1865152</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2022-04-28 08:44:08 -0700</bug_when>
    <thetext>Merge-queue error message about missing user permissions from contributors.json should indicate how to fix it.

Currently it just posts an error like: &quot;@xyz does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.&quot;. This isn&apos;t very clear for the people who indeed have that permission as per contributors.json, but who haven&apos;t added their GitHub username to contributors.json.

The error message should clearly indicate how to fix it (which is to add github username to contributors.json).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1865154</commentid>
    <comment_count>1</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2022-04-28 08:46:29 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/425</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1865162</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2022-04-28 09:21:02 -0700</bug_when>
    <thetext>Committed r293573 (250087@main): &lt;https://commits.webkit.org/250087@main&gt;

Reviewed commits have been landed. Closing PR #425 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1865163</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-04-28 09:22:14 -0700</bug_when>
    <thetext>&lt;rdar://problem/92467180&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>