239847 2022-04-28 05:39:44 -0700 Make sure to fail importScripts as per https://w3c.github.io/ServiceWorker/#importscripts step 4 2022-04-29 00:16:13 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen cdumez webkit-bug-importer oldest_to_newest 1865124 0 youennf 2022-04-28 05:39:44 -0700 Make sure to fail importScripts as per https://w3c.github.io/ServiceWorker/#importscripts step 4 1865127 1 458519 youennf 2022-04-28 05:41:45 -0700 Created attachment 458519 Patch 1865199 2 458519 cdumez 2022-04-28 10:58:00 -0700 Comment on attachment 458519 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458519&action=review r=me > Source/WebCore/workers/WorkerScriptLoader.cpp:85 > + auto* serviceWorkerGlobalScope = dynamicDowncast<ServiceWorkerGlobalScope>(workerGlobalScope); Would be nice to reduce scoping and do this in the if condition: `if (auto* serviceWorkerGlobalScope = dynamicDowncast<ServiceWorkerGlobalScope>(workerGlobalScope))` 1865362 3 458519 youennf 2022-04-28 23:34:19 -0700 Comment on attachment 458519 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458519&action=review >> Source/WebCore/workers/WorkerScriptLoader.cpp:85 >> + auto* serviceWorkerGlobalScope = dynamicDowncast<ServiceWorkerGlobalScope>(workerGlobalScope); > > Would be nice to reduce scoping and do this in the if condition: > `if (auto* serviceWorkerGlobalScope = dynamicDowncast<ServiceWorkerGlobalScope>(workerGlobalScope))` serviceWorkerGlobalScope is reused below, and it seems a tad better to have a wider scope instead of two casts. 1865367 4 ews-feeder 2022-04-29 00:15:39 -0700 Committed r293607 (250113@main): <https://commits.webkit.org/250113@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458519. 1865368 5 webkit-bug-importer 2022-04-29 00:16:13 -0700 <rdar://problem/92510321> 458519 2022-04-28 05:41:45 -0700 2022-04-29 00:15:40 -0700 Patch bug-239847-20220428144143.patch text/plain 4940 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWJhYzM2Y2RiZjg1MGJh ZjBkNDRlYTA1MDQ2YWQ4ZmRmYjcwNGNkNC4uMDIzNWU3MWJjOTZlY2RlODA1YjA3ZDU2YzM3NDMw OWEwNzU5YzMwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTA0LTI4ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIHN1cmUgdG8gZmFp bCBpbXBvcnRTY3JpcHRzIGFzIHBlciBodHRwczovL3czYy5naXRodWIuaW8vU2VydmljZVdvcmtl ci8jaW1wb3J0c2NyaXB0cyBzdGVwIDQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIzOTg0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE9uY2UgYSBzZXJ2aWNlIHdvcmtlciBpcyBpbnN0YWxsZWQsIHRoZSBz ZXJ2aWNlIHdvcmtlciBzaG91bGQgbm90IGJlIGFibGUgdG8gY2FsbCBpbXBvcnRTY3JpcHQgb24g bmV3IFVSTHMuCisgICAgICAgIENvdmVyZWQgYnkgdXBkYXRlZCB0ZXN0LgorCisgICAgICAgICog d29ya2Vycy9Xb3JrZXJTY3JpcHRMb2FkZXIuY3BwOgorCiAyMDIyLTA0LTI4ICBZb3Vlbm4gRmFi bGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZWdpc3RlciBzaGFyZWQgd29ya2Vy cyBhcyBzZXJ2aWNlIHdvcmtlciBjbGllbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93 b3JrZXJzL1dvcmtlclNjcmlwdExvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dv cmtlclNjcmlwdExvYWRlci5jcHAKaW5kZXggZWZhODY3N2UwOTMxMjQ2YzlhOTc3YTQ3ODY5ZTBk ZGJhOWY1ZmQ0Ni4uMWU0OGJhYjhjNWZjMGYzYzBlODA1N2IzZDdiMDA3NTcwYzM1Zjk0ZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJTY3JpcHRMb2FkZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyU2NyaXB0TG9hZGVyLmNwcApAQCAtODIs MTUgKzgyLDE3IEBAIHN0ZDo6b3B0aW9uYWw8RXhjZXB0aW9uPiBXb3JrZXJTY3JpcHRMb2FkZXI6 OmxvYWRTeW5jaHJvbm91c2x5KFNjcmlwdEV4ZWN1dGlvbkNvCiAgICAgbV9pc0NPRVBFbmFibGVk ID0gc2NyaXB0RXhlY3V0aW9uQ29udGV4dC0+c2V0dGluZ3NWYWx1ZXMoKS5jcm9zc09yaWdpbkVt YmVkZGVyUG9saWN5RW5hYmxlZDsKIAogI2lmIEVOQUJMRShTRVJWSUNFX1dPUktFUikKLSAgICBi b29sIGlzU2VydmljZVdvcmtlckdsb2JhbFNjb3BlID0gaXM8U2VydmljZVdvcmtlckdsb2JhbFNj b3BlPih3b3JrZXJHbG9iYWxTY29wZSk7Ci0KLSAgICBpZiAoaXNTZXJ2aWNlV29ya2VyR2xvYmFs U2NvcGUpIHsKLSAgICAgICAgaWYgKGF1dG8qIHNjcmlwdFJlc291cmNlID0gZG93bmNhc3Q8U2Vy dmljZVdvcmtlckdsb2JhbFNjb3BlPih3b3JrZXJHbG9iYWxTY29wZSkuc2NyaXB0UmVzb3VyY2Uo dXJsKSkgeworICAgIGF1dG8qIHNlcnZpY2VXb3JrZXJHbG9iYWxTY29wZSA9IGR5bmFtaWNEb3du Y2FzdDxTZXJ2aWNlV29ya2VyR2xvYmFsU2NvcGU+KHdvcmtlckdsb2JhbFNjb3BlKTsKKyAgICBp ZiAoc2VydmljZVdvcmtlckdsb2JhbFNjb3BlKSB7CisgICAgICAgIGlmIChhdXRvKiBzY3JpcHRS ZXNvdXJjZSA9IHNlcnZpY2VXb3JrZXJHbG9iYWxTY29wZS0+c2NyaXB0UmVzb3VyY2UodXJsKSkg ewogICAgICAgICAgICAgbV9zY3JpcHQgPSBzY3JpcHRSZXNvdXJjZS0+c2NyaXB0OwogICAgICAg ICAgICAgbV9yZXNwb25zZVVSTCA9IHNjcmlwdFJlc291cmNlLT5yZXNwb25zZVVSTDsKICAgICAg ICAgICAgIG1fcmVzcG9uc2VNSU1FVHlwZSA9IHNjcmlwdFJlc291cmNlLT5taW1lVHlwZTsKICAg ICAgICAgICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7CiAgICAgICAgIH0KKyAgICAgICAgYXV0byBz dGF0ZSA9IHNlcnZpY2VXb3JrZXJHbG9iYWxTY29wZS0+c2VydmljZVdvcmtlcigpLnN0YXRlKCk7 CisgICAgICAgIGlmIChzdGF0ZSAhPSBTZXJ2aWNlV29ya2VyU3RhdGU6OlBhcnNlZCAmJiBzdGF0 ZSAhPSBTZXJ2aWNlV29ya2VyU3RhdGU6Okluc3RhbGxpbmcpCisgICAgICAgICAgICByZXR1cm4g RXhjZXB0aW9uIHsgTmV0d29ya0Vycm9yLCAiSW1wb3J0aW5nIGEgc2NyaXB0IGZyb20gYSBzZXJ2 aWNlIHdvcmtlciB0aGF0IGlzIHBhc3QgaW5zdGFsbGluZyBzdGF0ZSJfcyB9OwogICAgIH0KICNl bmRpZgogCkBAIC0xMTksMTEgKzEyMSwxMSBAQCBzdGQ6Om9wdGlvbmFsPEV4Y2VwdGlvbj4gV29y a2VyU2NyaXB0TG9hZGVyOjpsb2FkU3luY2hyb25vdXNseShTY3JpcHRFeGVjdXRpb25DbwogICAg ICAgICByZXR1cm4gRXhjZXB0aW9uIHsgTmV0d29ya0Vycm9yLCBtX2Vycm9yLnNhbml0aXplZERl c2NyaXB0aW9uKCkgfTsKIAogI2lmIEVOQUJMRShTRVJWSUNFX1dPUktFUikKLSAgICBpZiAoaXNT ZXJ2aWNlV29ya2VyR2xvYmFsU2NvcGUpIHsKKyAgICBpZiAoc2VydmljZVdvcmtlckdsb2JhbFNj b3BlKSB7CiAgICAgICAgIGlmICghTUlNRVR5cGVSZWdpc3RyeTo6aXNTdXBwb3J0ZWRKYXZhU2Ny aXB0TUlNRVR5cGUocmVzcG9uc2VNSU1FVHlwZSgpKSkKICAgICAgICAgICAgIHJldHVybiBFeGNl cHRpb24geyBOZXR3b3JrRXJyb3IsICJtaW1lIHR5cGUgaXMgbm90IGEgc3VwcG9ydGVkIEphdmFT Y3JpcHQgbWltZSB0eXBlIl9zIH07CiAKLSAgICAgICAgZG93bmNhc3Q8U2VydmljZVdvcmtlckds b2JhbFNjb3BlPih3b3JrZXJHbG9iYWxTY29wZSkuc2V0U2NyaXB0UmVzb3VyY2UodXJsLCBTZXJ2 aWNlV29ya2VyQ29udGV4dERhdGE6OkltcG9ydGVkU2NyaXB0IHsgc2NyaXB0KCksIG1fcmVzcG9u c2VVUkwsIG1fcmVzcG9uc2VNSU1FVHlwZSB9KTsKKyAgICAgICAgc2VydmljZVdvcmtlckdsb2Jh bFNjb3BlLT5zZXRTY3JpcHRSZXNvdXJjZSh1cmwsIFNlcnZpY2VXb3JrZXJDb250ZXh0RGF0YTo6 SW1wb3J0ZWRTY3JpcHQgeyBzY3JpcHQoKSwgbV9yZXNwb25zZVVSTCwgbV9yZXNwb25zZU1JTUVU eXBlIH0pOwogICAgIH0KICNlbmRpZgogICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1w b3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCA3ZDRjZjVmODIxN2RhYmYzN2YxOWY4MDAxODQzMGU1 N2YxNGFmM2M0Li5mYWYyMGZhYzA2NTM4YWQ3N2M1Y2E2ZTZjNDVhOWQ5MTU4N2Q2ZWVjIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAyMi0wNC0yOCAg WW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBzdXJlIHRv IGZhaWwgaW1wb3J0U2NyaXB0cyBhcyBwZXIgaHR0cHM6Ly93M2MuZ2l0aHViLmlvL1NlcnZpY2VX b3JrZXIvI2ltcG9ydHNjcmlwdHMgc3RlcCA0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzk4NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9zZXJ2aWNlLXdvcmtlcnMv c2VydmljZS13b3JrZXIvaW1wb3J0LXNjcmlwdHMtdXBkYXRlZC1mbGFnLmh0dHBzLWV4cGVjdGVk LnR4dDoKKwogMjAyMi0wNC0yOCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgUmVnaXN0ZXIgc2hhcmVkIHdvcmtlcnMgYXMgc2VydmljZSB3b3JrZXIgY2xpZW50 cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0 cy9zZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvaW1wb3J0LXNjcmlwdHMtdXBkYXRlZC1m bGFnLmh0dHBzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvc2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyL2ltcG9ydC1zY3JpcHRz LXVwZGF0ZWQtZmxhZy5odHRwcy1leHBlY3RlZC50eHQKaW5kZXggMDdmZGM4ZDk2MzljYWEzMDdi MWFmNDNhM2QwNTlhZmQzZjI4NDAzOC4uMjFhZTAwMzg5ZmFkNjc1N2Q2OGYxNDRhNmMyMTgxYzRj NjczYzZmZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9zZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvaW1wb3J0LXNjcmlwdHMtdXBk YXRlZC1mbGFnLmh0dHBzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNlLXdvcmtlci9pbXBv cnQtc2NyaXB0cy11cGRhdGVkLWZsYWcuaHR0cHMtZXhwZWN0ZWQudHh0CkBAIC0yLDYgKzIsNiBA QAogUEFTUyBpbml0aWFsaXplIGdsb2JhbCBzdGF0ZQogUEFTUyBpbXBvcnQgc2NyaXB0IHByZXZp b3VzbHkgaW1wb3J0ZWQgYXQgd29ya2VyIGV2YWx1YXRpb24gdGltZQogUEFTUyBpbXBvcnQgc2Ny aXB0IHByZXZpb3VzbHkgaW1wb3J0ZWQgYXQgd29ya2VyIGluc3RhbGwgdGltZQotRkFJTCBpbXBv cnQgc2NyaXB0IG5vdCBwcmV2aW91c2x5IGltcG9ydGVkIGFzc2VydF9lcXVhbHM6IGV4cGVjdGVk IChzdHJpbmcpICJOZXR3b3JrRXJyb3IiIGJ1dCBnb3QgKG9iamVjdCkgbnVsbAorUEFTUyBpbXBv cnQgc2NyaXB0IG5vdCBwcmV2aW91c2x5IGltcG9ydGVkCiBQQVNTIFRlc3RzIGZvciBpbXBvcnRT Y3JpcHRzOiBpbXBvcnQgc2NyaXB0cyB1cGRhdGVkIGZsYWcKIAo=