239836 2022-04-27 19:33:03 -0700 Use more smart pointers in Element.cpp 2022-05-04 20:54:57 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen ajuma cdumez cmarcelo esprehn+autocc ews-watchlist kangil.han webkit-bug-importer oldest_to_newest 1865029 0 achristensen 2022-04-27 19:33:03 -0700 Use more smart pointers in Element.cpp 1865030 1 458486 achristensen 2022-04-27 19:33:57 -0700 Created attachment 458486 Patch 1865083 2 ews-feeder 2022-04-28 01:00:59 -0700 Committed r293569 (250083@main): <https://commits.webkit.org/250083@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458486. 1865084 3 webkit-bug-importer 2022-04-28 01:01:15 -0700 <rdar://problem/92445797> 1866726 4 achristensen 2022-05-04 20:54:57 -0700 *** Bug 234172 has been marked as a duplicate of this bug. *** 458486 2022-04-27 19:33:57 -0700 2022-04-28 01:01:00 -0700 Patch bug-239836-20220427193357.patch text/plain 3188 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2VjZTAxYjljMDJhMDk3 ZmZhM2I2OTQxNTVhYTc0ODNjNmY0NDJjOS4uMjZmYjM5ZTI5MWY2NTMxNjRjZjA4ZDQ5YjQ4ZDdk ZjcwMWIyMDU0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIyLTA0LTI3ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVXNlIG1v cmUgc21hcnQgcG9pbnRlcnMgaW4gRWxlbWVudC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzOTgzNgorCisgICAgICAgIFJldmlld2VkIGJ5IENo cmlzIER1bWV6LgorCisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RWxlbWVudDo6c2V0U2Nyb2xsTGVmdCk6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50Ojpz ZXRTY3JvbGxUb3ApOgorCiAyMDIyLTA0LTI3ICBUaW0gTmd1eWVuICA8bnRpbUBhcHBsZS5jb20+ CiAKICAgICAgICAgTWFrZSAtd2Via2l0LXRyYW5zZm9ybS1zdHlsZSBhbiBhbGlhcyBvZiB0cmFu c2Zvcm0tc3R5bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCAwYmQyNjcyMWNiZTg3MDQ3MzZi MThhNzU2ZTg4ZjA2NWE2NDA3MjNjLi41ZWJlNzhmZWJjYjBkOTc2YTcxMGI5MDI3YzE3ZDY0Yzcx NmU3ZmFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC0xNDYxLDE3ICsxNDYxLDE3IEBAIHZv aWQgRWxlbWVudDo6c2V0U2Nyb2xsTGVmdChpbnQgbmV3TGVmdCkKICAgICBvcHRpb25zLmFuaW1h dGVkID0gdXNlU21vb3RoU2Nyb2xsaW5nKFNjcm9sbEJlaGF2aW9yOjpBdXRvLCB0aGlzKSA/IFNj cm9sbElzQW5pbWF0ZWQ6OlllcyA6IFNjcm9sbElzQW5pbWF0ZWQ6Ok5vOwogCiAgICAgaWYgKGRv Y3VtZW50KCkuc2Nyb2xsaW5nRWxlbWVudCgpID09IHRoaXMpIHsKLSAgICAgICAgaWYgKGF1dG8q IGZyYW1lID0gZG9jdW1lbnRGcmFtZVdpdGhOb25OdWxsVmlldygpKSB7CisgICAgICAgIGlmIChS ZWZQdHIgZnJhbWUgPSBkb2N1bWVudEZyYW1lV2l0aE5vbk51bGxWaWV3KCkpIHsKICAgICAgICAg ICAgIEludFBvaW50IHBvc2l0aW9uKHN0YXRpY19jYXN0PGludD4obmV3TGVmdCAqIGZyYW1lLT5w YWdlWm9vbUZhY3RvcigpICogZnJhbWUtPmZyYW1lU2NhbGVGYWN0b3IoKSksIGZyYW1lLT52aWV3 KCktPnNjcm9sbFkoKSk7CiAgICAgICAgICAgICBmcmFtZS0+dmlldygpLT5zZXRTY3JvbGxQb3Np dGlvbihwb3NpdGlvbiwgb3B0aW9ucyk7CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuOwogICAg IH0KIAotICAgIGlmIChhdXRvKiByZW5kZXJlciA9IHJlbmRlckJveCgpKSB7CisgICAgaWYgKFdl YWtQdHIgcmVuZGVyZXIgPSByZW5kZXJCb3goKSkgewogICAgICAgICBpbnQgY2xhbXBlZExlZnQg PSBjbGFtcFRvSW50ZWdlcihuZXdMZWZ0ICogcmVuZGVyZXItPnN0eWxlKCkuZWZmZWN0aXZlWm9v bSgpKTsKICAgICAgICAgcmVuZGVyZXItPnNldFNjcm9sbExlZnQoY2xhbXBlZExlZnQsIG9wdGlv bnMpOwotICAgICAgICBpZiAoYXV0byogc2Nyb2xsYWJsZUFyZWEgPSByZW5kZXJlci0+bGF5ZXIo KSA/IHJlbmRlcmVyLT5sYXllcigpLT5zY3JvbGxhYmxlQXJlYSgpIDogbnVsbHB0cikKKyAgICAg ICAgaWYgKGF1dG8qIHNjcm9sbGFibGVBcmVhID0gcmVuZGVyZXIgJiYgcmVuZGVyZXItPmxheWVy KCkgPyByZW5kZXJlci0+bGF5ZXIoKS0+c2Nyb2xsYWJsZUFyZWEoKSA6IG51bGxwdHIpCiAgICAg ICAgICAgICBzY3JvbGxhYmxlQXJlYS0+c2V0U2Nyb2xsU2hvdWxkQ2xlYXJMYXRjaGVkU3RhdGUo dHJ1ZSk7CiAgICAgfQogfQpAQCAtMTQ4NCwxNyArMTQ4NCwxNyBAQCB2b2lkIEVsZW1lbnQ6OnNl dFNjcm9sbFRvcChpbnQgbmV3VG9wKQogICAgIG9wdGlvbnMuYW5pbWF0ZWQgPSB1c2VTbW9vdGhT Y3JvbGxpbmcoU2Nyb2xsQmVoYXZpb3I6OkF1dG8sIHRoaXMpID8gU2Nyb2xsSXNBbmltYXRlZDo6 WWVzIDogU2Nyb2xsSXNBbmltYXRlZDo6Tm87CiAKICAgICBpZiAoZG9jdW1lbnQoKS5zY3JvbGxp bmdFbGVtZW50KCkgPT0gdGhpcykgewotICAgICAgICBpZiAoYXV0byogZnJhbWUgPSBkb2N1bWVu dEZyYW1lV2l0aE5vbk51bGxWaWV3KCkpIHsKKyAgICAgICAgaWYgKFJlZlB0ciBmcmFtZSA9IGRv Y3VtZW50RnJhbWVXaXRoTm9uTnVsbFZpZXcoKSkgewogICAgICAgICAgICAgSW50UG9pbnQgcG9z aXRpb24oZnJhbWUtPnZpZXcoKS0+c2Nyb2xsWCgpLCBzdGF0aWNfY2FzdDxpbnQ+KG5ld1RvcCAq IGZyYW1lLT5wYWdlWm9vbUZhY3RvcigpICogZnJhbWUtPmZyYW1lU2NhbGVGYWN0b3IoKSkpOwog ICAgICAgICAgICAgZnJhbWUtPnZpZXcoKS0+c2V0U2Nyb2xsUG9zaXRpb24ocG9zaXRpb24sIG9w dGlvbnMpOwogICAgICAgICB9CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBpZiAoYXV0 byogcmVuZGVyZXIgPSByZW5kZXJCb3goKSkgeworICAgIGlmIChXZWFrUHRyIHJlbmRlcmVyID0g cmVuZGVyQm94KCkpIHsKICAgICAgICAgaW50IGNsYW1wZWRUb3AgPSBjbGFtcFRvSW50ZWdlcihu ZXdUb3AgKiByZW5kZXJlci0+c3R5bGUoKS5lZmZlY3RpdmVab29tKCkpOwogICAgICAgICByZW5k ZXJlci0+c2V0U2Nyb2xsVG9wKGNsYW1wZWRUb3AsIG9wdGlvbnMpOwotICAgICAgICBpZiAoYXV0 byogc2Nyb2xsYWJsZUFyZWEgPSByZW5kZXJlci0+bGF5ZXIoKSA/IHJlbmRlcmVyLT5sYXllcigp LT5zY3JvbGxhYmxlQXJlYSgpIDogbnVsbHB0cikKKyAgICAgICAgaWYgKGF1dG8qIHNjcm9sbGFi bGVBcmVhID0gcmVuZGVyZXIgJiYgcmVuZGVyZXItPmxheWVyKCkgPyByZW5kZXJlci0+bGF5ZXIo KS0+c2Nyb2xsYWJsZUFyZWEoKSA6IG51bGxwdHIpCiAgICAgICAgICAgICBzY3JvbGxhYmxlQXJl YS0+c2V0U2Nyb2xsU2hvdWxkQ2xlYXJMYXRjaGVkU3RhdGUodHJ1ZSk7CiAgICAgfQogfQo=