239829 2022-04-27 15:37:11 -0700 DisplayList::Recorder should lazily create the DrawGlyphsRecorder 2022-04-28 08:13:36 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bfulgham mmaxfield simon.fraser webkit-bug-importer zalan oldest_to_newest 1864950 0 simon.fraser 2022-04-27 15:37:11 -0700 DisplayList::Recorder should lazily create the DrawGlyphsRecorder 1864951 1 458475 simon.fraser 2022-04-27 15:38:25 -0700 Created attachment 458475 Patch 1864955 2 458475 mmaxfield 2022-04-27 15:42:16 -0700 Comment on attachment 458475 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458475&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:166 > + if (!m_drawGlyphsRecorder) > + m_drawGlyphsRecorder = makeUnique<DrawGlyphsRecorder>(*this, m_initialScale, m_deconstructDrawGlyphs); Can we pull this out into an ensure() function? > Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:275 > + float m_initialScale { 1 }; > + DrawGlyphsRecorder::DeconstructDrawGlyphs m_deconstructDrawGlyphs { DrawGlyphsRecorder::DeconstructDrawGlyphs::No }; Should these be batched up into a struct? Are we polluting the contents of the Recorder object? 1864963 3 simon.fraser 2022-04-27 15:53:52 -0700 (In reply to Myles C. Maxfield from comment #2) > Comment on attachment 458475 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=458475&action=review > > > Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:166 > > + if (!m_drawGlyphsRecorder) > > + m_drawGlyphsRecorder = makeUnique<DrawGlyphsRecorder>(*this, m_initialScale, m_deconstructDrawGlyphs); > > Can we pull this out into an ensure() function? > > > Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:275 > > + float m_initialScale { 1 }; > > + DrawGlyphsRecorder::DeconstructDrawGlyphs m_deconstructDrawGlyphs { DrawGlyphsRecorder::DeconstructDrawGlyphs::No }; > > Should these be batched up into a struct? Are we polluting the contents of > the Recorder object? Both true, but I'm not sure either are worth it. 1865049 4 webkit-bug-importer 2022-04-27 21:21:15 -0700 <rdar://problem/92438193> 1865141 5 ews-feeder 2022-04-28 08:13:33 -0700 Committed r293572 (250086@main): <https://commits.webkit.org/250086@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458475. 458475 2022-04-27 15:38:25 -0700 2022-04-28 08:13:35 -0700 Patch bug-239829-20220427153824.patch text/plain 4442 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGU2MjVkNjIyNTllNzM2 MjhmNTRiZTU4YzllYTAxZjEwNTFhMmVjNy4uODU0NmJiMmFjZjBkZDRkMTIxZjk3NjlhY2FlMjNk YmQzZDJlNjZlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIyLTA0LTI3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIERpc3BsYXlMaXN0 OjpSZWNvcmRlciBzaG91bGQgbGF6aWx5IGNyZWF0ZSB0aGUgRHJhd0dseXBoc1JlY29yZGVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzk4MjkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDcmVhdGluZyBh IERyYXdHbHlwaHNSZWNvcmRlciBkb2VzIGEgYml0IG9mIHdvcmsgdGhhdCBjYWxscyBpbnRvIENv cmUgR3JhcGhpY3MuIFdlIGRvbid0IG5lZWQKKyAgICAgICAgdG8gZG8gdGhpcyB3b3JrIGZvciBh IGxheWVyIHRoYXQgaGFzIG5vIHRleHQsIHNvIGRlbGF5IHRoaXMgd29yayB1bnRpbCB0aGUgZmly c3QgZHJhd0dseXBocygpIGNhbGwuCisKKyAgICAgICAgVGhpcyBpcyBhIGZldyAlIHBlcmYgZ2Fp biBvbiB0aGUgSW1hZ2VzIE1vdGlvbk1hcmsgc3VidGVzdC4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL0RyYXdHbHlwaHNSZWNvcmRlci5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2Rpc3BsYXlsaXN0cy9EaXNwbGF5TGlzdFJlY29yZGVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkRpc3BsYXlMaXN0OjpSZWNvcmRlcjo6UmVjb3JkZXIpOgorICAgICAgICAoV2ViQ29yZTo6 RGlzcGxheUxpc3Q6OlJlY29yZGVyOjpkcmF3R2x5cGhzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RSZWNvcmRlci5oOgorCiAyMDIyLTA0LTI3 ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEF2b2lk IHNlbmRpbmcgYSBmbHVzaCBJUEMgdG8gdGhlIEdQVSBwcm9jZXNzIHdoZW4gZGVzdHJveWluZyBh IFJlbW90ZUltYWdlQnVmZmVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9EcmF3R2x5cGhzUmVjb3JkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0RyYXdHbHlwaHNSZWNvcmRlci5oCmluZGV4IDdiMDE4ZDM3NTFkYmQ5MGZmNzM2OGE2 YzZhODFkMjdhNTU2ZWQyOWEuLjNlYzgzOWMxNzcyZmNmMjgwMDJiNmNlOWU1MTQzOGMxYjQ0NGRk ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0RyYXdHbHlw aHNSZWNvcmRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0RyYXdH bHlwaHNSZWNvcmRlci5oCkBAIC01Miw2ICs1Miw4IEBAIGNsYXNzIEdseXBoQnVmZmVyOwogY2xh c3MgR3JhcGhpY3NDb250ZXh0OwogCiBjbGFzcyBEcmF3R2x5cGhzUmVjb3JkZXIgeworICAgIFdU Rl9NQUtFX0ZBU1RfQUxMT0NBVEVEOworICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKERyYXdHbHlw aHNSZWNvcmRlcik7CiBwdWJsaWM6CiAgICAgZW51bSBjbGFzcyBEZWNvbnN0cnVjdERyYXdHbHlw aHMgOiBib29sIHsgTm8sIFllcyB9OwogICAgIGVudW0gY2xhc3MgRGVyaXZlRm9udEZyb21Db250 ZXh0IDogYm9vbCB7IE5vLCBZZXMgfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Rpc3BsYXlsaXN0cy9EaXNwbGF5TGlzdFJlY29yZGVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXlsaXN0cy9EaXNwbGF5TGlzdFJlY29y ZGVyLmNwcAppbmRleCA1NGJjODJjMDM3ZGMwYjU5NjJhZTNlYjAxZmRmMzBlNWIyMTIwOGY4Li4z MWM5ZWVmZmY4ZmI0ODkzZjJlOWFmMDJkMWVmNzYyNmRmMTM1M2NmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RSZWNv cmRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxp c3RzL0Rpc3BsYXlMaXN0UmVjb3JkZXIuY3BwCkBAIC00OCw3ICs0OCw4IEBAIG5hbWVzcGFjZSBE aXNwbGF5TGlzdCB7CiAKIFJlY29yZGVyOjpSZWNvcmRlcihjb25zdCBHcmFwaGljc0NvbnRleHRT dGF0ZSYgc3RhdGUsIGNvbnN0IEZsb2F0UmVjdCYgaW5pdGlhbENsaXAsIGNvbnN0IEFmZmluZVRy YW5zZm9ybSYgaW5pdGlhbENUTSwgRHJhd0dseXBoc1JlY29yZGVyOjpEZWNvbnN0cnVjdERyYXdH bHlwaHMgZGVjb25zdHJ1Y3REcmF3R2x5cGhzKQogICAgIDogR3JhcGhpY3NDb250ZXh0KHN0YXRl KQotICAgICwgbV9kcmF3R2x5cGhzUmVjb3JkZXIoKnRoaXMsIGluaXRpYWxDVE0ueFNjYWxlKCks IGRlY29uc3RydWN0RHJhd0dseXBocykKKyAgICAsIG1faW5pdGlhbFNjYWxlKGluaXRpYWxDVE0u eFNjYWxlKCkpCisgICAgLCBtX2RlY29uc3RydWN0RHJhd0dseXBocyhkZWNvbnN0cnVjdERyYXdH bHlwaHMpCiB7CiAgICAgbV9zdGF0ZVN0YWNrLmFwcGVuZCh7IHN0YXRlLCBpbml0aWFsQ1RNLCBp bml0aWFsQ1RNLm1hcFJlY3QoaW5pdGlhbENsaXApIH0pOwogfQpAQCAtMTYxLDcgKzE2MiwxMCBA QCB2b2lkIFJlY29yZGVyOjpkcmF3RmlsdGVyZWRJbWFnZUJ1ZmZlcihJbWFnZUJ1ZmZlciogc291 cmNlSW1hZ2UsIGNvbnN0IEZsb2F0UmVjdAogCiB2b2lkIFJlY29yZGVyOjpkcmF3R2x5cGhzKGNv bnN0IEZvbnQmIGZvbnQsIGNvbnN0IEdseXBoQnVmZmVyR2x5cGgqIGdseXBocywgY29uc3QgR2x5 cGhCdWZmZXJBZHZhbmNlKiBhZHZhbmNlcywgdW5zaWduZWQgbnVtR2x5cGhzLCBjb25zdCBGbG9h dFBvaW50JiBzdGFydFBvaW50LCBGb250U21vb3RoaW5nTW9kZSBzbW9vdGhpbmdNb2RlKQogewot ICAgIG1fZHJhd0dseXBoc1JlY29yZGVyLmRyYXdHbHlwaHMoZm9udCwgZ2x5cGhzLCBhZHZhbmNl cywgbnVtR2x5cGhzLCBzdGFydFBvaW50LCBzbW9vdGhpbmdNb2RlKTsKKyAgICBpZiAoIW1fZHJh d0dseXBoc1JlY29yZGVyKQorICAgICAgICBtX2RyYXdHbHlwaHNSZWNvcmRlciA9IG1ha2VVbmlx dWU8RHJhd0dseXBoc1JlY29yZGVyPigqdGhpcywgbV9pbml0aWFsU2NhbGUsIG1fZGVjb25zdHJ1 Y3REcmF3R2x5cGhzKTsKKworICAgIG1fZHJhd0dseXBoc1JlY29yZGVyLT5kcmF3R2x5cGhzKGZv bnQsIGdseXBocywgYWR2YW5jZXMsIG51bUdseXBocywgc3RhcnRQb2ludCwgc21vb3RoaW5nTW9k ZSk7CiB9CiAKIHZvaWQgUmVjb3JkZXI6OmRyYXdHbHlwaHNBbmRDYWNoZUZvbnQoY29uc3QgRm9u dCYgZm9udCwgY29uc3QgR2x5cGhCdWZmZXJHbHlwaCogZ2x5cGhzLCBjb25zdCBHbHlwaEJ1ZmZl ckFkdmFuY2UqIGFkdmFuY2VzLCB1bnNpZ25lZCBjb3VudCwgY29uc3QgRmxvYXRQb2ludCYgbG9j YWxBbmNob3IsIEZvbnRTbW9vdGhpbmdNb2RlIHNtb290aGluZ01vZGUpCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RS ZWNvcmRlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3Rz L0Rpc3BsYXlMaXN0UmVjb3JkZXIuaAppbmRleCBmNGRlMzI3MGEyOGFjNzcyNzRkNGViMTEyYWMw ZjQwZjNjMjYzZmU4Li45NWFlNjcyNWNlZjc0Y2JlZDc2NGQ5ZDQwOGU2NzZlNDQxMjI1YTQ4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMv RGlzcGxheUxpc3RSZWNvcmRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Rpc3BsYXlsaXN0cy9EaXNwbGF5TGlzdFJlY29yZGVyLmgKQEAgLTI3MCw3ICsyNzAsOSBA QCBwcml2YXRlOgogICAgIGNvbnN0IEFmZmluZVRyYW5zZm9ybSYgY3RtKCkgY29uc3Q7CiAKICAg ICBWZWN0b3I8Q29udGV4dFN0YXRlLCA0PiBtX3N0YXRlU3RhY2s7Ci0gICAgRHJhd0dseXBoc1Jl Y29yZGVyIG1fZHJhd0dseXBoc1JlY29yZGVyOworICAgIHN0ZDo6dW5pcXVlX3B0cjxEcmF3R2x5 cGhzUmVjb3JkZXI+IG1fZHJhd0dseXBoc1JlY29yZGVyOworICAgIGZsb2F0IG1faW5pdGlhbFNj YWxlIHsgMSB9OworICAgIERyYXdHbHlwaHNSZWNvcmRlcjo6RGVjb25zdHJ1Y3REcmF3R2x5cGhz IG1fZGVjb25zdHJ1Y3REcmF3R2x5cGhzIHsgRHJhd0dseXBoc1JlY29yZGVyOjpEZWNvbnN0cnVj dERyYXdHbHlwaHM6Ok5vIH07CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBEaXNwbGF5TGlzdAo=