239799 2022-04-26 20:33:23 -0700 Avoid sending a flush IPC to the GPU process when destroying a RemoteImageBuffer 2022-04-27 12:03:14 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=228673 InRadar P2 Normal --- 1 simon.fraser simon.fraser bfulgham sabouhallawa simon.fraser webkit-bug-importer zalan oldest_to_newest 1864707 0 simon.fraser 2022-04-26 20:33:23 -0700 Avoid sending a flush IPC to the GPU process when destroying a RemoteImageBuffer 1864708 1 458415 simon.fraser 2022-04-26 20:36:14 -0700 Created attachment 458415 Patch 1864726 2 458415 sabouhallawa 2022-04-26 22:39:46 -0700 Comment on attachment 458415 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458415&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). This should be removed before landing. > Source/WebCore/platform/graphics/ImageBuffer.h:101 > + virtual bool flushDrawingContextAsync() { return false; } It is not clear from the name what this function returns. Should it be renamed flushDrawingContextAsyncIfNeeded()? > Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:313 > + return false; The order in this function is a little bit hard to read. Can't it be rearranged like this: // Nothing to flush, return true if we need the caller to wait. if (!m_remoteDisplayList.needsFlush()) return hasPendingFlush(); // Do the flushing and tell the caller to wait. ... m_remoteDisplayList.flushContext(m_sentFlushIdentifier); ... return true; 1864871 3 simon.fraser 2022-04-27 12:02:05 -0700 https://trac.webkit.org/changeset/293522/webkit 1864872 4 webkit-bug-importer 2022-04-27 12:03:14 -0700 <rdar://problem/92412491> 458415 2022-04-26 20:36:14 -0700 2022-04-26 22:39:46 -0700 Patch bug-239799-20220426203613.patch text/plain 6607 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNDg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWE3NGJiNDQyYjViYzgw ZDA0OWVlZjFiN2JhMTI4NWNlNTAxOTUwYS4uM2RkMWNlYzY0NDBiY2ZmZDIyMmQ2MjZkZmYwMWUw ZDU3MmIyNjliNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIyLTA0LTI2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIHNlbmRp bmcgYSBmbHVzaCBJUEMgdG8gdGhlIEdQVSBwcm9jZXNzIHdoZW4gZGVzdHJveWluZyBhIFJlbW90 ZUltYWdlQnVmZmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzk3OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L0ltYWdlQnVmZmVyLmg6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6Zmx1c2hEcmF3 aW5nQ29udGV4dEFzeW5jKToKKwogMjAyMi0wNC0yNiAgSmVhbi1ZdmVzIEF2ZW5hcmQgIDxqeWFA YXBwbGUuY29tPgogCiAgICAgICAgIE1lZGlhU2Vzc2lvbi5zZXRQb3NpdGlvblN0YXRlKCkgZG9l cyBub3Qgd29yay4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggZDY3ZjYwMWE1YzE1MGI5MDQxMGIzMTIyMWE5NmJlMWFk ZjMxMGM3MC4uZWNmMGFkYTRmYzA3NmVkOWZiOWY0ZGM3ZWNkZWJiNmFiYmQ2OWJlYiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VM b2cKQEAgLTEsMyArMSwyMCBAQAorMjAyMi0wNC0yNiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJh c2VyQGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCBzZW5kaW5nIGEgZmx1c2ggSVBDIHRvIHRo ZSBHUFUgcHJvY2VzcyB3aGVuIGRlc3Ryb3lpbmcgYSBSZW1vdGVJbWFnZUJ1ZmZlcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM5Nzk5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWZ0ZXIgcjI4MDY1Miwg ZGVzdHJveWluZyBhIFJlbW90ZUltYWdlQnVmZmVyUHJveHkgd291bGQgYWx3YXlzIHNlbmQgYSBm bHVzaCB0byB0aGUgR1BVCisgICAgICAgIHByb2Nlc3MsIGV2ZW4gaWYgdGhlcmUgaGFkIGJlIG5v IGRyYXdpbmcgc2luY2UgdGhlIHByZXZpb3VzIGZsdXNoLgorCisgICAgICAgIEZpeCB0byBvbmx5 IHNlbmQgYSBmbHVzaCBhbmQgd2FpdCB3aGVuIG5lY2Vzc2FyeS4KKworICAgICAgICBSb3VnaGx5 IDglIHByb2dyZXNzaW9uIG9uIE1vdGlvbk1hcmsgSW1hZ2VzIHN1YnRlc3Qgb24gaVBob25lLgor CisgICAgICAgICogV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3MvUmVtb3RlSW1hZ2VCdWZmZXJQcm94 eS5oOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVJbWFnZUJ1ZmZlclByb3h5Ojp3YWl0Rm9yRGlk Rmx1c2hXaXRoVGltZW91dCk6CisKIDIwMjItMDQtMjYgIEVsbGlvdHQgV2lsbGlhbXMgIDxlbXdA YXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyAiW1hjb2RlXSBDb21w dXRlIFBHTyBwcm9mZGF0YSBwYXRocyBpbnN0ZWFkIG9mIHNlYXJjaGluZyBmb3IgdGhlbSBhdCBi dWlsZCB0aW1lIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv SW1hZ2VCdWZmZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVm ZmVyLmgKaW5kZXggOWNiMDc4ZWU5OGU3NTE3M2IzNGQ2N2Q5ZWFiMTVhOWU5ZDIwNmE3ZS4uNGFj ZjIzMDg4YTUzNTVkYzQ1NWVkMzM3Y2I0MGQ0MzNiZjNhY2EwZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5oCkBAIC05OCw3ICs5OCw3IEBAIHB1 YmxpYzoKICAgICB2aXJ0dWFsIEdyYXBoaWNzQ29udGV4dCogZHJhd2luZ0NvbnRleHQoKSB7IHJl dHVybiBudWxscHRyOyB9CiAgICAgdmlydHVhbCBib29sIHByZWZlcnNQcmVwYXJhdGlvbkZvckRp c3BsYXkoKSB7IHJldHVybiBmYWxzZTsgfQogICAgIHZpcnR1YWwgdm9pZCBmbHVzaERyYXdpbmdD b250ZXh0KCkgeyB9Ci0gICAgdmlydHVhbCB2b2lkIGZsdXNoRHJhd2luZ0NvbnRleHRBc3luYygp IHsgfQorICAgIHZpcnR1YWwgYm9vbCBmbHVzaERyYXdpbmdDb250ZXh0QXN5bmMoKSB7IHJldHVy biBmYWxzZTsgfQogICAgIHZpcnR1YWwgdm9pZCBkaWRGbHVzaChHcmFwaGljc0NvbnRleHRGbHVz aElkZW50aWZpZXIpIHsgfQogCiAgICAgdmlydHVhbCBGbG9hdFNpemUgbG9naWNhbFNpemUoKSBj b25zdCA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBo aWNzL1JlbW90ZUltYWdlQnVmZmVyUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9H UFUvZ3JhcGhpY3MvUmVtb3RlSW1hZ2VCdWZmZXJQcm94eS5oCmluZGV4IDhmY2U2ZTczNTg3ZmQ2 ODFlMmZhZDA2ODBiNjYwNDA2NGVlZWQ3MWUuLjA3YmI5NjIxMGQ1N2Y5NDY4YTg4OTlkZTA3MGUy ZjY3OTJkODIzNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3Jh cGhpY3MvUmVtb3RlSW1hZ2VCdWZmZXJQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9HUFUvZ3JhcGhpY3MvUmVtb3RlSW1hZ2VCdWZmZXJQcm94eS5oCkBAIC0xMjYsMTIgKzEy NiwxMyBAQCBwcm90ZWN0ZWQ6CiAjaWYgIUxPR19ESVNBQkxFRAogICAgICAgICBhdXRvIHN0YXJ0 VGltZSA9IE1vbm90b25pY1RpbWU6Om5vdygpOwogI2VuZGlmCi0gICAgICAgIExPR19XSVRIX1NU UkVBTShTaGFyZWREaXNwbGF5TGlzdHMsIHN0cmVhbSA8PCAiV2FpdGluZyBmb3IgRmx1c2h7IiA8 PCBtX3NlbnRGbHVzaElkZW50aWZpZXIgPDwgIn0gaW4gSW1hZ2UoIiA8PCBtX3JlbmRlcmluZ1Jl c291cmNlSWRlbnRpZmllciA8PCAiKSIpOworICAgICAgICBMT0dfV0lUSF9TVFJFQU0oU2hhcmVk RGlzcGxheUxpc3RzLCBzdHJlYW0gPDwgIlJlbW90ZUltYWdlQnVmZmVyUHJveHkgIiA8PCBtX3Jl bmRlcmluZ1Jlc291cmNlSWRlbnRpZmllciA8PCAiIHdhaXRGb3JEaWRGbHVzaFdpdGhUaW1lb3V0 OiB3YWl0aW5nIGZvciBmbHVzaCB7IiA8PCBtX3NlbnRGbHVzaElkZW50aWZpZXIpOwogICAgICAg ICB3aGlsZSAobnVtYmVyT2ZUaW1lb3V0cyA8IG1heGltdW1OdW1iZXJPZlRpbWVvdXRzICYmIGhh c1BlbmRpbmdGbHVzaCgpKSB7CiAgICAgICAgICAgICBpZiAoIW1fcmVtb3RlUmVuZGVyaW5nQmFj a2VuZFByb3h5LT53YWl0Rm9yRGlkRmx1c2goKSkKICAgICAgICAgICAgICAgICArK251bWJlck9m VGltZW91dHM7CiAgICAgICAgIH0KLSAgICAgICAgTE9HX1dJVEhfU1RSRUFNKFNoYXJlZERpc3Bs YXlMaXN0cywgc3RyZWFtIDw8ICJEb25lIHdhaXRpbmc6ICIgPDwgTW9ub3RvbmljVGltZTo6bm93 KCkgLSBzdGFydFRpbWUgPDwgIjsgIiA8PCBudW1iZXJPZlRpbWVvdXRzIDw8ICIgdGltZW91dChz KSIpOworCisgICAgICAgIExPR19XSVRIX1NUUkVBTShTaGFyZWREaXNwbGF5TGlzdHMsIHN0cmVh bSA8PCAiUmVtb3RlSW1hZ2VCdWZmZXJQcm94eSAiIDw8IG1fcmVuZGVyaW5nUmVzb3VyY2VJZGVu dGlmaWVyIDw8ICIgd2FpdEZvckRpZEZsdXNoV2l0aFRpbWVvdXQ6IGRvbmUgd2FpdGluZyAiIDw8 IChNb25vdG9uaWNUaW1lOjpub3coKSAtIHN0YXJ0VGltZSkubWlsbGlzZWNvbmRzKCkgPDwgIm1z OyAiIDw8IG51bWJlck9mVGltZW91dHMgPDwgIiB0aW1lb3V0KHMpIik7CiAKICAgICAgICAgaWYg KFVOTElLRUxZKG51bWJlck9mVGltZW91dHMgPj0gbWF4aW11bU51bWJlck9mVGltZW91dHMpKQog ICAgICAgICAgICAgUkVMRUFTRV9MT0dfRkFVTFQoU2hhcmVkRGlzcGxheUxpc3RzLCAiRXhjZWVk ZWQgdGltZW91dCB3aGlsZSB3YWl0aW5nIGZvciBmbHVzaCBpbiByZW1vdGUgcmVuZGVyaW5nIGJh Y2tlbmQ6ICUiIFBSSXU2NCAiLiIsIG1fcmVtb3RlUmVuZGVyaW5nQmFja2VuZFByb3h5LT5yZW5k ZXJpbmdCYWNrZW5kSWRlbnRpZmllcigpLnRvVUludDY0KCkpOwpAQCAtMTQ5LDcgKzE1MCw3IEBA IHByb3RlY3RlZDoKICAgICAgICAgICAgICAgICArK251bWJlck9mVGltZW91dHNPckZhaWx1cmVz OwogICAgICAgICB9CiAgICAgICAgIGlmIChudW1iZXJPZlRpbWVvdXRzT3JGYWlsdXJlcyA9PSBt YXhpbXVtVGltZW91dE9yRmFpbHVyZUNvdW50KSB7Ci0gICAgICAgICAgICBMT0dfV0lUSF9TVFJF QU0oU2hhcmVkRGlzcGxheUxpc3RzLCBzdHJlYW0gPDwgIkV4Y2VlZGVkIG1heCBudW1iZXIgb2Yg dGltZW91dHMgd2FpdGluZyBmb3IgaW1hZ2UgYnVmZmVyICIgPDwgbV9yZW5kZXJpbmdSZXNvdXJj ZUlkZW50aWZpZXIgPDwgIiBiYWNrZW5kIGNyZWF0aW9uIik7CisgICAgICAgICAgICBMT0dfV0lU SF9TVFJFQU0oU2hhcmVkRGlzcGxheUxpc3RzLCBzdHJlYW0gPDwgIlJlbW90ZUltYWdlQnVmZmVy UHJveHkgIiA8PCBtX3JlbmRlcmluZ1Jlc291cmNlSWRlbnRpZmllciA8PCAiIGVuc3VyZUJhY2tl bmRDcmVhdGVkOiBleGNlZWRlZCBtYXggbnVtYmVyIG9mIHRpbWVvdXRzIik7CiAgICAgICAgICAg ICBSRUxFQVNFX0xPR19GQVVMVChTaGFyZWREaXNwbGF5TGlzdHMsICJFeGNlZWRlZCBtYXggbnVt YmVyIG9mIHRpbWVvdXRzIHdhaXRpbmcgZm9yIGltYWdlIGJ1ZmZlciBiYWNrZW5kIGNyZWF0aW9u IGluIHJlbW90ZSByZW5kZXJpbmcgYmFja2VuZCAlIiBQUkl1NjQgIi4iLCBtX3JlbW90ZVJlbmRl cmluZ0JhY2tlbmRQcm94eS0+cmVuZGVyaW5nQmFja2VuZElkZW50aWZpZXIoKS50b1VJbnQ2NCgp KTsKICAgICAgICAgfQogICAgICAgICByZXR1cm4gbV9iYWNrZW5kLmdldCgpOwpAQCAtMjg2LDIx ICsyODcsMzAgQEAgcHJvdGVjdGVkOgogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIFRy YWNlU2NvcGUgdHJhY2luZ1Njb3BlKEZsdXNoUmVtb3RlSW1hZ2VCdWZmZXJTdGFydCwgRmx1c2hS ZW1vdGVJbWFnZUJ1ZmZlckVuZCk7Ci0gICAgICAgIGZsdXNoRHJhd2luZ0NvbnRleHRBc3luYygp OwotICAgICAgICB3YWl0Rm9yRGlkRmx1c2hXaXRoVGltZW91dCgpOworCisgICAgICAgIGJvb2wg c2hvdWxkV2FpdCA9IGZsdXNoRHJhd2luZ0NvbnRleHRBc3luYygpOworICAgICAgICBMT0dfV0lU SF9TVFJFQU0oU2hhcmVkRGlzcGxheUxpc3RzLCBzdHJlYW0gPDwgIlJlbW90ZUltYWdlQnVmZmVy UHJveHkgIiA8PCBtX3JlbmRlcmluZ1Jlc291cmNlSWRlbnRpZmllciA8PCAiIGZsdXNoRHJhd2lu Z0NvbnRleHQ6IHNob3VsZFdhaXQgIiA8PCBzaG91bGRXYWl0KTsKKyAgICAgICAgaWYgKHNob3Vs ZFdhaXQpCisgICAgICAgICAgICB3YWl0Rm9yRGlkRmx1c2hXaXRoVGltZW91dCgpOwogICAgIH0K IAotICAgIHZvaWQgZmx1c2hEcmF3aW5nQ29udGV4dEFzeW5jKCkgZmluYWwKKyAgICBib29sIGZs dXNoRHJhd2luZ0NvbnRleHRBc3luYygpIGZpbmFsCiAgICAgewogICAgICAgICBpZiAoVU5MSUtF TFkoIW1fcmVtb3RlUmVuZGVyaW5nQmFja2VuZFByb3h5KSkKLSAgICAgICAgICAgIHJldHVybjsK KyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgICAgICBpZiAobV9yZW1vdGVEaXNwbGF5 TGlzdC5uZWVkc0ZsdXNoKCkgfHwgIWhhc1BlbmRpbmdGbHVzaCgpKSB7CisgICAgICAgIGlmICht X3JlbW90ZURpc3BsYXlMaXN0Lm5lZWRzRmx1c2goKSkgewogICAgICAgICAgICAgbV9zZW50Rmx1 c2hJZGVudGlmaWVyID0gV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0Rmx1c2hJZGVudGlmaWVyOjpn ZW5lcmF0ZSgpOworICAgICAgICAgICAgTE9HX1dJVEhfU1RSRUFNKFNoYXJlZERpc3BsYXlMaXN0 cywgc3RyZWFtIDw8ICJSZW1vdGVJbWFnZUJ1ZmZlclByb3h5ICIgPDwgbV9yZW5kZXJpbmdSZXNv dXJjZUlkZW50aWZpZXIgPDwgIiBmbHVzaERyYXdpbmdDb250ZXh0QXN5bmMgLSBmbHVzaCAiIDw8 IG1fc2VudEZsdXNoSWRlbnRpZmllcik7CiAgICAgICAgICAgICBtX3JlbW90ZURpc3BsYXlMaXN0 LmZsdXNoQ29udGV4dChtX3NlbnRGbHVzaElkZW50aWZpZXIpOworICAgICAgICAgICAgbV9yZW1v dGVEaXNwbGF5TGlzdC5yZXNldE5lZWRzRmx1c2goKTsKKyAgICAgICAgICAgIHJldHVybiB0cnVl OwogICAgICAgICB9CisgICAgICAgIAorICAgICAgICBpZiAoaGFzUGVuZGluZ0ZsdXNoKCkpCisg ICAgICAgICAgICByZXR1cm4gdHJ1ZTsKIAotICAgICAgICBtX3JlbW90ZURpc3BsYXlMaXN0LnJl c2V0TmVlZHNGbHVzaCgpOworICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCiAgICAgdm9p ZCByZWNvcmROYXRpdmVJbWFnZVVzZShXZWJDb3JlOjpOYXRpdmVJbWFnZSYgaW1hZ2UpCg==