239788 2022-04-26 13:53:05 -0700 test-webkitpy TestInstallGitLFS fails 2022-04-27 10:16:43 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro jbedard jbedard webkit-bug-importer oldest_to_newest 1864617 0 mcatanzaro 2022-04-26 13:53:05 -0700 I see two failures when running test-webkitpy: [1571/2000] webkitscmpy.test.install_git_lfs_unittest.TestInstallGitLFS.test_no_repo failed: Traceback (most recent call last): File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_git_lfs_unittest.py", line 141, in test_no_repo self.assertEqual(0, program.main( AssertionError: 0 != 1 [1841/2000] webkitscmpy.test.install_git_lfs_unittest.TestInstallGitLFS.test_install failed: Traceback (most recent call last): File "/home/mcatanzaro/Projects/WebKit/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_git_lfs_unittest.py", line 83, in test_install self.assertEqual(0, program.main( AssertionError: 0 != 1 It's pretty suspicious: def test_install(self): with OutputCapture() as captured, mocks.remote.GitHub('github.com/git-lfs/git-lfs', releases={ 'v3.1.2/git-lfs-darwin-arm64-v3.1.2.zip': wkmocks.Response(status_code=200, content=self.ZIP_CONTENTS), 'v3.1.2/git-lfs-darwin-amd64-v3.1.2.zip': wkmocks.Response(status_code=200, content=self.ZIP_CONTENTS), }), mocks.local.Git(self.path), mocks.local.Svn(): self.assertIsNone(local.Git(self.path).config().get('lfs.repositoryformatversion')) self.assertEqual(0, program.main( args=('install-git-lfs',), path=self.path, )) self.assertEqual(local.Git(self.path).config()['lfs.repositoryformatversion'], '0') Looks like it's trying to install macOS binaries? 1864657 1 webkit-bug-importer 2022-04-26 15:55:28 -0700 <rdar://problem/92363359> 1864659 2 jbedard 2022-04-26 15:58:42 -0700 Pull request: https://github.com/WebKit/WebKit/pull/404 1864839 3 ews-feeder 2022-04-27 10:16:41 -0700 Committed r293515 (250046@main): <https://commits.webkit.org/250046@main> Reviewed commits have been landed. Closing PR #404 and removing active labels.