23977 2009-02-16 12:00:34 -0800 Unnecessary timer related headers in files and unnecessary public constructor. 2009-02-17 16:58:00 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin ap oldest_to_newest 109874 0 levin 2009-02-16 12:00:34 -0800 A few timer related headers are included where they aren't needed. The WorkerSharedTimer constructor is public but it is only used by doing "new WorkerSharedTimer" so it should be exposed using the static std::auto_ptr<> create() pattern. 109875 1 27705 levin 2009-02-16 12:08:47 -0800 Created attachment 27705 Patch for bug. 109890 2 27710 levin 2009-02-16 14:31:29 -0800 Created attachment 27710 Proposed fix. Removed extra parenthesis from last patch. 109924 3 dimich 2009-02-16 23:19:17 -0800 Is there indeed a value in adding the ::create to this private (for this cpp) and very simple class? It's a trivial helper class and seems to be more readable with just a simple constructor. I see there could be value in having create() method where it'd return PassRefPtr (to support refcounting), or there is an involved initialization that can have failures... Not sure there is a benefit in this case that is worthy of including extra header and more code. 109930 4 27710 ap 2009-02-17 00:32:34 -0800 Comment on attachment 27710 Proposed fix. r=me 109931 5 ap 2009-02-17 00:34:06 -0800 I think that the benefit is in following the same model everywhere, so searches (or automated tools) that someone may use to analyze code for possible leaks will not be tripped. 109932 6 ap 2009-02-17 00:34:54 -0800 But I agree that this is a border case. 109981 7 27736 levin 2009-02-17 10:49:29 -0800 Created attachment 27736 Proposed fix. (trivial cleanup) Removed static create method at dimich's request. 109984 8 27736 ap 2009-02-17 10:56:53 -0800 Comment on attachment 27736 Proposed fix. (trivial cleanup) r=me 110038 9 27736 levin 2009-02-17 16:56:18 -0800 Comment on attachment 27736 Proposed fix. (trivial cleanup) Committed as r41047. 27705 2009-02-16 12:08:47 -0800 2009-02-16 14:31:29 -0800 Patch for bug. bug23977.txt text/plain 2666 levin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjQ4ZTliMy4uMmY5MDJkYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0wMi0xNiAgRGF2aWQgTGV2aW4g IDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQnVnIDIzOTc3OiBVbm5lY2Vzc2FyeSB0aW1lciByZWxhdGVkIGhlYWRl cnMgaW4gZmlsZXMgYW5kIHVubmVjZXNzYXJ5IHB1YmxpYyBjb25zdHJ1Y3Rvci4KKyAgICAgICAg PGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzk3Nz4KKworICAgICAg ICBObyBvYnNlcnZhYmxlIGNoYW5nZSBpbiBiZWhhdmlvciwgc28gbm8gdGVzdC4KKworICAgICAg ICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgICogZG9tL1dvcmtlclJ1bkxvb3AuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6V29ya2VyU2hhcmVkVGltZXI6OmNyZWF0ZSk6CisgICAgICAgIChX ZWJDb3JlOjpXb3JrZXJTaGFyZWRUaW1lcjo6V29ya2VyU2hhcmVkVGltZXIpOgorICAgICAgICAq IGRvbS9Xb3JrZXJSdW5Mb29wLmg6CisKIDIwMDktMDItMTUgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIGR1cGxpY2F0ZSBjYXJldFdpZHRoIGNvbnN0 YW50cyB0byBSZW5kZXJPYmplY3QuaApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vRG9jdW1lbnQu Y3BwIGIvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDQ2ZjQ0NjAuLjVmYWExOTYgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAKQEAgLTM5LDcgKzM5LDYgQEAKICNpbmNsdWRlICJDb25zb2xlLmgiCiAjaW5jbHVk ZSAiQ29va2llSmFyLmgiCiAjaW5jbHVkZSAiRE9NSW1wbGVtZW50YXRpb24uaCIKLSNpbmNsdWRl ICJET01UaW1lci5oIgogI2luY2x1ZGUgIkRPTVdpbmRvdy5oIgogI2luY2x1ZGUgIkRvY0xvYWRl ci5oIgogI2luY2x1ZGUgIkRvY3VtZW50RnJhZ21lbnQuaCIKZGlmZiAtLWdpdCBhL1dlYkNvcmUv ZG9tL1dvcmtlclJ1bkxvb3AuY3BwIGIvV2ViQ29yZS9kb20vV29ya2VyUnVuTG9vcC5jcHAKaW5k ZXggMmNiYTVjOC4uZTczMWY5YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vV29ya2VyUnVuTG9v cC5jcHAKKysrIGIvV2ViQ29yZS9kb20vV29ya2VyUnVuTG9vcC5jcHAKQEAgLTMzLDIwICszMywy MSBAQAogI2lmIEVOQUJMRShXT1JLRVJTKQogCiAjaW5jbHVkZSAiU2NyaXB0RXhlY3V0aW9uQ29u dGV4dC5oIgorI2luY2x1ZGUgIlNoYXJlZFRpbWVyLmgiCiAjaW5jbHVkZSAiVGhyZWFkR2xvYmFs RGF0YS5oIgogI2luY2x1ZGUgIlRocmVhZFRpbWVycy5oIgogI2luY2x1ZGUgIldvcmtlclJ1bkxv b3AuaCIKICNpbmNsdWRlICJXb3JrZXJDb250ZXh0LmgiCiAjaW5jbHVkZSAiV29ya2VyVGhyZWFk LmgiCisjaW5jbHVkZSA8bWVtb3J5PgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIFdv cmtlclNoYXJlZFRpbWVyIDogcHVibGljIFNoYXJlZFRpbWVyIHsKIHB1YmxpYzoKLSAgICBXb3Jr ZXJTaGFyZWRUaW1lcigpCi0gICAgICAgIDogbV9zaGFyZWRUaW1lckZ1bmN0aW9uKDApCi0gICAg ICAgICwgbV9uZXh0RmlyZVRpbWUoMCkKKyAgICBzdGF0aWMgc3RkOjphdXRvX3B0cjxXb3JrZXJT aGFyZWRUaW1lcj4gY3JlYXRlKCkKICAgICB7CisgICAgICAgIHJldHVybiBzdGQ6OmF1dG9fcHRy PFdvcmtlclNoYXJlZFRpbWVyPihuZXcgV29ya2VyU2hhcmVkVGltZXIoKSk7CiAgICAgfQogCiAg ICAgLy8gU2hhcmVkVGltZXIgaW50ZXJmYWNlLgpAQCAtNTksMTIgKzYwLDE4IEBAIHB1YmxpYzoK ICAgICB2b2lkIGZpcmUoKSB7IG1fc2hhcmVkVGltZXJGdW5jdGlvbigpOyB9CiAKIHByaXZhdGU6 CisgICAgV29ya2VyU2hhcmVkVGltZXIoKQorICAgICAgICA6IG1fc2hhcmVkVGltZXJGdW5jdGlv bigwKQorICAgICAgICAsIG1fbmV4dEZpcmVUaW1lKDApCisgICAgeworICAgIH0KKwogICAgIHZv aWQgKCptX3NoYXJlZFRpbWVyRnVuY3Rpb24pKCk7CiAgICAgZG91YmxlIG1fbmV4dEZpcmVUaW1l OwogfTsKIAogV29ya2VyUnVuTG9vcDo6V29ya2VyUnVuTG9vcCgpCi0gICAgOiBtX3NoYXJlZFRp bWVyKG5ldyBXb3JrZXJTaGFyZWRUaW1lcikKKyAgICA6IG1fc2hhcmVkVGltZXIoV29ya2VyU2hh cmVkVGltZXI6OmNyZWF0ZSgpKQogewogfQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9Xb3Jr ZXJSdW5Mb29wLmggYi9XZWJDb3JlL2RvbS9Xb3JrZXJSdW5Mb29wLmgKaW5kZXggYWVhZjg4MC4u OGJkZGJlMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vV29ya2VyUnVuTG9vcC5oCisrKyBiL1dl YkNvcmUvZG9tL1dvcmtlclJ1bkxvb3AuaApAQCAtMzQsNyArMzQsNiBAQAogI2lmIEVOQUJMRShX T1JLRVJTKQogCiAjaW5jbHVkZSAiU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5oIgotI2luY2x1ZGUg IlNoYXJlZFRpbWVyLmgiCiAjaW5jbHVkZSA8d3RmL01lc3NhZ2VRdWV1ZS5oPgogI2luY2x1ZGUg PHd0Zi9Pd25QdHIuaD4KICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgo= 27710 2009-02-16 14:31:29 -0800 2009-02-17 10:54:59 -0800 Proposed fix. bug23977-2.txt text/plain 2664 levin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjQ4ZTliMy4uMmY5MDJkYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0wMi0xNiAgRGF2aWQgTGV2aW4g IDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQnVnIDIzOTc3OiBVbm5lY2Vzc2FyeSB0aW1lciByZWxhdGVkIGhlYWRl cnMgaW4gZmlsZXMgYW5kIHVubmVjZXNzYXJ5IHB1YmxpYyBjb25zdHJ1Y3Rvci4KKyAgICAgICAg PGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzk3Nz4KKworICAgICAg ICBObyBvYnNlcnZhYmxlIGNoYW5nZSBpbiBiZWhhdmlvciwgc28gbm8gdGVzdC4KKworICAgICAg ICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgICogZG9tL1dvcmtlclJ1bkxvb3AuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6V29ya2VyU2hhcmVkVGltZXI6OmNyZWF0ZSk6CisgICAgICAgIChX ZWJDb3JlOjpXb3JrZXJTaGFyZWRUaW1lcjo6V29ya2VyU2hhcmVkVGltZXIpOgorICAgICAgICAq IGRvbS9Xb3JrZXJSdW5Mb29wLmg6CisKIDIwMDktMDItMTUgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIGR1cGxpY2F0ZSBjYXJldFdpZHRoIGNvbnN0 YW50cyB0byBSZW5kZXJPYmplY3QuaApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vRG9jdW1lbnQu Y3BwIGIvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDQ2ZjQ0NjAuLjVmYWExOTYgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAKQEAgLTM5LDcgKzM5LDYgQEAKICNpbmNsdWRlICJDb25zb2xlLmgiCiAjaW5jbHVk ZSAiQ29va2llSmFyLmgiCiAjaW5jbHVkZSAiRE9NSW1wbGVtZW50YXRpb24uaCIKLSNpbmNsdWRl ICJET01UaW1lci5oIgogI2luY2x1ZGUgIkRPTVdpbmRvdy5oIgogI2luY2x1ZGUgIkRvY0xvYWRl ci5oIgogI2luY2x1ZGUgIkRvY3VtZW50RnJhZ21lbnQuaCIKZGlmZiAtLWdpdCBhL1dlYkNvcmUv ZG9tL1dvcmtlclJ1bkxvb3AuY3BwIGIvV2ViQ29yZS9kb20vV29ya2VyUnVuTG9vcC5jcHAKaW5k ZXggMmNiYTVjOC4uN2E4YmVkZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vV29ya2VyUnVuTG9v cC5jcHAKKysrIGIvV2ViQ29yZS9kb20vV29ya2VyUnVuTG9vcC5jcHAKQEAgLTMzLDIwICszMywy MSBAQAogI2lmIEVOQUJMRShXT1JLRVJTKQogCiAjaW5jbHVkZSAiU2NyaXB0RXhlY3V0aW9uQ29u dGV4dC5oIgorI2luY2x1ZGUgIlNoYXJlZFRpbWVyLmgiCiAjaW5jbHVkZSAiVGhyZWFkR2xvYmFs RGF0YS5oIgogI2luY2x1ZGUgIlRocmVhZFRpbWVycy5oIgogI2luY2x1ZGUgIldvcmtlclJ1bkxv b3AuaCIKICNpbmNsdWRlICJXb3JrZXJDb250ZXh0LmgiCiAjaW5jbHVkZSAiV29ya2VyVGhyZWFk LmgiCisjaW5jbHVkZSA8bWVtb3J5PgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIFdv cmtlclNoYXJlZFRpbWVyIDogcHVibGljIFNoYXJlZFRpbWVyIHsKIHB1YmxpYzoKLSAgICBXb3Jr ZXJTaGFyZWRUaW1lcigpCi0gICAgICAgIDogbV9zaGFyZWRUaW1lckZ1bmN0aW9uKDApCi0gICAg ICAgICwgbV9uZXh0RmlyZVRpbWUoMCkKKyAgICBzdGF0aWMgc3RkOjphdXRvX3B0cjxXb3JrZXJT aGFyZWRUaW1lcj4gY3JlYXRlKCkKICAgICB7CisgICAgICAgIHJldHVybiBzdGQ6OmF1dG9fcHRy PFdvcmtlclNoYXJlZFRpbWVyPihuZXcgV29ya2VyU2hhcmVkVGltZXIpOwogICAgIH0KIAogICAg IC8vIFNoYXJlZFRpbWVyIGludGVyZmFjZS4KQEAgLTU5LDEyICs2MCwxOCBAQCBwdWJsaWM6CiAg ICAgdm9pZCBmaXJlKCkgeyBtX3NoYXJlZFRpbWVyRnVuY3Rpb24oKTsgfQogCiBwcml2YXRlOgor ICAgIFdvcmtlclNoYXJlZFRpbWVyKCkKKyAgICAgICAgOiBtX3NoYXJlZFRpbWVyRnVuY3Rpb24o MCkKKyAgICAgICAgLCBtX25leHRGaXJlVGltZSgwKQorICAgIHsKKyAgICB9CisKICAgICB2b2lk ICgqbV9zaGFyZWRUaW1lckZ1bmN0aW9uKSgpOwogICAgIGRvdWJsZSBtX25leHRGaXJlVGltZTsK IH07CiAKIFdvcmtlclJ1bkxvb3A6OldvcmtlclJ1bkxvb3AoKQotICAgIDogbV9zaGFyZWRUaW1l cihuZXcgV29ya2VyU2hhcmVkVGltZXIpCisgICAgOiBtX3NoYXJlZFRpbWVyKFdvcmtlclNoYXJl ZFRpbWVyOjpjcmVhdGUoKSkKIHsKIH0KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vV29ya2Vy UnVuTG9vcC5oIGIvV2ViQ29yZS9kb20vV29ya2VyUnVuTG9vcC5oCmluZGV4IGFlYWY4ODAuLjhi ZGRiZTMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL1dvcmtlclJ1bkxvb3AuaAorKysgYi9XZWJD b3JlL2RvbS9Xb3JrZXJSdW5Mb29wLmgKQEAgLTM0LDcgKzM0LDYgQEAKICNpZiBFTkFCTEUoV09S S0VSUykKIAogI2luY2x1ZGUgIlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQuaCIKLSNpbmNsdWRlICJT aGFyZWRUaW1lci5oIgogI2luY2x1ZGUgPHd0Zi9NZXNzYWdlUXVldWUuaD4KICNpbmNsdWRlIDx3 dGYvT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4K 27736 2009-02-17 10:49:29 -0800 2009-02-17 16:56:18 -0800 Proposed fix. (trivial cleanup) bug23977.txt text/plain 1679 levin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGQ1ZjU5OS4uNzBkZmJhZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wMi0xNyAgRGF2aWQgTGV2aW4g IDxsZXZpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQnVnIDIzOTc3OiBVbm5lY2Vzc2FyeSB0aW1lciByZWxhdGVkIGhlYWRl cnMgaW4gZmlsZXMuCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjM5Nzc+CisKKyAgICAgICAgTm8gb2JzZXJ2YWJsZSBjaGFuZ2UgaW4gYmVoYXZpb3Is IHNvIG5vIHRlc3QuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAqIGRv bS9Xb3JrZXJSdW5Mb29wLmNwcDoKKyAgICAgICAgKiBkb20vV29ya2VyUnVuTG9vcC5oOgorCiAy MDA5LTAyLTE3ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vRG9j dW1lbnQuY3BwIGIvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDQ2ZjQ0NjAuLjVmYWEx OTYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAKQEAgLTM5LDcgKzM5LDYgQEAKICNpbmNsdWRlICJDb25zb2xlLmgiCiAj aW5jbHVkZSAiQ29va2llSmFyLmgiCiAjaW5jbHVkZSAiRE9NSW1wbGVtZW50YXRpb24uaCIKLSNp bmNsdWRlICJET01UaW1lci5oIgogI2luY2x1ZGUgIkRPTVdpbmRvdy5oIgogI2luY2x1ZGUgIkRv Y0xvYWRlci5oIgogI2luY2x1ZGUgIkRvY3VtZW50RnJhZ21lbnQuaCIKZGlmZiAtLWdpdCBhL1dl YkNvcmUvZG9tL1dvcmtlclJ1bkxvb3AuY3BwIGIvV2ViQ29yZS9kb20vV29ya2VyUnVuTG9vcC5j cHAKaW5kZXggMmNiYTVjOC4uNmE5ZWJiMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vV29ya2Vy UnVuTG9vcC5jcHAKKysrIGIvV2ViQ29yZS9kb20vV29ya2VyUnVuTG9vcC5jcHAKQEAgLTMzLDYg KzMzLDcgQEAKICNpZiBFTkFCTEUoV09SS0VSUykKIAogI2luY2x1ZGUgIlNjcmlwdEV4ZWN1dGlv bkNvbnRleHQuaCIKKyNpbmNsdWRlICJTaGFyZWRUaW1lci5oIgogI2luY2x1ZGUgIlRocmVhZEds b2JhbERhdGEuaCIKICNpbmNsdWRlICJUaHJlYWRUaW1lcnMuaCIKICNpbmNsdWRlICJXb3JrZXJS dW5Mb29wLmgiCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9Xb3JrZXJSdW5Mb29wLmggYi9XZWJD b3JlL2RvbS9Xb3JrZXJSdW5Mb29wLmgKaW5kZXggYWVhZjg4MC4uOGJkZGJlMyAxMDA2NDQKLS0t IGEvV2ViQ29yZS9kb20vV29ya2VyUnVuTG9vcC5oCisrKyBiL1dlYkNvcmUvZG9tL1dvcmtlclJ1 bkxvb3AuaApAQCAtMzQsNyArMzQsNiBAQAogI2lmIEVOQUJMRShXT1JLRVJTKQogCiAjaW5jbHVk ZSAiU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5oIgotI2luY2x1ZGUgIlNoYXJlZFRpbWVyLmgiCiAj aW5jbHVkZSA8d3RmL01lc3NhZ2VRdWV1ZS5oPgogI2luY2x1ZGUgPHd0Zi9Pd25QdHIuaD4KICNp bmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgo=