239767 2022-04-26 06:19:52 -0700 REGRESSION(249114@main) [GTK] Crashes on shutdown if the display is not set 2022-05-05 01:34:49 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned bugs-noreply cgarcia jbicha mcatanzaro oldest_to_newest 1864425 0 berto 2022-04-26 06:19:52 -0700 Running one of the devhelp tests crashes since WebKitGTK 2.36.1 if there's no display: error: XDG_RUNTIME_DIR not set in the environment. (test:5926): GLib-GObject-WARNING **: 14:00:44.774: invalid (NULL) pointer instance (test:5926): GLib-GObject-CRITICAL **: 14:00:44.774: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed (test:5926): Gdk-CRITICAL **: 14:00:44.774: gdk_wayland_display_get_wl_display: assertion 'GDK_IS_WAYLAND_DISPLAY (display)' failed EGLDisplay Initialization failed: EGL_NOT_INITIALIZED Thread 1 "test" received signal SIGSEGV, Segmentation fault. 0x00007ffff2c94ae7 in wl_display_disconnect () from /usr/lib/x86_64-linux-gnu/libwayland-client.so.0 (gdb) bt #0 0x00007ffff2c94ae7 in wl_display_disconnect () at /usr/lib/x86_64-linux-gnu/libwayland-client.so.0 #1 0x00007ffff5930735 in WebCore::PlatformDisplayWayland::~PlatformDisplayWayland() () at ./Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp:105 #2 0x00007ffff5930749 in WebCore::PlatformDisplayWayland::~PlatformDisplayWayland() () at ./Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp:107 #3 0x00007ffff7df4f77 in __run_exit_handlers (status=0, listp=0x7ffff7f88738 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at exit.c:108 #4 0x00007ffff7df511a in __GI_exit (status=<optimized out>) at exit.c:139 #5 0x00007ffff7ddd804 in __libc_start_main (main= 0x555555555149 <main>, argc=1, argv=0x7fffffffec28, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffec18) at ../csu/libc-start.c:366 #6 0x000055555555508a in _start () 1864426 1 berto 2022-04-26 06:21:59 -0700 Almost certainly due to this change: https://github.com/WebKit/WebKit/commit/72fad08f2bfe7d2744c3217fe0ec0afcc671c53e 1866400 2 458781 cgarcia 2022-05-04 02:26:16 -0700 Created attachment 458781 Patch 1866562 3 berto 2022-05-04 12:26:56 -0700 Thanks, I confirm that the patch fixes the devhelp tests. 1866781 4 ews-feeder 2022-05-05 01:34:44 -0700 Committed r293826 (250299@main): <https://commits.webkit.org/250299@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458781. 458781 2022-05-04 02:26:16 -0700 2022-05-05 01:34:47 -0700 Patch wk-no-display-crash.diff text/plain 4470 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNjE2ZWY1NmFmYjAuLjhlZjY1ZjVjOTk4MiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDIxIEBACisyMDIyLTA1LTA0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKDI0OTExNEBtYWluKSBbR1RLXSBDcmFz aGVzIG9uIHNodXRkb3duIGlmIHRoZSBkaXNwbGF5IGlzIG5vdCBzZXQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzOTc2NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhbmRsZSB0aGUgY2FzZSBvZiBQbGF0 Zm9ybURpc3BsYXkgY3JlYXRlZCB3aXRoIGEgbnVsbHB0ciBHZGtEaXNwbGF5LgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZvcm1EaXNwbGF5LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlBsYXRmb3JtRGlzcGxheTo6UGxhdGZvcm1EaXNwbGF5KToKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy93YXlsYW5kL1BsYXRmb3JtRGlzcGxheVdheWxhbmQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UGxhdGZvcm1EaXNwbGF5V2F5bGFuZDo6UGxhdGZvcm1EaXNwbGF5V2F5bGFuZCk6 CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXlXYXlsYW5kOjp+UGxhdGZvcm1EaXNw bGF5V2F5bGFuZCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MveDExL1BsYXRmb3JtRGlz cGxheVgxMS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXlYMTE6OlBsYXRm b3JtRGlzcGxheVgxMSk6CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXlYMTE6On5Q bGF0Zm9ybURpc3BsYXlYMTEpOgorCiAyMDIyLTA1LTA0ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5f Z2FyZG5lckBhcHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxlIFRleHRDaGVja2luZ1R5cGU6OkNv cnJlY3Rpb24gb24gTWFjQ2F0YWx5c3QuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9QbGF0Zm9ybURpc3BsYXkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvUGxhdGZvcm1EaXNwbGF5LmNwcAppbmRleCA3NTNjODdlMjM4NmIuLjk3MjMz ZWZiMGRkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGxh dGZvcm1EaXNwbGF5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Q bGF0Zm9ybURpc3BsYXkuY3BwCkBAIC0xNzcsMTUgKzE3NywxNyBAQCBQbGF0Zm9ybURpc3BsYXk6 OlBsYXRmb3JtRGlzcGxheShHZGtEaXNwbGF5KiBkaXNwbGF5KQogICAgICwgbV9lZ2xEaXNwbGF5 KEVHTF9OT19ESVNQTEFZKQogI2VuZGlmCiB7CisgICAgaWYgKG1fc2hhcmVkRGlzcGxheSkgewog I2lmIFVTRShBVFNQSSkgJiYgVVNFKEdUSzQpCi0gICAgaWYgKGNvbnN0IGNoYXIqIGF0c3BpQnVz QWRkcmVzcyA9IHN0YXRpY19jYXN0PGNvbnN0IGNoYXIqPihnX29iamVjdF9nZXRfZGF0YShHX09C SkVDVChkaXNwbGF5KSwgIi1ndGstYXRzcGktYnVzLWFkZHJlc3MiKSkpCi0gICAgICAgIG1fYWNj ZXNzaWJpbGl0eUJ1c0FkZHJlc3MgPSBTdHJpbmc6OmZyb21VVEY4KGF0c3BpQnVzQWRkcmVzcyk7 CisgICAgICAgIGlmIChjb25zdCBjaGFyKiBhdHNwaUJ1c0FkZHJlc3MgPSBzdGF0aWNfY2FzdDxj b25zdCBjaGFyKj4oZ19vYmplY3RfZ2V0X2RhdGEoR19PQkpFQ1QobV9zaGFyZWREaXNwbGF5Lmdl dCgpKSwgIi1ndGstYXRzcGktYnVzLWFkZHJlc3MiKSkpCisgICAgICAgICAgICBtX2FjY2Vzc2li aWxpdHlCdXNBZGRyZXNzID0gU3RyaW5nOjpmcm9tVVRGOChhdHNwaUJ1c0FkZHJlc3MpOwogI2Vu ZGlmCiAKLSAgICBnX3NpZ25hbF9jb25uZWN0KG1fc2hhcmVkRGlzcGxheS5nZXQoKSwgImNsb3Nl ZCIsIEdfQ0FMTEJBQ0soK1tdKEdka0Rpc3BsYXkqLCBnYm9vbGVhbiwgZ3BvaW50ZXIgdXNlckRh dGEpIHsKLSAgICAgICAgYXV0byYgcGxhdGZvcm1EaXNwbGF5ID0gKnN0YXRpY19jYXN0PFBsYXRm b3JtRGlzcGxheSo+KHVzZXJEYXRhKTsKLSAgICAgICAgcGxhdGZvcm1EaXNwbGF5LnNoYXJlZERp c3BsYXlEaWRDbG9zZSgpOwotICAgIH0pLCB0aGlzKTsKKyAgICAgICAgZ19zaWduYWxfY29ubmVj dChtX3NoYXJlZERpc3BsYXkuZ2V0KCksICJjbG9zZWQiLCBHX0NBTExCQUNLKCtbXShHZGtEaXNw bGF5KiwgZ2Jvb2xlYW4sIGdwb2ludGVyIHVzZXJEYXRhKSB7CisgICAgICAgICAgICBhdXRvJiBw bGF0Zm9ybURpc3BsYXkgPSAqc3RhdGljX2Nhc3Q8UGxhdGZvcm1EaXNwbGF5Kj4odXNlckRhdGEp OworICAgICAgICAgICAgcGxhdGZvcm1EaXNwbGF5LnNoYXJlZERpc3BsYXlEaWRDbG9zZSgpOwor ICAgICAgICB9KSwgdGhpcyk7CisgICAgfQogfQogCiB2b2lkIFBsYXRmb3JtRGlzcGxheTo6c2hh cmVkRGlzcGxheURpZENsb3NlKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3dheWxhbmQvUGxhdGZvcm1EaXNwbGF5V2F5bGFuZC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy93YXlsYW5kL1BsYXRmb3JtRGlzcGxheVdheWxhbmQuY3Bw CmluZGV4IDExMTQxOTg2ODg3MC4uNzYxYmM0Y2JmZGE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy93YXlsYW5kL1BsYXRmb3JtRGlzcGxheVdheWxhbmQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dheWxhbmQvUGxhdGZvcm1E aXNwbGF5V2F5bGFuZC5jcHAKQEAgLTg2LDcgKzg2LDcgQEAgUGxhdGZvcm1EaXNwbGF5V2F5bGFu ZDo6UGxhdGZvcm1EaXNwbGF5V2F5bGFuZChzdHJ1Y3Qgd2xfZGlzcGxheSogZGlzcGxheSkKICNp ZiBQTEFURk9STShHVEspCiBQbGF0Zm9ybURpc3BsYXlXYXlsYW5kOjpQbGF0Zm9ybURpc3BsYXlX YXlsYW5kKEdka0Rpc3BsYXkqIGRpc3BsYXkpCiAgICAgOiBQbGF0Zm9ybURpc3BsYXkoZGlzcGxh eSkKLSAgICAsIG1fZGlzcGxheShnZGtfd2F5bGFuZF9kaXNwbGF5X2dldF93bF9kaXNwbGF5KGRp c3BsYXkpKQorICAgICwgbV9kaXNwbGF5KGRpc3BsYXkgPyBnZGtfd2F5bGFuZF9kaXNwbGF5X2dl dF93bF9kaXNwbGF5KGRpc3BsYXkpIDogbnVsbHB0cikKIHsKIH0KICNlbmRpZgpAQCAtOTksNyAr OTksNyBAQCBQbGF0Zm9ybURpc3BsYXlXYXlsYW5kOjp+UGxhdGZvcm1EaXNwbGF5V2F5bGFuZCgp CiAgICAgYm9vbCBuYXRpdmVEaXNwbGF5T3duZWQgPSB0cnVlOwogI2VuZGlmCiAKLSAgICBpZiAo bmF0aXZlRGlzcGxheU93bmVkKSB7CisgICAgaWYgKG5hdGl2ZURpc3BsYXlPd25lZCAmJiBtX2Rp c3BsYXkpIHsKICAgICAgICAgbV9jb21wb3NpdG9yID0gbnVsbHB0cjsKICAgICAgICAgbV9yZWdp c3RyeSA9IG51bGxwdHI7CiAgICAgICAgIHdsX2Rpc3BsYXlfZGlzY29ubmVjdChtX2Rpc3BsYXkp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MveDExL1BsYXRm b3JtRGlzcGxheVgxMS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy94MTEv UGxhdGZvcm1EaXNwbGF5WDExLmNwcAppbmRleCBmZmUxOTE3OTdmYmEuLjg5YWJiMTdiMDE1NyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MveDExL1BsYXRmb3Jt RGlzcGxheVgxMS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MveDEx L1BsYXRmb3JtRGlzcGxheVgxMS5jcHAKQEAgLTk2LDcgKzk2LDcgQEAgUGxhdGZvcm1EaXNwbGF5 WDExOjpQbGF0Zm9ybURpc3BsYXlYMTEoRGlzcGxheSogZGlzcGxheSkKICNpZiBQTEFURk9STShH VEspCiBQbGF0Zm9ybURpc3BsYXlYMTE6OlBsYXRmb3JtRGlzcGxheVgxMShHZGtEaXNwbGF5KiBk aXNwbGF5KQogICAgIDogUGxhdGZvcm1EaXNwbGF5KGRpc3BsYXkpCi0gICAgLCBtX2Rpc3BsYXko R0RLX0RJU1BMQVlfWERJU1BMQVkoZGlzcGxheSkpCisgICAgLCBtX2Rpc3BsYXkoZGlzcGxheSA/ IEdES19ESVNQTEFZX1hESVNQTEFZKGRpc3BsYXkpIDogbnVsbHB0cikKIHsKICAgICBjbGVhclNo YXJpbmdHTENvbnRleHRBdEV4aXQoKTsKIH0KQEAgLTExMyw3ICsxMTMsNyBAQCBQbGF0Zm9ybURp c3BsYXlYMTE6On5QbGF0Zm9ybURpc3BsYXlYMTEoKQogI2Vsc2UKICAgICBib29sIG5hdGl2ZURp c3BsYXlPd25lZCA9IHRydWU7CiAjZW5kaWYKLSAgICBpZiAobmF0aXZlRGlzcGxheU93bmVkKQor ICAgIGlmIChuYXRpdmVEaXNwbGF5T3duZWQgJiYgbV9kaXNwbGF5KQogICAgICAgICBYQ2xvc2VE aXNwbGF5KG1fZGlzcGxheSk7CiB9CiAK