239760 2022-04-26 00:40:27 -0700 PlatformDisplay::PlatformDisplay(GdkDisplay* display) does not set m_eglDisplay to EGL_NO_DISPLAY 2022-04-26 11:52:40 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build PC Linux RESOLVED FIXED P2 Normal --- 1 xry111 webkit-unassigned bugs-noreply mcatanzaro oldest_to_newest 1864376 0 xry111 2022-04-26 00:40:27 -0700 The value of PlatformDisplay::m_eglDisplay is left with a random value, then triggers EGLDisplay Initialization failed: EGL_BAD_DISPLAY in PlatformDisplay::initializeEGLDisplay. 1864417 1 458354 xry111 2022-04-26 05:05:42 -0700 Created attachment 458354 Patch 1864465 2 458354 mcatanzaro 2022-04-26 08:30:58 -0700 Comment on attachment 458354 Patch Oops. This change looks safe and good. But could you please use the initializer list, as in the constructor above? 1864468 3 458371 xry111 2022-04-26 08:40:40 -0700 Created attachment 458371 Patch 1864470 4 xry111 2022-04-26 08:44:20 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 458354 [details] > Patch > > Oops. > > This change looks safe and good. But could you please use the initializer > list, as in the constructor above? Updated. I initially didn't like a "," leading the line but now I've found out WebKit widely uses initializer lists with such a format. 1864554 5 ews-feeder 2022-04-26 11:52:36 -0700 Committed r293441 (249996@main): <https://commits.webkit.org/249996@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458371. 458354 2022-04-26 05:05:42 -0700 2022-04-26 08:40:30 -0700 Patch bug-239760-20220426200540.patch text/plain 1617 xry111 U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWJkZjRjM2UxYTk0MmY3 ZGZlMmJhYWRiNzUzOTA2ZDk0ZmRiMmVkZS4uY2JiOGEyN2JkM2FkNWVjYWJjMDYzNWViNTQyZjRh NjcyZjIyZDlkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTA0LTI2ICBYaSBS dW95YW8gIDx4cnkxMTFAbWVuZ3lhbjEyMjMud2FuZz4KKworICAgICAgICBbR1RLXSBJbml0aWFs aXplIG1fZWdsRGlzcGxheSBpbiBQbGF0Zm9ybURpc3BsYXk6OlBsYXRmb3JtRGlzcGxheShHZGtE aXNwbGF5KikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzOTc2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlIGlzIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXk6OlBsYXRmb3JtRGlzcGxheSk6CisgICAgICAgIGluaXRp YWxpemUgbV9lZ2xEaXNwbGF5IHRvIEVHTF9OT19ESVNQTEFZLgorCiAyMDIyLTA0LTI2ICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0RhdGFiYXNl VHJhY2tlcl0gVXNlIFBSSXU2NCBmb3IgbG9nZ2luZyBmb3IgcG9ydGFiaWxpdHkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QbGF0Zm9ybURpc3BsYXkuY3BwCmlu ZGV4IDU3ZWU3ZDQ1ODgwZGM1NGJhZmVhNDA3MDFjNzkwODJkMmNhY2M4ZjYuLmQwMDlmNDdhODFh OWU5YTM4ZTkxM2UwMTQ3MzBhMTYyZTljM2JlY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZvcm1EaXNwbGF5LmNwcApAQCAtMTc0LDYgKzE3NCwx MCBAQCBQbGF0Zm9ybURpc3BsYXk6OlBsYXRmb3JtRGlzcGxheSgpCiBQbGF0Zm9ybURpc3BsYXk6 OlBsYXRmb3JtRGlzcGxheShHZGtEaXNwbGF5KiBkaXNwbGF5KQogICAgIDogbV9zaGFyZWREaXNw bGF5KGRpc3BsYXkpCiB7CisjaWYgVVNFKEVHTCkKKyAgICBtX2VnbERpc3BsYXkgPSBFR0xfTk9f RElTUExBWTsKKyNlbmRpZgorCiAjaWYgVVNFKEFUU1BJKSAmJiBVU0UoR1RLNCkKICAgICBpZiAo Y29uc3QgY2hhciogYXRzcGlCdXNBZGRyZXNzID0gc3RhdGljX2Nhc3Q8Y29uc3QgY2hhcio+KGdf b2JqZWN0X2dldF9kYXRhKEdfT0JKRUNUKGRpc3BsYXkpLCAiLWd0ay1hdHNwaS1idXMtYWRkcmVz cyIpKSkKICAgICAgICAgbV9hY2Nlc3NpYmlsaXR5QnVzQWRkcmVzcyA9IFN0cmluZzo6ZnJvbVVU RjgoYXRzcGlCdXNBZGRyZXNzKTsK 458371 2022-04-26 08:40:40 -0700 2022-04-26 11:52:38 -0700 Patch bug-239760-20220426234039.patch text/plain 1561 xry111 U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWJkZjRjM2UxYTk0MmY3 ZGZlMmJhYWRiNzUzOTA2ZDk0ZmRiMmVkZS4uY2JiOGEyN2JkM2FkNWVjYWJjMDYzNWViNTQyZjRh NjcyZjIyZDlkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTA0LTI2ICBYaSBS dW95YW8gIDx4cnkxMTFAbWVuZ3lhbjEyMjMud2FuZz4KKworICAgICAgICBbR1RLXSBJbml0aWFs aXplIG1fZWdsRGlzcGxheSBpbiBQbGF0Zm9ybURpc3BsYXk6OlBsYXRmb3JtRGlzcGxheShHZGtE aXNwbGF5KikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzOTc2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlIGlzIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpQbGF0Zm9ybURpc3BsYXk6OlBsYXRmb3JtRGlzcGxheSk6CisgICAgICAgIGluaXRp YWxpemUgbV9lZ2xEaXNwbGF5IHRvIEVHTF9OT19ESVNQTEFZLgorCiAyMDIyLTA0LTI2ICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0RhdGFiYXNl VHJhY2tlcl0gVXNlIFBSSXU2NCBmb3IgbG9nZ2luZyBmb3IgcG9ydGFiaWxpdHkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QbGF0Zm9ybURpc3BsYXkuY3BwCmlu ZGV4IDU3ZWU3ZDQ1ODgwZGM1NGJhZmVhNDA3MDFjNzkwODJkMmNhY2M4ZjYuLjc1M2M4N2UyMzg2 YjU1OTBiZTFkYzZlYjVkMTNkNzBkZThhMDM3ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZvcm1EaXNwbGF5LmNwcApAQCAtMTczLDYgKzE3Myw5 IEBAIFBsYXRmb3JtRGlzcGxheTo6UGxhdGZvcm1EaXNwbGF5KCkKICNpZiBQTEFURk9STShHVEsp CiBQbGF0Zm9ybURpc3BsYXk6OlBsYXRmb3JtRGlzcGxheShHZGtEaXNwbGF5KiBkaXNwbGF5KQog ICAgIDogbV9zaGFyZWREaXNwbGF5KGRpc3BsYXkpCisjaWYgVVNFKEVHTCkKKyAgICAsIG1fZWds RGlzcGxheShFR0xfTk9fRElTUExBWSkKKyNlbmRpZgogewogI2lmIFVTRShBVFNQSSkgJiYgVVNF KEdUSzQpCiAgICAgaWYgKGNvbnN0IGNoYXIqIGF0c3BpQnVzQWRkcmVzcyA9IHN0YXRpY19jYXN0 PGNvbnN0IGNoYXIqPihnX29iamVjdF9nZXRfZGF0YShHX09CSkVDVChkaXNwbGF5KSwgIi1ndGst YXRzcGktYnVzLWFkZHJlc3MiKSkpCg==