239755 2022-04-25 21:39:38 -0700 Ensure completion handler is called in SWServer::clear 2022-04-27 19:06:14 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu cdumez webkit-bug-importer youennf oldest_to_newest 1864348 0 sihui_liu 2022-04-25 21:39:38 -0700 ... 1864349 1 458325 sihui_liu 2022-04-25 21:40:52 -0700 Created attachment 458325 Patch 1864440 2 458325 youennf 2022-04-26 07:42:05 -0700 Comment on attachment 458325 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458325&action=review > Source/WebCore/workers/service/server/SWServer.cpp:348 > + if (m_registrationStore) { I would reverse the check, something like: if (! m_registrationStore) { completionHandler(); return; } 1864929 3 458325 sihui_liu 2022-04-27 14:09:59 -0700 Comment on attachment 458325 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458325&action=review >> Source/WebCore/workers/service/server/SWServer.cpp:348 >> + if (m_registrationStore) { > > I would reverse the check, something like: > if (! m_registrationStore) { completionHandler(); return; } Sure, will change. 1864930 4 458466 sihui_liu 2022-04-27 14:10:50 -0700 Created attachment 458466 Patch for landing 1865023 5 ews-feeder 2022-04-27 19:05:07 -0700 Committed r293550 (250070@main): <https://commits.webkit.org/250070@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458466. 1865024 6 webkit-bug-importer 2022-04-27 19:06:14 -0700 <rdar://problem/92433826> 458325 2022-04-25 21:40:52 -0700 2022-04-27 14:10:47 -0700 Patch bug-239755-20220425214051.patch text/plain 2129 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNDA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWMyOTgxNjY4ZTIxMjRh ZTIxNGJhNzE2NjllZTg2ZWEyOTUxYjA5Ni4uN2RlZWRhNjMwY2EzZTM2MzQwYmE1NDcyNDAzNDZi YjYwODM1MDdkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIyLTA0LTI1ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIEVuc3VyZSBjb21wbGV0aW9u IGhhbmRsZXIgaXMgY2FsbGVkIGluIFNXU2VydmVyOjpjbGVhcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM5NzU1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NX U2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNXU2VydmVyOjpjbGVhckFsbCk6CisgICAg ICAgIChXZWJDb3JlOjpTV1NlcnZlcjo6Y2xlYXIpOgorCiAyMDIyLTA0LTI1ICBEZXZpbiBSb3Vz c28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiByZXF1ZXN0 IGludGVyY2VwdGlvbiBzaG91bGQgbm90IGJlIGd1YXJkZWQgYmFzZWQgb24gc2VydmljZSB3b3Jr ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NX U2VydmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2 ZXIuY3BwCmluZGV4IDdkNGUzYWJhYTkzYzIwN2U5NmZkZTUyYWI5ZGFkODE4NmVhZDQzMzcuLmU1 NmUyNjJkNjgxZTVkOTNiYjgxMjU1MzgwYTk1MGY5YmRlNjI5Y2IgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCkBAIC0yODcsOCAr Mjg3LDEyIEBAIHZvaWQgU1dTZXJ2ZXI6OmNsZWFyQWxsKENvbXBsZXRpb25IYW5kbGVyPHZvaWQo KT4mJiBjb21wbGV0aW9uSGFuZGxlcikKICAgICAgICAgbV9yZWdpc3RyYXRpb25zLmJlZ2luKCkt PnZhbHVlLT5jbGVhcigpOwogICAgIG1fcGVuZGluZ0NvbnRleHREYXRhcy5jbGVhcigpOwogICAg IG1fb3JpZ2luU3RvcmUtPmNsZWFyQWxsKCk7Ci0gICAgaWYgKG1fcmVnaXN0cmF0aW9uU3RvcmUp CisgICAgaWYgKG1fcmVnaXN0cmF0aW9uU3RvcmUpIHsKICAgICAgICAgbV9yZWdpc3RyYXRpb25T dG9yZS0+Y2xlYXJBbGwoV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikpOworICAgICAgICByZXR1 cm47CisgICAgfQorCisgICAgY29tcGxldGlvbkhhbmRsZXIoKTsKIH0KIAogdm9pZCBTV1NlcnZl cjo6c3RhcnRTdXNwZW5zaW9uKENvbXBsZXRpb25IYW5kbGVyPHZvaWQoKT4mJiBjb21wbGV0aW9u SGFuZGxlcikKQEAgLTM0MSw4ICszNDUsMTIgQEAgdm9pZCBTV1NlcnZlcjo6Y2xlYXIoY29uc3Qg U2VjdXJpdHlPcmlnaW5EYXRhJiBzZWN1cml0eU9yaWdpbiwgQ29tcGxldGlvbkhhbmRsZXIKICAg ICBmb3IgKGF1dG8qIHJlZ2lzdHJhdGlvbiA6IHJlZ2lzdHJhdGlvbnNUb1JlbW92ZSkKICAgICAg ICAgcmVnaXN0cmF0aW9uLT5jbGVhcigpOwogCi0gICAgaWYgKG1fcmVnaXN0cmF0aW9uU3RvcmUp CisgICAgaWYgKG1fcmVnaXN0cmF0aW9uU3RvcmUpIHsKICAgICAgICAgbV9yZWdpc3RyYXRpb25T dG9yZS0+Zmx1c2hDaGFuZ2VzKFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKKyAgICAgICAg cmV0dXJuOworICAgIH0KKworICAgIGNvbXBsZXRpb25IYW5kbGVyKCk7CiB9CiAKIHZvaWQgU1dT ZXJ2ZXI6OkNvbm5lY3Rpb246OmZpbmlzaEZldGNoaW5nU2NyaXB0SW5TZXJ2ZXIoY29uc3QgU2Vy dmljZVdvcmtlckpvYkRhdGFJZGVudGlmaWVyJiBqb2JEYXRhSWRlbnRpZmllciwgY29uc3QgU2Vy dmljZVdvcmtlclJlZ2lzdHJhdGlvbktleSYgcmVnaXN0cmF0aW9uS2V5LCBjb25zdCBXb3JrZXJG ZXRjaFJlc3VsdCYgcmVzdWx0KQo= 458466 2022-04-27 14:10:50 -0700 2022-04-27 19:05:09 -0700 Patch for landing bug-239755-20220427141049.patch text/plain 2180 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDY4YzVlOTkwN2M3Y2Rl YjdjMTUzZDNjOGY4MzUzNGZmNTQ5ZmE3ZS4uMjZjMjQ1NjYyNGJjYzFjMGU3NzU1MTkzZWY0NDA5 NWM2YjYyODRjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIyLTA0LTI3ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIEVuc3VyZSBjb21wbGV0aW9u IGhhbmRsZXIgaXMgY2FsbGVkIGluIFNXU2VydmVyOjpjbGVhcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM5NzU1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgWW91ZW5uIEZhYmxldC4KKworICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dT ZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1dTZXJ2ZXI6OmNsZWFyQWxsKToKKyAgICAg ICAgKFdlYkNvcmU6OlNXU2VydmVyOjpjbGVhcik6CisKIDIwMjItMDQtMjQgIFBoaWxpcHBlIE5v cm1hbmQgIDxwaGlsbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIFRyYWNrIGhh bmRsaW5nIGZpeGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uv c2VydmVyL1NXU2VydmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2 ZXIvU1dTZXJ2ZXIuY3BwCmluZGV4IDExZDI5OGUwMWJmYTcwYTZmZmMzNDRhYjg5ODhmYzQ5NjI4 YzBhZDkuLjYwZDJhYjgzZTE1YmJlOTI0OGQ3NWVlZjM3MDI5ZjE2NGE1OTAwMTcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCkBA IC0yODcsOCArMjg3LDEwIEBAIHZvaWQgU1dTZXJ2ZXI6OmNsZWFyQWxsKENvbXBsZXRpb25IYW5k bGVyPHZvaWQoKT4mJiBjb21wbGV0aW9uSGFuZGxlcikKICAgICAgICAgbV9yZWdpc3RyYXRpb25z LmJlZ2luKCktPnZhbHVlLT5jbGVhcigpOwogICAgIG1fcGVuZGluZ0NvbnRleHREYXRhcy5jbGVh cigpOwogICAgIG1fb3JpZ2luU3RvcmUtPmNsZWFyQWxsKCk7Ci0gICAgaWYgKG1fcmVnaXN0cmF0 aW9uU3RvcmUpCi0gICAgICAgIG1fcmVnaXN0cmF0aW9uU3RvcmUtPmNsZWFyQWxsKFdURk1vdmUo Y29tcGxldGlvbkhhbmRsZXIpKTsKKyAgICBpZiAoIW1fcmVnaXN0cmF0aW9uU3RvcmUpCisgICAg ICAgIHJldHVybiBjb21wbGV0aW9uSGFuZGxlcigpOworCisgICAgbV9yZWdpc3RyYXRpb25TdG9y ZS0+Y2xlYXJBbGwoV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikpOwogfQogCiB2b2lkIFNXU2Vy dmVyOjpzdGFydFN1c3BlbnNpb24oQ29tcGxldGlvbkhhbmRsZXI8dm9pZCgpPiYmIGNvbXBsZXRp b25IYW5kbGVyKQpAQCAtMzQxLDggKzM0MywxMCBAQCB2b2lkIFNXU2VydmVyOjpjbGVhcihjb25z dCBTZWN1cml0eU9yaWdpbkRhdGEmIHNlY3VyaXR5T3JpZ2luLCBDb21wbGV0aW9uSGFuZGxlcgog ICAgIGZvciAoYXV0byogcmVnaXN0cmF0aW9uIDogcmVnaXN0cmF0aW9uc1RvUmVtb3ZlKQogICAg ICAgICByZWdpc3RyYXRpb24tPmNsZWFyKCk7CiAKLSAgICBpZiAobV9yZWdpc3RyYXRpb25TdG9y ZSkKLSAgICAgICAgbV9yZWdpc3RyYXRpb25TdG9yZS0+Zmx1c2hDaGFuZ2VzKFdURk1vdmUoY29t cGxldGlvbkhhbmRsZXIpKTsKKyAgICBpZiAoIW1fcmVnaXN0cmF0aW9uU3RvcmUpCisgICAgICAg IHJldHVybiBjb21wbGV0aW9uSGFuZGxlcigpOworCisgICAgbV9yZWdpc3RyYXRpb25TdG9yZS0+ Zmx1c2hDaGFuZ2VzKFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKIH0KIAogdm9pZCBTV1Nl cnZlcjo6Q29ubmVjdGlvbjo6ZmluaXNoRmV0Y2hpbmdTY3JpcHRJblNlcnZlcihjb25zdCBTZXJ2 aWNlV29ya2VySm9iRGF0YUlkZW50aWZpZXImIGpvYkRhdGFJZGVudGlmaWVyLCBjb25zdCBTZXJ2 aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5JiByZWdpc3RyYXRpb25LZXksIFdvcmtlckZldGNoUmVz dWx0JiYgcmVzdWx0KQo=